shafik accepted this revision.
shafik added a comment.

LGTM



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1218
+    auto GlobalIndex = P.getGlobal(VD);
+    assert(GlobalIndex); // visitVarDecl() didn't return false.
+    if (!this->emitGetPtrGlobal(*GlobalIndex, VD))
----------------
I don't get the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136815/new/

https://reviews.llvm.org/D136815

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D136815: [clang][I... Shafik Yaghmour via Phabricator via cfe-commits

Reply via email to