ilinpv added a comment.

In D127812#4009014 <https://reviews.llvm.org/D127812#4009014>, @paulkirth wrote:

> Hi, thanks for the fix. that unblocked our builder. Unfortunately, we still 
> see some errors in tests.
>
>   FAIL: Clang :: Driver/aarch64-features.c (7460 of 16622)
>   ******************** TEST 'Clang :: Driver/aarch64-features.c' FAILED 
> ********************
>   Script:
>   --
>   : 'RUN: at line 1';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-none-linux-gnu -### 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 
> -fsyntax-only 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 2';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> arm64-none-linux-gnu -### 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 
> -fsyntax-only 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 10';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-android -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck -check-prefix=CHECK-FMV 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 13';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-android -rtlib=compiler-rt -mno-fmv  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck -check-prefix=CHECK-FMV-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 16';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck -check-prefix=CHECK-FMV-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 19';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> arm64-unknown-linux -rtlib=libgcc  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck -check-prefix=CHECK-FMV-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 26';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-android -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 29';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 32';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> arm64-unknown-linux -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 35';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64--none-eabi -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 38';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-apple-darwin -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 41';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-windows-gnu -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 44';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-unknown-openbsd -rtlib=compiler-rt  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 47';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu -rtlib=libgcc  
> --gcc-toolchain=/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/aarch64-linux-gnu-tree/gcc-10
>   -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 51';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu -rtlib=libgcc  
> --gcc-toolchain=/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/aarch64-linux-gnu-tree/gcc-7.5.0
>   -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 55';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu -rtlib=libgcc  
> --gcc-toolchain=/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/aarch64-linux-gnu-tree/gcc-9.3.1
>   -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 59';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu -rtlib=libgcc  
> --gcc-toolchain=/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/aarch64-linux-gnu-tree/gcc-9.3.0
>   -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-OFF 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 63';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> arm64-linux -rtlib=compiler-rt -mno-outline-atomics  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck  
> -check-prefixes=CHECK-OUTLINE-ATOMICS-OFF,CHECK-NO-OUTLINE-ATOMICS 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 67';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-linux-gnu -rtlib=libgcc -mno-outline-atomics  
> --gcc-toolchain=/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/aarch64-linux-gnu-tree/gcc-10
>   -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck  
> -check-prefixes=CHECK-OUTLINE-ATOMICS-OFF,CHECK-NO-OUTLINE-ATOMICS 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 72';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-apple-darwin -rtlib=compiler-rt -moutline-atomics  -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   : 'RUN: at line 75';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target 
> aarch64-windows-gnu -rtlib=libgcc -moutline-atomics  
> --gcc-toolchain=/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/aarch64-linux-gnu-tree/gcc-7.5.0
>   -### -c 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c 2>&1 | 
> /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck 
> -check-prefix=CHECK-OUTLINE-ATOMICS-ON 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   --
>   Exit Code: 1
>   
>   Command Output (stderr):
>   --
>   /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c:22:19: 
> error: CHECK-FMV-OFF: expected string not found in input
>   // CHECK-FMV-OFF: "-target-feature" "-fmv"
>                     ^
>   <stdin>:1:1: note: scanning from here
>   Fuchsia clang version 16.0.0 (https://llvm.googlesource.com/llvm-project 
> 9b2fecec406d6a6bcda9fbb9251db2ae202c7400)
>   ^
>   <stdin>:6:461: note: possible intended match here
>    "/b/s/w/ir/x/w/staging/llvm_build/bin/clang-16" "-cc1" "-triple" 
> "aarch64-unknown-linux-gnu" "-emit-obj" "-mrelax-all" "--mrelax-relocations" 
> "-disable-free" "-clear-ast-before-backend" "-main-file-name" 
> "aarch64-features.c" "-mrelocation-model" "pic" "-pic-level" "2" 
> "-pic-is-pie" "-mframe-pointer=non-leaf" "-fmath-errno" "-ffp-contract=on" 
> "-fno-rounding-math" "-mconstructor-aliases" "-funwind-tables=2" 
> "-target-cpu" "generic" "-target-feature" "+neon" "-target-feature" "+v8a" 
> "-target-abi" "aapcs" "-mllvm" "-treat-scalable-fixed-error-as-warning" 
> "-debugger-tuning=gdb" 
> "-fcoverage-compilation-dir=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver"
>  "-resource-dir" "/b/s/w/ir/x/w/staging/llvm_build/lib/clang/16" 
> "-internal-isystem" "/b/s/w/ir/x/w/staging/llvm_build/lib/clang/16/include" 
> "-internal-isystem" "/usr/local/include" "-internal-externc-isystem" 
> "/include" "-internal-externc-isystem" "/usr/include" 
> "-fdebug-compilation-dir=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver"
>  "-ferror-limit" "19" "-fno-signed-char" "-fgnuc-version=4.2.1" 
> "-target-feature" "+outline-atomics" "-faddrsig" 
> "-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" "aarch64-features.o" "-x" "c" 
> "/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c"
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                         ^
>   
>   Input file: <stdin>
>   Check file: 
> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c
>   
>   -dump-input=help explains the following input dump.
>   
>   Input was:
>   <<<<<<
>               1: Fuchsia clang version 16.0.0 
> (https://llvm.googlesource.com/llvm-project 
> 9b2fecec406d6a6bcda9fbb9251db2ae202c7400) 
>   check:22'0     
> X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  error: no match found
>               2: Target: aarch64-unknown-linux-gnu 
>   check:22'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               3: Thread model: posix 
>   check:22'0     ~~~~~~~~~~~~~~~~~~~~
>               4: InstalledDir: /b/s/w/ir/x/w/staging/llvm_build/bin 
>   check:22'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               5:  (in-process) 
>   check:22'0     ~~~~~~~~~~~~~~
>               6:  "/b/s/w/ir/x/w/staging/llvm_build/bin/clang-16" "-cc1" 
> "-triple" "aarch64-unknown-linux-gnu" "-emit-obj" "-mrelax-all" 
> "--mrelax-relocations" "-disable-free" "-clear-ast-before-backend" 
> "-main-file-name" "aarch64-features.c" "-mrelocation-model" "pic" 
> "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=non-leaf" "-fmath-errno" 
> "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" 
> "-funwind-tables=2" "-target-cpu" "generic" "-target-feature" "+neon" 
> "-target-feature" "+v8a" "-target-abi" "aapcs" "-mllvm" 
> "-treat-scalable-fixed-error-as-warning" "-debugger-tuning=gdb" 
> "-fcoverage-compilation-dir=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver"
>  "-resource-dir" "/b/s/w/ir/x/w/staging/llvm_build/lib/clang/16" 
> "-internal-isystem" "/b/s/w/ir/x/w/staging/llvm_build/lib/clang/16/include" 
> "-internal-isystem" "/usr/local/include" "-internal-externc-isystem" 
> "/include" "-internal-externc-isystem" "/usr/include" 
> "-fdebug-compilation-dir=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver"
>  "-ferror-limit" "19" "-fno-signed-char" "-fgnuc-version=4.2.1" 
> "-target-feature" "+outline-atomics" "-faddrsig" 
> "-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o" "aarch64-features.o" "-x" "c" 
> "/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/aarch64-features.c" 
>   check:22'0     
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   check:22'1                                                                  
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>          ?                                                                    
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                 possible intended match
>   >>>>>>
>   
>   --
>   
>   ********************
>
> https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8794231481315947569/overview
>
> If this will be hard to fix, can you revert until this can be sorted out?

The test was fixed bf94eac6a3f7c5cd8941956d44c15524fa3751bd 
<https://reviews.llvm.org/rGbf94eac6a3f7c5cd8941956d44c15524fa3751bd> ( it 
missed the case that Fuchsia has ToolChain::RLT_CompilerRT as default 
GetDefaultRuntimeLibType ). 
Please let me know if you have any issues remained with the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to