[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik created this revision. philnik added reviewers: aaron.ballman, rsmith, RKSimon. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ wants to switch from `__compressed_pair` to using `no_unique

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

mstorsjo added a comment. In D122766#3420925 , @thakis wrote: > Windows can handle slashes, but several tools can't. I worry that if we do > something different than cl, some random corner case might break (dbghelp, or > some source server thing or some

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 419642. mboehme added a comment. Herald added a project: All. Uploading newest version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/include/clang/B

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

MaskRay added inline comments. Comment at: clang/test/Driver/modules.cpp:79 +// +// RUN: %clang -fcxx-modules -### %s 2>&1 | FileCheck %s --check-prefix=CHECK-CXX-MODULES +// CHECK-CXX-MODULES: "-fcxx-modules" You need to specify a pre-20 -stdc to make the test

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cec39b91c50: [C++20] [Modules] Don't generate strong function of a partition in importing… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 3cec39b - [C++20] [Modules] Don't generate strong function of a partition in importing modules

Author: Chuanqi Xu Date: 2022-04-01T14:36:04+08:00 New Revision: 3cec39b91c50944095affc52eee286e3161772b4 URL: https://github.com/llvm/llvm-project/commit/3cec39b91c50944095affc52eee286e3161772b4 DIFF: https://github.com/llvm/llvm-project/commit/3cec39b91c50944095affc52eee286e3161772b4.diff LO

[PATCH] D122871: Clang-Formatting

ps-19 added a comment. I think inbuilt clang formatter in llvm ate up my work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.org/D122871 ___ cfe-commits mailing list cfe-

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. @rsmith gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. Herald added a subscriber: MaskRay. @rsmith @Bigcheese gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 ___ cfe-commits m

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 ___ cfe-commits mailing list cfe-co

[PATCH] D122871: Clang-Formatting

ps-19 created this revision. ps-19 added reviewers: aaron.ballman, ktkachov, xbolva00, jyknight, jy7.yang, jyasskin, jyh, jyimusuuhilik, Dan, DaAnIV, danalbert, Danbab, danbeam. Herald added a project: All. ps-19 requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder added a comment. Herald added a project: All. Is there anything missing here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119221/new/ https://reviews.llvm.org/D119221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D122869: [lit] Fix setup of sanitizer environment

vitalybuka created this revision. vitalybuka added reviewers: eugenis, kda, rnk. Herald added a reviewer: bollu. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbi

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:53 + if (auto *LHSValue = dyn_cast_or_null( + Env.getValue(*LHSNorm, SkipPast::Reference))) +if (auto *RHSValue = dyn_cast_or_null( ---

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/StorageLocation.h:59-60 /// can be traced independently by abstract interpretation. For example: a -/// struct with public members. +/// struct with public members

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6916 + Triple Target = S.Context.getTargetInfo().getTriple(); + if (Target.getEnvironment() != Triple::Compute) { +uint32_t Pipeline = It is OK to have SV_GroupIndex on a compute

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield. python3kgae added a project: clang. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added a project: All. python3kgae requested review of this revision. Herald added subs

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

shraiysh added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:74-75 + // for the allocs. + // TODO: Create a dedicated alloca BasicBlock at function creation such that + // we do not need to move the current InertPoint here. +

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

shraiysh added a comment. LGTM. Can we please rebase this and fix the same in `convertOmpAtomicUpdate` and `convertOmpAtomicCapture` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 _

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail marked an inline comment as done. lkail added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:448 + void setMaxAtomicWidth() override { +// For layout on ELF targets, we support up to 16 bytes. +if (getTriple().isOSBinFormatELF()) hubert

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 419618. lkail retitled this revision from "[PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up" to "[PowerPC] Support 16-byte lock free atomics on pwr8 and up". lkail edited the summary of this revision. lkail added a comment. Make 16-byte atomic

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419616. FabioRS marked 6 inline comments as done. FabioRS set the repository for this revision to rG LLVM Github Monorepo. FabioRS added a comment. namespace ns { int y = 1; void foo(); } void ns::foo() {[[int x; y++; ]]} namespace ns { int y = 1; voi

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

ampandey-AMD updated this revision to Diff 419617. ampandey-AMD added a comment. Updated the title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 Files: clang/include/clang/Basic/DiagnosticDriverKinds.

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6348-6349 +} else { + // If neither of these things, we have a user we don't know how to handle, + // so default to previous behavior of emitting a terrible error message. + ret

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added a comment. I also agree that this is a useful debugging builtin, and no program logic should be forced to depend on the output of this builtin. It's just used to print out some useful debugging information Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { erichkeane wrote: > yihanaa wrote: > > erichkeane wrote: > > >

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

ChuanqiXu added a comment. @iains now it passes the CI! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. BTW, it looks like the patch needs to rebase with main so that other people could play it self if interested. Comment at: clang/lib/Sema/SemaConcept.cpp:489 + // Attn Reviewers: we need to do this for the function constraints for + // comparison of

[clang] f1b0a4f - An expression should only contain an unexpanded parameter pack if it

Author: Richard Smith Date: 2022-03-31T20:02:53-07:00 New Revision: f1b0a4fc540f986372f09768c325d505b75b414d URL: https://github.com/llvm/llvm-project/commit/f1b0a4fc540f986372f09768c325d505b75b414d DIFF: https://github.com/llvm/llvm-project/commit/f1b0a4fc540f986372f09768c325d505b75b414d.diff

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

ChuanqiXu updated this revision to Diff 419603. ChuanqiXu added a comment. Specify itanium_abi_triple to make CI on windows passes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 Files: clang/include/clang/Basic/Module.h clang/lib/Seriali

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:448 + void setMaxAtomicWidth() override { +// For layout on ELF targets, we support up to 16 bytes. +if (getTriple().isOSBinFormatELF()) I believe this should be pres

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

thakis added a comment. Do you know what cl.exe does to paths in pdb files? Does it write mixed-slashiness for foo/bar.h includes, or does it write backslashes throughout? Windows can handle slashes, but several tools can't. I worry that if we do something different than cl, some random corner

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/include/clang/Sema/Sema.h:7011 + + bool CheckConstraintSatisfaction( + const NamedDecl *Template, ArrayRef ConstraintExprs, ChuanqiXu wrote: > I think this one need comment too. What's the difference with

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

peixin added a comment. Added @shraiysh and @NimishMishra . They may be more familiar to this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 ___ cfe-comm

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added a comment. Thanks @erichkeane @aaron.ballman ! Yeah, I didn't receive buildbots notice about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 __

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. Herald added a subscriber: StephenFan. @nemanjai mentioned "All the issues I was seeing seem to have been resolved. I can build with CLANG_DEFAULT_PIE_ON_LINUX=on without any failing sanitizer or crt failures." Will recommit. And ppc64 bots have hopefully got better with

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers added a comment. @steakhal, good question. Digging into the change archaeology, I see this change was made by Anna Zaks in Jan 2016 - see commit header below. There's no reference to a review with comments, and I don't know how to find those if they exist, perhaps @NoQ could help wit

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. @jgorbe Sorry for the trouble. Thank you for the backtrace and the revert. Indeed, it seems like I've missed an assumption w.r.t. over/underflow, and will have to sort that out before re-landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:34 // PPC32: @o = global %struct.O zeroinitializer, align 1{{$}} // PPC64: @o = global %struct.O zeroinitializer, align 8{{$}} Just noting that GCC increas

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2113-2117 if (CanonicalType->isRecordType()) { - TmpRes = dumpRecord(CGF, CanonicalType, FieldPtr, Align, Func, Lvl + 1); + TmpRes = dumpRecord(CGF, CanonicalType, FieldLV, Align, Func, Lvl +

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118409/new/ https://reviews.llvm.org/D118409 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D122852: [OPENMP] Fix assertion in clang::ASTContext::getTypeInfoImpl

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. The problem is when mapping of array s

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

jgorbe added a comment. By the way, the line number for `llvm::misexpect::verifyMisExpect` in the stack trace above includes the debug `printf`s I inserted to get the variable values so it won't match the exact line number in the repo. But I think that's the only call to `BranchProbability` in

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

jgorbe added a comment. Hi, this patch is causing floating point exceptions for us during profile generation. On a debug build I get this assertion failure (see stack trace below): clang: /usr/local/google/home/jgorbe/code/llvm/llvm/lib/Support/BranchProbability.cpp:41: llvm::BranchProbabil

[clang] 83bde93 - resolve typo in the manual.

Author: Shivam Date: 2022-04-01T03:15:17+05:30 New Revision: 83bde93cef369f85ea0adc25a4cf2349ea65bb3a URL: https://github.com/llvm/llvm-project/commit/83bde93cef369f85ea0adc25a4cf2349ea65bb3a DIFF: https://github.com/llvm/llvm-project/commit/83bde93cef369f85ea0adc25a4cf2349ea65bb3a.diff LOG: r

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz updated this revision to Diff 419570. beanz added a comment. Updates based on feedback from @aaron.ballman & @MaskRay. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122699/new/ https://reviews.llvm.org/D122699 Files: clang/incl

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 updated this revision to Diff 419567. jhuber6 added a comment. Herald added a reviewer: aaron.ballman. Updating to use an attribute instead to get around the loss of the identifier info when using PCH. Unfortunately this still causes problems when using PCH. Repository: rG LLVM Github

[PATCH] D122846: [CUDA] Don't call inferCUDATargetForImplicitSpecialMember too early.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe528e721633: [CUDA] Don't call inferCUDATargetForImplicitSpecialMember too early. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES

[clang] fe528e7 - [CUDA] Don't call inferCUDATargetForImplicitSpecialMember too early.

Author: Artem Belevich Date: 2022-03-31T13:49:12-07:00 New Revision: fe528e72163371e10242f4748dab687eef30a1f9 URL: https://github.com/llvm/llvm-project/commit/fe528e72163371e10242f4748dab687eef30a1f9 DIFF: https://github.com/llvm/llvm-project/commit/fe528e72163371e10242f4748dab687eef30a1f9.diff

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

steakhal added a comment. Couls you please provide some context about why did we have this suppression in the first place? Other than that, I'm on board with this, but we should really investigate the historical reasons why we had this. If it turns out to be a valid usecase, but a rather speci

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5576 + "program to refer to the anonymous union, and there is therefore no need " + "to mangle its name. '"); +} erichkeane wrote: > rjmccall wrote: > > Unfortunately, I think

[PATCH] D122846: [CUDA] Don't call inferCUDATargetForImplicitSpecialMember too early.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122846/new/ https://reviews.llvm.org/D122846 __

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:79 +for (BoolValue *Constraint : Env1.getFlowConditionConstraints()) { + Expr1 = &Env1.makeAnd(*Expr1, *Constraint); +} Hmm, interesting. I think we

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

aaron.ballman added a comment. In D122822#3420162 , @rsmith wrote: > I'm also concerned that this builtin is making a lot of design decisions on > behalf of the programmer, meaning that either it does exactly what you want > or it's not suitable for you

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane updated this revision to Diff 419548. erichkeane added a comment. Handle the unnamed bitfield case. I'm still not sure how to reproduce the 'unreachable' example I added that @rjmccall suggested was possible, nor how we can deal with that, so waiting on his feedback for how he thinks

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added a comment. In D122822#3420357 , @rsmith wrote: > One thing we could do would be to build a descriptor for the type (as data) > -- a type name string, a type "kind", plus (for a record type) a list of > (field type descriptor, field name

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

rsmith added a comment. One thing we could do would be to build a descriptor for the type (as data) -- a type name string, a type "kind", plus (for a record type) a list of (field type descriptor, field name, offset) tuples -- and pass it to a user-specified function. We could provide a library

[PATCH] D122846: [CUDA] Don't call inferCUDATargetForImplicitSpecialMember too early.

tra created this revision. tra added a reviewer: yaxunl. Herald added a subscriber: bixia. Herald added a project: All. tra requested review of this revision. Herald added a project: clang. Otherwise we may crash because the special member has not been sufficiently set up yet. Fixes #54537 Rep

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

mstorsjo added a comment. > When targeting Windows, the path separator used when targeting Windows > depends on the build environment when Clang _itself_ is built. This leads to > inconsistencies in Chrome builds where Clang running on non-Windows > environments uses the forward slash (/) path

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5561 + // field represents an anonymous record type. + const CXXRecordDecl *RD = FD->getType()->getAsCXXRecordDecl(); + rjmccall wrote: > Alas, bit-fields are also allowed to be anony

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > erichkeane wrote: > > yihanaa wrote: > > >

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

rjmccall added a comment. Unfortunately, this initialization case does allow a situation where Comment at: clang/lib/AST/ItaniumMangle.cpp:5561 + // field represents an anonymous record type. + const CXXRecordDecl *RD = FD->getType()->getAsCXXRecordDecl(); +

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { erichkeane wrote: > yihanaa wrote: > > erichkeane wrote: > > >

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

rjmccall added a comment. In D122822#3420162 , @rsmith wrote: > I'm concerned about the direction of this patch given @rjmccall's comments on > https://reviews.llvm.org/D112626 -- presumably the way we'd want to address > those comments would be to conv

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added a comment. In D122822#3420162 , @rsmith wrote: > I'm concerned about the direction of this patch given @rjmccall's comments on > https://reviews.llvm.org/D112626 -- presumably the way we'd want to address > those comments would be to conve

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > erichkeane wrote: > > yihanaa wrote: > > >

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane updated this revision to Diff 419530. erichkeane added a comment. fix a typo in the 'triple' . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122608/new/ https://reviews.llvm.org/D122608 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenModule.h clang/

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane updated this revision to Diff 419526. erichkeane marked an inline comment as done. erichkeane added a comment. Applied clang-format, removed 'Name' as Aaron found is no longer used, fixed the Sema test to not run on Windows triple, where ifunc is not available CHANGES SINCE LAST ACTI

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { erichkeane wrote: > yihanaa wrote: > > yihanaa wrote: > > > eri

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > yihanaa wrote: > > erichkeane wrote: > > >

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > erichkeane wrote: > > yihanaa wrote: > > > eri

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

aaron.ballman added a comment. FWIW, I'm seeing a precommit CI failure on Windows: Failed Tests (1): Clang :: SemaCXX/externc-ifunc-resolver.cpp May as well also fix up the clang-format issues in the review. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6319 +bool Cod

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

rsmith added subscribers: rjmccall, rsmith. rsmith added a comment. I'm concerned about the direction of this patch given @rjmccall's comments on https://reviews.llvm.org/D112626 -- presumably the way we'd want to address those comments would be to convert a `__builtin_dump_struct(a, f)` call in

Re: [clang] 1905416 - [HLSL] Further improve to numthreads diagnostics

On Thu, Mar 31, 2022 at 12:34 PM Chris Bieneman via cfe-commits wrote: > > > Author: Chris Bieneman > Date: 2022-03-31T11:34:01-05:00 > New Revision: 19054163e11a6632b4973c936e5aa93ec742c866 > > URL: > https://github.com/llvm/llvm-project/commit/19054163e11a6632b4973c936e5aa93ec742c866 > DIFF: >

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { erichkeane wrote: > yihanaa wrote: > > erichkeane wrote: > > >

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > erichkeane wrote: > > yihanaa wrote: > > >

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D122805#3419662 , @martong wrote: > In D122805#3419129 , @steakhal > wrote: > >> Please add a test ca

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { erichkeane wrote: > yihanaa wrote: > > erichkeane wrote: > > >

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch extends the join logic for environments to explicitly

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao added inline comments. Comment at: clang/lib/AST/Expr.cpp:2193 SmallString<256> Path(PLoc.getFilename()); Ctx.getLangOpts().remapPathPrefix(Path); +if (Ctx.getTargetInfo().getTriple().isOSWindows()) { hans wrote: > I was going to say perhaps

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added a comment. In D122822#3420057 , @yihanaa wrote: > There is another question, which way should I print for an empty array? > > #1: Same as non empty array > > int[0] a = [ > ] > > #2: > > int[0] a = [] > > The #1's format is more uni

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added a comment. There is another question, which way should I print for an empty array? #1: Same as non empty array int[0] a = [ ] #2: int[0] a = [] The #1's format is more uniform, and the #2 maybe looks a little clearer. What do you think? @erichkeane Repository: rG LLVM

[clang] 0e89090 - Use functions with prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-03-31T13:45:39-04:00 New Revision: 0e890904ea342aba088ed2a55b537ffdb0562234 URL: https://github.com/llvm/llvm-project/commit/0e890904ea342aba088ed2a55b537ffdb0562234 DIFF: https://github.com/llvm/llvm-project/commit/0e890904ea342aba088ed2a55b537ffdb0562234.diff

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46774df30715: [misexpect] Re-implement MisExpect Diagnostics (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2071 + if (Types.find(Type) == Types.end()) +return Types[Context.VoidPtrTy]; + return Types[Type]; yihanaa wrote: > erichkeane wrote: > > yihanaa wrote: > > > erichkeane wrote: >

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2071 + if (Types.find(Type) == Types.end()) +return Types[Context.VoidPtrTy]; + return Types[Type]; erichkeane wrote: > yihanaa wrote: > > erichkeane wrote: > > > When can we hit thi

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

yaxunl added a comment. This patch can be retitled as "Refactor sanitizer options handling for AMDGPU Toolchain". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 _

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

goncharov added a comment. Hi, I have found this test to cs-preinline-sample-profile.test to be flaky around 10% of the runs. Could you please check what might be the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122471/new/ https://reviews

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > erichkeane wrote: > > Instead of this initi

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:56 +Env.getValue(*RHSNorm, SkipPast::Reference))) + return Env.makeIff(*LHSValue, *RHSValue); + xazax.hun wrote: >

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. Ping, I'd like to finalize the new driver in time for the GPU newsletter and the LLVM Performance Workshop at CGO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 ___

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateF

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added a comment. I just pushed one more commit rG19054163e11a6632b4973c936e5aa93ec742c866 that further refines the subject specification and covers the merging attributes and conflicting attributes on the same decl. Th

[clang] 1905416 - [HLSL] Further improve to numthreads diagnostics

Author: Chris Bieneman Date: 2022-03-31T11:34:01-05:00 New Revision: 19054163e11a6632b4973c936e5aa93ec742c866 URL: https://github.com/llvm/llvm-project/commit/19054163e11a6632b4973c936e5aa93ec742c866 DIFF: https://github.com/llvm/llvm-project/commit/19054163e11a6632b4973c936e5aa93ec742c866.diff

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel added a comment. Thanks for the reviews. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateFields=*/true, +

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419499. ymandel marked 5 inline comments as done. ymandel added a comment. adjusted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 419494. john.brawn added a comment. Adjusted formatting slightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c llvm/lib/CodeG

  1   2   >