shraiysh added inline comments.
================ Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:74-75 + // for the allocs. + // TODO: Create a dedicated alloca BasicBlock at function creation such that + // we do not need to move the current InertPoint here. + if (builder.GetInsertBlock() == ---------------- [Suggestion] We probably don't need to do this, because if a conversion does not require an alloca (for example, barrier), we will be creating a basicblock unnecessarily. So, creating this on-demand seems okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
