aaron.ballman added a comment. FWIW, I'm seeing a precommit CI failure on Windows:
Failed Tests (1): Clang :: SemaCXX/externc-ifunc-resolver.cpp May as well also fix up the clang-format issues in the review. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6319 +bool CodeGenModule::CheckAndReplaceExternCIFuncs( + llvm::GlobalValue *Elem, IdentifierInfo *Name, + llvm::GlobalValue *CppFunc) { ---------------- `Name` appears to be entirely unused? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122608/new/ https://reviews.llvm.org/D122608 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits