[clang-tools-extra] e507711 - Attempt to fix Windows builds after D110386

Author: Kirill Bobyrev Date: 2021-09-28T08:13:01+02:00 New Revision: e50771181b7e0d96b30ee33049dc05172125b927 URL: https://github.com/llvm/llvm-project/commit/e50771181b7e0d96b30ee33049dc05172125b927 DIFF: https://github.com/llvm/llvm-project/commit/e50771181b7e0d96b30ee33049dc05172125b927.diff

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375476. cor3ntin added a comment. Rename commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modernize-unary-s

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375475. cor3ntin added a comment. Accept \r as an escape sequence n unevaluated string literal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-e

[clang-tools-extra] 1bcd6b5 - [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

Author: Kirill Bobyrev Date: 2021-09-28T07:44:28+02:00 New Revision: 1bcd6b51a98263d440ff7549070060f7e7b0326a URL: https://github.com/llvm/llvm-project/commit/1bcd6b51a98263d440ff7549070060f7e7b0326a DIFF: https://github.com/llvm/llvm-project/commit/1bcd6b51a98263d440ff7549070060f7e7b0326a.diff

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 375472. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/builtins-amdgcn.

[PATCH] D110485: Support [[no_unique_address]] for all targets.

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. MSVC gets to chose the ABI rules for their platform. It is not Clang policy to pick ABI rules and then break them later. If you'd like to contribute an implementation of `[[msvc

[PATCH] D110485: Support [[no_unique_address]] for all targets.

ivan171 added a comment. In D110485#3026533 , @rjmccall wrote: > We should not add a standard feature with ABI impact if we aren't certain > we're going to match MSVC's ABI on it. I'm sorry, but this needs to wait > until there's an MSVC release that o

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375468. expnkx added a comment. should be diff3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/include/clang/Basic/Attr.td clang/test/Preprocessor/has_attribute.cpp clang/test/SemaCXX/cx

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. In D110485#3026533 , @rjmccall wrote: > We should not add a standard feature with ABI impact if we aren't certain > we're going to match MSVC's ABI on it. I'm sorry, but this needs to wait > until there's an MSVC release that of

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. In D110485#3026533 , @rjmccall wrote: > We should not add a standard feature with ABI impact if we aren't certain > we're going to match MSVC's ABI on it. I'm sorry, but this needs to wait > until there's an MSVC release that of

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375466. expnkx added a comment. itanium + microsoft test both CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/include/clang/Basic/Attr.td clang/test/SemaCXX/cxx2a-no-unique-address.cpp In

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:44 #include "clang/Basic/TargetCXXABI.h" +#include "clang/Basic/TargetInfo.h" #include "clang/Basic/XRayLists.h" It's a shame to have to do this in such a pervasively-included head

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

rjmccall added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1095 CanQualType FloatComplexTy, DoubleComplexTy, LongDoubleComplexTy; - CanQualType Float128ComplexTy; + CanQualType Float128ComplexTy, Ibm128ComplexTy; CanQualType VoidPtrTy, NullPtrTy; ---

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, well, that's a huge simplification! Thank you for pushing on this with the language group. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110281/new/ https://revi

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. I think it would be better to provide a generic ABI specification that is designed to "lower" `_BitInt` types into more basic concepts that ABIs typically already have rules for. It would be appropriate to note at the top that this is only a generic specification and

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

rjmccall added a comment. `ObjCObjectPointerType` used to have a much weirder representation for the builtin object types like `id` and `Class`, and it's possible that this was an artifact of that. Otherwise I'm not sure, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new

[PATCH] D110485: Support [[no_unique_address]] for all targets.

rjmccall added a comment. We should not add a standard feature with ABI impact if we aren't certain we're going to match MSVC's ABI on it. I'm sorry, this needs to wait until MSVC releases a compiler that supports this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https:

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375461. expnkx added a comment. I just find that Preprocessor test has a windows (msvc not gnu) specific test that tests no_unique_address. add that to patch and see whether it is mergable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/

Re: [clang] 76d845c - [clang-format] Fix unittest failures with -Werror

FWIW, a common way to address this issue is to use the 'unsigned' suffix, as in: EXPECT_EQ(x, 5u); On Thu, Sep 23, 2021 at 4:24 PM Nemanja Ivanovic via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Nemanja Ivanovic > Date: 2021-09-23T18:24:39-05:00 > New Revision: 76d845cb169f048cb

[PATCH] D110358: [WIP][OpenMP][DeviceRTL] Add the initial support for SIMD execution (NOT FOR REVIEW)

tianshilei1992 updated this revision to Diff 375457. tianshilei1992 added a comment. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When it is `target simd`: - outlined function can be emitted. - function call to `__kmpc_simd_51` can be emitted. Reposit

[PATCH] D110607: [Inliner] Attempt to inline calls to alwaysinline functions first

aeubanks added a comment. I'll update the tests if this lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110607/new/ https://reviews.llvm.org/D110607 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D110607: [Inliner] Attempt to inline calls to alwaysinline functions first

aeubanks created this revision. aeubanks added a reviewer: mtrofin. Herald added subscribers: ormris, hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For PR46945 we added an extra alwaysinline i

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. ninja: error: unknown target 'check-libc', did you mean 'check-lit'? what's wrong with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 ___ cfe-commits mailing list cfe-

[PATCH] D110599: [test] Don't run optimization-remark.c against the legacy PM

aeubanks updated this revision to Diff 375445. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110599/new/ https://reviews.llvm.org/D110599 Files: clang/test/Frontend/optimization-remark.c Index: clang/test/Front

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG593b074a096c: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc… (authored by saghir). Repository: rG LLVM Github Monorepo

[clang] 593b074 - [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

Author: Ahsan Saghir Date: 2021-09-27T19:51:28-05:00 New Revision: 593b074a096c542c6753916caa754f321a111f21 URL: https://github.com/llvm/llvm-project/commit/593b074a096c542c6753916caa754f321a111f21 DIFF: https://github.com/llvm/llvm-project/commit/593b074a096c542c6753916caa754f321a111f21.diff

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:470 + ExpectedHint{": S1", "x"}, + ExpectedHint{": S2::Inner", "y"}); } mizvekov wrote: > nridge wrote: > > mizvekov wrote: > > > mi

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 375443. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > "as binder can NOT discard a subset of a csect."? Thanks, this does looks better! > The linker (binder) doesn't have to discard a subset of csect, but it should > ensure there are not two non-local symbols with the same name. > The latter is what I request. > Without

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:470 + ExpectedHint{": S1", "x"}, + ExpectedHint{": S2::Inner", "y"}); } nridge wrote: > mizvekov wrote: > > mizvekov wrote: > > >

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously, the code in add_new_check.py that loo

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:470 + ExpectedHint{": S1", "x"}, + ExpectedHint{": S2::Inner", "y"}); } mizvekov wrote: > mizvekov wrote: > > nridge wrote: > > > Th

[PATCH] D110599: [test] Don't run optimization-remark.c against the legacy PM

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We may not emit some inlining remarks under -O0 (which seems reasonable), so use -O1 in these tests. This happens to make it pass when the legacy PM i

[PATCH] D109967: Simplify handling of builtin with inline redefinition

kees added a comment. Yeah, I can confirm that many cases are improved with this patch (others are more sensitive and depend on the __bos behavior I mentioned). With the 17 kernel FORTIFY self-tests, all 17 fail without this patch. With this patch, 9 start passing. Nice! CHANGES SINCE LAST AC

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" HazardyKnusperkeks wrote: > feg208 wrote: > > HazardyKnusperkeks wro

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375431. expnkx added a comment. do not know why it cannot be built. upload and then verify again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/include/clang/Basic/Attr.td clang/test/SemaC

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. @aaron.ballman ping. Hi, Aaron, did you get time looking at this patch again? I made some adjustments in test and explained overloadable attribute use case in comments. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

tra updated this revision to Diff 375425. tra edited the summary of this revision. tra added a comment. Fixed the failing test affected by the search path changes. Disabled addition of CUDA include path if -nogpuinc is in effect. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

tra created this revision. tra added reviewers: tambre, jlebar. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. This allows clang to work on Linux distributions like Debian where /include may be a symlink to /usr/include. We only need

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen updated this revision to Diff 375422. ychen added a comment. - Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/incl

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

JonChesterfield added a comment. This seems to be related to some things failing on amdgpu at present: > Target AMDGPU RTL --> Error wrong exec_mode value specified in HSA code > object file: 3 The semantics for this mode seem to have been introduced in D106460

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. In D110422#3025911 , @jsji wrote: >> "as binder can NOT discard only part of a csect." this part caused confusion >> to me... > > OK, yeah, csect is special to XCOFF, so this is not the same concept of > sections in ELF. "as bi

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen updated this revision to Diff 375414. ychen added a comment. - Disable comma operator diagnose in SFINAE context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Basic/D

[PATCH] D109967: Simplify handling of builtin with inline redefinition

kees added a comment. I'm setting up to test this patch (thank you!) using my current kernel FORTIFY improvements. Right now I have a bunch of compile-time behavior selftests written: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/overflow&id=3c5221f3f4fd865a78

[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Headers/altivec.h:17337 static __inline__ vector long long __ATTRS_o_ai vec_vbpermq(vector unsigned char __a, vector unsigned char __b) { re

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. @rsmith can you please help with committing patch to trunk? Do not sure if I have correct rights to do it. Were are several failing tests, seems like it is caused by bugs in pre-merge checks (For example this one on win: https://github.com/google/llvm-premerge-checks

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > "as binder can NOT discard only part of a csect." this part caused confusion > to me... OK, yeah, csect is special to XCOFF, so this is not the same concept of sections in ELF. > I haven't verified but it is possible that PGO picks the first pair (zero > value) and hav

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. > However, on AIX, the current binder can NOT discard the weak symbols if we > put all of them into the same csect, as binder can NOT discard only part of a > csect. "as binder can NOT discard only part of a csect." this part caused confusion to me... > CountersOffset

[PATCH] D110586: Update `DynTypedNode` to support the conversion of TypeLocs.

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g, sbenza. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This provides better support for TypeLocs to allow TypeLoc-related Matchers to feature stricter

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75f0194d3d25: [Driver] Remove confusing *-linux-android detection with non-android --target= (authored by MaskRay). Repository: rG LLVM Github Mon

[clang] 75f0194 - [Driver] Remove confusing *-linux-android detection with non-android --target=

Author: Fangrui Song Date: 2021-09-27T13:28:40-07:00 New Revision: 75f0194d3d252388635325a78490f5c0f49c4ca6 URL: https://github.com/llvm/llvm-project/commit/75f0194d3d252388635325a78490f5c0f49c4ca6 DIFF: https://github.com/llvm/llvm-project/commit/75f0194d3d252388635325a78490f5c0f49c4ca6.diff

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. OK, I may not describe the example clearly. Let me use example code with offsets and llvm internal calculations as the example, so that you might be clearer. Let us say we have 2 objects , which both have weak function foo (and some non-weak functions). [2054] m 0x1

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

MaskRay updated this revision to Diff 375383. MaskRay edited the summary of this revision. MaskRay added a reverted change: D53463: [Driver] allow Android triples to alias for non Android targets. MaskRay added a comment. revert D53463 Repository: rG LLVM Git

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

Ping on this On Wed, Sep 15, 2021 at 1:52 PM David Blaikie wrote: > > > On Tue, Sep 14, 2021 at 10:04 AM Richard Smith > wrote: > >> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> Author: David Blaikie >>> Date: 2021-09-13T19:17:0

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

nickdesaulniers added a comment. Sorry, I missed the email for this code review, let me check my filters aren't too agressive. > The Android kernel build does not use the Android triple. That's no longer the case, so we might as well just wholesale revert D53463

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375374. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Add parens in CFG.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/inc

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1541 + if (IsConsteval && NotLocation.isValid()) { +if (ElseStmt.isUnset()) + ElseStmt = Actions.ActOnNullStmt(ThenStmtLoc); aaron.ballman wrote: > cor3ntin wrote: > > aaron.bal

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375370. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Diag

[PATCH] D110482: [clang] Implement if consteval (P1938)

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1541 + if (IsConsteval && NotLocation.isValid()) { +if (ElseStmt.isUnset()) + ElseStmt = Actions.ActOnNullStmt(ThenStmtLoc); cor3ntin wrote: > aaron.ballman wrote: > > erichk

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

modimo added a comment. Thanks for the thorough review @tejohnson! I'll do additional validation on FB code that uses exceptions and if that all looks good I'll send up a change to turn this default on with the findings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1541 + if (IsConsteval && NotLocation.isValid()) { +if (ElseStmt.isUnset()) + ElseStmt = Actions.ActOnNullStmt(ThenStmtLoc); aaron.ballman wrote: > erichkeane wrote: > > So this i

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20faf789199d: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation (authored by modimo). Changed prior to commit: https://

[clang] 20faf78 - [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

Author: modimo Date: 2021-09-27T12:28:07-07:00 New Revision: 20faf789199d31a40c7f1a359361980c65067aab URL: https://github.com/llvm/llvm-project/commit/20faf789199d31a40c7f1a359361980c65067aab DIFF: https://github.com/llvm/llvm-project/commit/20faf789199d31a40c7f1a359361980c65067aab.diff LOG: [

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5942 "jump bypasses initialization of VLA type alias">; def note_protected_by_constexpr_if : Note< "jump enters controlled statement of constexpr if">; cor3ntin

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5942 "jump bypasses initialization of VLA type alias">; def note_protected_by_constexpr_if : Note< "jump enters controlled statement of constexpr if">; erichkeane

[PATCH] D110482: [clang] Implement if consteval (P1938)

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1541 + if (IsConsteval && NotLocation.isValid()) { +if (ElseStmt.isUnset()) + ElseStmt = Actions.ActOnNullStmt(ThenStmtLoc); erichkeane wrote: > So this is interesting. I'm

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei updated this revision to Diff 375360. lei added a comment. Address review comments and add handling for vector long types without vsx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109178/new/ https://reviews.llvm.org/D109178 Files: clang/in

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added inline comments. Comment at: clang/lib/AST/Stmt.cpp:915 -IfStmt::IfStmt(const ASTContext &Ctx, SourceLocation IL, bool IsConstexpr, - Stmt *Init, VarDecl *Var, Expr *Cond, SourceLocation LPL, - SourceLocation RPL, Stmt *Then, SourceL

[clang] 18cf5b2 - Fixing docs build

Author: Chris Bieneman Date: 2021-09-27T14:16:28-05:00 New Revision: 18cf5b220d3f5e5ee1998a163764e15e56763815 URL: https://github.com/llvm/llvm-project/commit/18cf5b220d3f5e5ee1998a163764e15e56763815 DIFF: https://github.com/llvm/llvm-project/commit/18cf5b220d3f5e5ee1998a163764e15e56763815.diff

[PATCH] D108567: Implement #pragma clang final extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e48ef20358f: Implement #pragma clang final extension (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D108567?vs=374377&id=

[clang] 1e48ef2 - Implement #pragma clang final extension

Author: Chris Bieneman Date: 2021-09-27T14:11:16-05:00 New Revision: 1e48ef20358fb097f43d9b133e33bd23723d79c2 URL: https://github.com/llvm/llvm-project/commit/1e48ef20358fb097f43d9b133e33bd23723d79c2 DIFF: https://github.com/llvm/llvm-project/commit/1e48ef20358fb097f43d9b133e33bd23723d79c2.diff

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay added a comment. Supplement: Even if you omit the vendor part in `-DLLVM_DEFAULT_TARGET_TRIPLE` (if unspecified, use `-DLLVM_HOST_TRIPLE`), `x86_64-linux-gnu`, you will see `Target: x86_64-unknown-linux-gnu` in `clang -v` output (and similarly in `-dumpmachine`/`--print-target-triple`).

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375352. cor3ntin added a comment. Herald added a subscriber: dexonsmith. use ConstexprSpecKind to describe whether the IfStmt is constexpr or consteval. Other minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

HazardyKnusperkeks added a comment. In D109951#3015841 , @guitard0g wrote: > @MyDeveloperDay @HazardyKnusperkeks I don't have commit access, could one of > you commit this for me? Thanks so much for your review! > > Name: Josh Learn > Email: joshua_le...

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

MaskRay added a comment. @marxin Can you check this from Suse perspective? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109727/new/ https://reviews.llvm.org/D109727 ___ cfe-commits mailing list cfe-c

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added a comment. In D108247#3025415 , @tambre wrote: >> Another workaround would be to place a fake /usr/lib/cuda/include/cuda.h >> with something like this: > > My CMake CI bot [[ https://open.cdash.org/test/498767666 | encountered > `cmath` templa

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks added a subscriber: tstellar. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" feg208

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

thakis added a comment. Reverted in 36dc5c048ac745ef62769dd824a9a13659afc2ef for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386

[clang-tools-extra] 36dc5c0 - Revert "[clangd] Refactor IncludeStructure: use File (unsigned) for most computations"

Author: Nico Weber Date: 2021-09-27T14:38:18-04:00 New Revision: 36dc5c048ac745ef62769dd824a9a13659afc2ef URL: https://github.com/llvm/llvm-project/commit/36dc5c048ac745ef62769dd824a9a13659afc2ef DIFF: https://github.com/llvm/llvm-project/commit/36dc5c048ac745ef62769dd824a9a13659afc2ef.diff LO

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

carlosgalvezp added a comment. Thanks for the clarification, makes sense! I got the notification about the build failure, thanks for fixing. I actually added it in the first place but then noticed that checkers typically didn't include any STL header so I thought maybe there was a restriction o

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tambre added a comment. In D108247#3025238 , @tra wrote: > So, what's the current state of affairs regarding CUDA SDK layout in debian? `/usr/bin`: most executables , `nvcc` and `

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

aaron.ballman added a comment. In D110493#3025394 , @carlosgalvezp wrote: > Super, thanks! It went really smooth :) > > Newbie question: I noticed that `[clang-tidy]` is no longer part of the > commit message, I thought the intention was to keep it to m

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen added a comment. In D103938#3025265 , @aaron.ballman wrote: > In D103938#3024938 , @ychen wrote: > >> In D103938#3018918 , @ychen wrote: >> >>> In D103938#3018588 <

[clang-tools-extra] ef0f728 - Add a missing include to appease the build bots

Author: Aaron Ballman Date: 2021-09-27T14:19:39-04:00 New Revision: ef0f728abe6ec43f2f75082c9b47ec7fade2ead2 URL: https://github.com/llvm/llvm-project/commit/ef0f728abe6ec43f2f75082c9b47ec7fade2ead2 DIFF: https://github.com/llvm/llvm-project/commit/ef0f728abe6ec43f2f75082c9b47ec7fade2ead2.diff

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

carlosgalvezp added a comment. Super, thanks! It went really smooth :) Newbye question: I noticed that `[clang-tidy]` is no longer part of the commit message, I thought the intention was to keep it to more easily glance through the commit history? CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#3022332 , @sylvestre.ledru wrote: > @phosek > It was probably my fault (mix of different in-tree / out of tree builds) > Quick question, why the path to `__config_site` contains this triple > `x86_64-pc-linux-gnu` > (in `

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

aaron.ballman closed this revision. aaron.ballman added a comment. In D110493#3025343 , @carlosgalvezp wrote: > Awesome, thanks a lot for the review! :) Sure, you can use the following to > commit on my behalf, since I don't think I have such permission

[clang-tools-extra] b2a2c38 - Fix bug in readability-uppercase-literal-suffix

Author: Carlos Galvez Date: 2021-09-27T14:03:53-04:00 New Revision: b2a2c38349a18b89b04d342632d5ea02f86dfdd6 URL: https://github.com/llvm/llvm-project/commit/b2a2c38349a18b89b04d342632d5ea02f86dfdd6 DIFF: https://github.com/llvm/llvm-project/commit/b2a2c38349a18b89b04d342632d5ea02f86dfdd6.diff

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

carlosgalvezp added a comment. Awesome, thanks a lot for the review! :) Sure, you can use the following to commit on my behalf, since I don't think I have such permissions: Carlos Galvez carlosgalv...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110493/new/ https://reviews.

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

aaron.ballman added a comment. I'm not certain how, but somehow this review is set to be uneditable, so I cannot mark it as accepted (or close it later once it lands). > bakinovsky-m created this object with edit policy "Administrators". I think you may need to edit the review's policy so it go

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

aaron.ballman added a comment. Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, please let me know what name and email address you would like me to use for patch attribution in git. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. Sorry, I still don't understand this response: > We have 3 sets weak symbols here: weak_func, profc_weak_foo, profd_weak_func. > We can't ensure that binder always choose 3 of them from same object. So this part of the description isn't clear to me: > However, on AIX,

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Would you like me to commit on your behalf? If so, please let me know what name and email address you'd like me to use for patch attribution in git. CHANGES SI

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. In D110422#3025133 , @MaskRay wrote: > The description isn't clear why the previous `weak` symbol usage does not > work. Have you verified that it does not work? Yes, we started with the `weak` symbols for `profc`/`profd` first, an

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman added a comment. In D103938#3024938 , @ychen wrote: > In D103938#3018918 , @ychen wrote: > >> In D103938#3018588 , >> @aaron.ballman wrote: >> >>> In D10393

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added a comment. So, what's the current state of affairs regarding CUDA SDK layout in debian? Clang does rely on very particular ordering of includes, so having CUDA headers in a location clang does not expect will lead to issues sooner or later. If the headers are not available where --cuda-

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGc4afb5f81b62: [HIP] Fix linking of asanrt.bc (authored by yaxunl). Herald added a project: clang. Changed p

[clang] c4afb5f - [HIP] Fix linking of asanrt.bc

Author: Yaxun (Sam) Liu Date: 2021-09-27T13:25:46-04:00 New Revision: c4afb5f81b62b903e4af8a92235e1b901e184040 URL: https://github.com/llvm/llvm-project/commit/c4afb5f81b62b903e4af8a92235e1b901e184040 DIFF: https://github.com/llvm/llvm-project/commit/c4afb5f81b62b903e4af8a92235e1b901e184040.dif

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

erichkeane added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; aaron.ballman wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > aaron.ballman wrote: > > > > cor3ntin wrote: > >

  1   2   >