aaron.ballman added a comment. In D110493#3025394 <https://reviews.llvm.org/D110493#3025394>, @carlosgalvezp wrote:
> Super, thanks! It went really smooth :) > > Newbie question: I noticed that `[clang-tidy]` is no longer part of the > commit message, I thought the intention was to keep it to more easily glance > through the commit history? We usually put `[project]` markings in the subject so it's easier for code reviewers to know what PRs are in an area of interest to them, and I suppose I could keep them as part of the commit message. But the commit message "title" is supposed to be concise (I hear 50 characters is a common measure for it), so I usually remove the [project] marker reflexively to keep the title of the commit brief. Btw, this patch failed some bots because of a missing #include which I've added in ef0f728abe6ec43f2f75082c9b47ec7fade2ead2 <https://reviews.llvm.org/rGef0f728abe6ec43f2f75082c9b47ec7fade2ead2>. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110493/new/ https://reviews.llvm.org/D110493 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
