rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed.
MSVC gets to chose the ABI rules for their platform. It is not Clang policy to pick ABI rules and then break them later. If you'd like to contribute an implementation of `[[msvc::no_unique_address]]` that matches MSVC's ABI, that would be welcome. I don't know, maybe that's as simple as making it use the existing implementation; @zygoloid might know better. But "add an ABI feature ahead of the platform owner and then fix the ABI problems later" is not how we do things. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
