[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

lebedev.ri added a comment. I think this should be as simple as having an opt-in "DisableAllAliaseeChecks" option in `.clang-tidy`, that force-disables all the checks that are actually aliases and not proper checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D110310: State the kind of VerifyDiagnosticConsumer regex syntax (NFC)

sberg created this revision. sberg added a project: clang. sberg requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110310 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h Index: clang/include/clang/Frontend/VerifyDiagnosticConsum

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

carlosgalvezp added a comment. Herald added a subscriber: jeroen.dobbelaere. Hi! I've been following this issue about aliases in clang-tidy through different bug reports and commit attempts. I see that the author abandoned this commit without an explanation. What's the reason? Where can I follo

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:61 SrcMgr::CharacteristicKind FileKind = SrcMgr::C_User; + FileID ID; }; Most includes are part of the preamble, so there are two relevant parse actions (preamble, and mainfile-

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. HIP currently uses -mlink-builtin-bitcode to link all bitcode libraries, which changes the linkage of functions to be internal once they are l

[PATCH] D110286: [WIP][Clang][OpenMP] Add new clang argument `-fopenmp-target-simd`

tianshilei1992 updated this revision to Diff 374433. tianshilei1992 added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. it can emit right mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110286/new/ h

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

aheejin accepted this revision. aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:14 // Instructions requiring HasSIMD128 and the simd128 prefix byte +multiclass ABSTRACT_SIMD_Ihttps://reviews.llvm.org/D110295/new/ https://reviews.

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added inline comments. Comment at: clang/test/CodeGen/thinlto-funcattr-prop.ll:14 + +; RUN: llvm-dis %t/b.bc -o - | FileCheck %s + tejohnson wrote: > This is checking the summary generated by opt, not the result of the > llvm-lto2 run. Fixed. ==

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 374431. modimo marked 23 inline comments as done. modimo added a comment. Address feedback, rename funcattrs-prop-indirect.ll to funcattrs-prop-unknown.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebec077e07f5: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow… (authored by pengfei). Repository: rG LLVM Github M

[clang] ebec077 - [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

Author: Wang, Pengfei Date: 2021-09-23T11:02:48+08:00 New Revision: ebec077e07f5d35a870f075fb665c006978d49ea URL: https://github.com/llvm/llvm-project/commit/ebec077e07f5d35a870f075fb665c006978d49ea DIFF: https://github.com/llvm/llvm-project/commit/ebec077e07f5d35a870f075fb665c006978d49ea.diff

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Nevermind. LGTM Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:1315 vti.RegClass:$merge, vti.RegClass:$rs2, vti.RegClass:$rs1,

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

craig.topper requested changes to this revision. craig.topper added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:1315 vti.RegClass:$merge, vti.RegClass:$rs2, vti.RegClass:$rs1, -

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 ___

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:102-106 + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); + if (Iter != EBB->end()) +++Iter; + Builder.SetInsertPoint(EBB, Iter); -

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added a comment. Thanks Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109658/new/ https://reviews.llvm.org/D109658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374419. hsmhsm added a comment. Update source comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/b

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109658/new/ https://reviews.llvm.org/D109658 ___

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. In D110257#3016113 , @rnk wrote: > In D110257#3015641 , @hsmhsm wrote: > >> The logic at >> https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Utils/InlineFunction.cpp#L209

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added a comment. By the way, we synced with GCC and we are using the same order in the builtins now. https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=db3b96df03fdbe2fb770729501e2e9b65e66c2da;hp=ed643e9f171e99b0aa1453b3f29ed1103e9b5c80 We still have some different builtin names due to hi

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

rjmccall added a comment. Hmm. It sounds like we misbehave if we're working with a non-canonical ivar. While it does seem preferable in general for lookups done after merging modules to return the canonical ivar, I'm not sure we can rely on the AST only having references to that ivar, since e

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2972 #define _mm_mask_fcmadd_round_sch(A, U, B, C, R) \ ((__m128h)__builtin_ia32_selectps_128( \ (__mmask8)(U & 1),

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2972 #define _mm_mask_fcmadd_round_sch(A, U, B, C, R) \ ((__m128h)__builtin_ia32_selectps_128( \ (__mmask8)(U & 1)

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2972 #define _mm_mask_fcmadd_round_sch(A, U, B, C, R) \ ((__m128h)__builtin_ia32_selectps_128( \ (__mmask8)(U & 1),

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374405. tra added a comment. Removed a test file committed by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt clang/l

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374404. tra added a comment. Cleanups. Added more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} leonardchan wrote: > phosek wrote: > > This

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 374396. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 Files: compiler-rt/test/CMakeLists.txt Index: compiler-rt/test/CMakeLists.txt ==

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

ngzhian accepted this revision. ngzhian added a comment. This revision is now accepted and ready to land. The binary opcodes LGTM, not too sure about the tablegen stuff, tests look good too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110295/new/

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

tlively created this revision. tlively added reviewers: aheejin, ngzhian. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-co

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

nemanjai accepted this revision. nemanjai added a comment. LGTM other than the code can be simplified as suggested. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15888-15895 +SmallVector RevOps; +unsigned NumVecs = +(BuiltinID == PPC::BI__builtin_mma_b

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} phosek wrote: > This is going to run Ninja

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 374393. leonardchan retitled this revision from "[compiler-rt] Ensure LIT_TEST_DEP targets are actually built" to "[compiler-rt] Ensure required deps for tests targets are actually built". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_texture_intrinsics.h:41 + +namespace { + jlebar wrote: > jlebar wrote: > > what are you trying to accomplish with an anon ns inside a header? > I know you wrote it in the commit message, but th

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110160/new/ https://reviews.llvm.org/D110160 __

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374391. tra marked 2 inline comments as done. tra added a comment. Added better C++11 guards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/C

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song updated this revision to Diff 374388. yonghong-song added a comment. - use -std=c2x attribute syntax `[[]]` in test to more precisely specify the location of the attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/ ht

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. In D110127#3016371 , @aaron.ballman wrote: > In D110127#3013876 , @yonghong-song > wrote: > >> You can see that it doesn't matter where the attribute is placed, the >> attribute i

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#2998350 , @krisb wrote: > But it seems imported declarations are broken not just for static locals, but > for all inlined entities, for example > > namespace ns { > inline __attribute__((always_inline)) > int foo()

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

jansvoboda11 updated this revision to Diff 374383. jansvoboda11 added a comment. Use empty files and `-E` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110160/new/ https://reviews.llvm.org/D110160 Files: clang/unittests/Tooling/ToolingTest.cpp

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

jansvoboda11 added a comment. I think we need a warning option to be able to suppress it (or conditionally promote to an error). Comment at: clang/unittests/Tooling/ToolingTest.cpp:238-245 Args.push_back("tool-executable"); - Args.push_back("-target"); - // Invalid argume

[clang] 747b1a6 - [NFC] Remove trailing spaces from some files

Author: Shilei Tian Date: 2021-09-22T18:17:40-04:00 New Revision: 747b1a67a3dd706ffab9df9ee6f816b75ccaa5b6 URL: https://github.com/llvm/llvm-project/commit/747b1a67a3dd706ffab9df9ee6f816b75ccaa5b6 DIFF: https://github.com/llvm/llvm-project/commit/747b1a67a3dd706ffab9df9ee6f816b75ccaa5b6.diff L

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

jansvoboda11 updated this revision to Diff 374382. jansvoboda11 added a comment. Use flags not specific to Darwin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110160/new/ https://reviews.llvm.org/D110160 Files: clang/unittests/Tooling/ToolingTe

[PATCH] D108567: Implement #pragma clang final extension

beanz updated this revision to Diff 374377. beanz added a comment. Updates based on feedback from @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108567/new/ https://reviews.llvm.org/D108567 Files: clang/docs/LanguageExtensions.rst

[PATCH] D108567: Implement #pragma clang final extension

beanz marked 3 inline comments as done and an inline comment as not done. beanz added a comment. Will push updates in a second. Comment at: clang/test/Lexer/final-macro.c:14 +// expected-warning@+2{{macro 'Foo' has been marked as final and should not be redefined}} +// expecte

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1552179ac019: [WebAssembly] Add relaxed-simd feature (authored by ngzhian, committed by tlively). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 1552179 - [WebAssembly] Add relaxed-simd feature

Author: Zhi An Ng Date: 2021-09-22T14:52:50-07:00 New Revision: 1552179ac0199d819396d8b8db807016a78c8951 URL: https://github.com/llvm/llvm-project/commit/1552179ac0199d819396d8b8db807016a78c8951 DIFF: https://github.com/llvm/llvm-project/commit/1552179ac0199d819396d8b8db807016a78c8951.diff LOG

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbbf2e8c8ae7: Diagnose -Wunused-value based on CFG reachability (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] cbbf2e8 - Diagnose -Wunused-value based on CFG reachability

Author: Yuanfang Chen Date: 2021-09-22T14:38:06-07:00 New Revision: cbbf2e8c8ae7730ff0121f4868de4a7d188feb65 URL: https://github.com/llvm/llvm-project/commit/cbbf2e8c8ae7730ff0121f4868de4a7d188feb65 DIFF: https://github.com/llvm/llvm-project/commit/cbbf2e8c8ae7730ff0121f4868de4a7d188feb65.diff

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

MaskRay added a comment. Please mention GNU ld 2.25 (2014) in the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 ___ cfe-commits mailing list cfe-

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 __

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb875343873a5: [Clang] Ignore BTFTag attr if used as a type attribute (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] b875343 - [Clang] Ignore BTFTag attr if used as a type attribute

Author: Yonghong Song Date: 2021-09-22T13:48:29-07:00 New Revision: b875343873a584965daf507d73ff1fe71eab1953 URL: https://github.com/llvm/llvm-project/commit/b875343873a584965daf507d73ff1fe71eab1953 DIFF: https://github.com/llvm/llvm-project/commit/b875343873a584965daf507d73ff1fe71eab1953.diff

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374362. tra added a comment. Require c++11 for texture support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Head

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374360. tra added a comment. Switched to purely in-header implementation based on constexpr perfect hash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/l

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

yonghong-song updated this revision to Diff 374358. yonghong-song added a comment. - to adjust some wording in AttrDocs.td based on Aaron's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110116/new/ https://reviews.llvm.org/D110116 File

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 374354. gandhi21299 added a comment. - replaced a `cast` with a `dyn_cast` since the return value from `getCalleeFunction()` is not always a Function - `RUN on line 2` was causing 2 more scalar registers to be used on tonga due to @func_alias not being i

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Great, thanks! I will take care of landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111 _

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:81-84 lookup_result R = lookup(Id); for (lookup_iterator Ivar = R.begin(), IvarEnd = R.end(); Ivar != IvarEnd; ++Ivar) { +if (auto *ivar = dyn_cast((*Ivar)->getCanonicalDecl())) --

[PATCH] D110279: [OpenMP][Offloading] Change `bool IsSPMD` to `int8_t Mode` in `__kmpc_target_init` and `__kmpc_target_deinit`

tianshilei1992 added a comment. In D110279#3016332 , @jdoerfert wrote: > This should not change anything, right? Please confirm running a non-trivial > example, like miniqmc or so, and then this is good to go. miniQMC report 26/26 Passed. Will land the

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

aaron.ballman added a comment. In D110127#3013876 , @yonghong-song wrote: > You can see that it doesn't matter where the attribute is placed, the > attribute is always attached to the typedef. > I think the reason is for declarations, we only allow the

[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno, jansvoboda11. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. While working on https://reviews.llvm.org/D110280 I've tried to merge decl contexts as it seems to be

[PATCH] D110286: [WIP][Clang][OpenMP] Add new clang argument `-fopenmp-target-simd`

tianshilei1992 created this revision. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently an OpenMP thread is ma

[PATCH] D110279: [OpenMP][Offloading] Change `bool IsSPMD` to `int8_t Mode` in `__kmpc_target_init` and `__kmpc_target_deinit`

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. This should not change anything, right? Please confirm running a non-trivial example, like miniqmc or so, and then this is good to go. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

aaron.ballman added a comment. In D110127#3013391 , @dblaikie wrote: > Given this is about being preserved into debug info - I imagine it'll have > the same behavior as using a typedef in a function return type - whenever > that currently shows up in th

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson added a comment. In D110276#3016295 , @thakis wrote: > Oh, the win failure > (https://buildkite.com/llvm-project/premerge-checks/builds/57480#f7da3275-775a-4cf4-9624-d3539dd1f709) > might actually be real. Windows doesn't allow deleting files

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

thakis added a comment. Oh, the win failure (https://buildkite.com/llvm-project/premerge-checks/builds/57480#f7da3275-775a-4cf4-9624-d3539dd1f709) might actually be real. Windows doesn't allow deleting files that are still in use, and due to AV or similar, the file might still be in use for a b

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit with documentation grammar. Comment at: clang/include/clang/Basic/AttrDocs.td:2024 +The attribute can also be used as a type qualifi

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110276/new/ https://reviews.llvm.org/D110276 ___ c

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes seem reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

Conanap updated this revision to Diff 374329. Conanap added a comment. Added error testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110282/new/ https://reviews.llvm.org/D110282 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c clang/te

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

Conanap created this revision. Conanap added reviewers: PowerPC, nemanjai, saghir, stefanp. Conanap added projects: PowerPC, clang, LLVM. Herald added a subscriber: kbarton. Conanap requested review of this revision. The `__darn` family of builtins are only available on Pwr9, and only `__darn_32`

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. In D110089#3016145 , @jlebar wrote: >> Depending on which particular operation is used, the arguments vary, too. > > So something like > > T __nv_tex_surf_handler(name, arg1) { > switch (name) { > ... > default: >

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

erichkeane added a comment. @rjmccall : We were able to get the SYCL committee to change the rules to make this feature 'implementable' now based on your feedback, so here it is. This has been baking in our downstream for a while, so my hope is that this is sufficiently validated to be 'done'

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, rjmccall. Herald added subscribers: Naghasan, Anastasia, ebevhan, mgrang, yaxunl. erichkeane requested review of this revision. After significant problems in our downstream with the previous implementation, the SYCL stand

[PATCH] D110279: [WIP][OpenMP][Offloading] Change `bool IsSPMD` to `int8_t Mode` in `__kmpc_target_init` and `__kmpc_target_deinit`

tianshilei1992 updated this revision to Diff 374323. tianshilei1992 added a comment. fix issues and add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110279/new/ https://reviews.llvm.org/D110279 Files: clang/test/OpenMP/declare_target

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno, jansvoboda11. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. When have ObjCInterfaceDecl with the same name in 2 different modules, hitting the assertion > Assert

[PATCH] D110279: [WIP][OpenMP][Offloading] Change `bool IsSPMD` to `int8_t Mode` in `__kmpc_target_init` and `__kmpc_target_deinit`

tianshilei1992 updated this revision to Diff 374318. tianshilei1992 added a comment. fix issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110279/new/ https://reviews.llvm.org/D110279 Files: clang/test/OpenMP/declare_target_codegen_globalizat

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

jlebar added a comment. > Depending on which particular operation is used, the arguments vary, too. So something like T __nv_tex_surf_handler(name, arg1) { switch (name) { ... default: panic(); } } T __nv_tex_surf_handler(name, arg1, arg2) { switch(...) {

[PATCH] D110279: [WIP][OpenMP][Offloading] Change `bool IsSPMD` to `int8_t Mode` in `__kmpc_target_init` and `__kmpc_target_deinit`

tianshilei1992 created this revision. Herald added subscribers: ormris, guansong, hiraditya, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, o

[PATCH] D110278: Adding doWithCleanup abstraction

beanz created this revision. beanz added reviewers: lhames, dblaikie. Herald added subscribers: dexonsmith, mgorny. beanz requested review of this revision. Herald added projects: clang, LLVM. This patch adds a new `doWithCleanup` abstraction to LLVM that works with `llvm::Error`, `int`, `bool`, a

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

rnk added a comment. In D110257#3015641 , @hsmhsm wrote: > The logic at > https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Utils/InlineFunction.cpp#L2093 > assumes that static allocas (within callee) are contiguous. No, it doesn't mak

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:484 + AnyMemberHasInitPerUnion, [&](const FieldDecl *F) { if (!FieldsToInit.count(F)) return; Given tha

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:449 +return false; + if (Tok->is(TT_TypenameMacro)) +return false; I think this is still right, because it is a type (according to the configuration). =

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374312. quinnp added a comment. Moving the semachecking of `test_data_class` from the function to the switch case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Fil

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson created this revision. tejohnson added reviewers: thakis, scott.linder. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In looking at the disk space used by a ninja check-all, I found that a few of the largest files were

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added a subscriber: rnk. jdoerfert added a comment. In D110257#3015712 , @jdoerfert wrote: > In D110257#3015641 , @hsmhsm wrote: > >> In D110257#3015553 , @arsen

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

nemanjai added a comment. The description says it causes issues but there is no test case. Please add the test case that causes issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110273/new/ https://reviews.llvm.org/D110273 ___

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:102-106 + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); + if (Iter != EBB->end()) +++Iter; + Builder.SetInsertPoint(EBB, Iter); -

[clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple,mangled}

Author: David Blaikie Date: 2021-09-22T11:11:49-07:00 New Revision: 38c09ea2d279eabe3602e2002f8cdfcc5380 URL: https://github.com/llvm/llvm-project/commit/38c09ea2d279eabe3602e2002f8cdfcc5380 DIFF: https://github.com/llvm/llvm-project/commit/38c09ea2d279eabe3602e2002f8cdfcc5380.diff

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

Conanap created this revision. Conanap added reviewers: PowerPC, nemanjai, stefanp, saghir. Conanap added projects: clang, LLVM, PowerPC. Herald added subscribers: steven.zhang, kbarton. Conanap requested review of this revision. The signatures for the PowerPC builtins `lharx` and `lbarx` are inco

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 374298. MyDeveloperDay added a comment. Use better vector initialization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 374294. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Remove use of Typenamemacros (we'll solve this a different way later) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D

[clang] 97b2f20 - Change error for storage-class to mean linkage, fix lang-linkage diag

Author: Erich Keane Date: 2021-09-22T10:51:05-07:00 New Revision: 97b2f20a446e54f4354d8f950dfab62c37e6ddf4 URL: https://github.com/llvm/llvm-project/commit/97b2f20a446e54f4354d8f950dfab62c37e6ddf4 DIFF: https://github.com/llvm/llvm-project/commit/97b2f20a446e54f4354d8f950dfab62c37e6ddf4.diff L

[PATCH] D110255: Change error for storage-class to mean linkage, fix lang-linkage diag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110255/new/ https://reviews.llvm.org/D110255 ___ cfe-commits mailing lis

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9923674787: Don't diagnose unused but set when the Cleanup attribute is used. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109862

[clang] af99236 - Don't diagnose unused but set when the Cleanup attribute is used.

Author: Michael Benfield Date: 2021-09-22T17:48:09Z New Revision: af99236747872af7e77092cbf6ddd18fa8623a2f URL: https://github.com/llvm/llvm-project/commit/af99236747872af7e77092cbf6ddd18fa8623a2f DIFF: https://github.com/llvm/llvm-project/commit/af99236747872af7e77092cbf6ddd18fa8623a2f.diff L

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:575 unsigned AlwaysInline : 1; +unsigned NoUnwind : 1; +// Indicate if function contains instructions that mayThrow tejohnson wrote: > No Unwind needs a comment. A

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. Thanks for your patience, finally had a chance to go through everything much more carefully. Looks good, mostly a bunch of small or nitpicky final suggestions. The main comment/question of significance relates to where hasUnknownCall is being set currently. Patch tit

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 374290. serge-sans-paille added a comment. Set default as suggested by @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/

  1   2   >