nemanjai accepted this revision. nemanjai added a comment. LGTM other than the code can be simplified as suggested.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15888-15895 + SmallVector<Value *, 4> RevOps; + unsigned NumVecs = + (BuiltinID == PPC::BI__builtin_mma_build_acc) ? 4 : 2; + for (unsigned i = NumVecs; i > 0; --i) + RevOps.push_back(Ops[i]); + for (unsigned i = 1; i <= NumVecs; ++i) + Ops[i] = RevOps[i - 1]; ---------------- This entire block seems to simply be `std::reverse(Ops.begin() + 1, Ops.end())` Also, please add a note that the very first operand is the pointer to the pair/accumulator that is actually being built. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
