[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D105877: [Coroutines] Run coroutine passes by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a1727ba51d2: [Coroutines] Run coroutine passes by default (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-com

[clang] 8a1727b - [Coroutines] Run coroutine passes by default

Author: Chuanqi Xu Date: 2021-07-15T14:33:40+08:00 New Revision: 8a1727ba51d262365b0d9fe10fef7e50da7022cd URL: https://github.com/llvm/llvm-project/commit/8a1727ba51d262365b0d9fe10fef7e50da7022cd DIFF: https://github.com/llvm/llvm-project/commit/8a1727ba51d262365b0d9fe10fef7e50da7022cd.diff LO

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:265 +/// Create a stub function, suitable for being passed to atexit, +/// which passes the given address to the given destructor function. Since the function has some spe

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 358839. RedDocMD added a comment. Cleanup, still doesn't work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrMode

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke updated this revision to Diff 358835. Sockke added a comment. update to display context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D106030: [Clang] add support for error+warning fn attrs

efriedma added a comment. In D106030#2878897 , @arsenm wrote: > Adding something to the IR for the sole purpose of producing a diagnostic > feels really weird. I'm not sure I see why the frontend can't see this > attribute and directly warn In C++, you

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

MTC accepted this revision. MTC added a comment. This revision is now accepted and ready to land. LGTM, thanks for your cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 ___ cfe-commits mailin

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. The PPC instructions tablegen part looks good to me. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1589 [IntrNoMem, IntrHasSideEffects]>; def int

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke updated this revision to Diff 358820. Sockke edited the summary of this revision. Sockke added a comment. Thanks for your review! I have run clang/docs/tools/dump_ast_matchers.py to regenerate the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://r

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham marked an inline comment as done. bnbarham added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:2854 +bool recompileFinalized = +Result == OutOfDate && Capabilities & ARR_OutOfDate && +getModuleManager().getModuleCache(

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham updated this revision to Diff 358826. bnbarham marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105328/new/ https://reviews.llvm.org/D105328 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Have 1 punctuation nit (that I'm not sure about), the rest looks good. Comment at: clang/lib/Serialization/ASTReader.cpp:2854 +bool recompileFinalized = +

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/avx512cfma-intrinsics.ll:3 +; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=knl -mattr=+avx512bw -mattr=+avx512fp16 -mattr=+avx512vl | FileCheck %s + +declare <4 x float> @llvm.x86.avx512fp16.mask.vfmaddc.ph.1

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15140 + Value *fdiv = Builder.CreateFDiv(X, Y, "recipdiv"); + Builder.getFastMathFlags().operator&=(FMF); + return fdiv; Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D106030: [Clang] add support for error+warning fn attrs

arsenm added a comment. Adding something to the IR for the sole purpose of producing a diagnostic feels really weird. I'm not sure I see why the frontend can't see this attribute and directly warn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1060

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 358814. nickdesaulniers added a comment. - remove accidentally committed logging statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 Files: clang/docs

[PATCH] D106030: [Clang] add support for error+warning fn attrs

arsenm added inline comments. Comment at: llvm/lib/CodeGen/PreISelIntrinsicLowering.cpp:208 } +// TODO: is this the best pass for this? +for (BasicBlock &BB : F) { Why not just do in in codegen in IRTranslator/SelectionDAGBuilder?

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, aaron.ballman, craig.topper, efriedma, lebedev.ri, jdoerfert, arsenm. Herald added subscribers: dexonsmith, hiraditya. nickdesaulniers requested review of this revision. Herald added subscribers: llvm-commits, cfe-comm

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham marked 2 inline comments as done. bnbarham added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1063 +<< ModuleName; +return ImportingInstance.getFrontendOpts().AllowPCMWithCompilerErrors; + } vsapsai wrote: > bnbarham

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham updated this revision to Diff 358798. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105328/new/ https://reviews.llvm.org/D105328 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/include/clang/Basic/DiagnosticSerialization

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde79ba9f9a2d: [OpenCL] opencl-c.h: CL3.0 generic address space (authored by airlied). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] de79ba9 - [OpenCL] opencl-c.h: CL3.0 generic address space

Author: Dave Airlie Date: 2021-07-15T10:51:04+10:00 New Revision: de79ba9f9a2de3d86fa3f44b57e147844b6f2625 URL: https://github.com/llvm/llvm-project/commit/de79ba9f9a2de3d86fa3f44b57e147844b6f2625 DIFF: https://github.com/llvm/llvm-project/commit/de79ba9f9a2de3d86fa3f44b57e147844b6f2625.diff L

[PATCH] D105601: opencl-c.h: reorder atomic operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG090f007e3481: [OpenCL][NFC] opencl-c.h: reorder atomic operations (authored by airlied). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 090f007 - [OpenCL][NFC] opencl-c.h: reorder atomic operations

Author: Dave Airlie Date: 2021-07-15T10:48:44+10:00 New Revision: 090f007e3481863430e4443765769e73f8f40e5f URL: https://github.com/llvm/llvm-project/commit/090f007e3481863430e4443765769e73f8f40e5f DIFF: https://github.com/llvm/llvm-project/commit/090f007e3481863430e4443765769e73f8f40e5f.diff L

[libclc] ea469b0 - libclc: Add -cl-no-stdinc to clang flags on clang >=13

Author: Jan Vesely Date: 2021-07-15T10:43:26+10:00 New Revision: ea469b08b847cef5f4c8187228f1e4bbf881706a URL: https://github.com/llvm/llvm-project/commit/ea469b08b847cef5f4c8187228f1e4bbf881706a DIFF: https://github.com/llvm/llvm-project/commit/ea469b08b847cef5f4c8187228f1e4bbf881706a.diff LO

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers added a comment. Thanks for the updates, comments and the reproducer. I've added those in this update. If possible, I'd like to get this change accepted to avoid the crash we currently see, and I'll immediately follow up with the FIXMEs. Otherwise, I'll iterate quickly on the FIXMEs.

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers updated this revision to Diff 358792. vabridgers added a comment. address comments, add test case suggested by @bjope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAn

[PATCH] D106027: Allow setting CLANG_LINKS_TO_CREATE to an empty list

veprbl created this revision. Herald added a subscriber: mgorny. veprbl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A user might want to redefine CLANG_LINKS_TO_CREATE to an empty list `""`, but such a value would be considered as a `F

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang updated this revision to Diff 358761. NeHuang marked 4 inline comments as done. NeHuang added a comment. Address review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 Files

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15081 } + case PPC::BI__builtin_ppc_cmpb: { +llvm::Type *Ty = Ops[0]->getType(); NeHuang wrote: > nemanjai wrote: > > I find it rather sur

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:402-403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; break; JDevlieghere wrote: > What's the p

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. @dyung I appreciate the help tracking this down! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 ___ cfe-commits mailing list cfe-commit

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfec72ffeec: [clang] Refactor AST printing tests to share more infrastructure (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9cfec72 - [clang] Refactor AST printing tests to share more infrastructure

Author: Nathan Ridge Date: 2021-07-14T19:44:18-04:00 New Revision: 9cfec72ffeec242783b70e792c50bd163dcf9dbb URL: https://github.com/llvm/llvm-project/commit/9cfec72ffeec242783b70e792c50bd163dcf9dbb DIFF: https://github.com/llvm/llvm-project/commit/9cfec72ffeec242783b70e792c50bd163dcf9dbb.diff

[clang] 4a4229f - [WebAssembly] Codegen for v128.storeX_lane instructions

Author: Thomas Lively Date: 2021-07-14T16:15:25-07:00 New Revision: 4a4229f70f815a0a83e8e226ec1718af693faf4d URL: https://github.com/llvm/llvm-project/commit/4a4229f70f815a0a83e8e226ec1718af693faf4d DIFF: https://github.com/llvm/llvm-project/commit/4a4229f70f815a0a83e8e226ec1718af693faf4d.diff

[PATCH] D106019: [WebAssembly] Codegen for v128.storeX_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a4229f70f81: [WebAssembly] Codegen for v128.storeX_lane instructions (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D10

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 358773. shafik marked 8 inline comments as done. shafik added a comment. - Removed virtual from `FindTypeForAutoReturnForDIE` - Added missing nullptr checks - Modernized the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://revie

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung accepted this revision. dyung added a comment. In D105457#2878352 , @nridge wrote: > In D105457#2878302 , @dyung wrote: > >> Interesting. If you can get me an updated patch, I can give it a try on my >> mac

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

george.burgess.iv added a comment. thanks for this! mostly just nits from me Comment at: clang/lib/AST/ExprConstant.cpp:15755 + +bool Expr::tryEvaluateStrLen(uint64_t &Result, ASTContext &Ctx) const { + Expr::EvalStatus Status; Looks like this is the second "t

[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

alexfh added a comment. In D105890#2873969 , @thakis wrote: > I think this is incorrect. See D105892 and > https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to > suppress warnings – the warnings exi

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra marked an inline comment as done. tra added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx-mma.py:84 + # It uses __mma_tf32_m16n16k8_ld_c but __mma_m16n16k8_st_c_f32. + make_ldst_ops(["m16n16k8"], ["a", "b", "c", "d"], ["tf32", "f32"])) ---

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358760. ZarkoCA added a comment. - Add more RUN lines to test - change `if` condition to be one line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/in

[PATCH] D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58494c856a15: [clang-format] Make BreakAfterReturnType work with K&R C functions (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[clang] 58494c8 - [clang-format] Make BreakAfterReturnType work with K&R C functions

Author: owenca Date: 2021-07-14T14:38:02-07:00 New Revision: 58494c856a15f5b0e886c7baf5d505ac6c05dfe5 URL: https://github.com/llvm/llvm-project/commit/58494c856a15f5b0e886c7baf5d505ac6c05dfe5 DIFF: https://github.com/llvm/llvm-project/commit/58494c856a15f5b0e886c7baf5d505ac6c05dfe5.diff LOG: [

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. T

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added a comment. Also, have you looked into operand bundles instead of metadata? I don't know much about them, but they might help with the optimizations-dropping-metadata problem. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. In D105457#2878302 , @dyung wrote: > Interesting. If you can get me an updated patch, I can give it a try on my > machine with 7.5 to verify if you like. I posted an updated patch, if you can give that a whirl that would be great

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

morehouse added a subscriber: MaskRay. morehouse added a comment. Are comdats needed? Can we get proper dead stripping with just `SHF_LINK_ORDER`? @MaskRay recently updated the documentation for associated metadata to imply that our sym

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge updated this revision to Diff 358750. nridge added a comment. Work around a gcc 7 bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 Files: clang/unittests/AST/ASTPrint.h clang/unittests/AST/D

[PATCH] D106019: [WebAssembly] Codegen for v128.storeX_lane instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In D105457#2878292 , @nridge wrote: > Making the default argument a non-lambda seems to be sufficient to avoid the > error: > > template > class function { > public: > template > function(F) {} > }; > > void

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. Making the default argument a non-lambda seems to be sufficient to avoid the error: template class function { public: template function(F) {} }; void DefaultFunc(); template void Foo(M, function = DefaultFunc); void Bar() { Foo(42);

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. Thanks! I reduced it further to: template class function { public: template function(F) {} }; template void Foo(M, function = [](){}); void Bar() { Foo(42); Foo(42.0); } with gcc 7, this gives: /tmp/cccKjL8O.s: Assembler message

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 358738. Conanap marked an inline comment as done. Conanap added a comment. Added more sema checking, test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2068 +EmittedMDIdGeneralized = true; + } + This code also seems unnecessary as it puts metadata on function definitions. Comment at: clang/lib/CodeGen/CodeGen

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In case it is useful, here is the full preprocessed file. F17936275: StmtPrinterTest.preproc.cpp.orig.gz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple cc1 jobs

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105695/new/ https://reviews.llvm.org/D105695 ___ cfe-commits mailing list cfe-

[PATCH] D105726: [asan][clang] Add flag to outline instrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac500fd18f06: [asan][clang] Add flag to outline instrumentation (authored by kstoimenov, committed by vitalybuka). Changed prior to commit: https:

[clang] ac500fd - [asan][clang] Add flag to outline instrumentation

Author: Kirill Stoimenov Date: 2021-07-14T13:36:34-07:00 New Revision: ac500fd18f0615c45d9d127bfb576ffa1e11425a URL: https://github.com/llvm/llvm-project/commit/ac500fd18f0615c45d9d127bfb576ffa1e11425a DIFF: https://github.com/llvm/llvm-project/commit/ac500fd18f0615c45d9d127bfb576ffa1e11425a.di

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In D105457#2877971 , @dblaikie wrote: > In D105457#2876511 , @dyung wrote: > >> If it helps, I have so far been able to reduce the file to this which still >> shows the failure when compile

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 358726. jansvoboda11 added a comment. Entirely disable `DepFS` when scanning PCHs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.llvm.org/D104536 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorke

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple cc1 jobs

jansvoboda11 updated this revision to Diff 358724. jansvoboda11 retitled this revision from "[clang][tooling] Accept Clang invocations with "-fno-integrated-as"" to "[clang][tooling] Accept Clang invocations with multiple cc1 jobs". jansvoboda11 edited the summary of this revision. jansvoboda11 a

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358717. jamieschmeiser added a comment. Remove accidental inclusion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenFunction.h c

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. In D104058#2877631 , @nickdesaulniers wrote: > Change LGTM, but I don't understand why the following tests are modified: > > - llvm/test/ThinLTO/X86/devirt2.ll This is needed to fix two `missing symbol resolution` errors th

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This can happen when a template with two parameter types i

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

morehouse added a subscriber: MaskRay. morehouse added a comment. We should also tests for the new flags in clang/test/Driver/clang_f_opts.c. Comment at: clang/docs/CallGraphSection.rst:58 + +A type identifier may be repeated in different entries. The id value 0 is +reserved fo

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! (Maybe leave a couple of days in case others have comments.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://rev

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie added a comment. In D105457#2876511 , @dyung wrote: > If it helps, I have so far been able to reduce the file to this which still > shows the failure when compiled with gcc 7.5: Could you provide the preprocessed input file - maybe that run thr

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, assuming @aaron.ballman is happy! (a couple of optional nits inline) Comment at: clang/lib/Basic/DarwinSDKInfo.cpp:28 + // If no exact entry found, try just th

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 358702. mizvekov added a comment. - Small simplification to implementation, don't need to cast to NamespaceDecl. - Simplification to tests: Use some evil prep hackery to avoid needing multipe files. - Verify result of getReferencedDeclOfCallee is non-null.

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

MyDeveloperDay added a comment. In D105943#2877886 , @HazardyKnusperkeks wrote: > This could be a way, but I will also state here that I prefer adding it to > plain `clang-format`. I do too, and that is my preference, Perhaps this way we can establish

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2877618 , @atomgalaxy wrote: > It would probably be better to make the config option names for passes that > may mutate whitespace be prefixed with MaybeIncorrect than fork the tool. > Scary options are better than

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

dexonsmith added a subscriber: aaron.ballman. dexonsmith added a comment. Thanks for splitting this out! It mostly looks good, just a few things inline. Comment at: clang/lib/Basic/DarwinSDKInfo.cpp:27-28 +return KV->getSecond(); + // If no exact entry found, try just the

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2876916 , @MyDeveloperDay wrote: >> So yes, I'm in favour of landing this patch (though not exactly in the >> current form, I'd prefer more future-proof options for instance, not only >> handling const) > >

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3317-3321 + for (const DeclContext *DC = D->getDeclContext(); DC; DC = DC->getParent()) { +if (const auto *NS = dyn_cast(DC)) + if (NS->isStdNamespace()) +return true; + }

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

HazardyKnusperkeks added a comment. This could be a way, but I will also state here that I prefer adding it to plain `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105943/new/ https://reviews.llvm.org/D105943 __

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

dexonsmith added a comment. Does this need an upgrade for old bitcode that has serialized 32-bit types? If not, can you explain why not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105491/new/ https://reviews.llvm.org/D105491 __

[libunwind] 850b57c - [runtimes] Bring back TARGET_TRIPLE

Author: Louis Dionne Date: 2021-07-14T15:15:22-04:00 New Revision: 850b57c5fbe7b44d18c9667bb31adfbe307453a6 URL: https://github.com/llvm/llvm-project/commit/850b57c5fbe7b44d18c9667bb31adfbe307453a6 DIFF: https://github.com/llvm/llvm-project/commit/850b57c5fbe7b44d18c9667bb31adfbe307453a6.diff

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

aaron.ballman added a comment. In D104601#2848366 , @Meinersbur wrote: > In D104601#2847400 , @aaron.ballman > wrote: > >> ... would add that it's very common for implementers to ask developers to >> run their

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3314 +return false; + const Decl *D = E.getReferencedDeclOfCallee(); + if (!S.SourceMgr.isInSystemHeader(D->getLocation())) aaron.ballman wrote: > This can return `nullptr`, so we shoul

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105726/new/ https://reviews.llvm.org/D105726 ___

[PATCH] D104420: thread_local support for AIX

jamieschmeiser added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2971 +isEmittedWithConstantInitializer(VD, true) && +!VD->needsDestruction(getContext())) { + // Emit a weak global function referring to the initialization function. --

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358690. jamieschmeiser added a comment. Respond to review comments: update comments and make functions not weak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/CGDeclCXX.c

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov updated this revision to Diff 358689. kstoimenov added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105726/new/ https://reviews.llvm.org/D105726 Files: clang/docs/AddressSanitizer.rst clang/docs/Users

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; vsavchenko wrote: > ASDenysPetrov

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 358685. ASDenysPetrov added a comment. Made`ignoreCast` non-virtual . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/incl

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

lei added a comment. please add sema checking for pwr8 builtins. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond.ll:80 +declare i32 @llvm.ppc.lharx(i8*) +define dso_local signext i16 @test_lharx(i16* %a) local_unnamed_addr #0 { +; CHECK-64-LAB

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha created this revision. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As part of https://bugs.llvm.org/show_bug.cgi?id=46251, this patch adds definition of matrix initialisation. I am not very familiar with this part

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), efriedma wrote: > ne

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Other than missing llvm test is LGTM Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; fmayer wrote: > vitalybuka wrote: > > this patch mostly change code under

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG970e0900104d: [WebAssembly] Codegen for v128.loadX_lane instructions (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D105

[clang] 970e090 - [WebAssembly] Codegen for v128.loadX_lane instructions

Author: Thomas Lively Date: 2021-07-14T11:31:53-07:00 New Revision: 970e0900104d6f67a9c15fa9c913cf3eeba5d06a URL: https://github.com/llvm/llvm-project/commit/970e0900104d6f67a9c15fa9c913cf3eeba5d06a DIFF: https://github.com/llvm/llvm-project/commit/970e0900104d6f67a9c15fa9c913cf3eeba5d06a.diff

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL co

[libunwind] 5099e01 - [runtimes] Inherit the TARGET_TRIPLE that may be set by LLVM

Author: Louis Dionne Date: 2021-07-14T14:29:29-04:00 New Revision: 5099e0156818665ae5381337f64ca68d659e0556 URL: https://github.com/llvm/llvm-project/commit/5099e0156818665ae5381337f64ca68d659e0556 DIFF: https://github.com/llvm/llvm-project/commit/5099e0156818665ae5381337f64ca68d659e0556.diff

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please change `compact` in the title to `compat`. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:76-79 +BUILTIN(__builtin_ppc_mtfsb0, "vUi", "") +BUILTIN

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers added a comment. Thanks all for the updates and comments. I'll address promptly and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358673. jamieschmeiser added a comment. Respond to review comments: create stub functions, return 0 from function and other fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/

  1   2   3   >