veprbl created this revision. Herald added a subscriber: mgorny. veprbl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
A user might want to redefine CLANG_LINKS_TO_CREATE to an empty list `""`, but such a value would be considered as a `FALSE` by cmake. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106027 Files: clang/tools/driver/CMakeLists.txt Index: clang/tools/driver/CMakeLists.txt =================================================================== --- clang/tools/driver/CMakeLists.txt +++ clang/tools/driver/CMakeLists.txt @@ -58,7 +58,7 @@ add_dependencies(clang clang-resource-headers) -if(NOT CLANG_LINKS_TO_CREATE) +if(NOT DEFINED CLANG_LINKS_TO_CREATE) set(CLANG_LINKS_TO_CREATE clang++ clang-cl clang-cpp) endif()
Index: clang/tools/driver/CMakeLists.txt =================================================================== --- clang/tools/driver/CMakeLists.txt +++ clang/tools/driver/CMakeLists.txt @@ -58,7 +58,7 @@ add_dependencies(clang clang-resource-headers) -if(NOT CLANG_LINKS_TO_CREATE) +if(NOT DEFINED CLANG_LINKS_TO_CREATE) set(CLANG_LINKS_TO_CREATE clang++ clang-cl clang-cpp) endif()
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
