[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} What does this do? A hard-coded list cannot catch up with the real dynamic symbol list.

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction See https://bugs.llvm.org/show_bug.cgi?id=50797#c6

hokein created this revision. hokein added a reviewer: dgoldman. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105533 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/Sema/typo-correction-no-hang.c I

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:489 DeclRefs[ND].push_back( -SymbolRef{SM.getFileLoc(Loc), Roles, ASTNode.Parent}); +SymbolRef{SM.getFileLoc(Loc), Roles, getRefContainer(ASTNode.Parent)}); // Don

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 356874. TaoPan added a comment. git rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/C

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2861036 , @ychen wrote: > In D97915#2860984 , @ChuanqiXu wrote: > >> In D97915#2860916 , @ychen wrote: >> >>> In D97915#2859237

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

This revision was automatically updated to reflect the committed changes. Closed by commit rG593bf9b4ded3: [Clang][RISCV] Implement vlseg and vlsegff. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:425 + Features["isa207"] = llvm::StringSwitch(CPU) + .Case("pwr9", true) Will it be better if name to `isa2_07`, `isa3_0` to make it less confusing? Besides, in

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 356864. TaoPan added a comment. Update dependent D99487 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: llvm/lib/CodeGen/AsmPr

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. I tried to keep this simple and only add the Linux support for now. There seem to be some subtle differences of how different operating systems handle export lists and linker scripts, and I wasn't confident about how to make this work on those systems. Repository:

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar created this revision. tstellar added reviewers: dim, MaskRay. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105527 Files: clang/tools/libclang/CMakeLists.tx

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham updated this revision to Diff 356861. bnbarham added a comment. Updated the test comment with the actual cause (ie. `Top` being recompiled and inserted, not `M`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105328/new/ https://reviews.l

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham added a comment. In D105328#2861028 , @vsapsai wrote: > This problem shouldn't happen based on module-level name hashing but for some > reason it is happening. If I'm not mistaken, InMemoryModuleCache uses .pcm > file name as the key. But that

[PATCH] D105526: opencl-c.h: some CL3.0 compat bits

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This is some of the easier pieces of making the opencl-c.h header CL 3.0 compatible. Repository:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2860984 , @ChuanqiXu wrote: > In D97915#2860916 , @ychen wrote: > >> In D97915#2859237 , @ChuanqiXu >> wrote: >> >>> In D97915#2848816

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

vsapsai added a comment. This problem shouldn't happen based on module-level name hashing but for some reason it is happening. If I'm not mistaken, InMemoryModuleCache uses .pcm file name as the key. But that file name should contain a hash part that is based on the modulemap path. But framewor

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2860916 , @ychen wrote: > In D97915#2859237 , @ChuanqiXu wrote: > >> In D97915#2848816 , @ychen wrote: >> Thanks for clarifying. Let

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. @aaron.ballman I created a DR for the option of temporarily disabling the effects of this change under "-fms-compatibility". https://reviews.llvm.org/D105518 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https:

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2d5fce86e81: [clang] fixes named return of variables with dependent alignment (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/n

[clang] f2d5fce - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-07T02:54:55+02:00 New Revision: f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 URL: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 DIFF: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365.dif

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov updated this revision to Diff 356844. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105518/new/ https://reviews.llvm.org/D105518 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai added a comment. Can you please add a test for this similar to `clang/test/Driver/ppc-pcrel.cpp` and other similar tests? Also, I imagine this will produce some warnings from the back end since the back end doesn't know what these target features mean. Can you please see what happens w

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Microsoft STL currently has some issues with P2266 . We disable it for now in that mode, but we might come back la

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

NoQ added a comment. WDYT about the following format: Equality constraints: reg_$0 == reg_$1 == reg_$2 Disequality constraints: reg_$0 != reg_$3, != reg_$4 Comma is a bit hard to notice but otherwise kinda nicely readable? Repository: rG LLVM Github Monorep

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2859237 , @ChuanqiXu wrote: > In D97915#2848816 , @ychen wrote: > >>> Thanks for clarifying. Let's solve the semantics problem first. >>> With the introduction about 'raw frame', I t

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 356838. ychen marked 2 inline comments as done. ychen added a comment. - Move `raw frame` description to `Switched-Resume` section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.or

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a comment. In D98799#2860881 , @dblaikie wrote: > In D98799#2850700 , @dblaikie wrote: > >> In D98799#2850682 , @ahatanak wrote: >> >>> I think I've fixed all the p

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru updated this revision to Diff 356836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-cast-align.c Index: clang/test/Sema/warn-cast-align.c ==

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356835. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

MaskRay added subscribers: rampitec, arsenm. MaskRay added a comment. This is great. unsigned long foo(unsigned long addr, unsigned long a0, unsigned long a1, unsigned long a2, unsigned long a3, unsigned long a4, unsigned long a5) {

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. In D98799#2850700 , @dblaikie wrote: > In D98799#2850682 , @ahatanak wrote: > >> I think I've fixed all the places in CodeGen that create fake >> `FunctionDecl`s and would cause clang to c

[clang] 6c9559b - DebugInfo: Mangle K&R declarations for debug info linkage names

Author: David Blaikie Date: 2021-07-06T16:28:02-07:00 New Revision: 6c9559b67b91966bfeff9e17808a3e84a92e64a0 URL: https://github.com/llvm/llvm-project/commit/6c9559b67b91966bfeff9e17808a3e84a92e64a0 DIFF: https://github.com/llvm/llvm-project/commit/6c9559b67b91966bfeff9e17808a3e84a92e64a0.diff

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:633 + // pass more options in specific target + switch (ToolChain.getArch()) { Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:634-638 + switch (T

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356833. mizvekov added a comment. - hasDependentAlignment now returns true for VarDecls with undeduced auto types. - Add couple of tests that cover these kinds of VarDecls appearing: - Valid code with a range for loop in dependent context. - Error recover

[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/module-target-abi-tests.ll:5 +; RUN: cat %s > %t.emptyabi +; RUN: echo '!0 = !{i32 1, !"target-abi", !""}' >> %t.emptyabi +; RUN: llc -mtriple=riscv32 < %t.emptyabi -o /dev/null khchen wrote: > jrt

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 created this revision. jrtc27 added reviewers: chandlerc, rjmccall, rsmith. Herald added subscribers: ormris, dexonsmith, dang, s.egerton, simoncook, hiraditya, kristof.beyls. jrtc27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commit

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105375/new/ https://reviews.llvm.org/D105375 ___

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356821. manas added a comment. Pass commands through settings instead of rest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/entrypoint.p

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji created this revision. jsji added reviewers: PowerPC, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D105314 added the abibility choose to use AsmParser for parsing inline asm. -no-int

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2860598 , @Quuxplusone wrote: > I have no strong/well-informed opinions here. I have an idea to offer, //if// > there is precedent for it. My idea is, keep it as an error if the rvalue > resolution finds nothing, but (

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

Quuxplusone added a comment. > I'd like to give some time for other stakeholders to give their opinion if > this is not too urgent, specially @Quuxplusone and @rsmith. I have no strong/well-informed opinions here. I have an idea to offer, //if// there is precedent for it. My idea is, keep it as

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, with some whitespace nits inline. In D103165#2790932 , @t.p.northover wrote: >> Also this way llvm::thread users that don't need f

[PATCH] D105395: [IRBuilder] Add type argument to CreateMaskedLoad/Gather

dblaikie added a comment. Might use some testing? (guess there was previously missing testing, or this API change would've broken those tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105395/new/ https://reviews.llvm.org/D105395

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie added a comment. Looks generally good - few things might be able to be tidied up/simplified, I think? Comment at: clang/unittests/AST/ASTPrint.h:61-62 +private: + // Can be specialized for specific node types. + bool shouldIgnoreNode(const NodeType *N) { return fals

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 ___

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen updated this revision to Diff 356796. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaTemplate.

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2860021 , @aaron.ballman wrote: > I would argue it gives the committee valuable implementation experience > feedback: the change breaks at least one popular system header. But we already knew that :-) Reverting the ch

[PATCH] D105489: [compiler-rt] [test] Fix asan symbolize tests on py3.10

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d68bb1765f9: [compiler-rt] [test] Fix asan symbolize tests on py3.10 (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github Monorepo

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

yaxunl added a comment. LGTM. Pls change the negative tests to positive tests as Artem suggested. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:20 -// DEV-NEG-NOT: @v1 -__device__ int v1; tra wrote: > hliao wrote: > > BTW, as clang codegen tests,

[PATCH] D103587: [AIX] Define __TOS_AIX__ predefined macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG045872f42203: [AIX] Define __TOS_AIX__ predefined macro (authored by Jake-Egan, committed by stevewan). Changed prior to commit: https://reviews.llvm.org/D103587?vs=349913&id=356783#toc Repository: r

[clang] 045872f - [AIX] Define __TOS_AIX__ predefined macro

Author: Jake Egan Date: 2021-07-06T14:15:35-04:00 New Revision: 045872f42203223450c96a518b6478d255a5d586 URL: https://github.com/llvm/llvm-project/commit/045872f42203223450c96a518b6478d255a5d586 DIFF: https://github.com/llvm/llvm-project/commit/045872f42203223450c96a518b6478d255a5d586.diff LOG

[PATCH] D105489: [compiler-rt] [test] Fix asan symbolize tests on py3.10

delcypher accepted this revision. delcypher added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105489/new/ https://reviews.llvm.org/D105489 ___ cfe-commits mailing list cfe-com

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s //

[PATCH] D105285: [Clang] Add test dependency on llvm-ar

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105285/new/ https://reviews.llvm.org/D105285 __

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105295/new/ https://reviews.llvm.org/D105295 __

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 356774. quinnp added a comment. Updating pwr10 features to include previous features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/lib/Basic/Targets/

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] This patch adds features for pwr7, pwr8, and pwr9 that can be used for semacheking builtin func

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:254 +/// Constructs a 512-bit floating-point vector of [32 x half] from a +///128-bit floating-point vector of [16 x half]. The lower 256 bits +///contain the value of the source vector.

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2801-2802 + // Get a root symbol in case of SymbolCast. + while (isa(Sym)) +Sym = cast(Sym)->getOperand(); + vsavchenko wrote: > ASDenysPetrov wrote: >

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2859742 , @pekka.jaaskelainen wrote: >> Ok, thanks for clarification. Does it mean there is something we need to add >> to LLVM somewhere to make it work correctly? Would it be specific to Arm or >> generally for a

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

t.p.northover added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103165/new/ https://reviews.llvm.org/D103165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 356766. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D97204: [RFC] Clang 64-bit source locations

simon_tatham added a comment. This patch doesn't seem to have attracted much review attention in the last couple of weeks. On the theory that perhaps it's just too big and monolithic to review in one go, I've started to break it up into smaller pieces. So far I've only covered the preparation s

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in

[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added subscribers: dexonsmith, martong. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series workin

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in

[PATCH] D105493: [clang] Change set type used for SourceLocation.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added a subscriber: dexonsmith. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working toward

[PATCH] D105492: [clang] Introduce SourceLocation::[U]IntType typedefs.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added subscribers: dexonsmith, arphaman, kbarton, nemanjai. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added subscribers: dexonsmith, hiraditya. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part of a

[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. Herald added a subscriber: hiraditya. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. No implementation uses the `

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong added a comment. > Do you happen to have a screenshot of how it looks? Yes! :) F17793264: image.png F17793282: image.png I've added borders to the tables in the `Disequality Info` section, because the default ren

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1cbea3e5275: [RISCV] Remove Zvamo implication for v1.0-rc change (authored by arcbbb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105396/new/ https://re

[clang] f1cbea3 - [RISCV] Remove Zvamo implication for v1.0-rc change

Author: ShihPo Hung Date: 2021-07-07T00:14:58+08:00 New Revision: f1cbea3e527547fc08c55235c11970a8d9f2637e URL: https://github.com/llvm/llvm-project/commit/f1cbea3e527547fc08c55235c11970a8d9f2637e DIFF: https://github.com/llvm/llvm-project/commit/f1cbea3e527547fc08c55235c11970a8d9f2637e.diff L

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong added a comment. In D104917#2845181 , @NoQ wrote: >> We have a few in `test/Analysis/exploded-graph-rewriter/` where we test >> parts of the emitted html. > > And they're now failing on the pre-merge buildbots. So i guess updating > existing tes

[PATCH] D105489: [compiler-rt] [test] Fix asan symbolize tests on py3.10

mgorny created this revision. mgorny added a reviewer: delcypher. Herald added a subscriber: dberris. mgorny requested review of this revision. Update the asan_symbolize_script for changes in argparse output in Python 3.10. The parser output 'options' instead of 'optional arguments'. https://re

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 356752. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong updated this revision to Diff 356751. martong added a comment. Herald added a reviewer: Szelethus. - Rebase on top of the newest version of the dependent patch - Draw borders for the table of the disequality info - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2801-2802 + // Get a root symbol in case of SymbolCast. + while (isa(Sym)) +Sym = cast(Sym)->getOperand(); + ASDenysPetrov wrote: > vsavchenko wrote: > >

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay added a comment. Yeah, I made the almost identical change but got some push back on it extending the dependencies (I think it also meant that the clang-format target needed alot more source to be compiled) Dinking around in clangBasic is probably outside my pay grade ;-) Reposi

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2859886 , @mizvekov wrote: > In D99005#2859476 , @aaron.ballman > wrote: > >> https://godbolt.org/z/dvEbv7GKo >> >> I'm not certain if this is as expected of an issue, thoug

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. I found some issues. Working on improvement. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2797-2799 +ProgramStateRef +RangeConstraintManager::updateExistingConstraints(ProgramStateRef State, +

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added a comment. @theraven: Can you post a minimal repro of your case? I don't follow your distinction between "caller" and "enclosing function." Regarding `noreturn` and `always_inline`: maybe the rules for `musttail` could be relaxed in cases like the one you mention, but it would re

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 356737. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/PPC.cpp:175 + if (getTriple().isOSAIX() && LongDoubleWidth == 64) { +Builder.defineMacro("__LONGDOUBLE6

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // The M

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // Th

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

Et7f3 added a comment. Mb I just looked in driver how to setup diagnostics (which included frontend). Ok so I see 2 options: - move TextDiagnosticsPrinter in clangBasic - Use SMDiagnostic like clang/tools/clang-format/ClangFormat.cpp:324 but it seem to need a SMLoc so not really adapted. Repo

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // The M

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2859476 , @aaron.ballman wrote: > https://godbolt.org/z/dvEbv7GKo > > I'm not certain if this is as expected of an issue, though. In the original > example, `C` carried state that was set up after initialization but wa

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 356726. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // Th

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao updated this revision to Diff 356721. hliao added a comment. Kindly PING for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105135/new/ https://reviews.llvm.org/D105135 Files: clang/test/CodeGenCUDA/host-used-device-var.cu clang/t

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 356719. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev updated this revision to Diff 356715. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105375/new/ https://reviews.llvm.org/D105375 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

pekka.jaaskelainen added a comment. > Ok, thanks for clarification. Does it mean there is something we need to add > to LLVM somewhere to make it work correctly? Would it be specific to Arm or > generally for all CPU targets? To my understanding, what is required is to keep SPIR_KERNEL CC wor

[PATCH] D103587: [AIX] Define __TOS_AIX__ predefined macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 _

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: alexfh, njames93, aaron.ballman. MyDeveloperDay added projects: clang-tools-extra, clang. Herald added subscribers: jdoerfert, xazax.hun. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 356705. jamieschmeiser added a comment. Fix formatting problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/cxx11-thread-loca

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Undeduced fields in a valid record cause crashes when trying to obtain the size and/or layout of the record. Repository:

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 356701. NeHuang marked 4 inline comments as done. NeHuang added a comment. Address review comments on the test case. Target cpu sema checking covered in front end test cases. will keep current coverage in backend test. Repository: rG LLVM Github Monorepo

  1   2   >