[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2741223 , @phosek wrote: > In D101479#2741202 , @mstorsjo > wrote: > >> In D101479#2740895 , @phosek wrote: >> >>> On other platforms

[PATCH] D101926: [amdgpu-arch] Fix rpath to run from build dir

pdhaliwal accepted this revision. pdhaliwal added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:17 +set_target_properties(amdgpu-arch PROPERTIES INSTALL_RPATH_USE_LINK_PATH ON) + --

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343293. OikawaKirie added a comment. Add a regression test case by mocking the `open` function. When this function is called with the file name of the invocation list, the mocked `open` function will reject the open operation and dump a log. And we will

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis created this revision. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101974 Files: clang/utils/re

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

This revision was automatically updated to reflect the committed changes. Closed by commit rG16c7829784f0: [clangd] Check if macro is already in the IdentifierTable before loading it (authored by qdelacru, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 16c7829 - [clangd] Check if macro is already in the IdentifierTable before loading it

Author: Queen Dela Cruz Date: 2021-05-06T08:24:06+02:00 New Revision: 16c7829784f071d9fd4ae9da4cc8b3786a58018e URL: https://github.com/llvm/llvm-project/commit/16c7829784f071d9fd4ae9da4cc8b3786a58018e DIFF: https://github.com/llvm/llvm-project/commit/16c7829784f071d9fd4ae9da4cc8b3786a58018e.dif

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2741202 , @mstorsjo wrote: > In D101479#2740895 , @phosek wrote: > >> On other platforms the decision whether to use static or shared is >> controlled by `-static-libstdc++`, do

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. I am investigating the find_package issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 343290. jdoerfert added a comment. Address the last test failures (all ordering) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 Files: clang/include/clang/Basic/

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2740895 , @phosek wrote: > On other platforms the decision whether to use static or shared is controlled > by `-static-libstdc++`, does CL have a similar flag or shall we support > `-static-libstdc++` in MSVC driver

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

jdoerfert created this revision. jdoerfert added reviewers: ABataev, ggeorgakoudis. Herald added subscribers: jfb, guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. If a tes

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 343285. jdoerfert added a comment. Reapply test changes accidentally dropped Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 Files: clang/include/clang/Basic/Attr

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 343282. jdoerfert added a comment. Herald added a subscriber: jfb. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 Files: clang/include/clang/Basic/A

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

jdoerfert updated this revision to Diff 343279. jdoerfert marked an inline comment as done. jdoerfert added a comment. Split the new/delete operators based on std::nothrow_t and provide the ones that do not use this type by default, the others as part of . Repository: rG LLVM Github Monorepo

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

OikawaKirie added a comment. Ping @sammccall again for landing this patch on my behalf. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.org/D97265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG207b08a9130b: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monore

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGf97b843d8819: [OpenMP] Fix non-determinism in clang copyin codegen (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ ht

[clang] f97b843 - [OpenMP] Fix non-determinism in clang copyin codegen

Author: Giorgis Georgakoudis Date: 2021-05-05T19:24:03-07:00 New Revision: f97b843d8819f824dcc1b6afa746ce9a7a386db3 URL: https://github.com/llvm/llvm-project/commit/f97b843d8819f824dcc1b6afa746ce9a7a386db3 DIFF: https://github.com/llvm/llvm-project/commit/f97b843d8819f824dcc1b6afa746ce9a7a386db

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a subscriber: dexonsmith. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements the direction proposed in https://github.com/itanium-cxx-abi/cxx-

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added a subscriber: pengfei. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. x86 is only used for the bootloader and we use x86-64 libc++ headers in

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

NoQ updated this revision to Diff 343264. NoQ added a comment. Rebase to address the comment! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101787/new/ https://reviews.llvm.org/D101787 Files: clang-tools-extra/clang-tidy/utils/Aliasing.cpp clang-tools-extra/test/clang-tidy/checkers

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1 // RUN: %check_clang_tidy %s bugprone-redundant-branch-condition %t aaron.ballman wrote: > You need to add `-fblocks` here to enable bl

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture &C) { + return C.capturesVariable() && C.getCaptureKind() == LCK_ByRef && + C.getCapturedVar() == Var;

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

ggeorgakoudis updated this revision to Diff 343262. ggeorgakoudis added a comment. Update for comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index:

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added a comment. Thanks, I'm broadly very happy with this. My remaining comments are all very minor. Comment at: clang/include/clang/AST/Expr.h:1619 + static void streamChar(unsigned val, CharacterKind Kind, raw_ostream &OS) { +switch (Kind) { Th

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, two nits, one below. Add a sentence to the commit message describing the problem. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1013 + Builder.Crea

[PATCH] D101965: Added Support for Warning Flag -Wstack-usage=

rsanthir.quic added a comment. Another approach is explored here: https://reviews.llvm.org/D101964 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101965/new/ https://reviews.llvm.org/D101965 ___ cfe-commi

[PATCH] D101964: Added support for -Wstack-usage flag and Framesize reporting fix

rsanthir.quic added a comment. Another approach is explored here: https://reviews.llvm.org/D101965 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101964/new/ https://reviews.llvm.org/D101964 ___ cfe-commi

[PATCH] D101965: Added Support for Warning Flag -Wstack-usage=

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang, hiraditya. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The -Wstack-usage flag has been added, which provides a warning mess

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

ggeorgakoudis updated this revision to Diff 343256. ggeorgakoudis added a comment. Update by Johanne's correction on the source of non-determinism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101952/new/ https://reviews.llvm.org/D101952 Files:

[PATCH] D101964: Added support for -Wstack-usage flag and Framesize reporting fix

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang, hiraditya. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds support for the -Wstack-usage flag. It also changes

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2733622 , @mstorsjo wrote: > In D101479#2733434 , @thakis wrote: > >> In D101479#2733354 , @mstorsjo >> wrote: >> >>> Not sure if we wa

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen planned changes to this revision. ychen added a comment. Plan to rebase this together with the following patch for two lookups (aligned and non-aligned new/delete, and generate code accordingly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added a comment. In D101191#2738130 , @nikic wrote: > LGTM. I can take care of reverting if there are issues. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101191/new/ https://reviews.llvm.

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: openmp/libomptarget/src/rtl.cpp:76 + std::string full_plugin_name; + void *handle = dlopen("libomptarget.so", RTLD_NOW); JonChesterfield wrote: > This logic is cut from D73657 without addressing any of the re

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru added a comment. Yes I need help landing this, please use qdela...@cisco.com. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101870/new/ https://reviews.llvm.org/D101870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain &TC, + const ArgList &Args, Similar to other functions in this

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, grokos, ABataev, gregrodgers, RaviNarayanaswamy, pdhaliwal, hfinkel, tlwilmar, AndreyChurbanov, jlpeyton, protze.joachim, ye-luo, tianshilei1992. Herald added subscribers: kerbowa, guansong, yaxunl, mgorny, nhaehnl

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added a comment. How about `WASM_ADDRESS_SPACE_NON_INTEGRAL` or `WASM_ADDRESS_SPACE_OPAQUE` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 ___ cfe-com

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; sbc100 wrote: > tlively wrote: > > sbc100 wrote: > > > tlively wrote: > > > > sbc100 wrote: > > > > > tl

[PATCH] D101957: [clang][Fuchsia] Also use -fc++-abi=fuchsia for selecting relative-vtables multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101957 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/tes

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; tlively wrote: > sbc100 wrote: > > tlively wrote: > > > sbc100 wrote: > > > > tlively wrote: > > > > > sb

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. By the way, I set up a WIP patch for changing LLDB's import away from the current MinimalImport of records to something that is more in line with how Clang works: https://reviews.llvm.org/D101950 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex added a comment. Here's my branch on Github: https://github.com/SilensAngelusNex/llvm-project/tree/has-type-info Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:138-150 +template struct disjunction; +template struct disjunction : public T {

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex updated this revision to Diff 343219. SilensAngelusNex marked 2 inline comments as done. SilensAngelusNex added a comment. Regenerate docs and replace `is_one_of` with `TypeListContainsSuperOf`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D101952: [OpenMP] Fix non-determinism in clang copyin codegen

ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; sbc100 wrote: > tlively wrote: > > sbc100 wrote: > > > tlively wrote: > > > > sbc100 wrote: > > > > > Wh

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; tlively wrote: > sbc100 wrote: > > tlively wrote: > > > sbc100 wrote: > > > > What does "object" mean her

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; sbc100 wrote: > tlively wrote: > > sbc100 wrote: > > > What does "object" mean here? Are we just talki

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; tlively wrote: > sbc100 wrote: > > What does "object" mean here? Are we just talking about reference ty

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3dbcd24c7d: [Driver] Move -print-runtime-dir and -print-resource-dir tests (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/

[clang] 9d3dbcd - [Driver] Move -print-runtime-dir and -print-resource-dir tests

Author: Petr Hosek Date: 2021-05-05T15:23:49-07:00 New Revision: 9d3dbcd24c7d61e83fe5b3c4e7b7e4ecf9d70cd7 URL: https://github.com/llvm/llvm-project/commit/9d3dbcd24c7d61e83fe5b3c4e7b7e4ecf9d70cd7 DIFF: https://github.com/llvm/llvm-project/commit/9d3dbcd24c7d61e83fe5b3c4e7b7e4ecf9d70cd7.diff LO

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis updated this revision to Diff 343210. ggeorgakoudis added a comment. More updates to tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 Files: clang/test/OpenMP/cancel_codegen.cpp cla

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

leonardchan abandoned this revision. leonardchan added a comment. Abandoned in favor of D85802 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93668/new/ https://reviews.llvm.org/D93668

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

Quuxplusone added subscribers: ldionne, Quuxplusone. Quuxplusone accepted this revision as: Quuxplusone. Quuxplusone added a comment. This does actually look like a pretty straightforward typo in `forward_list`; the other containers all seem to get it right. It's too bad that none of our tests no

[clang] 6bbfa0f - When performing template argument deduction to select a partial

Author: Richard Smith Date: 2021-05-05T14:47:18-07:00 New Revision: 6bbfa0fd408e81055c360c2e059554dd76fd7f09 URL: https://github.com/llvm/llvm-project/commit/6bbfa0fd408e81055c360c2e059554dd76fd7f09 DIFF: https://github.com/llvm/llvm-project/commit/6bbfa0fd408e81055c360c2e059554dd76fd7f09.diff

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield added a comment. I think the lit test suite is intended to set environment variables such that this is not necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101935/new/ https://reviews.llvm.org/D101935 _

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrTable.td:15 multiclass TABLE { + let mayLoad = 1 in defm TABLE_GET_#rt : I<(outs rt:$res), (ins table32_op:$table), wingo wrote: > I think you may need `hasSideEffects = 0

[PATCH] D77598: Integral template argument suffix and cast printing

rnk added a comment. My concerns are addressed, but I think @rsmith hasn't confirmed that all his concerns are addressed yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing li

[PATCH] D101902: [clangd] Split CC and refs limit and increase refs limit to 1000

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe623ce6188d6: [clangd] Split CC and refs limit and increase refs limit to 1000 (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGE

[clang-tools-extra] e623ce6 - [clangd] Split CC and refs limit and increase refs limit to 1000

Author: Kirill Bobyrev Date: 2021-05-05T23:39:48+02:00 New Revision: e623ce6188d698422d4ead24065056d6a869e6f8 URL: https://github.com/llvm/llvm-project/commit/e623ce6188d698422d4ead24065056d6a869e6f8 DIFF: https://github.com/llvm/llvm-project/commit/e623ce6188d698422d4ead24065056d6a869e6f8.diff

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis updated this revision to Diff 343197. ggeorgakoudis added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849 Files: clang/test/OpenMP/cancel_codegen.cpp clang/test/O

[PATCH] D101902: [clangd] Split CC and refs limit and increase refs limit to 1000

kbobyrev updated this revision to Diff 343196. kbobyrev marked an inline comment as done. kbobyrev added a comment. s/LimitReferences/ReferencesLimit/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101902/new/ https://reviews.llvm.org/D101902 File

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added a comment. LGTM with Sam's comments resolved! Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:40 + // appropriate. + WASM_ADDRESS_SPACE_OBJECT = 1 +}; sbc100 wrote: > What does "object" mean here? Are we just talking about

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343194. pirama added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/docs/ReleaseNotes.rst clang/tools/clang-format/git-cl

[PATCH] D100604: [PowerPC] Improve codegen for int-to-fp conversion of subword vector extract

Conanap updated this revision to Diff 343193. Conanap added a comment. Rebased and fixed indentations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100604/new/ https://reviews.llvm.org/D100604 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/CodeGen/PowerPC/uint-to-fp-v4i32.

[PATCH] D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG78a7d8c4dd10: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 78a7d8c - [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-05-05T14:19:30-07:00 New Revision: 78a7d8c4dd1076dccfde2c48fc924d8f5529f4d1 URL: https://github.com/llvm/llvm-project/commit/78a7d8c4dd1076dccfde2c48fc924d8f5529f4d1 DIFF: https://github.com/llvm/llvm-project/commit/78a7d8c4dd1076dccfde2c48fc924d8f5529f4d

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2740150 , @tlively wrote: > @dblaikie, what's the best practice for making tests robust to this > difference? If you need a label or register (eg: if you want to check a branch branches to some particular spot) - th

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/ https://reviews.llvm.org/D101813 __

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek added inline comments. Comment at: clang/test/Driver/print-resource-dir.c:3 +// RUN:-resource-dir=%S/Inputs/resource-dir \ +// RUN: | FileCheck %s -check-prefix=PRINT-RESOURCE-DIR +// PRINT-RESOURCE-DIR: Inputs{{/|\\}}resource-dir MaskRay wrot

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius added a comment. Oh, I forgot, please add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added a comment. In D101878#2740133 , @curdeius wrote: > LGTM but let's wait a day or two before landing, so that others can chime in. > Btw, do you have commit rights? If no, please provide "Name " for > c

[PATCH] D101862: [clang-format] Rename common types between C#/JS

exv updated this revision to Diff 343182. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. @dblaikie, what's the best practice for making tests robust to this difference? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101805/new/ https://reviews.llvm.org/D101805 ___ cfe

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

exv updated this revision to Diff 343180. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM but let's wait a day or two before landing, so that others can chime in. Btw, do you have commit rights? If no, please provide "Name " for commit attribution. Comme

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 343177. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. please provide an email address (for attribution) if i should land this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101870/new/ https://reviews.llvm.org/D101870 __

[PATCH] D101885: [WebAssembly] Add SIMD const_splat intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81fce29d6e1f: [WebAssembly] Add SIMD const_splat intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 81fce29 - [WebAssembly] Add SIMD const_splat intrinsics

Author: Thomas Lively Date: 2021-05-05T13:46:45-07:00 New Revision: 81fce29d6e1f0a83e8a4170c7f24cdd93869d55a URL: https://github.com/llvm/llvm-project/commit/81fce29d6e1f0a83e8a4170c7f24cdd93869d55a DIFF: https://github.com/llvm/llvm-project/commit/81fce29d6e1f0a83e8a4170c7f24cdd93869d55a.diff

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks accepted this revision. aeubanks added a comment. If you'd like you can split this into separate changes, one for adding the warning and another for adding it into warning groups, either way is fine. Seems like the reported false positives have been addressed. Repository: rG LLVM Git

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): curdeius wrote: > Is this print

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343171. pirama added a comment. Remove debug print(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clang-format Index: clang

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

curdeius added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): Is this print supposed to stay or is it a remnant of print-debugging?

[clang] 602f318 - [WebAssembly] Fix constness of pointer params to load intrinsics

Author: Thomas Lively Date: 2021-05-05T13:16:56-07:00 New Revision: 602f318cfdac999a8604f1588159326b1a1a1a23 URL: https://github.com/llvm/llvm-project/commit/602f318cfdac999a8604f1588159326b1a1a1a23 DIFF: https://github.com/llvm/llvm-project/commit/602f318cfdac999a8604f1588159326b1a1a1a23.diff

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG602f318cfdac: [WebAssembly] Fix constness of pointer params to load intrinsics (authored by tlively). Changed prior to commit: https://reviews.llv

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

tlively added a comment. In D101884#2739898 , @aheejin wrote: > I see, thanks. Then other load instructions are OK not to be fixed? > > - `v128.load` > - `v128.loadN_splat` > - `v128.loadNxM_s/u` Yep, the intrinsics for those instructions were already us

[PATCH] D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101934/new/ https://reviews.llvm.org/D101934 ___

[clang] 627a526 - [WebAssembly] Update narrowing builtin function operand types

Author: Thomas Lively Date: 2021-05-05T13:04:04-07:00 New Revision: 627a52695537dd2bea068630887431febbf06856 URL: https://github.com/llvm/llvm-project/commit/627a52695537dd2bea068630887431febbf06856 DIFF: https://github.com/llvm/llvm-project/commit/627a52695537dd2bea068630887431febbf06856.diff

[PATCH] D101883: [WebAssembly] Update narrowing builtin function operand types

This revision was automatically updated to reflect the committed changes. Closed by commit rG627a52695537: [WebAssembly] Update narrowing builtin function operand types (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101883/new/

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

steveire added a comment. Please run `llvm-project/clang/docs/tools/dump_ast_matchers.py` to generate updated documentation for this (there is a `urlopen(url)` which slows things down, so I usually comment that out when running it). Do you have this on a git clone somewhere? It's easier to take

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

HazardyKnusperkeks added a comment. I have not a great knowledge about python, but it looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commit

[PATCH] D101937: [Clang][Manual] Mention -fdebug-info-for-profiling.

mbenfield created this revision. mbenfield added reviewers: rsmith, wmi. Herald added a subscriber: wenlei. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option is necessary for effective AutoFDO, and it also seems that the

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I see, thanks. Then other load instructions are OK not to be fixed? - `v128.load` - `v128.loadN_splat` - `v128.loadNxM_s/u` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 ___ cfe-commits mailing list cfe-com

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

tlively added a comment. It only matters for pointer parameters. For example, `const int *` is meaningfully different from `int *`, but `const int` is not usefully different from `int`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ ht

[PATCH] D101862: [clang-format] Rename common types between C#/JS

exv updated this revision to Diff 343144. exv added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 Files: clang/lib/Format/FormatToken.h clang/lib/Format/FormatTokenLexer.cpp clan

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

exv updated this revision to Diff 343143. exv marked an inline comment as done. exv added a comment. - Incorporate curdeius's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 Files: clang/lib/Fo

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. Rebased and comments addressed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

  1   2   >