[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

khchen added a comment. Is it okay to you? @kito-cheng @frasercrmck This patch could fix https://bugs.llvm.org/show_bug.cgi?id=49962, I hope this could be merged soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm

[PATCH] D68321: Fix clang Visual Studio build instructions

Loghorn added a comment. Is there a chance this will ever be merged? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2700324 , @ychen wrote: > In D100739#2700273 , @ChuanqiXu > wrote: > >> I hadn't looked into the details. I would try to make it. >> But from my understanding to this problem

[PATCH] D100368: [X86] Support some missing intrinsics

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2699038 , @dblaikie wrote: > In D99160#2698980 , @alok wrote: > >> In D99160#2671899 , @dblaikie wrote: >> >>> In D99160#2670460

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2700273 , @ChuanqiXu wrote: > I hadn't looked into the details. I would try to make it. > But from my understanding to this problem, the correct solution should remain > the previous behavior if the end user doesn't spec

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. I hadn't looked into the details. I would try to make it. But from my understanding to this problem, the correct solution should remain the previous behavior if the end user doesn't specify `alignas` for `promise_type`. I mean, it shouldn't make so many test cases fail

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGST

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman created this revision. arphaman added reviewers: ab, t.p.northover. Herald added subscribers: ributzka, kristof.beyls. arphaman requested review of this revision. Herald added a project: clang. Clang's driver currently prints out different default triples when it's invoked like this on A

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. @dblaikie I did some investigation, found the root cause and provided an alternative solution. Could you check whether you are okay with either approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ http

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. So I checked gcc on godbolt since gcc docs are not so clear. UnusedButSetParameter is ignored with: - -Wunused alone - -Wextra alone - -Wall -Wunused But works with -Wextra -Wunused or -Wall -Wextra. So I think we should put UnusedButSetParameter under -Wextra

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2699412 , @xbolva00 wrote: > I am a little bit worried that another off by default warning is not ideal > from user point of view. Either the user simply would fail to find out that > there is a new option or will b

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. In D98450#2699970 , @arphaman wrote: > Sorry, getting back to this only now. > > In D98450#2621907 , @aaron.ballman > wrote: > >> In D98450#2621877

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. Sorry, getting back to this only now. In D98450#2621907 , @aaron.ballman wrote: > In D98450#2621877 , @MForster wrote: > >> That's ok for me. I'd suggest to wait for Aaron's feedback, bec

[PATCH] D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC]

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The motivation here is to make it available in the base class whether a fact is managed

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

tra added a subscriber: jlebar. tra added a comment. LGTM overall. @jlebar: I could use your opinion here. Comment at: clang/lib/Headers/__clang_hip_cmath.h:341 - typedef decltype(__test(std::declval<_Tp>())) type; - static const bool value = !std::is_same::value; + typed

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

dexonsmith added a comment. Maybe LLVM should grow an `LLVMTargetInfo` library that sits between `LLVMSupport` and `LLVMCore`, as a version of solution 2 that doesn't induce more bloating in Support. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17183/new/ https

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 338648. penagos added a comment. Update Format test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/For

[clang] 199c397 - Revert "[clang-scan-deps] Add support for clang-cl"

Author: Alexandre Ganea Date: 2021-04-19T17:45:18-04:00 New Revision: 199c39748292cbc89cd148a0d8364ebb1014ec38 URL: https://github.com/llvm/llvm-project/commit/199c39748292cbc89cd148a0d8364ebb1014ec38 DIFF: https://github.com/llvm/llvm-project/commit/199c39748292cbc89cd148a0d8364ebb1014ec38.dif

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos marked an inline comment as done. penagos added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); Quuxplusone wrote: > Quuxplusone wrote: > > IMO you should

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 338641. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp =

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Remove the dependence on standard C++ header for overloaded math functions in HIP header since standard C++ header is not available for hipRTC. https://reviews.llvm.org/D100794 Files: clang/l

[PATCH] D93325: Add srcloc output to clang-query

steveire added a comment. @aaron.ballman ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. > Thanks! We found the issue. I think I'll revert the patch, and will reland a > fixed version. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 __

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire updated this revision to Diff 338631. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100712/new/ https://reviews.llvm.org/D100712 Files: clang/lib/Tooling/DumpTool/APIData.h clang/lib/Tooling/DumpTool/A

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. Thanks! We found the issue. I think I'll revert the patch, and will reland a fixed version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 _

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. > @gulfem We're taking a look now. Could you please post a link to the full > build log, including the cmake flags used? This is the link to one of our failing builds: https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang-linux-arm64/b8849674814150864912/overview Here,

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda abandoned this revision. kda added a comment. will attempt in smaller pieces. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:3317 ConstantInt::get(IntptrTy, LocalStackSize)); -IRB.SetInsertPoint(InsBefore); -FakeStack

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. In D100776#2699565 , @rnk wrote: > Of the three people who commented on D17183 > , you and I are on the only ones in favor of > this approach. I think @echristo and @jyknight both preferred approa

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. @gulfem We're taking a look now. Could you please post a link to the full build log, including the cmake flags used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev updated this revision to Diff 338624. ABataev added a comment. Fixes and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100673/new/ https://reviews.llvm.org/D100673 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/d

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rnk added subscribers: jyknight, echristo. rnk added a comment. Of the three people who commented on D17183 , you and I are on the only ones in favor of this approach. I think @echristo and @jyknight both preferred approach 2. I'd like to get at least an agreemen

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280 STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc()) })); // clang-format on steveire wrote: > njames93 wrote: > > I'm not entirely sure on the case,

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire updated this revision to Diff 338620. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100712/new/ https://reviews.llvm.org/D100712 Files: clang/lib/Tooling/DumpTool/APIData.h clang/lib/Tooling/DumpTool/A

[clang] 782c3e2 - [AST] Fix comparison to of SourceRanges in container

Author: Stephen Kelly Date: 2021-04-19T21:19:21+01:00 New Revision: 782c3e23ba09ca7b01034d0fbf0b34044c1c79a3 URL: https://github.com/llvm/llvm-project/commit/782c3e23ba09ca7b01034d0fbf0b34044c1c79a3 DIFF: https://github.com/llvm/llvm-project/commit/782c3e23ba09ca7b01034d0fbf0b34044c1c79a3.diff

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

This revision was automatically updated to reflect the committed changes. Closed by commit rG782c3e23ba09: [AST] Fix comparison to of SourceRanges in container (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100723/new/ htt

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const &RHS) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false;

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. This seems to break our `Fucshia` builds. If we cannot do a quick fix, we need to revert this patch. Please see the error message below: FAIL: Clang :: ClangScanDeps/vfsoverlay.cpp (1863 of 27822) TEST 'Clang :: ClangScanDeps/vfsoverlay.cpp' FAILED

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

This revision was automatically updated to reflect the committed changes. Closed by commit rGabacaef18162: [AST] Update introspection API to use const-ref for copyable types (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D100720?vs=338366&id=338613#toc Repository

[clang] abacaef - [AST] Update introspection API to use const-ref for copyable types

Author: Stephen Kelly Date: 2021-04-19T21:07:47+01:00 New Revision: abacaef1816254fc425fa81d137a8d54215d5913 URL: https://github.com/llvm/llvm-project/commit/abacaef1816254fc425fa81d137a8d54215d5913 DIFF: https://github.com/llvm/llvm-project/commit/abacaef1816254fc425fa81d137a8d54215d5913.diff

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2698422 , @curdeius wrote: > More I look at the current state of this option, more I think it's misleading. > I would expect that the if after else is also controlled by this option. And, > the last else as

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. another false positive: ../../third_party/abseil-cpp/absl/strings/internal/str_format/float_conversion.cc:879:20: error: variable 'kBufSizeForHexFloatRepr' set but not used [-Werror,-Wunused-but-set-variable] constexpr size_t kBufSizeForHexFloatRepr = https://s

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a subscriber: rsmith. xbolva00 added a comment. In D100581#2697697 , @mbenfield wrote: > In D100581#2693131 , @xbolva00 > wrote: > These warnings are not enabled by any other flags. This is di

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

george.burgess.iv added a reviewer: rtrieu. george.burgess.iv added a comment. Just a few more nits and LGTM. We probably want the thoughts of someone with ownership in warnings to be sure. +rtrieu might be good? Comment at: clang/lib/Sema/SemaDecl.cpp:13740 +// other than ass

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

dexonsmith added a comment. In D100762#2699252 , @arichardson wrote: > I'm not sure it's a good idea to remove the `-ast-dump=json` option. While > this is -cc1 option, there do seem to be external consumers based on a quick > search for "-ast-dump=jso

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. In D97183#2699080 , @RedDocMD wrote: > For the following function: > > void foo(std::unique_ptr P) { > A* praw = P.get(); > A* other = praw; > if (other) {} > P->foo(); > } > > Where do we expect a note? Where

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); Quuxplusone wrote: > IMO you should use `"test < a | b >> c;"` as your test case here, to reassu

[PATCH] D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers

george.burgess.iv added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3/new/ https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap created this revision. Conanap added reviewers: saghir, nemanjai, PowerPC. Conanap added projects: PowerPC, clang, LLVM. Herald added a subscriber: kbarton. Conanap requested review of this revision. The code gen for f32 to i32 bitcast is not currently the most efficient. For example:

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); IMO you should use `"test < a | b >> c;"` as your test case here, to reassure the reader that i

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:20 +// need to `include `. +#include +#endif jdoerfert wrote: > JonChesterfield wrote: > > I think there are legitimate use cases for writing

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8805574c183: [CUDA][HIP] Allow non-ODR use of host var in device (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] d880557 - [CUDA][HIP] Allow non-ODR use of host var in device

Author: Yaxun (Sam) Liu Date: 2021-04-19T14:45:24-04:00 New Revision: d8805574c183484f02855fa82d2e8932415e URL: https://github.com/llvm/llvm-project/commit/d8805574c183484f02855fa82d2e8932415e DIFF: https://github.com/llvm/llvm-project/commit/d8805574c183484f02855fa82d2e8932415e.dif

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

arichardson requested changes to this revision. arichardson added a reviewer: aaron.ballman. arichardson added a comment. I'm not sure it's a good idea to remove the `-ast-dump=json` option. While this is -cc1 option, there do seem to be external consumers based on a quick search for "-ast-dump=

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/test/AST/ast-dump-comment-json.cpp:44 // CHECK-NEXT: "loc": { -// CHECK-NEXT: "offset": 72, +// CHECK-NEXT: "offset": 89, // CH

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

lxfind added a comment. In D100282#2699171 , @rjmccall wrote: > MLIR is an in-tree project that can be updated. Sure, but I think there are some important differences. As far as I understand, in MLIR, unlike in C++/Swift frontend where a coroutine funct

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl updated this revision to Diff 338575. yaxunl added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen/TargetI

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

yln added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:444-447 +// Prior to c++17, "the failure argument shall be no stronger than the +// success argument". This condition has been lifted and the only +// precondition is 31.7.2.18. Effectively treat th

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

rjmccall added a comment. MLIR is an in-tree project that can be updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 ___ cfe-commits mailing list cfe-commi

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos created this revision. penagos added reviewers: Saldivarcher, MyDeveloperDay, JakeMerdichAMD, krasimir. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This serves to augment the improvements made in https://reviews.llvm.or

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 338565. abhina.sreeskantharajan added a comment. Rebase + set size of char as 1 when creating a StringRef to fix lit failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://revi

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: dexonsmith, kerbowa, kbarton, mgorny, nhaehnle, jvesely, nemanjai. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reverts parts of https://review

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG with 1 nit. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:14 +RefClades = ["NestedNameSpecifierLoc", "TemplateArgumentLoc", "TypeLoc"] + --

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. For the following function: void foo(std::unique_ptr P) { A* praw = P.get(); A* other = praw; if (other) {} P->foo(); } Where do we expect a note? Where `praw` is initialized, where `other` is initialized or both? Repository: rG LLVM Github Mono

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338554. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/Code

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

tejohnson added a comment. In D99554#2674229 , @wenlei wrote: > Does this help non-distributed ThinLTO as well? cc: @weiwang No. See the note in Wei's description about this: > Note that this patch only changes the distributed thinlto mode. For in > pro

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 338552. yaxunl marked an inline comment as done. yaxunl added a comment. Rebase and fix HIP header bug exposed by this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Headers/__clang

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

dblaikie added a comment. In D99160#2698980 , @alok wrote: > In D99160#2671899 , @dblaikie wrote: > >> In D99160#2670460 , @djtodoro wrote: >> >>> In D99160#2669576

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 338551. pzheng added a comment. Add missing comments. Thanks for spotting it, @xbolva00. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNot

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

MaskRay added subscribers: vitalybuka, eugenis. MaskRay added a comment. @eugenis @vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100251/new/ https://reviews.llvm.org/D100251 ___ cfe-commits ma

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2671899 , @dblaikie wrote: > In D99160#2670460 , @djtodoro wrote: > >> In D99160#2669576 , @dblaikie wrote: >> >>> In D99160#2668977

[PATCH] D100350: [AIX] Diagnose thinLTO usage in clang on AIX.

This revision was automatically updated to reflect the committed changes. Closed by commit rG369c0e0f48dd: [AIX] Diagnose thinLTO usage in clang on AIX. (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 369c0e0 - [AIX] Diagnose thinLTO usage in clang on AIX.

Author: Wael Yehia Date: 2021-04-19T16:39:48Z New Revision: 369c0e0f48dd3585566d251cc99955dbdeed84a1 URL: https://github.com/llvm/llvm-project/commit/369c0e0f48dd3585566d251cc99955dbdeed84a1 DIFF: https://github.com/llvm/llvm-project/commit/369c0e0f48dd3585566d251cc99955dbdeed84a1.diff LOG: [A

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

aaron.ballman accepted this revision. aaron.ballman added a comment. I only found one tiny nit, and otherwise it LGTM, but this is a bit out of my wheelhouse. Comment at: clang/lib/CodeGen/CodeGenFunction.h:529 +// following (6.9.2.3.1 in C++11): +// - terminate, +

[clang] 6a72ed2 - [clang] NFC: Fix range-based for loop warnings related to decl lookup

Author: Jan Svoboda Date: 2021-04-19T18:31:31+02:00 New Revision: 6a72ed239cc3f30c1149721f07de463b4b459b16 URL: https://github.com/llvm/llvm-project/commit/6a72ed239cc3f30c1149721f07de463b4b459b16 DIFF: https://github.com/llvm/llvm-project/commit/6a72ed239cc3f30c1149721f07de463b4b459b16.diff L

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:22 + +// CHECK: store i32 1 +// CHECK: store i32 2 tra wrote: > Nit: You may want to add a `CHECK-LABEL: `. It does not make > much o

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Small test nit. LGTM otherwise. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:22 + +// CHECK: store i32 1 +// CHECK: store i32 2 Nit: You may want to a

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. Here's the fix for enabling these on ARM: https://reviews.llvm.org/D100772 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Neon

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added a comment. In D99861#2697449 , @Qix- wrote: > I'm not sure exactly how to continue after the last few comments - what > should the approach be for this patch? Or are these things we can shoot for > in later patches? I don't think the

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic updated this revision to Diff 338539. rsanthir.quic added a comment. only the pol128 intrinsic is incompatible with ARM, the rest should be supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 Files: clang/lib/CodeGen/CG

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. Thanks for looking into this @DavidSpickett ! What you found makes sense. I'll update this patch to remove only the poly128 vadd from the mapping. I'll also add another patch that will correctly enable the remaining vadd intrinsics for ARM. Repository: rG LLVM

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:591-592 return Bld.CreateAnd(Bld.CreateNUWSub(NumThreads, Bld.getInt32(1)), Bld.CreateNot(Mask), "master_tid"); } This is another undefined codege

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn requested changes to this revision. fhahn added a comment. This revision now requires changes to proceed. In D99433#2662275 , @everton.constantino wrote: > Great, Ill update the patch then. Thanks for the comments! Sounds good to me, thanks! Markin

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: jfb, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In OpenMP 5.1, the required f

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added a comment. In D96418#2676338 , @lebedev.ri wrote: > Seems fine to me. > Might be good for someone else (@aaron.ballman ?) to also take a look, not > sure. ping. @aaron.ballman any chance you could take another quick look? Repository: rG L

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2698168 , @protze.joachim wrote: > I tested the patch and still get wrong results (I modified the > `declare_mapper_nested_default_mappers_complex_structure.cpp` test to use my > verbose printf from bugzilla): > >

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 338520. DmitryPolukhin added a comment. Fix wrong character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 Files: clang-tools-extra/clang-tidy/ClangTidyDiagno

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

njames93 updated this revision to Diff 338518. njames93 added a comment. Fix up compilation failures and test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files: clang-tools-extra/clangd/Clan

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 338517. DmitryPolukhin added a comment. Put feature behind flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 Files: clang-tools-extra/clang-tidy/ClangTidyDi

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arichardson. Herald added subscribers: dang, usaxena95, kadircet, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: llvm-

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone

jansvoboda11 updated this revision to Diff 338507. jansvoboda11 added a comment. Rebase, delete RefBase copy assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100460/new/ https://reviews.llvm.org/D100460 Files: clang-tools-extra/clangd/TU

[clang] aa1e391 - Fix test/Frontend/print-header-includes.c

Author: Hans Wennborg Date: 2021-04-19T15:39:09+02:00 New Revision: aa1e3914020b1211e6bdd306d4f5f2010971d6ee URL: https://github.com/llvm/llvm-project/commit/aa1e3914020b1211e6bdd306d4f5f2010971d6ee DIFF: https://github.com/llvm/llvm-project/commit/aa1e3914020b1211e6bdd306d4f5f2010971d6ee.diff

[clang] 05b4bab - [SystemZ][z/OS] Set more text files as text

Author: Abhina Sreeskantharajan Date: 2021-04-19T09:31:46-04:00 New Revision: 05b4babc9d85a6669a39a58351fd8b1ebca2ab96 URL: https://github.com/llvm/llvm-project/commit/05b4babc9d85a6669a39a58351fd8b1ebca2ab96 DIFF: https://github.com/llvm/llvm-project/commit/05b4babc9d85a6669a39a58351fd8b1ebca2

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

This revision was automatically updated to reflect the committed changes. Closed by commit rG05b4babc9d85: [SystemZ][z/OS] Set more text files as text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100654/new/ h

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

curdeius planned changes to this revision. curdeius added a subscriber: klimek. curdeius added a comment. More I look at the current state of this option, more I think it's misleading. I would expect that the if after else is also controlled by this option. And, the last else as well (adding yet

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

Jonathan.Crowther accepted this revision. Jonathan.Crowther added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100654/new/ https://reviews.llvm.org/D100654 _

[PATCH] D100759: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb36dc8dcf1c: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver… (authored by hans). Repository: rG LLVM Github Monore

[clang] bb36dc8 - Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option

Author: Hans Wennborg Date: 2021-04-19T15:22:15+02:00 New Revision: bb36dc8dcf1c4a16cafdafc6b225ec6036144f41 URL: https://github.com/llvm/llvm-project/commit/bb36dc8dcf1c4a16cafdafc6b225ec6036144f41 DIFF: https://github.com/llvm/llvm-project/commit/bb36dc8dcf1c4a16cafdafc6b225ec6036144f41.diff

  1   2   >