ChuanqiXu added a comment.

I hadn't looked into the details. I would try to make it.
But from my understanding to this problem, the correct solution should remain 
the previous behavior if the end user doesn't specify `alignas` for 
`promise_type`. I mean, it shouldn't make so many test cases fail.

> The alloca of the raw frame pointer (suppose we insert it in the frontend) 
> would be included in the non-overaligned frame if we don't teach CoroFrame 
> how to elide it.

It is confusing to me, maybe I need to look into the codes. First, the raw 
frame pointer isn't inserted in the frontend. Do you mean coro.begin? Then, 
what's the relationship between eliding and over-aligned? It also makes me 
confused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100739/new/

https://reviews.llvm.org/D100739

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to