rnk added subscribers: jyknight, echristo. rnk added a comment. Of the three people who commented on D17183 <https://reviews.llvm.org/D17183>, you and I are on the only ones in favor of this approach. I think @echristo and @jyknight both preferred approach 2. I'd like to get at least an agreement to disagree from one of them before approving this.
--- I remember now that the last time this came up, we wanted to preserve the ability for the frontend to generate IR for any target, even if it has no registered backend. This means we don't need `REQUIRES: foo-registered-target` lines in our clang IRgen tests. LLVM keeps the data layout in the backends. This dependency from clangBasic to LLVMIR wasn't a major consideration at the time. That makes me lean a little bit towards leaving this as it is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100776/new/ https://reviews.llvm.org/D100776 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
