[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

arcbbb created this revision. arcbbb added reviewers: craig.topper, rogfer01, khchen, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AvoidStdIoOutsideMainCheck.cpp:22 + Finder->addMatcher( + declRefExpr(to(varDecl(hasAnyName("cin", "wcin", "cout", "wcout", "cerr", +"wcerr"),

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 337344. balazske added a comment. Add another test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[clang-tools-extra] cbc9c4e - [clangd] Add support for inline parameter hints

Author: Nathan Ridge Date: 2021-04-14T02:31:20-04:00 New Revision: cbc9c4ea90e17980b7b65966f4bbdba26a395e45 URL: https://github.com/llvm/llvm-project/commit/cbc9c4ea90e17980b7b65966f4bbdba26a395e45 DIFF: https://github.com/llvm/llvm-project/commit/cbc9c4ea90e17980b7b65966f4bbdba26a395e45.diff

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

hokein added a comment. a small suggestion to simplify the tests. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-equivalentbitwidth-off.cpp:1 +// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \ +// RUN: -co

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 updated this revision to Diff 337333. LiuChen3 added a comment. Address Craig's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99565/new/ https://reviews.llvm.org/D99565 Files: clang/include/clang/Driver/Options.td clang/test/

Re: [clang] c965e14 - Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions."

Please include some details about why a patch is being reverted in the patch description - helps with history & triage (if someone's seeing a local failure they'll have an idea whether this patch will address their issue, if someone wants to do the same kind of work in the future they'd know the pi

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

ChuanqiXu accepted this revision. ChuanqiXu added a comment. I agree with the idea we should set the attribute in the frontend or move Coro-early pass in the front. It looks more weird to add a `noinline` attribute and move it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100415: [Coroutines] Split coroutine during CoroEarly into an init and ramp function

ChuanqiXu added a comment. The overall idea looks good to me. Since this is a fundamental and large change, I need time to run it actually and look into details. Noticed that this patch introduces new intrinsics and new concept `init function`, it may be needed to add them in the coroutines docu

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

lxfind added a comment. In D100282#2687532 , @ychen wrote: > I think the setting is in CoroEarly from the beginning is that it is an > implementation detail? Clients should only worry about coroutine shape. > Maybe we could set `noinline` in frontends

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

rjmccall added a comment. That something is an (unlowered) coroutine is an important semantic property of the function that should be represented more explicitly in IR than just whether it contains a call to an intrinsic in the `llvm.coro.id` family. Coroutines have somewhat different structur

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

ychen added a comment. I think the setting is in CoroEarly from the beginning is that it is an implementation detail? Clients should only worry about coroutine shape. Maybe we could set `noinline` in frontends to express the intent and remove it in coroearly/corosplit? Repository: rG LLVM

[PATCH] D100368: [X86] Support some missing intrinsics

LiuChen3 updated this revision to Diff 337301. LiuChen3 added a comment. Address Simon's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368 Files: clang/lib/Headers/avx512fintrin.h clang/test/Co

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2685698 , @Anastasia wrote: > In D97669#2678460 , @benshi001 wrote: > >> In D97669#2676826 , @Anastasia >> wrote: >> >>> In D97669#26658

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2686130 , @morehouse wrote: > If the effect is similar to entropic, why do we need this patch as well? They just have some similarities, they will be better after patching. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

Jim accepted this revision. Jim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100266/new/ https://reviews.llvm.org/D100266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D100415: [Coroutines] Split coroutine during CoroEarly into an init and ramp function

lxfind updated this revision to Diff 337290. lxfind added a comment. some cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100415/new/ https://reviews.llvm.org/D100415 Files: clang/lib/CodeGen/CGCoroutine.cpp llvm/include/llvm/IR/Intrins

[PATCH] D100428: [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

arphaman added a comment. Thanks, will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100428/new/ https://reviews.llvm.org/D100428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D100428: [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Can you add a comment to the code explaining why the filename could be empty? With that, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D100428: [clang][FileManager] Support empty file name in getVirtualFileRef for serialized diagnostics

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. After https://reviews.llvm.org/D90484 libclang is unable to read a serialized diagnostic file which cont

[PATCH] D100411: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

sunfish added a comment. Great, thanks! And yes, switching to roundeven for both scalar and SIMD ISel sounds right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100411/new/ https://reviews.llvm.org/D100411 _

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. @hoyFB wrote: > @ormris I'd like to follow up on this. We had a similar change internally > which led up to some gains when combined with SPGO, and we'd like to help > move forward with this patch here. Would you mind sharing the plan or > progress on your side? Thanks!

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:711 +if (CalleeQualType.isNull()) { + // The function callee is invalid and already triggered an error. + // Avoid compounding errors. haberman wrote: > rsmith wrote: > > Even in

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3066 - if (isCopyElisionCandidate(ReturnType, VD, CESK)) -return VD; - return nullptr; +static void downgradeNRVOResult(Sema::NRVOResult &Res, bool CanMove) { + Res.S = std::min(Res.S, CanMove ? S

[PATCH] D100411: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

tlively added a comment. The Wasm rounding semantics (https://webassembly.github.io/spec/core/exec/numerics.html#op-fnearest) are essentially the same as the semantics for roundeven (https://llvm.org/docs/LangRef.html#llvm-roundeven-intrinsic, added to LLVM in May 2020), so that would be the l

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3066 - if (isCopyElisionCandidate(ReturnType, VD, CESK)) -return VD; - return nullptr; +static void downgradeNRVOResult(Sema::NRVOResult &Res, bool CanMove) { + Res.S = std::min(Res.S, CanMove ? Sema

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. A

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:711 +if (CalleeQualType.isNull()) { + // The function callee is invalid and already triggered an error. + // Avoid compounding errors. rsmith wrote: > Even in invalid code we sh

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

xbolva00 added a comment. Nice new feature! Please also update Release Notes for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 ___ cfe-commits mailing li

[PATCH] D100411: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. This looks good to me! Could you briefly comment here on what the issue with `llvm.roundeven` is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

njames93 created this revision. njames93 added a reviewer: steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a print method that takes a raw_ostream. Change LocationCallFormatterCpp::format to call that method. Reposi

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG69545154cc28: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 6954515 - [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

Author: Anton Bikineev Date: 2021-04-14T01:01:40+02:00 New Revision: 69545154cc28a0a7f813174253c6cb428666eb3a URL: https://github.com/llvm/llvm-project/commit/69545154cc28a0a7f813174253c6cb428666eb3a DIFF: https://github.com/llvm/llvm-project/commit/69545154cc28a0a7f813174253c6cb428666eb3a.diff

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3144-3145 +/// \param ReturnType This is the return type of the function. +/// \returns The copy elision candidate, in case the initial return expression +/// was copy elidable, or nullptr otherwise. +con

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added a comment. Functionally this looks good to me. I've suggested some minor cleanups and I understand you're doing some wordsmithing on the diagnostics; I think once those are complete this will be ready to land. Thank you! Comment at: clang/lib/CodeGen/CGExpr.cpp:4

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Seems harmless, so lg :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99808/new/ https://reviews.llvm.org/D99808 _

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; njames93 wrote: >

[PATCH] D100415: [Coroutines] Split coroutine during CoroEarly into an init and ramp function

lxfind created this revision. Herald added subscribers: ChuanqiXu, hoy, modimo, wenlei, hiraditya. lxfind requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. A coroutine has the following structure in LLVM IR: en

[PATCH] D99231: [AST] Add introspection support for more base nodes

njames93 added subscribers: aaron.ballman, rsmith. njames93 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) +

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 337266. mizvekov added a comment. - Changed the downgrade* function name to disallowNRVO, given second thought, I think it's appropriate name. - Change to one variable declaration per statement as per Arthur's review. Repository: rG LLVM Github Monorepo

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:1649 +Group, Flags<[CoreOption, HelpHidden]>, +HelpText<"Do not emit unaligned move instructions unless users explicitly uses.">; def fassociative_math : Flag<["-"], "fassociative-mat

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1723 + if (Args.hasArg(options::OPT_fuse_unaligned_vector_move)) +addArg(Twine("-x86-enable-unaligned-vector-move=true")); + else if (Args.hasArg(options::OPT_fno_use_unaligned_vector

[PATCH] D100391: [RISCV][Clang] Add RVV miscellaneous intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:97 +// type (SEW and LMUL), and computes another vector type which only changed +// SEW as given value. Ingore to define a new builtin if its qeuivalent +// type has illegal

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. @rsmith: Actually, there is still something not quite right with this patch that I have to finish investigating. The B5 test should not have gotten copy elision. I thought at first that we had gotten the function return type deduced durin

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

MaskRay added a comment. This touches sanitizers so hope #sanitizers folks can weigh in as well. Comment at: llvm/include/llvm/IR/Function.h:156 + static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, +

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 ___

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3066 - if (isCopyElisionCandidate(ReturnType, VD, CESK)) -return VD; - return nullptr; +static void downgradeNRVOResult(Sema::NRVOResult &Res, bool CanMove) { + Res.S = std::min(Res.S, CanMove ? Sema

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3066 - if (isCopyElisionCandidate(ReturnType, VD, CESK)) -return VD; - return nullptr; +static void downgradeNRVOResult(Sema::NRVOResult &Res, bool CanMove) { + Res.S = std::min(Res.S, CanMove ? Sema

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

lxfind updated this revision to Diff 337259. lxfind added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 Files: clang/lib/CodeGen/CGCoroutine.cpp clang/test/CodeGenCoroutines/c

[PATCH] D97296: [analyzer] [NFC] Add a new parameter ProgramStateRef to SValBuilder::evalCast function

ASDenysPetrov added a comment. This is the only revision in the stack which was bypass your attention. It's fairly harmless although a big one. Please, look at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97296/new/ https://reviews.llvm.org/D97296

[PATCH] D100411: [WebAssembly] Use standard intrinsics for f32x4 and f64x2 ops

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. N

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3084-3085 + bool ForceCXX20) { + bool hasCXX11 = getLangOpts().CPlusPlus11 || ForceCXX20, + hasCXX20 = getLangOpts().CPlusPlus20 || ForceCXX20; + Named

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:605-609 + while (!isa(Ex)) { +auto *PE = cast(Ex); +Ex = IgnoreImplicitAsWritten(PE->getSubExpr()); +PE->setSubExpr(Ex); + } rsmith wrote: > This loop is problematic: it's gener

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 337252. haberman marked 14 inline comments as done. haberman added a comment. - Addressed more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files:

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

ArturGainullin added a comment. In D100361#2686823 , @rnk wrote: > Example: > https://github.com/llvm/llvm-project/blob/main/clang/unittests/Driver/ToolChainTest.cpp#L29 Thank you for the example! I will take a look and may consider adding a test as a

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit rG192c6023e1e2: [Driver] Make the findVCToolChainViaEnvironment case-insensitive (authored by ArturGainullin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[clang] 192c602 - [Driver] Make the findVCToolChainViaEnvironment case-insensitive

Author: Artur Gainullin Date: 2021-04-13T13:36:37-07:00 New Revision: 192c6023e1e2f31284752d17846401158445f42d URL: https://github.com/llvm/llvm-project/commit/192c6023e1e2f31284752d17846401158445f42d DIFF: https://github.com/llvm/llvm-project/commit/192c6023e1e2f31284752d17846401158445f42d.dif

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne friendly ping. In D89013#2686799 , @ldionne wrote: > I agree the design is clean from the "what we ship" perspective. I really > like the idea of shipping the whole library in a generic spot and only having > one file em

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3290 } - -if (!getLangOpts().CPlusPlus20 && NeedSecondOverloadResolution && -!getDiagnostics().isIgnored(diag::warn_return_std_move, +if (!getDiagnostics().isIgnored(diag::warn_return_std

[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

njames93 updated this revision to Diff 337249. njames93 added a comment. Use InMemoryFileSystem instead of Remapped files, turns out they don't work if the file doesn't exist on disk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100343/new/ https

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4728 - enum CopyElisionSemanticsKind { -CES_Strict = 0, -CES_AllowParameters = 1, -CES_AllowDifferentTypes = 2, -CES_AllowExceptionVariables = 4, -CES_AllowRValueReferenceType = 8,

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 337248. mizvekov marked 7 inline comments as done. mizvekov added a comment. - Address rsmith review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files:

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

rnk added a comment. Example: https://github.com/llvm/llvm-project/blob/main/clang/unittests/Driver/ToolChainTest.cpp#L29 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100361/new/ https://reviews.llvm.org/D100361 _

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm This code could greatly benefit from some unit tests similar in style to the GCC installation detection tests, but It would be unreasonable for me to insist on them. Repository: rG LLVM Gi

[PATCH] D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG204aaf879548: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro. (authored by sdesmalen). Changed prior to commit: https:

[clang] 204aaf8 - [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

Author: Sander de Smalen Date: 2021-04-13T21:12:53+01:00 New Revision: 204aaf879548616df407f662bc03d28b8d08d1fb URL: https://github.com/llvm/llvm-project/commit/204aaf879548616df407f662bc03d28b8d08d1fb DIFF: https://github.com/llvm/llvm-project/commit/204aaf879548616df407f662bc03d28b8d08d1fb.di

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106 uint64_t Members = 0; IsIndirect = !isHomogeneousAggregate(Ty, Base, Members); } rnk wrote: > rnk wrote: > > Do we need to worry about H[VF]As passed to variadic functi

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne added a comment. I agree the design is clean from the "what we ship" perspective. I really like the idea of shipping the whole library in a generic spot and only having one file embody all the target specific configuration of the library. I think it's a very elegant way to handle the co

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:7 +Finds calls to ``new`` that may throw ``std::bad_alloc``

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

aaron.ballman added a comment. Thanks! I think the changes generally LG, but I did have a question that might generate a small change. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:82 + const auto IsSizeTypeOrDifferenceType = hasTyp

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106 uint64_t Members = 0; IsIndirect = !isHomogeneousAggregate(Ty, Base, Members); } rnk wrote: > D

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 64c24f493e5f4637ee193f10f469cdd2695b4ba6 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

rnk added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106 uint64_t Members = 0; IsIndirect = !isHomogeneousAggregate(Ty, Base, Members); } Do we need to worry about H[VF]As passed to variadic functions, or is there a special case

[clang] 64c24f4 - Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

Author: Hana Dusíková Date: 2021-04-13T15:45:09-04:00 New Revision: 64c24f493e5f4637ee193f10f469cdd2695b4ba6 URL: https://github.com/llvm/llvm-project/commit/64c24f493e5f4637ee193f10f469cdd2695b4ba6 DIFF: https://github.com/llvm/llvm-project/commit/64c24f493e5f4637ee193f10f469cdd2695b4ba6.diff

[PATCH] D40660: Enable auto-linking on Windows

mstorsjo edited subscribers, added: libcxx-commits, mstorsjo; removed: llvm-commits, cfe-commits. mstorsjo added a comment. I see that @smeenai brought up the inconsistency between `_DLL` and `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` already back when this was reviewed. I'm running into problems

[clang] c058a71 - Correct the tablegen for checking mutually exclusive stmt attrs

Author: Aaron Ballman Date: 2021-04-13T15:20:30-04:00 New Revision: c058a7122787c8e503cf6306b8da03c0e56a41a5 URL: https://github.com/llvm/llvm-project/commit/c058a7122787c8e503cf6306b8da03c0e56a41a5 DIFF: https://github.com/llvm/llvm-project/commit/c058a7122787c8e503cf6306b8da03c0e56a41a5.diff

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. But please wait for additional "Accept" from either `hokein` or `aaron.ballman`. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99543/n

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c0bc69490a5: Ship `llvm-cxxfilt` in the toolchain. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 4c0bc69 - Ship `llvm-cxxfilt` in the toolchain.

Author: Dan Liew Date: 2021-04-13T11:58:33-07:00 New Revision: 4c0bc69490a57f2f8f9ede948e6d66cc0900879a URL: https://github.com/llvm/llvm-project/commit/4c0bc69490a57f2f8f9ede948e6d66cc0900879a DIFF: https://github.com/llvm/llvm-project/commit/4c0bc69490a57f2f8f9ede948e6d66cc0900879a.diff LOG:

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100405/new/ https://reviews.llvm.org/D100405 _

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

delcypher created this revision. delcypher added reviewers: steven_wu, arphaman, dexonsmith. Herald added subscribers: yaxunl, mgorny. delcypher requested review of this revision. Herald added a project: clang. Originally done for rdar://problem/57155465. rdar://76602859 Repository: rG LLVM G

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

aaron.ballman added a comment. Do you need someone to commit this on your behalf? If so, what email address and name would you like me to use for commit attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.or

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

gandhi21299 marked 2 inline comments as done. gandhi21299 added a comment. I am looking towards more feedback on this patch, please do follow up at your convenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46b8ea2fff90: [clang-tidy] Add check for implicit widening of multiplication result (authored by lebedev.ri). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 46b8ea2 - [clang-tidy] Add check for implicit widening of multiplication result

Author: Roman Lebedev Date: 2021-04-13T21:41:22+03:00 New Revision: 46b8ea2fff90b44b7ae558999721cf30f9b83aa9 URL: https://github.com/llvm/llvm-project/commit/46b8ea2fff90b44b7ae558999721cf30f9b83aa9 DIFF: https://github.com/llvm/llvm-project/commit/46b8ea2fff90b44b7ae558999721cf30f9b83aa9.diff

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri added a comment. @aaron.ballman thank you so much for the review! Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:130 + StringRef TyAsString = + IndexExprType->isSignedIntegerType() ? "ssize_t" : "size_t"; + --

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 337214. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Address final nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/ https://reviews.llvm.org/D93822 Files: clang-t

[clang] 701d70d - String Literal and Wide String Literal Encoding from the Preprocessor

Author: ThePhD Date: 2021-04-13T14:18:07-04:00 New Revision: 701d70d4c25c4e02b303ba6dee1495708496f615 URL: https://github.com/llvm/llvm-project/commit/701d70d4c25c4e02b303ba6dee1495708496f615 DIFF: https://github.com/llvm/llvm-project/commit/701d70d4c25c4e02b303ba6dee1495708496f615.diff LOG: S

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

aaron.ballman closed this revision. aaron.ballman added a comment. In D100346#2686407 , @ThePhD wrote: > In D100346#2686342 , @aaron.ballman > wrote: > >> Okay, I'm sold. Thank you for the detailed explanation! T

[PATCH] D100402: [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u}

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits in the documentation. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:130 +

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD added a comment. In D100346#2686342 , @aaron.ballman wrote: > Okay, I'm sold. Thank you for the detailed explanation! The changes LGTM. Do > you have commit privileges or would you like me to commit on your behalf? (If > you'd like me to commit,

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D100346#2686015 , @ThePhD wrote: > In D100346#2685530 , @aaron.ballman > wrote: > >> ... >>

[PATCH] D99568: [clang][invocation] Fix copy constructor of CompilerInvocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99568/new/ https://reviews.llvm.org/D99568

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53d474abc92c: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has… (authored by tianshilei1992). Repository: rG LLVM Gi

[clang] 53d474a - [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

Author: Shilei Tian Date: 2021-04-13T13:22:49-04:00 New Revision: 53d474abc92c42bed5d0cab5c79ee9ea5666aad1 URL: https://github.com/llvm/llvm-project/commit/53d474abc92c42bed5d0cab5c79ee9ea5666aad1 DIFF: https://github.com/llvm/llvm-project/commit/53d474abc92c42bed5d0cab5c79ee9ea5666aad1.diff L

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

kkwli0 accepted this revision. kkwli0 added a comment. This revision is now accepted and ready to land. No more comments from the community. I think it is okay to accept this revision. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/n

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader created this revision. Herald added subscribers: Naghasan, ldrumm, dexonsmith, kerbowa, Anastasia, ebevhan, yaxunl, nhaehnle, jvesely, jholewinski. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. If the effect is similar to entropic, why do we need this patch as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100161/new/ https://reviews.llvm.org/D100161 ___ cfe-comm

  1   2   >