craig.topper added inline comments.
================
Comment at: clang/include/clang/Basic/riscv_vector.td:97
+// type (SEW and LMUL), and computes another vector type which only
changed
+// SEW as given value. Ingore to define a new builtin if its qeuivalent
+// type has illegal lmul or the SEW does not changed.
----------------
Ingore -> Ignore
================
Comment at: clang/include/clang/Basic/riscv_vector.td:97
+// type (SEW and LMUL), and computes another vector type which only
changed
+// SEW as given value. Ingore to define a new builtin if its qeuivalent
+// type has illegal lmul or the SEW does not changed.
----------------
craig.topper wrote:
> Ingore -> Ignore
qeuivalent -> equivalent
================
Comment at: clang/include/clang/Basic/riscv_vector.td:101
+// and LMUL), and computes another vector type which only changed LMUL as
+// given value. The new LMUL should be smaller than the old one. Ingore to
+// define a new builtin if its qeuivalent type has illegal lmul.
----------------
Same
================
Comment at: clang/include/clang/Basic/riscv_vector.td:102
+// given value. The new LMUL should be smaller than the old one. Ingore to
+// define a new builtin if its qeuivalent type has illegal lmul.
+// (LFixedLog2LMUL:Value): Larger Fixed Log2LMUL. Given a vector type (SEW
----------------
Same
================
Comment at: clang/include/clang/Basic/riscv_vector.td:105
+// and LMUL), and computes another vector type which only changed LMUL as
+// given value. The new LMUL should be larger than the old one. Ingore to
+// define a new builtin if its qeuivalent type has illegal lmul.
----------------
Same
================
Comment at: clang/include/clang/Basic/riscv_vector.td:106
+// given value. The new LMUL should be larger than the old one. Ingore to
+// define a new builtin if its qeuivalent type has illegal lmul.
//
----------------
Same
================
Comment at: clang/include/clang/Basic/riscv_vector.td:1304
+ // Reinterpret between different SEW under the same LMUL
+ foreach dst_sew = ["(FixedLog2SEW:3)", "(FixedLog2SEW:4)",
"(FixedLog2SEW:5)",
+ "(FixedLog2SEW:6)"] in {
----------------
Would this make more sense as just FixedSEW:8, FixedSEW:16, etc. I don't think
the Log2 is helping here. We need it for LMUL because of the fractional lmul,
but not SEW.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100391/new/
https://reviews.llvm.org/D100391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
