[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

kadircet added a comment. In D95538#2527335 , @curdeius wrote: > Why is fixing (or removing) the fallback style in the .clang-format file not > enough?? sure that would be one way to go, and that's what the user did already. It feels confusing to me that

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2967 + // needs to be indented. + bool ClosesBlock = + Line->MatchingOpening

[PATCH] D95571: [clangd] Remove some obsolete options that are now always on

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I assume you'll handle the internal integration part ;) Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:453 -// FIXME: retire this flag in llvm 13 release cycle. -

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

curdeius added a comment. Why is fixing (or removing) the fallback style in the .clang-format file not enough?? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95538/new/ https://reviews.llvm.org/D95538 _

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

kadircet updated this revision to Diff 319765. kadircet added a comment. - Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95538/new/ https://reviews.llvm.org/D95538 Files: clang/lib/Format/Format.cpp clang/unittests/Format/FormatTest

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

kadircet added a comment. Sure adding tests, sorry for leaving them out the first time. To give more insights, `format::getStyle()` tries to figure out `FallbackStyle` at the beginning of the function, and errors out if it can't. But in most cases `FallbackStyle` is not needed, e.g. there's alr

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2526483 , @MaskRay wrote: > Looks quite good. > > In D76802#2526382 , @phosek wrote: > >> @MaskRay does this look good to you? > > Looks like GNU ld has an infinite loop problem w.r

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 319762. phosek added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-g

[PATCH] D95590: [RISCV] Define preprocessor definitions for 'P' extension

Jim created this revision. Jim added reviewers: craig.topper, HsiangKai, kito-cheng, jrtc27, luismarques. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zz

[PATCH] D95589: [RISCV] Support experimental 'P' extension 0.9

Jim created this revision. Jim added reviewers: craig.topper, HsiangKai, jrtc27, kito-cheng, luismarques. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zz

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, jansvoboda11. Herald added subscribers: dang, ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Add -cc1 flags `-fmodules-uses-lock` and `-fno-modules-uses-lock` to allow the lock manager

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1478 + enum class AtomicOperationKind { +Unsupported, +Init, This shouldn't be here; if you have places that don't always represent an atomic operation, queries for the k

[PATCH] D95581: Frontend: Refactor compileModuleAndReadAST, NFC

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. This renames `compileModuleAndReadAST`, adding a `BehindLock` suffix, and refactors it to signifi

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2688-2689 // ::= S # __attribute__((__swiftcall__)) // Clang-only + // ::= T # __attribute__((__swiftasynccall__)) // + // Cl

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added inline comments. Comment at: llvm/include/llvm-c/Core.h:163 LLVMX86_MMXTypeKind, /**< X86 MMX */ + LLVMX86_AMXTypeKind, /**< X86 AMX */ LLVMTokenTypeKind, /**< Tokens */ MaskRay wrote: > cuviper wrote: > > This is a breaking change

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

MaskRay added a comment. > Implement option to omit P10 instructions from > stubs Please mention the option name directly. Please avoid P10 - the abbreviation is confusing. Comment at: lld/ELF/Config.h:74 +// For -

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak reopened this revision. ahatanak added a comment. This revision is now accepted and ready to land. Address post-commit review comments. - Use operand bundle instead of attribute. - Emit a call to `@llvm.objc.clang.arc.noop.use` in the front-end so that the optimization passes know the c

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 319719. ahatanak retitled this revision from "[ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR" to "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in t

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. In D91913#2526866 , @dmajor wrote: > If I'm reading git correctly, the change is still present on the 12.x branch. > Should it be reverted there too? I could have sworn that I saw it already reverted on the 12.x branch too, but I

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:157 llvm::Function *makeModuleDtorFunction() override; + void + adjustShadowVarLinkage(const VarDecl *D, clang-format it? `void` hanging all by itself looks odd. Comment

[clang-tools-extra] c3df9d5 - [clangd] Parse Diagnostics block, and nest ClangTidy block under it.

Author: Sam McCall Date: 2021-01-28T01:36:23+01:00 New Revision: c3df9d58c75e0f89ca95e947804d65e79a491adc URL: https://github.com/llvm/llvm-project/commit/c3df9d58c75e0f89ca95e947804d65e79a491adc DIFF: https://github.com/llvm/llvm-project/commit/c3df9d58c75e0f89ca95e947804d65e79a491adc.diff LO

[PATCH] D95560: [CUDA][HIP] Fix function scope static variable

tra added a comment. > A static variable in device and global functions is supposed to have > implicit device attribute. Currently it does not. This causes incorrect > diagnostics about host variables accessed by device functions. Correct diagnostics sevice-side local static vars is a valid conc

[PATCH] D95362: [clangd] Parse Diagnostics block, and nest ClangTidy block under it.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3df9d58c75e: [clangd] Parse Diagnostics block, and nest ClangTidy block under it. (authored by sammccall). Changed prior to commit: https://revie

[clang-tools-extra] c3df9d5 - [clangd] Parse Diagnostics block, and nest ClangTidy block under it.

Author: Sam McCall Date: 2021-01-28T01:36:23+01:00 New Revision: c3df9d58c75e0f89ca95e947804d65e79a491adc URL: https://github.com/llvm/llvm-project/commit/c3df9d58c75e0f89ca95e947804d65e79a491adc DIFF: https://github.com/llvm/llvm-project/commit/c3df9d58c75e0f89ca95e947804d65e79a491adc.diff LO

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 319716. timwoj added a comment. - Make LineLevel an enum class - Combine multiple duplicate checks into a named variable - Minor formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

dmajor added a comment. If I'm reading git correctly, the change is still present on the 12.x branch. Should it be reverted there too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 __

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

Conanap updated this revision to Diff 319715. Conanap marked 12 inline comments as done. Conanap added a comment. Removed lambda functions and made a static function, included a R2SaveStub test case that covers if it fits in 34 bits with option --no-power10-stubs. CHANGES SINCE LAST ACTION ht

[clang-tools-extra] 29472bb - [clangd] Log warning when using legacy (theia) semantic highlighting.

Author: Sam McCall Date: 2021-01-28T01:29:28+01:00 New Revision: 29472bb76915c4929aecc938300f6df31f63ac29 URL: https://github.com/llvm/llvm-project/commit/29472bb76915c4929aecc938300f6df31f63ac29 DIFF: https://github.com/llvm/llvm-project/commit/29472bb76915c4929aecc938300f6df31f63ac29.diff LO

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

MaskRay added inline comments. Comment at: llvm/include/llvm-c/Core.h:163 LLVMX86_MMXTypeKind, /**< X86 MMX */ + LLVMX86_AMXTypeKind, /**< X86 AMX */ LLVMTokenTypeKind, /**< Tokens */ cuviper wrote: > This is a breaking change to the C ABI -- can w

[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

This revision was automatically updated to reflect the committed changes. Closed by commit rG29472bb76915: [clangd] Log warning when using legacy (theia) semantic highlighting. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95

[clang-tools-extra] 29472bb - [clangd] Log warning when using legacy (theia) semantic highlighting.

Author: Sam McCall Date: 2021-01-28T01:29:28+01:00 New Revision: 29472bb76915c4929aecc938300f6df31f63ac29 URL: https://github.com/llvm/llvm-project/commit/29472bb76915c4929aecc938300f6df31f63ac29 DIFF: https://github.com/llvm/llvm-project/commit/29472bb76915c4929aecc938300f6df31f63ac29.diff LO

[PATCH] D95166: Disable rosegment for old Android versions.

glandium added a comment. "Android only supports lld" might be true now, but it hasn't always been true, which means the change is not backwards compatible with versions of the NDK that don't use lld. Also, `-fuse-ld` is still a valid flag that can allow to use a different linker than lld. Re

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall created this revision. sammccall added reviewers: nridge, kadircet. Herald added subscribers: usaxena95, jfb, arphaman, mgrang, javed.absar. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is

[clang] 727fc31 - [cxx_status] Mark P0732R2 as only 'partial', not 'Clang 12', as some of

Author: Richard Smith Date: 2021-01-27T16:08:51-08:00 New Revision: 727fc31a9898dfb89610ca1bc05ff86204a77177 URL: https://github.com/llvm/llvm-project/commit/727fc31a9898dfb89610ca1bc05ff86204a77177 DIFF: https://github.com/llvm/llvm-project/commit/727fc31a9898dfb89610ca1bc05ff86204a77177.diff

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D94844#2524854 , @nathawes wrote: > @JDevlieghere and @dexonsmith would you mind taking another look? > > I ended up changing the 'lookup

[clang] 727fc31 - [cxx_status] Mark P0732R2 as only 'partial', not 'Clang 12', as some of

Author: Richard Smith Date: 2021-01-27T16:08:51-08:00 New Revision: 727fc31a9898dfb89610ca1bc05ff86204a77177 URL: https://github.com/llvm/llvm-project/commit/727fc31a9898dfb89610ca1bc05ff86204a77177 DIFF: https://github.com/llvm/llvm-project/commit/727fc31a9898dfb89610ca1bc05ff86204a77177.diff

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 319693. ilinpv added a comment. Clang driver tests for outline atomics were added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/To

[PATCH] D95575: clang-cl: Accept /std:c11, /std:c17 flags

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, kristof.beyls. Herald added a reviewer: jansvoboda11. thakis requested review of this revision. clang-cl already defaults to C17 for .c files, but no harm in accepting these flags. Fixes PR48185. https:/

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

dexonsmith added a comment. In D95561#2526417 , @varungandhi-apple wrote: > I don't get how you stack your change on top of someone else's change (the > diff seems to have been created with only one commit), but this depends on > https://reviews.llvm.or

[PATCH] D95562: [ASTMatchers] Fix traversal below range-for elements

steveire updated this revision to Diff 319705. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95562/new/ https://reviews.llvm.org/D95562 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/ASTMatcher

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95573 Files: clang/include/clang/AST/Recu

[PATCH] D95571: [clangd] Remove some obsolete options that are now always on

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - always collect mai

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2967 + // needs to be indented. + bool ClosesBlock = + Line->MatchingOpeningBlockLineIndex != UnwrappedLine::kInvalidIndex && curdeius wrote: > Please move below to the plac

[clang] 764a7a2 - clang: Fix static_assert in a few contexts in microsoft mode

Author: Nico Weber Date: 2021-01-27T18:15:25-05:00 New Revision: 764a7a2155c6747ec8d0b38d8edbb65960eae874 URL: https://github.com/llvm/llvm-project/commit/764a7a2155c6747ec8d0b38d8edbb65960eae874 DIFF: https://github.com/llvm/llvm-project/commit/764a7a2155c6747ec8d0b38d8edbb65960eae874.diff LO

[clang] 764a7a2 - clang: Fix static_assert in a few contexts in microsoft mode

Author: Nico Weber Date: 2021-01-27T18:15:25-05:00 New Revision: 764a7a2155c6747ec8d0b38d8edbb65960eae874 URL: https://github.com/llvm/llvm-project/commit/764a7a2155c6747ec8d0b38d8edbb65960eae874 DIFF: https://github.com/llvm/llvm-project/commit/764a7a2155c6747ec8d0b38d8edbb65960eae874.diff LO

[PATCH] D95559: clang: Fix static_assert in a few contexts in microsoft mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG764a7a2155c6: clang: Fix static_assert in a few contexts in microsoft mode (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95559?vs=319661&id=3196

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

rnk added a subscriber: erik.pilkington. rnk added a comment. @erik.pilkington , you added this assert in http://github.com/llvm/llvm-project/commit/3cdc317342d8c2b36de2839ea6ebefec17cb271e, are you OK with this? I'm OK with the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95499: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX

rnk accepted this revision. rnk added a subscriber: akhuang. rnk added a comment. This revision is now accepted and ready to land. lgtm I believe @akhuang's recent change to this file made it so debug info names are unqualified in all modes. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. This needs a unit test, I personally don't understand what this is doing or why its needed, if its a bug can you reference a bug in bugzilla that explains the bug a l

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 __

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2525131 , @dmajor wrote: > Firefox has a build break from this change. In certain Android configurations > we use bfd or gold. The statement in the commit message "Android only > supports LLD" is news to me, could you

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

alexfh added a comment. In D93688#2525947 , @alexfh wrote: > This patch causes practically infinite traversal times on code that contains > deeply nested lambdas. I'll try to get a suitable repro, but could you maybe > revert this in the meantime? Actua

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

MaskRay added a comment. Please also comment (and update the description) that self-link may be used. This is subtle. The reason is that the ELF section names (e.g. `__llvm_prf_cnts`) are C identifiers and considered GC roots in the absence of the `SHF_LINK_ORDER` flag. Repository: rG LLVM

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

MaskRay added a comment. Looks quite good. In D76802#2526382 , @phosek wrote: > @MaskRay does this look good to you? Looks like GNU ld has an infinite loop problem w.r.t self-link SHF_LINK_ORDER: https://sourceware.org/bugzilla/show_bug.cgi?id=27259 >

[PATCH] D95559: clang: Fix static_assert in a few contexts in microsoft mode

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, and I think we should also backport this to Clang 12. Comment at: clang/lib/Parse/ParseDecl.cpp:4219 // Parse _Static_assert declaration. -if (Tok.is(tok

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

kromanenkov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:199 - for (const auto &I : llvm::reverse(PathRange)) -PathList = prependCXXBase(I, PathList); + llvm::SmallPtrSet BaseTypes; + for (const auto &BaseSpec : PathList) ---

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

kromanenkov added a comment. Looks like you run formatter on the whole file, maybe narrow down its scope a little? For example, only for the touched function? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95307/new/ https://reviews.llvm.org/D95307

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. In D91913#2526403 , @rnk wrote: > Anyway, I apologize for the misunderstanding. I'm doing my best to operate in > good faith with LLVM project policies. Hopefully you feel that you have a > path forward here. Thank you, I appreci

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rsmith added a comment. In D91913#2526317 , @hvdijk wrote: > In D91913#2526117 , @rsmith wrote: > >> I think @rnk's observation that `__VA_OPT__` isn't actually available in any >> compilation mode other than C++20

[PATCH] D95562: [ASTMatchers] Fix traversal below range-for elements

steveire updated this revision to Diff 319674. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95562/new/ https://reviews.llvm.org/D95562 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/ASTMatcher

[PATCH] D95562: [ASTMatchers] Fix traversal below range-for elements

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95562 Files: clang/lib/ASTMatchers/ASTMat

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire updated this revision to Diff 319672. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94865/new/ https://reviews.llvm.org/D94865 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319671. tbaeder added a comment. Forgot clang-format of course, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprMember.cpp clang/test/CX

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added a comment. I don't get how you stack your change on top of someone else's change (the diff seems to have been created with only one commit), but this depends on https://reviews.llvm.org/D95228, which depends on https://reviews.llvm.org/D95044. Repository: rG LLVM Git

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. @rjmccall I have addressed the comments about diagnostics. Could you please review it? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4398 + let Content = [{ +TODO + }]; I have left this as a TODO for now, so that it can be filled in later when the exact details of the convention are implemented in

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rnk added a comment. In D91913#2526317 , @hvdijk wrote: > My concern isn't with the revert itself, it's without waiting for approval. > That's a crystal clear LLVM developer policy violation: changes need to be > approved, or obvious, or by developers re

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple created this revision. varungandhi-apple added reviewers: rjmccall, ahatanak. Herald added subscribers: dexonsmith, arphaman, kbarton, hiraditya, jgravelle-google, sbc100, nemanjai, dschuff. Herald added a reviewer: aaron.ballman. varungandhi-apple published this revision for rev

[PATCH] D95487: Itanium Mangling: Fix handling of in .

rjmccall added a comment. I agree, that seems like the right decision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95487/new/ https://reviews.llvm.org/D95487 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. @MaskRay does this look good to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319668. akhuang added a comment. make function return lambda string, and add test for lambda in function parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Fil

[clang] a7246ba - Itanium Mangling: In 'enable_if', omit X/E around .

Author: James Y Knight Date: 2021-01-27T16:46:52-05:00 New Revision: a7246ba02a8923f316419a62d836dbe1c0b437bd URL: https://github.com/llvm/llvm-project/commit/a7246ba02a8923f316419a62d836dbe1c0b437bd DIFF: https://github.com/llvm/llvm-project/commit/a7246ba02a8923f316419a62d836dbe1c0b437bd.diff

[clang] 8ca3360 - Itanium Mangling: Fix handling of in .

Author: James Y Knight Date: 2021-01-27T16:46:52-05:00 New Revision: 8ca33605ff0cfc536f5c6710fb5f6378bf11959a URL: https://github.com/llvm/llvm-project/commit/8ca33605ff0cfc536f5c6710fb5f6378bf11959a DIFF: https://github.com/llvm/llvm-project/commit/8ca33605ff0cfc536f5c6710fb5f6378bf11959a.diff

[clang] 9c7aeae - Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

Author: James Y Knight Date: 2021-01-27T16:46:51-05:00 New Revision: 9c7aeaebb3ac1b94200b59b111742cb6b8f090c2 URL: https://github.com/llvm/llvm-project/commit/9c7aeaebb3ac1b94200b59b111742cb6b8f090c2 DIFF: https://github.com/llvm/llvm-project/commit/9c7aeaebb3ac1b94200b59b111742cb6b8f090c2.diff

[PATCH] D95560: [CUDA][HIP] Fix function scope static variable

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently static variables are allowed in device, global, and host device functions. A static variable in device and global functions is supposed to have implicit device attribute. Currently it d

[PATCH] D95559: clang: Fix static_assert in a few contexts in microsoft mode

thakis created this revision. thakis added reviewers: hans, rnk. thakis requested review of this revision. Follow-up to D17444 . Fixes PR48904. See bug for details. https://reviews.llvm.org/D95559 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Sema/static-

[PATCH] D95488: Itanium Mangling: In 'enable_if', omit X/E around .

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7246ba02a89: Itanium Mangling: In 'enable_if', omit X/E around . (authored by jyknight). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D95487: Itanium Mangling: Fix handling of in .

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ca33605ff0c: Itanium Mangling: Fix handling of in . (authored by jyknight). Changed prior to commit: https://reviews

[PATCH] D93922: Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c7aeaebb3ac: Itanium Mangling: Mangle `__alignof__` differently than `alignof`. (authored by jyknight). Repository: rG LLVM Github Monorepo CHAN

[clang] a7246ba - Itanium Mangling: In 'enable_if', omit X/E around .

Author: James Y Knight Date: 2021-01-27T16:46:52-05:00 New Revision: a7246ba02a8923f316419a62d836dbe1c0b437bd URL: https://github.com/llvm/llvm-project/commit/a7246ba02a8923f316419a62d836dbe1c0b437bd DIFF: https://github.com/llvm/llvm-project/commit/a7246ba02a8923f316419a62d836dbe1c0b437bd.diff

[clang] 8ca3360 - Itanium Mangling: Fix handling of in .

Author: James Y Knight Date: 2021-01-27T16:46:52-05:00 New Revision: 8ca33605ff0cfc536f5c6710fb5f6378bf11959a URL: https://github.com/llvm/llvm-project/commit/8ca33605ff0cfc536f5c6710fb5f6378bf11959a DIFF: https://github.com/llvm/llvm-project/commit/8ca33605ff0cfc536f5c6710fb5f6378bf11959a.diff

[clang] 9c7aeae - Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

Author: James Y Knight Date: 2021-01-27T16:46:51-05:00 New Revision: 9c7aeaebb3ac1b94200b59b111742cb6b8f090c2 URL: https://github.com/llvm/llvm-project/commit/9c7aeaebb3ac1b94200b59b111742cb6b8f090c2 DIFF: https://github.com/llvm/llvm-project/commit/9c7aeaebb3ac1b94200b59b111742cb6b8f090c2.diff

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rnk added a comment. OK, thanks for the direction. We'll try to port code to use the device you listed. I see you think we need a new warning for this, a clang 12 release note, and then this can reland. @hvdijk , that plan looks good to me, and I'll let you and Richard sort it out. I don't pla

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. In D91913#2526117 , @rsmith wrote: > I think @rnk's observation that `__VA_OPT__` isn't actually available in any > compilation mode other than C++20 (which I hadn't previously realized) is > important here: we'd left longstanding

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire updated this revision to Diff 319660. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94865/new/ https://reviews.llvm.org/D94865 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D95487: Itanium Mangling: Fix handling of in .

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5145 + ASTContext &Ctx = Context.getASTContext(); + if (Ctx.getLangOpts().getClangABICompat() > LangOptions::ClangABI::Ver11) { +mangleExpression(E, UnknownArity, /*AsTemplateArg=*/true); --

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Extract registering device variable to CUDA runtime codegen function since it will be called in multiple places. https://reviews.llvm.org/D95558 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[clang] 5dfa37a - Don't allow __VA_OPT__ to be detected by #ifdef.

Author: Richard Smith Date: 2021-01-27T13:34:15-08:00 New Revision: 5dfa37a76153f2a18ac7fe30721cc1332b672ea2 URL: https://github.com/llvm/llvm-project/commit/5dfa37a76153f2a18ac7fe30721cc1332b672ea2 DIFF: https://github.com/llvm/llvm-project/commit/5dfa37a76153f2a18ac7fe30721cc1332b672ea2.diff

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rsmith added a comment. In D91913#2526255 , @rnk wrote: > In D91913#2525993 , @hvdijk wrote: > >> @rnk Taking it upon yourself to revert this without approval and without >> communication on all branches, especiall

[clang] 5dfa37a - Don't allow __VA_OPT__ to be detected by #ifdef.

Author: Richard Smith Date: 2021-01-27T13:34:15-08:00 New Revision: 5dfa37a76153f2a18ac7fe30721cc1332b672ea2 URL: https://github.com/llvm/llvm-project/commit/5dfa37a76153f2a18ac7fe30721cc1332b672ea2 DIFF: https://github.com/llvm/llvm-project/commit/5dfa37a76153f2a18ac7fe30721cc1332b672ea2.diff

[clang] 44f7929 - [Demangle] Support demangling Swift calling convention in MS demangler.

Author: Varun Gandhi Date: 2021-01-27T13:24:54-08:00 New Revision: 44f792966e0f2935ea9e0ce96a4f35e01bfe6b61 URL: https://github.com/llvm/llvm-project/commit/44f792966e0f2935ea9e0ce96a4f35e01bfe6b61 DIFF: https://github.com/llvm/llvm-project/commit/44f792966e0f2935ea9e0ce96a4f35e01bfe6b61.diff

[PATCH] D95053: [Demangle] Support demangling Swift calling convention in MS demangler.

This revision was automatically updated to reflect the committed changes. Closed by commit rG44f792966e0f: [Demangle] Support demangling Swift calling convention in MS demangler. (authored by varungandhi-apple). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 44f7929 - [Demangle] Support demangling Swift calling convention in MS demangler.

Author: Varun Gandhi Date: 2021-01-27T13:24:54-08:00 New Revision: 44f792966e0f2935ea9e0ce96a4f35e01bfe6b61 URL: https://github.com/llvm/llvm-project/commit/44f792966e0f2935ea9e0ce96a4f35e01bfe6b61 DIFF: https://github.com/llvm/llvm-project/commit/44f792966e0f2935ea9e0ce96a4f35e01bfe6b61.diff

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

cuviper added inline comments. Comment at: llvm/include/llvm-c/Core.h:163 LLVMX86_MMXTypeKind, /**< X86 MMX */ + LLVMX86_AMXTypeKind, /**< X86 AMX */ LLVMTokenTypeKind, /**< Tokens */ This is a breaking change to the C ABI -- can we move it to the

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rnk added a comment. In D91913#2525993 , @hvdijk wrote: > @rnk Taking it upon yourself to revert this without approval and without > communication on all branches, especially given the earlier suggestion by > @rsmith to only revert this on the LLVM 12 br

[PATCH] D95487: Itanium Mangling: Fix handling of in .

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:549 void mangleInitListElements(const InitListExpr *InitList); - void mangleDeclRefExpr(const NamedDecl *D); - void mangleExpression(const Expr *E, unsigned Arity = Unkno

[clang] 5d3dca2 - Ignore unknown attribute warnings in this test

Author: Aaron Ballman Date: 2021-01-27T15:45:35-05:00 New Revision: 5d3dca24aab847f0fdfd558987c1c28469e2f31e URL: https://github.com/llvm/llvm-project/commit/5d3dca24aab847f0fdfd558987c1c28469e2f31e DIFF: https://github.com/llvm/llvm-project/commit/5d3dca24aab847f0fdfd558987c1c28469e2f31e.diff

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

dexonsmith added a comment. I haven't looked at the code in detail (deferring to @JDevlieghere), but the new tests look great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94844/new/ https://reviews.llvm.org/D94844 ___ cfe-commits m

[PATCH] D95487: Itanium Mangling: Fix handling of in .

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. I can accept this, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95487/new/ https://reviews.llvm.org/D95487 __

  1   2   3   >