This revision was automatically updated to reflect the committed changes.
Closed by commit rG29472bb76915: [clangd] Log warning when using legacy (theia)
semantic highlighting. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95031/new/
https://reviews.llvm.org/D95031
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
Index: clang-tools-extra/clangd/ClangdLSPServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -510,6 +510,11 @@
"semanticTokens request, choosing the latter (no notifications).");
Opts.TheiaSemanticHighlighting = false;
}
+ if (Opts.TheiaSemanticHighlighting) {
+ log("Using legacy semanticHighlights notification, which will be removed "
+ "in clangd 13. Clients should use the standard semanticTokens "
+ "request instead.");
+ }
if (Params.rootUri && *Params.rootUri)
Opts.WorkspaceRoot = std::string(Params.rootUri->file());
Index: clang-tools-extra/clangd/ClangdLSPServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -510,6 +510,11 @@
"semanticTokens request, choosing the latter (no notifications).");
Opts.TheiaSemanticHighlighting = false;
}
+ if (Opts.TheiaSemanticHighlighting) {
+ log("Using legacy semanticHighlights notification, which will be removed "
+ "in clangd 13. Clients should use the standard semanticTokens "
+ "request instead.");
+ }
if (Params.rootUri && *Params.rootUri)
Opts.WorkspaceRoot = std::string(Params.rootUri->file());
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
