hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
I assume you'll handle the internal integration part ;) ================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:453 -// FIXME: retire this flag in llvm 13 release cycle. -opt<bool> AsyncPreamble{ - "async-preamble", - cat(Misc), - desc("Reuse even stale preambles, and rebuild them in the background. This " - "improves latency at the cost of accuracy."), - init(ClangdServer::Options().AsyncPreambleBuilds), - Hidden, -}; +RetiredFlag<bool> AsyncPreamble("async-preamble"); ---------------- nit: maybe we can group these RetiredFlag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95571/new/ https://reviews.llvm.org/D95571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits