[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/n

[clang] 89b0972 - [Sema] Fix deleted function problem in implicitly movable test

Author: Yang Fan Date: 2021-01-01T15:47:49+08:00 New Revision: 89b0972aa2f58f927633c63570b36550a17f4e63 URL: https://github.com/llvm/llvm-project/commit/89b0972aa2f58f927633c63570b36550a17f4e63 DIFF: https://github.com/llvm/llvm-project/commit/89b0972aa2f58f927633c63570b36550a17f4e63.diff LOG:

[PATCH] D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon

nullptr.cpp created this revision. Herald added a subscriber: xazax.hun. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93961 Files: clang-tools-extra/clang-ti

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 314208. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp cla

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie accepted this revision. dblaikie added a comment. Looks good - test cases might benefit from some descriptive comments (explaining why the pseudo probe pass needs to be enabled to test the unique linkage name pass - I guess to check that it appears in just the right place in the pass p

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added subscribers: AndrewLitteken, bbn, JDevlieghere, jdoerfert, aprantl. dblaikie added a comment. In D93747#2470504 , @hoy wrote: > In D93747#2470387 , @dblaikie wrote: > >> Please remove the clang test

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. Additionally, this bug has already been reported: https://bugs.llvm.org/show_bug.cgi?id=46927 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 ___

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. @MyDeveloperDay I expect to see exactly that. `clang-format` currently does not respect `AfterEnum`, treating it as always `true`. This is why I changed `UnwrappedLineParser.cpp`. The unit test is incorrect as the style used for the `clang-format` C(++) unit tests uses

[clang] d1fd723 - Refactor how -fno-semantic-interposition sets dso_local on default visibility external linkage definitions

Author: Fangrui Song Date: 2020-12-31T13:59:45-08:00 New Revision: d1fd72343c6ff58a3b66bc0df56fed9ac21e4056 URL: https://github.com/llvm/llvm-project/commit/d1fd72343c6ff58a3b66bc0df56fed9ac21e4056 DIFF: https://github.com/llvm/llvm-project/commit/d1fd72343c6ff58a3b66bc0df56fed9ac21e4056.diff

[clang] 219d00e - [test] Make ELF tests immune to dso_local/dso_preemptable/(none) differences

Author: Fangrui Song Date: 2020-12-31T13:59:44-08:00 New Revision: 219d00e0d90941d3e54fc711ea1e7b5e4b5b4335 URL: https://github.com/llvm/llvm-project/commit/219d00e0d90941d3e54fc711ea1e7b5e4b5b4335 DIFF: https://github.com/llvm/llvm-project/commit/219d00e0d90941d3e54fc711ea1e7b5e4b5b4335.diff

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

MaskRay added a comment. In D80421#2081794 , @joewholden wrote: > This is actually wrong anyway If it is wrong, it should be abandoned. If it is correct, can you add some tests under clang/test/Driver and test with `ninja check-clang-driver`? Repositor

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg marked 2 inline comments as done. thezbyg added a comment. After some updating, rebuilding and searching for differences in Objective-C++ formatting, I managed to find where the problem with these failing tests is. In **_verifyFormat** function C++ code formatting is tested for stability

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 314200. hoy marked an inline comment as done. hoy added a comment. Adding a test for the new pseudo probe test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llv

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy marked an inline comment as done. hoy added inline comments. Comment at: llvm/tools/opt/NewPMDriver.cpp:136-138 +static cl::opt PseudoProbeForProfiling( +"new-pm-pseudo-probe-for-profiling", cl::init(false), cl::Hidden, +cl::desc("Emit pseudo probes to enable PGO prof

[PATCH] D93952: [Clang][Misc] Fix fragile test

MaskRay added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:1 -// RUN: %clang -O1 -fno-unroll-loops -S -o - %s -emit-llvm | FileCheck %s +// This relies on %clang_cc1, %clang does not emit the block names in Release mode. +// RUN: %clang_cc1 -O1 -fno-unroll-loops

[PATCH] D93952: [Clang][Misc] Fix fragile test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a65b8c739a0: [Clang][Misc] Change run line in fragile test (authored by adpatel6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1a65b8c - [Clang][Misc] Change run line in fragile test

Author: Atmn Date: 2020-12-31T13:48:21-05:00 New Revision: 1a65b8c739a09c587fb55ef4d2d7def13718111c URL: https://github.com/llvm/llvm-project/commit/1a65b8c739a09c587fb55ef4d2d7def13718111c DIFF: https://github.com/llvm/llvm-project/commit/1a65b8c739a09c587fb55ef4d2d7def13718111c.diff LOG: [Cl

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel updated this revision to Diff 314195. atmnpatel added a comment. Better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952 Files: clang/test/Misc/loop-opt-setup.c Index: clang/test/Misc/loop-opt

[PATCH] D93952: [Clang][Misc] Fix fragile test

MaskRay added a comment. In D93952#2475762 , @atmnpatel wrote: > Ah I see, I was never able to find clear documentation on what exactly the > -cc1 flag does other than the conceptual description. This should fix it > right? -cc1 options are implementati

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. In D86844#2475552 , @xbolva00 wrote: > Do you plan to implement gcc’s option in Clang as followup? I was not planning on it but I can if no one is planning on it and doesn't mind waiting a bit. Also, clang/test/Misc/loop-opt-s

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel updated this revision to Diff 314193. atmnpatel added a comment. Ah I see, I was never able to find clear documentation on what exactly the -cc1 flag does other than the conceptual description. This should fix it right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh added a comment. Looks good to me, just some grammar nitpicks from my side. (I only discovered the "Suggest Edit" feature halfway through the review; I didn't update the comments I already made as I'm not sure in which format you prefer them?) Comment at: clang/docs/O

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Thanks for the update. Looks good overall. A minor question about backticks. I'm no native English speaker, so I would recommend a second review from someone else too. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+===

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri added inline comments. Comment at: clang/test/Sema/implicit-widening-of-pointer-offset-in-array-subscript-expression.c:24 +void t1(char *base, int a, int b) { + // FIXME: test `[a * b]base` pattern? +} dblaikie wrote: > lebedev.ri wrote: > > dblaikie

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 314188. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. - Add test for inverse array subscript expression - Support it by skipping paren expressions - Actually ensure that we only diagnose only truly implicit casts, but not implici

[PATCH] D93958: [OpenCL] Restrict pointer to member functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. lgtm, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93958/new/ https://reviews.llvm.org/D93958 ___ cfe-commits mailing list

[PATCH] D93958: [OpenCL] Restrict pointer to member functions

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. OpenCL doesn't allow function pointers and therefore pointers to member functions are to be restricted too. Even if this C++ feature pr

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544 +TEST_F(FormatTest, FormatsAccessModifiers) { + EXPECT_EQ("struct foo {\n" +" int i;\n" any reason this can't be verifyFormat? Comment at

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added a comment. ok so this looks ok, but before we commit can we have a discussion about why you think it fails for the comment case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 __

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. Take the following example: enum { A, B, C, D, E, F, G, H, I } Short; And the following minimal .clang-format --- ColumnLimit: 10 BreakBeforeBraces: Custom BraceWrapping: AfterEnum: true To use AfterEnum you must be using "Custom" for BreakBef

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. I think if you think you have a bug that you log it in the bug tracker and we track it with this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 _

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314052. Bdragon28 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add missing OpenMP TLS test for powerpcle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a reviewer: q66. Bdragon28 added a comment. Add q66 to reviewers list for the targeting bits relevant to Void ppcle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 _

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313931. Bdragon28 added a comment. - Fix LLVM object handling unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp clang/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313930. Bdragon28 added a comment. Herald added a subscriber: mgorny. - Fix bug in clang/test/Driver/linux-header-search.cpp -- The powerpc64le test was being done with -m32 accidentally. - Update llvm/unittests/ADT/TripleTest.cpp for powerpcle. - Update gc

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:2864-2868 +Adds builtin function declarations during compilations. By default +the OpenCL headers are not loaded and therefore the builtin functions + are not decla

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314184. Anastasia added a comment. Addressed comments from Marco. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/Users

[PATCH] D93952: [Clang][Misc] Fix fragile test

fhahn added a comment. In D93952#2475526 , @atmnpatel wrote: > I can't say that I know with any certainty, I'm too inexperienced. This > failure was missed by me locally, the pre-merge bot, and by most of the > buildbots other than the ones I mentioned a

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh added a comment. In D91348#2475646 , @Anastasia wrote: > LGTM, the change seems reasonable. Thanks! > >> A minor side-effect of this change is that it also produces the >> warning for co_await and co_yield now. > > This warning is produced for **siz

[PATCH] D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bee4d4e8f54: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free… (authored by bgraur, committed by SureYeaah). Repositor

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Herald added a subscriber: lxfind. LGTM, the change seems reasonable. Thanks! > A minor side-effect of this change is that it also produces the > warning for co_await and co_yield now. T

[clang] 8bee4d4 - Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"

Author: Bogdan Graur Date: 2020-12-31T11:47:49Z New Revision: 8bee4d4e8f54b5f28b9117b552d3b2c655ff129b URL: https://github.com/llvm/llvm-project/commit/8bee4d4e8f54b5f28b9117b552d3b2c655ff129b DIFF: https://github.com/llvm/llvm-project/commit/8bee4d4e8f54b5f28b9117b552d3b2c655ff129b.diff LOG:

[PATCH] D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"

bgraur created this revision. bgraur added a reviewer: SureYeaah. Herald added a subscriber: hiraditya. bgraur requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test clang/test/Misc:loop-opt-setup.c fails when executed in Re

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

nullptr.cpp updated this revision to Diff 314177. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93955/new/ https://reviews.llvm.org/D93955 Files: clang/include/

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During the initialization process, more than one error may be encountered, but Clang reports only one of them. This patch makes Clang report all

[PATCH] D93817: Update transformations to use poison for insertelement/shufflevector's placeholder value

aqjune added a comment. Running Alive2 finds one failure, which is fixed by updating the shufflevector semantics to return poison on undef/poison mask (D93818 ): Transforms/InstCombine/shufflevector-div-rem-inseltpoison.ll

[PATCH] D93817: Update transformations to use poison for insertelement/shufflevector's placeholder value

aqjune updated this revision to Diff 314175. aqjune added a comment. Find a few missing places & update them to use poison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93817/new/ https://reviews.llvm.org/D93817 Files: clang/test/CodeGen/SystemZ

[clang] f2cc266 - [test] Fix -triple and delete UNSUPPORTED: system-windows

Author: Fangrui Song Date: 2020-12-31T00:13:34-08:00 New Revision: f2cc2669a0d91994c93f2e9708e137484081a7c1 URL: https://github.com/llvm/llvm-project/commit/f2cc2669a0d91994c93f2e9708e137484081a7c1 DIFF: https://github.com/llvm/llvm-project/commit/f2cc2669a0d91994c93f2e9708e137484081a7c1.diff