[PATCH] D92299: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides.

2020-12-13 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63ec9e40d100: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides. (authored by hokein). Repository: rG LLVM Github Mono

[clang-tools-extra] 63ec9e4 - [clangd] Go-to-definition on pure virtual method decls jumps to all overrides.

2020-12-13 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-12-14T08:56:24+01:00 New Revision: 63ec9e40d10056b0f85605d585e7db0b4146851e URL: https://github.com/llvm/llvm-project/commit/63ec9e40d10056b0f85605d585e7db0b4146851e DIFF: https://github.com/llvm/llvm-project/commit/63ec9e40d10056b0f85605d585e7db0b4146851e.diff LO

[PATCH] D92299: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides.

2020-12-13 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 311501. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92299/new/ https://reviews.llvm.org/D92299 Files: clang-tools-extra/clan

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

2020-12-13 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6326b098852b: [AST][RecoveryExpr] Preserve type for broken overrload member call expr. (authored by hokein). Repository: rG LLVM Github Monorepo

[clang] 6326b09 - [AST][RecoveryExpr] Preserve type for broken overrload member call expr.

2020-12-13 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-12-14T08:50:41+01:00 New Revision: 6326b098852bea51debe415a85eebd1753151cd0 URL: https://github.com/llvm/llvm-project/commit/6326b098852bea51debe415a85eebd1753151cd0 DIFF: https://github.com/llvm/llvm-project/commit/6326b098852bea51debe415a85eebd1753151cd0.diff LO

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

2020-12-13 Thread sameeran joshi via Phabricator via cfe-commits
sameeranjoshi accepted this revision. sameeranjoshi added a comment. This revision is now accepted and ready to land. Looks good from my end. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 _

[clang] 05cdf4a - Consider reference, pointer, and pointer-to-member TemplateArguments to be different if they have different types.

2020-12-13 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-12-13T22:43:24-08:00 New Revision: 05cdf4acf42acce9ddcff646a5d6ac666710fe6d URL: https://github.com/llvm/llvm-project/commit/05cdf4acf42acce9ddcff646a5d6ac666710fe6d DIFF: https://github.com/llvm/llvm-project/commit/05cdf4acf42acce9ddcff646a5d6ac666710fe6d.diff

[clang] abbd57e - Factor out and centralize repeated 'getExpandedPackSize'.

2020-12-13 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-12-13T22:43:23-08:00 New Revision: abbd57e558b907a7be8adc5a5b9699dd7c23b1af URL: https://github.com/llvm/llvm-project/commit/abbd57e558b907a7be8adc5a5b9699dd7c23b1af DIFF: https://github.com/llvm/llvm-project/commit/abbd57e558b907a7be8adc5a5b9699dd7c23b1af.diff

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

2020-12-13 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D91245#2437741 , @Quuxplusone wrote: > Peanut gallery says: It seems to me that your root problem here is that > `co_yield` is not being recognized by the parser as a keyword, and so you're > seeing e.g. `co_yield* p;` the s

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

2020-12-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Maybe Clang's `-Wformat` should be extended to cover Linux kernel-specific format options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93182/new/ https://reviews.llvm.org/D93182 __

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

2020-12-13 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 311485. ChuanqiXu added a comment. Re-upload patch with context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91245/new/ https://reviews.llvm.org/D91245 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

2020-12-13 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D91245#2437518 , @MyDeveloperDay wrote: > What does `the behavior goes wrong` mean? why can't it be left aligned? Because when we use PointerAlignment attribute, I think we mean that the pointer need to be aligned in declar

Re: Buildbot to listen main branch

2020-12-13 Thread Galina Kistanova via cfe-commits
Hello everyone, The buildbot listens to the "main" branch now. Please let me know if you will see issues. Thanks Galina On Tue, Dec 8, 2020 at 9:57 PM Galina Kistanova wrote: > Hello everyone, > > To follow the main branch creation I'm going to update the buildbot to > listen for the change

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

2020-12-13 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 311476. nridge added a comment. Add a missed call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-e

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

2020-12-13 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. This check needs documentation adding in `clang-tools-extra/docs/clang-tidy/checks/linux-kernel-logfunctions-h.rst` Also needs to add this in `clang-tools-extra/docs/clang-tidy/checks/list.rst`, keeping it in alphabetical order. Also need to add an entry to `clang-tools

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

2020-12-13 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added reviewers: sammccall, hokein, kadircet. nridge added a comment. Shopping the patch around to some possible reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 ___

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

2020-12-13 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfef242c32e83: [clangd] Fix locateMacroAt() for macro definition outside preamble (authored by nridge). Repository: rG LLVM Github Monorepo CHANGE

[clang-tools-extra] fef242c - [clangd] Fix locateMacroAt() for macro definition outside preamble

2020-12-13 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-12-13T18:33:33-05:00 New Revision: fef242c32e833b84e8b46bd56a28c01c5f9aa65d URL: https://github.com/llvm/llvm-project/commit/fef242c32e833b84e8b46bd56a28c01c5f9aa65d DIFF: https://github.com/llvm/llvm-project/commit/fef242c32e833b84e8b46bd56a28c01c5f9aa65d.diff

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

2020-12-13 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 311472. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91025/new/ https://reviews.llvm.org/D91025 Files: clang-tools-ext

[clang] 5ad202c - [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

2020-12-13 Thread via cfe-commits
Author: Tony Date: 2020-12-13T23:02:59Z New Revision: 5ad202ce8963157242785a8345024a80c721ece2 URL: https://github.com/llvm/llvm-project/commit/5ad202ce8963157242785a8345024a80c721ece2 DIFF: https://github.com/llvm/llvm-project/commit/5ad202ce8963157242785a8345024a80c721ece2.diff LOG: [NFC][AM

[PATCH] D93181: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

2020-12-13 Thread Tony Tye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

2020-12-13 Thread Nicolás Alvarez via Phabricator via cfe-commits
nicolas17 created this revision. nicolas17 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code example for "RecursiveASTVisitor based ASTFrontendActions" was using unique_ptr(new X) when creating the AST consumer; change it to use make

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

2020-12-13 Thread Tom Rix via Phabricator via cfe-commits
trixirt created this revision. trixirt added reviewers: nickdesaulniers, alexfh, hokein, aaron.ballman, njames93. trixirt added a project: clang-tools-extra. Herald added subscribers: Charusso, xazax.hun, mgorny. trixirt requested review of this revision. Herald added a project: clang. Herald adde

[PATCH] D78938: Make LLVM build in C++20 mode

2020-12-13 Thread Nuno Lopes via Phabricator via cfe-commits
nlopes added a comment. Thanks @lebedev.ri for the pointer! I started working on exactly the same thing as I was trying to link a C++20 project with LLVM. @BRevzin is there anything missing in this patch? Do you have commit access or do you need help to land this? Repository: rG LLVM Github

[PATCH] D93181: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

2020-12-13 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93181/new/ https://reviews.llvm.org/D93181 _

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

2020-12-13 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre added a comment. In D92409#2450690 , @rsmith wrote: > In D92409#2450550 , @thopre wrote: > >> In D92409#2426196 , @thopre wrote: >> >>> Is there a way to disable it fr

[PATCH] D93181: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

2020-12-13 Thread Tony Tye via Phabricator via cfe-commits
t-tye created this revision. t-tye added reviewers: kzhuravl, ronlieb. Herald added subscribers: dexonsmith, tpr, dstuttard, yaxunl. t-tye requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://r

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2020-12-13 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Whatever the final decision is, maybe add a doxygen comment explaining the semantics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 _

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2020-12-13 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei, spatel. RKSimon requested review of this revision. Herald added a project: clang. As suggested by @pengfei on D92940 My concern with this is that by default llvm.vector.reduce.fmax/min

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2020-12-13 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4855a1004d4d: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction… (authored by RKSimon). Repository: rG LLVM Github Monorepo

[clang] 4855a10 - [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2020-12-13 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-12-13T15:37:35Z New Revision: 4855a1004d4d87b6c21c510c1724e74a8d37d91a URL: https://github.com/llvm/llvm-project/commit/4855a1004d4d87b6c21c510c1724e74a8d37d91a DIFF: https://github.com/llvm/llvm-project/commit/4855a1004d4d87b6c21c510c1724e74a8d37d91a.diff LOG:

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2020-12-13 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9559 static __inline__ double __DEFAULT_FN_ATTRS512 _mm512_reduce_max_pd(__m512d __V) { _mm512_mask_reduce_operator(max_pd); pengfei wrote: > Better to change min and max as well. O

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2020-12-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:26 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple r600-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES -target-cpu turks +// XFAIL: * azabaznov wrote

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

2020-12-13 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D92257#2438928 , @MyDeveloperDay wrote: > Could we consider dropping the maximum? While rewriting the tests with the unmodified clang-format I just confirmed that currently only the minimum of 1 is enforced, there

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

2020-12-13 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:22 -/// OpenCL supported extensions and optional core features -class OpenCLOptions { - struct Info { -bool Supported; // Is this option supported -bool Enabled; // Is this option

[PATCH] D91996: [clang-format] Remove double trim

2020-12-13 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG36306403d492: [clang-format] Remove double trim (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91996/new/ https://reviews.l

[clang] 3630640 - [clang-format] Remove double trim

2020-12-13 Thread Björn Schäpers via cfe-commits
Author: Björn Schäpers Date: 2020-12-13T14:16:54+01:00 New Revision: 36306403d492d4a4b54c72c6c4c511021584243b URL: https://github.com/llvm/llvm-project/commit/36306403d492d4a4b54c72c6c4c511021584243b DIFF: https://github.com/llvm/llvm-project/commit/36306403d492d4a4b54c72c6c4c511021584243b.diff

[PATCH] D93170: [clang-format][NFC] Expand BreakBeforeBraces examples

2020-12-13 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. We should have the same examples added to the unit tests so we know they are correct (and stay correct) But I really appreciate the documentation effort Repository: rG LLVM

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-13 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you so much too. I could learn how to write better clang tests. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___ cfe-commits

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-13 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d1729232cd: [VE] Optimize toolchain regression test (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] 05d1729 - [VE] Optimize toolchain regression test

2020-12-13 Thread Kazushi Marukawa via cfe-commits
Author: Kazushi (Jam) Marukawa Date: 2020-12-13T20:26:05+09:00 New Revision: 05d1729232cdff323cafd469532504aa85740967 URL: https://github.com/llvm/llvm-project/commit/05d1729232cdff323cafd469532504aa85740967 DIFF: https://github.com/llvm/llvm-project/commit/05d1729232cdff323cafd469532504aa85740

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

2020-12-13 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. (Also, for studying the effect of this one, on an IR level, the difference is already present in the output of `-S -emit-llvm` from clang, unless using `-Xclang -disable-llvm-passes`, but I'm sure you already took that into account.) Repository: rG LLVM Github Mono

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

2020-12-13 Thread Alex Orlov via Phabricator via cfe-commits
aorlov updated this revision to Diff 311431. aorlov added reviewers: mibintc, hokein. aorlov added subscribers: mibintc, hokein. aorlov added a comment. Updated. Disabled function parameters access checking in function templates. Hi, @broadwaylamb, @rsmith, @saar.raz, @doug.gregor, @mibintc, @hoke