[clang] 2ca0ea1 - [Driver] Fix formatting as suggested by clang-format (NFC)

Author: Dmitry Antipov Date: 2020-09-26T08:52:51+03:00 New Revision: 2ca0ea15e5c910ff93874679f0a03c923fe85e5b URL: https://github.com/llvm/llvm-project/commit/2ca0ea15e5c910ff93874679f0a03c923fe85e5b DIFF: https://github.com/llvm/llvm-project/commit/2ca0ea15e5c910ff93874679f0a03c923fe85e5b.diff

[clang] 96318f6 - [Driver] Perform Linux distribution detection only once

Author: Dmitry Antipov Date: 2020-09-26T08:44:08+03:00 New Revision: 96318f64a7864747ebbb4e33cb75b0dea465abfc URL: https://github.com/llvm/llvm-project/commit/96318f64a7864747ebbb4e33cb75b0dea465abfc DIFF: https://github.com/llvm/llvm-project/commit/96318f64a7864747ebbb4e33cb75b0dea465abfc.diff

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

This revision was automatically updated to reflect the committed changes. Closed by commit rG96318f64a786: [Driver] Perform Linux distribution detection only once (authored by dmantipov). Changed prior to commit: https://reviews.llvm.org/D87187?vs=294302&id=294478#toc Repository: rG LLVM Git

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. benshi001 requested review of this revision. AVR.cpp should be kept up-to-date with AVRDevices.td Repository: rG LLVM Github Monorepo http

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

dmajor added a comment. This change broke the configure step of Firefox mingw builds. The build bot won't give me the full details, so I'll need to set up a local repro next week if needed, but my hunch is that we have some test like `$CC $CFLAGS conftest.c -o conftest` and then check for the e

[PATCH] D88333: Correctly parse attributes on the declaration of an anonymous bit-field

rsmith added a comment. I think we established rough consensus in CWG (at least, no one objected) that this is a grammar bug -- there's nothing for these attributes to appertain to, so they shouldn't be permitted. Unless CWG indicates it wants to change direction here I think we should continue

[clang] ebb1092 - [Clang][OpenMP] Added support for nowait target in CodeGen via regular task

Author: Shilei Tian Date: 2020-09-25T22:10:36-04:00 New Revision: ebb1092a2875739d3e9bb6b1fb230c0e0d88ebff URL: https://github.com/llvm/llvm-project/commit/ebb1092a2875739d3e9bb6b1fb230c0e0d88ebff DIFF: https://github.com/llvm/llvm-project/commit/ebb1092a2875739d3e9bb6b1fb230c0e0d88ebff.diff L

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task

This revision was automatically updated to reflect the committed changes. Closed by commit rGebb1092a2875: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc created this revision. ddcc added a reviewer: ostannard. Herald added a subscriber: dang. Herald added a project: clang. ddcc requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88349 Files: clang/include/clang/Driver/Options.td Index: clan

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGExpr.cpp:1181 + if (T->isMemberPointerType()) +return CGM.getCXXABI().EmitMemberPointerIsNotNull( +*this, V, T->getAs())

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

MaskRay added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:372 apply across DSO boundaries. As in the regular CFI, each DSO must be -built with ``-flto``. +built with ``-flto`` or ``flto=thin``. typo: `-flto=thin` Repository: rG LLVM Gi

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 ___ cfe-com

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294461. ellis added a comment. Rename `mangleObjCMethodName` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Man

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk added a comment. In D88336#2296051 , @ahatanak wrote: > It looks like this still doesn't check null correctly (i.e., compare to -1) > for data member pointers. Is that correct? Thanks for catching this. The new revision takes advantage of CXXABI::Em

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk updated this revision to Diff 294457. vsk added a comment. Simplify, per Akira's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88336/new/ https://reviews.llvm.org/D88336 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExpr

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar added a comment. wha... As you know, `const` doesn't mean anything, that can be const-casted away. And then you'll be able to observe that this nominally-static variable is just a normal variable. Since this doesn't make sense and contradicts their documentation, I'm tempted to say thi

[clang] a000580 - [RISCV] Update driver tests

Author: Evandro Menezes Date: 2020-09-25T18:36:53-05:00 New Revision: a000580a89718a1ff27a3129e34367b9a3fa1730 URL: https://github.com/llvm/llvm-project/commit/a000580a89718a1ff27a3129e34367b9a3fa1730 DIFF: https://github.com/llvm/llvm-project/commit/a000580a89718a1ff27a3129e34367b9a3fa1730.dif

[PATCH] D88345: [CUDA] Allow `static const {__constant__, __device__}` variables.

tra created this revision. tra added reviewers: jlebar, yaxunl. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. tra requested review of this revision. While CUDA documentation claims that such variables are not allowed[1], NVCC has been accepting them since CUDA-10.0

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

ahatanak added a comment. It looks like this still doesn't check null correctly (i.e., compare to -1) for data member pointers. Is that correct? Comment at: clang/lib/CodeGen/CGCall.cpp:3750 + // Under the Itanium ABI, if the argument has member pointer type, it's a + // pai

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG58cdbf518b6e: Sema: add support for `__attribute__((__swift_private__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87720?vs=294167&id=294443#toc Repository: rG LLVM G

[clang] 58cdbf5 - Sema: add support for `__attribute__((__swift_private__))`

Author: Saleem Abdulrasool Date: 2020-09-25T22:33:53Z New Revision: 58cdbf518b6ebaee59d0492375e2e8f7da87ca41 URL: https://github.com/llvm/llvm-project/commit/58cdbf518b6ebaee59d0492375e2e8f7da87ca41 DIFF: https://github.com/llvm/llvm-project/commit/58cdbf518b6ebaee59d0492375e2e8f7da87ca41.diff

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall added inline comments. Comment at: clang/include/clang/AST/Mangle.h:130 + bool includeCategoryNamespace = true); void mangleObjCMethodName(const ObjCMethodDecl *MD, raw_ostream &); Could you switch the polarity

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. Off-Topic: I was just attempting to apply this to my codebase at work. Seems this will be more challenging than anticipated 😉 My best guess is this is related to D72730 Applying fixes ... terminate called after throwing an ins

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a tool to simply parse a

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. "Minimal" example for the behavior I described before. `clang++ -fsyntax-only ~/llvm/clang/test/SemaCXX/warn-range-loop-analysis.cpp -Wrange-loop-analysis 2>&1 | wc -l` 269 Then fix it by: `~/llvm/build-const-fix/bin/clang-tidy ~/llvm/clang/test/SemaCXX/warn-ra

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk created this revision. vsk added reviewers: jkorous, ahatanak. Herald added a subscriber: dexonsmith. Herald added a project: clang. vsk requested review of this revision. Extend -fsanitize=nullability-arg to handle call sites which accept C++ member function pointers. rdar://62476022 Repos

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

aaron.ballman added reviewers: steveire, klimek, sammccall. aaron.ballman added a subscriber: steveire. aaron.ballman added a comment. In D88275#2295413 , @ymandel wrote: > In D88275#2295379 , @aaron.ballman > wrot

[PATCH] D88333: Correctly parse attributes on the declaration of an anonymous bit-field

aaron.ballman created this revision. aaron.ballman added reviewers: hubert.reinterpretcast, rsmith. aaron.ballman requested review of this revision. The C++ grammar allows you to specify an attribute list on an anonymous bit-field, but we were not properly parsing that case. This would lead to a

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294395. ellis added a comment. Fix variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp cl

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ellis requested review of this revision. This reduces code duplication between CGObjCMac.cpp and Mangle.cpp for generating the mangled name of an Objective-C method. This has no intended functiona

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/stack-protector.c:39 // SAFESTACK-NOSSP: attributes #[[A]] = {{.*}} safestack -// SAFESTACK-NOSSP-NOT: ssp +// SAFESTACK-NOSSP-NOT: attribute #[[A]] = {{.*}} ssp should be `attributes` plura

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Nice to get async through "regular" tasks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D7807

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel updated this revision to Diff 294363. ymandel added a comment. restored changes to unrelated parts of html docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88275/new/ https://reviews.llvm.org/D88275 Files: clang/docs/LibASTMatchersRef

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. In D88275#2295379 , @aaron.ballman wrote: > This seems to be strongly related to the `TK_IgnoreUnlessSpelledInSource` > traversal behavior; is there a reason you can't use that traversal mode with > `hasParent()` (does it behave

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

aaron.ballman added a comment. This seems to be strongly related to the `TK_IgnoreUnlessSpelledInSource` traversal behavior; is there a reason you can't use that traversal mode with `hasParent()` (does it behave differently)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

JonasToth added a comment. In D54222#2294123 , @jranieri-grammatech wrote: > In D54222#1290789 , @JonasToth wrote: > >> I agree with @Eugene.Zelenko that this check should rather live in >> `bugprone-` as the issu

[clang] 76eb163 - Sema: remove unnecessary parameter for SwiftName handling (NFCI)

Author: Saleem Abdulrasool Date: 2020-09-25T17:01:06Z New Revision: 76eb163259c46171559a49111a394a3e48d1e523 URL: https://github.com/llvm/llvm-project/commit/76eb163259c46171559a49111a394a3e48d1e523 DIFF: https://github.com/llvm/llvm-project/commit/76eb163259c46171559a49111a394a3e48d1e523.diff

[PATCH] D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rG76eb163259c4: Sema: remove unnecessary parameter for SwiftName handling (NFCI) (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88263/ne

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:461 + if (auto *CE = llvm::dyn_cast(RHS->IgnoreCasts())) { +// Make sure we get the version of move with 1 arg, the other is for moving +// ranges. sammccall wrote: > nit: you

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

njames93 updated this revision to Diff 294357. njames93 marked 2 inline comments as done. njames93 added a comment. Updated function doc Fix potential assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88297/new/ https://reviews.llvm.org/D8829

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

CarolineConcatto updated this revision to Diff 294356. CarolineConcatto added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 Files: clang/include/clang/Driver/Options.t

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. Should we wait until the next OpenMP LLVM meeting to push this? Comment at: openmp/libomptarget/include/Ident.h:48-51 +auto removePath = [](const std::string &path) { +std::size_t pos = path.rfind('/'); +return path.substr(pos + 1);

[PATCH] D88319: [AST] Delete broken, unused template.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. ymandel requested review of this revision. The `const*` overload of `IgnoreExprNodes` can't compile. Moreover, this didn't turn up because it's unused. There's no obvious fix, so I've deleted it.

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 294352. jhuber6 added a comment. Adding message to build with debugging symbols if source location is not found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files:

[clang] 62c3727 - [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR

Author: Vedant Kumar Date: 2020-09-25T09:39:40-07:00 New Revision: 62c372770d2e87f3e882a20d43c6814e6c4fe0f5 URL: https://github.com/llvm/llvm-project/commit/62c372770d2e87f3e882a20d43c6814e6c4fe0f5 DIFF: https://github.com/llvm/llvm-project/commit/62c372770d2e87f3e882a20d43c6814e6c4fe0f5.diff

[PATCH] D87332: [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62c372770d2e: [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel updated this revision to Diff 294348. ymandel added a comment. Fixed to use more standard type adaptors. Registration now works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88275/new/ https://reviews.llvm.org/D88275 Files: clang/docs/L

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/test/CodeGen/fp-floatcontrol-pragma.cpp:154 + if (i<0) + return 1.0 + 2.0; + // Check that floating point constant folding doesn't occur if sepavloff wrote: > In this particular case we know for sure that the re

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

aganea accepted this revision. aganea added a comment. Makes sense, you cache the commonly taken path, but not the (very uncommon) VFS codepath. LGTM, with some minor comments. Thanks again! Comment at: clang/include/clang/Driver/Distro.h:117 - bool IsOpenSUSE() const { -

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. One minor remark from me, otherwise LGTM. @grokos Any concerns or is this OK? Comment at: openmp/libomptarget/src/interface.cpp:73-76 + FATAL_MESSAGE0(1, "fail

[PATCH] D88314: Added llvm-string-referencing check

bogser01 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. bogser01 requested review of this revision. Clang-tidy pass detecting the use of const std::string& references. Use of llvm::StringRef is recommended in the LLVM Programmer's Manual inste

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

MaskRay added a comment. In D65880#2294871 , @protze.joachim wrote: > I still see some clang-specific and system link directories listed in the > linker line before the directories from `LIBRARY_PATH`: > > $ LIBRARY_PATH=test1 /usr/local/clang/bin/clan

[PATCH] D88312: "ErrorReturn checker" WIP review

balazske added a comment. Here are the results with this checker o

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. A improved version of the checker is added for further discussion (or should continue here?) and to show the improved checker code. See D88312 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D88312: "ErrorReturn checker" WIP review

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, Szelethus, dkrupp. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske requested review of this revision. This is a testing version for the checker that is implemented in D

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720 __

[PATCH] D88311: Added llvm-string-referencing check

bogser01 updated this revision to Diff 294331. bogser01 added a comment. Herald added a subscriber: mgorny. Changed upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88311/new/ https://reviews.llvm.org/D88311 Files: clang-tools-extra/clang-

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

davidxl added a comment. Perhaps also add clang option manual description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87737/new/ https://reviews.llvm.org/D87737 ___ cfe-commits mailing list cfe-commit

[PATCH] D88311: Added llvm-string-referencing check

bogser01 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. bogser01 requested review of this revision. Clang-tidy pass detecting the use of const std::string& references. Use of llvm::StringRef is recommended in the LLVM Programmer's Manual instead: htt

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1150 + if (llvm::isa(D) || llvm::isa(D)) { +Decls = getDeclAtPosition(AST, *CurLoc, + Relations | DeclRelation::Underlying); hokein wrote: >

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. In D87528#2270502 , @sepavloff wrote: >> @sepavloff Is it OK if I continue work on this item? Not sure about the >> protocol when continuing someone else's patch. > > It is OK for me. There is also an action in Phabricator "Comman

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel updated this revision to Diff 294312. ymandel added a comment. update dynamic registry and the ast matcher doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88275/new/ https://reviews.llvm.org/D88275 Files: clang/docs/LibASTMatchersRefe

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

MyDeveloperDay added a comment. Which bit to you find more complex? adding something to the FormatToken or the use of the `is()` calls? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84306/new/ https://reviews.llvm.org/D84306 _

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao updated this revision to Diff 294307. hliao added a comment. Remove the irrelevant change on .clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88303/new/ https://reviews.llvm.org/D88303 Files: clang/lib/CodeGen/CGCall.cpp clan

[clang] a51d51a - Fix some of the more egregious 80-col and whitespace issues; NFC

Author: Aaron Ballman Date: 2020-09-25T10:37:38-04:00 New Revision: a51d51a0d4d72ab423b11da4c5c877bc6e89a580 URL: https://github.com/llvm/llvm-project/commit/a51d51a0d4d72ab423b11da4c5c877bc6e89a580 DIFF: https://github.com/llvm/llvm-project/commit/a51d51a0d4d72ab423b11da4c5c877bc6e89a580.diff

[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, generally I think clang-format seems to remove trailing spaces anyway so it might be that the duplicate might disappear on the second format. but I'm good with this

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao created this revision. hliao added a reviewer: yaxunl. Herald added subscribers: cfe-commits, kerbowa, Anastasia, nhaehnle, jvesely. Herald added a project: clang. hliao requested review of this revision. - `-cl-fp32-correctly-rounded-divide-sqrt` is already handled in a per-instruction man

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 294302. dmantipov marked an inline comment as done. dmantipov added a comment. Well, the problem with tests seems to be a bit wider - tests uses llvm::vfs::InMemoryFileSystem, which is not "real", so detection will return Distro::UnknownDistro anyway. So

[clang] 85cea77 - Typo fix; NFC

Author: Aaron Ballman Date: 2020-09-25T10:26:29-04:00 New Revision: 85cea77ecb7f2ca51198ec1ad1d28845e803ee32 URL: https://github.com/llvm/llvm-project/commit/85cea77ecb7f2ca51198ec1ad1d28845e803ee32 DIFF: https://github.com/llvm/llvm-project/commit/85cea77ecb7f2ca51198ec1ad1d28845e803ee32.diff

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

JonasToth updated this revision to Diff 294301. JonasToth added a comment. - fix typo that provided wrong argument to AST building Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88088/new/ https://reviews.llvm.org/D88088 Files: clang/lib/Analysis

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

JonasToth updated this revision to Diff 294300. JonasToth added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88088/new/ https://reviews.llvm.org/D88088 Files: clang/lib/Analysis/ExprMutationAnalyzer.cpp cl

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Could you add a test that sets this flag? Perhaps we can run CodeCompletionTests.cpp twice, once with this flag, once without? Just to exercise these code paths, I think most expectations ther

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

protze.joachim added a comment. I still see some clang-specific and system link directories listed in the linker line before the directories from `LIBRARY_PATH`: $ LIBRARY_PATH=test1 /usr/local/clang/bin/clang -Ltest2 -v hello.c "/usr/bin/ld" .../crtbegin.o -Ltest2 -L/usr/lib/gcc/x86_64-re

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:414 // If CMD is one of the forms: // void foo(T arg) { FieldName = arg; } // R foo(T arg) { FieldName = arg; return *this; } can you also update the docs? Co

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1150 + if (llvm::isa(D) || llvm::isa(D)) { +Decls = getDeclAtPosition(AST, *CurLoc, + Relations | DeclRelation::Underlying); I think it shou

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thanks! Comment at: clang-tools-extra/clangd/Hover.cpp:461 + if (auto *CE = llvm::dyn_cast(RHS->IgnoreCasts())) { +// Make sure we get the version of move wi

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 294296. jhuber6 added a comment. Added definition for the ident_t struct from kmp.h along with a method to extract the source location information. Checking the target outcome now prints the file location if ident_t location is available. Repository: rG

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek created this revision. klimek added a reviewer: sammccall. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. klimek requested review of this revision. MacroUnexpander applies the structural formatting of expanded lines into UnwrappedLines to the corresponding une

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/KernelNameRestrictionCheck.cpp:53 +void KernelNameRestrictionCheck::registerPPCallbacks( +const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) { + PP->addPPCallbacks(

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:8061 + QualType MTETy = Step->Type; + It seemed less intrusive/more reliable to fix this during the init-process, and perhaps would fix a few additional cases. The VarDecl gets upd

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall. erichkeane requested review of this revision. Like the VarDecl that gets its type updated based on an init-list, this patch corrects the MaterializeTemporaryExpr's type to make sure it isn't creating an incomplete type

[PATCH] D88140: [clang-tidy] Check for sigaction in cert-sig30-c.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:91 + hasObjectExpression(ignoringParenImpCasts(declRefExpr( + anyOf(hasType(recordDecl(hasName("sigaction"))), +hasType(pointsTo(recordDecl(hasN

[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

curdeius added a comment. Finally I've opted for creating a small revision just fixing this particular bug report. Mind however that the problem is a bit more complex and to solve all possible cases we would need to first reformat the source code, then sort the includes and then again, possibly

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Extend the Trivial setter

[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

curdeius updated this revision to Diff 294291. curdeius added a comment. - Ooops. Revert unwanted test changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88296/new/ https://reviews.llvm.org/D88296 Files: clang/lib/Format/Format.cpp clang/u

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:31-33 + // This check does not work with function calls in std namespace. + if (!FD->isGlobal() || FD->isInStdNamespace()) +return false; baloghadamsof

[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

curdeius created this revision. curdeius added a reviewer: MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. curdeius requested review of this revision. This fixes PR46555. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88296 Files: clang

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

CarolineConcatto marked 23 inline comments as done. CarolineConcatto added a comment. @awarzynski thank you for the review. It is a big patch to review at once. I accepted almost all of your changes. Comment at: flang/test/Flang-Driver/emit-obj.f90:2 ! RUN: not %flang-new %s

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

Quuxplusone added a comment. (This patch was split out from D88220 at my request.) @nullptr.cpp, please add the regression test from https://godbolt.org/z/5EfK99 . After a test is added, this patch LGTM (but will need approval also from someone else). Your s

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:31 +static bool isSystemCall(const FunctionDecl *FD) { + // This check does not work with function calls in std namespace. + if (!FD->isGlobal() || FD->isInStdNamespac

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

CarolineConcatto updated this revision to Diff 294288. CarolineConcatto added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Solve review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/

[PATCH] D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88263/new/ https://reviews.llvm.org/D88263 __

[clang] 6a1bca8 - [Analyzer] Fix unused variable warning in Release builds

Author: Benjamin Kramer Date: 2020-09-25T14:09:43+02:00 New Revision: 6a1bca8798c6ba119f188061472b60876495b9ae URL: https://github.com/llvm/llvm-project/commit/6a1bca8798c6ba119f188061472b60876495b9ae DIFF: https://github.com/llvm/llvm-project/commit/6a1bca8798c6ba119f188061472b60876495b9ae.dif

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp created this revision. nullptr.cpp added reviewers: Quuxplusone, rsmith, erik.pilkington. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. nullptr.cpp requested review of this revision. In C++11 standard, to become implicitly movable, the expression in

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss updated this revision to Diff 294284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 Files: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp llvm/test/CodeGen/AArch64/note-gnu-property-pac-bti-0.ll llvm/test/CodeGen/AArch64/note-gnu

[clang] e336b74 - [clang-format] Add a MacroExpander.

Author: Manuel Klimek Date: 2020-09-25T14:08:13+02:00 New Revision: e336b74c995d665bc3fb75164375bbb0f78f516c URL: https://github.com/llvm/llvm-project/commit/e336b74c995d665bc3fb75164375bbb0f78f516c DIFF: https://github.com/llvm/llvm-project/commit/e336b74c995d665bc3fb75164375bbb0f78f516c.diff

[PATCH] D83296: [clang-format] Add a MacroExpander.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. klimek marked 5 inline comments as done. Closed by commit rGe336b74c995d: [clang-format] Add a MacroExpander. (authored by klimek). Changed prior to commit: https://

[PATCH] D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker

baloghadamsoftware added a comment. In D87146#2294514 , @baloghadamsoftware wrote: > In D87146#2294423 , @ASDenysPetrov > wrote: > >> It would be nice if someone had time to look at this. Thanks. > > I am just loo

  1   2   >