CarolineConcatto marked 23 inline comments as done. CarolineConcatto added a comment.
@awarzynski thank you for the review. It is a big patch to review at once. I accepted almost all of your changes. ================ Comment at: flang/test/Flang-Driver/emit-obj.f90:2 ! RUN: not %flang-new %s 2>&1 | FileCheck %s --check-prefix=ERROR-IMPLICIT -! RUN: not %flang-new -emit-obj %s 2>&1 | FileCheck %s --check-prefix=ERROR-EXPLICIT ! RUN: not %flang-new -fc1 -emit-obj %s 2>&1 | FileCheck %s --check-prefix=ERROR-FC1 ---------------- awarzynski wrote: > Why is this line deleted? `flang-new -emit-obj` should still fail, right? I remove this because the text does not apply any more ! ERROR-IMPLICIT: error: unknown argument: '-o' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
