jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land.
One minor remark from me, otherwise LGTM. @grokos Any concerns or is this OK? ================ Comment at: openmp/libomptarget/src/interface.cpp:73-76 + FATAL_MESSAGE0(1, "failure of target construct while offloading is mandatory"); + } + else + FATAL_MESSAGE0(1, "failure of target construct while offloading is mandatory"); ---------------- also check if `info` has an actual location please. If line and column are 0, print a message that `-g` can help provide source location information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
