[PATCH] D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation

bruno updated this revision to Diff 293356. bruno added a comment. Add context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87853/new/ https://reviews.llvm.org/D87853 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/Template.h clang/lib/Sema/SemaTemplate.cpp cla

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

sylvestre.ledru added a comment. @MarcusJohnson91 I know it is confusing but we don't use the Mozilla coding style. We are using the Google style. You can use the code snippet that I provided here: https://bugs.llvm.org/show_bug.cgi?id=47589 it is easy to reproduce even without argument or conf

[clang] 1dc7836 - [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`

Author: Eduardo Caldas Date: 2020-09-22T06:47:36Z New Revision: 1dc7836aed134b4543bad6aa54f15cc0e51a627f URL: https://github.com/llvm/llvm-project/commit/1dc7836aed134b4543bad6aa54f15cc0e51a627f DIFF: https://github.com/llvm/llvm-project/commit/1dc7836aed134b4543bad6aa54f15cc0e51a627f.diff LOG

[PATCH] D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf582c9b0f3a: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87779/new/ https:

[PATCH] D88024: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dc7836aed13: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] af582c9 - [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

Author: Eduardo Caldas Date: 2020-09-22T06:47:36Z New Revision: af582c9b0f3a09b6a1b5101fd30dcbcef5c188b0 URL: https://github.com/llvm/llvm-project/commit/af582c9b0f3a09b6a1b5101fd30dcbcef5c188b0 DIFF: https://github.com/llvm/llvm-project/commit/af582c9b0f3a09b6a1b5101fd30dcbcef5c188b0.diff LOG

[PATCH] D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation

bruno updated this revision to Diff 293351. bruno retitled this revision from "[Sema] Update specialization iterator after template argument deduction." to "[SemaTemplate] Stop passing insertion position around during VarTemplate instantiation". bruno edited the summary of this revision. bruno ad

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *RetValUnderCons

[PATCH] D87853: [Sema] Update specialization iterator after template argument deduction.

bruno commandeered this revision. bruno edited reviewers, added: hoy; removed: bruno. bruno added a comment. Herald added subscribers: modimo, lxfind, ributzka, jkorous. I'm taking this over from Hongtao (w/ his blessing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang-tools-extra] aa3c763 - [clang] Traverse init-captures while indexing

Author: Nathan Ridge Date: 2020-09-22T02:32:09-04:00 New Revision: aa3c7638ba1648e020cf65a424389e093f2b3a1a URL: https://github.com/llvm/llvm-project/commit/aa3c7638ba1648e020cf65a424389e093f2b3a1a DIFF: https://github.com/llvm/llvm-project/commit/aa3c7638ba1648e020cf65a424389e093f2b3a1a.diff

[PATCH] D87257: [clang] Traverse init-captures while indexing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa3c7638ba16: [clang] Traverse init-captures while indexing (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D87257?vs=2930

[clang-tools-extra] f18f8f3 - [clangd] Link libclangdSupport into clangd-index-server

Author: Nathan Ridge Date: 2020-09-22T02:28:48-04:00 New Revision: f18f8f34d3d82b0842daf184c71e8240620d925c URL: https://github.com/llvm/llvm-project/commit/f18f8f34d3d82b0842daf184c71e8240620d925c DIFF: https://github.com/llvm/llvm-project/commit/f18f8f34d3d82b0842daf184c71e8240620d925c.diff

[PATCH] D87979: [clangd] Link libclangdSupport into clangd-index-server

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18f8f34d3d8: [clangd] Link libclangdSupport into clangd-index-server (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87979/new/ https:/

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Uh-oh, so you're saying that you're actively modeling every single operator `+` and `-` on every single integer in the program even when they don't represent any iterators at all? How can a raw inte

[PATCH] D88071: [clangd] Add a trained DecisionForest for code completion.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Replaces the dummy CodeCompletion model with a trained DecisionForest model. The

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, yup, thanks, this looks good! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:146 +return SVB.makeLoc(BaseReg); +} + if (Init->isDelegatingIni

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

NoQ requested changes to this revision. NoQ added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Analysis/Checkers/CPlusPlus11LockChecker.cpp:379-382 +void rm_bad1() { + rm1.lock(); // no-warning + rm1.lock(); // expected-warning{{This lo

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator wrote: > > morehouse added a comment. > > This change appears to trigger an assertion failure in sysmsg.c on the PPC > bot: > http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% > >

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#228 , @tentzen wrote: > Thank you for prompt reply again. > >> [rjmccall] And I agree with him that the potential benefits are substantial. >> I'm just saying that one barely-trafficked RFC thread is not evidence of

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

rjmccall added a comment. I had a question in the other patch about whether you should just have a method on FixedPointSemantics that returns the unscaled semantics (since FixedPointSemantics is totally capable of expressing integer types), which would let fitsInFloatSemantics have more obvious

[PATCH] D88003: Fix typos in ASTMatchers.h

YangZhihui updated this revision to Diff 293326. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88003/new/ https://reviews.llvm.org/D88003 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h Index: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293323. tianshilei1992 added a comment. Fixed the case `target_teams_distribute_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/C

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293320. tianshilei1992 added a comment. Fixed the case `target_teams_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOp

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. In D83154#2286587 , @keith wrote: > With D87928 do you think we would want this > flag as well? The only difference I can think of (besides general UX) is if > you need to remap paths outside of y

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 293313. amyk added a comment. Address Nemanja's review comments: - More specific comments when bitcasting the inputs - Pull out conditions to bitcast the input, use ternary op depending if the input is 32 or 64-bits - Create new static function to check if a gi

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator wrote: > > morehouse added a comment. > > This change appears to trigger an assertion failure in sysmsg.c on the PPC > bot: > http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% > >

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Thank you for prompt reply again. > [rjmccall] And I agree with him that the potential benefits are substantial. > I'm just saying that one barely-trafficked RFC thread is not evidence of a > community consensus. OK, thanks. it's good to know you are also supportive i

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

rsmith added a comment. In D87808#2280197 , @dblaikie wrote: > @rsmith What's the deal with these anonymous structs/unions? Why do they have > copy/move constructors (are those technically called from the enclosing > class's copy/move constructors?) but

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

morehouse added a comment. This change appears to trigger an assertion failure in sysmsg.c on the PPC bot: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% TEST 'SanitizerCommon-msan-powerpc64le-Linux :: Linux/sysmsg.c' FAILED

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:103-110 + enum class CompareResult { +unknown, +identical, +less, +less_equal, +greater, +greater_equal baloghadamsoft

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. With D87928 do you think we would want this flag as well? The only difference I can think of (besides general UX) is if you need to remap paths outside of your source root, I believe having a `*-prefix-map` style flag makes that a bit mor

[PATCH] D87928: Provide -fsource-dir flag in Clang

keith added a comment. In D87928#2282609 , @phosek wrote: > This change is trying to address the issues raised in D83154 > . There are still some open questions: > > - Is `-fsource-dir` the best name for this flag? I thin

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 293296. weiwang added a comment. minor update to test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/t

[PATCH] D87953: [xray] Function coverage groups

ianlevesque updated this revision to Diff 293289. ianlevesque added a comment. const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D85810: [clang] Pass-through remarks options to linker

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:104 + CmdArgs.push_back(Args.MakeArgString( + Twine("--plugin-opt=opt-remarks-format=") + Format.data()));

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

grokos added a comment. In D87946#2286413 , @jhuber6 wrote: > I wasn't aware they were explicitly deprecated. If we're keeping around old > interfaces for backwards compatibility I should also add in the old mapper > functions without the `ident_t` point

[PATCH] D87953: [xray] Function coverage groups

ianlevesque added a comment. In D87953#2284071 , @MaskRay wrote: > How large the overhead is? This is somewhat surprising to me. It is the binary size overhead, not the runtime overhead, that we are limited on (when deployed on Android). Repository:

[PATCH] D87953: [xray] Function coverage groups

ianlevesque updated this revision to Diff 293278. ianlevesque added a comment. Address code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 Files: clang/include/clang/Basic/CodeGenOptions.

[PATCH] D87953: [xray] Function coverage groups

ianlevesque marked 7 inline comments as done. ianlevesque added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:814 +auto FuncGroups = CGM.getCodeGenOpts().XRayTotalFunctionGroups; +if (FuncGroups > 1) { + auto FuncName = ArrayRef(CurFn->getName().

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 293276. weiwang added a comment. 1. remove unreachable code 2. udpate test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/Com

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. In D87946#2286406 , @grokos wrote: > In D87946#2286024 , @jhuber6 wrote: > >> Added ident_t structs to additional runtime functions. > > Why are we adding the extra parameter to those additi

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang added a comment. In D87808#2282223 , @rnk wrote: > In D87808#2280197 , @dblaikie wrote: > >> @rsmith What's the deal with these anonymous structs/unions? Why do they >> have copy/move constructors (are thos

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

grokos added a comment. In D87946#2286024 , @jhuber6 wrote: > Added ident_t structs to additional runtime functions. Why are we adding the extra parameter to those additional functions? Non-mapper API functions have been deprecated, clang does not emit t

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87927/new/ https://reviews.llvm.org/D87927

[clang] 0f6facc - Don't build a StringLiteral expression with reference type when

Author: Richard Smith Date: 2020-09-21T15:25:19-07:00 New Revision: 0f6facca9701f6df87d13e55d70bd7111a0472aa URL: https://github.com/llvm/llvm-project/commit/0f6facca9701f6df87d13e55d70bd7111a0472aa DIFF: https://github.com/llvm/llvm-project/commit/0f6facca9701f6df87d13e55d70bd7111a0472aa.diff

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

dmgreen added a comment. > @dmgreen for arm?:) This would seem more like a good general codegen cleanup than something that would be target dependent. It would probably be more dependent on the code that is being run, than the exact target. But yeah, I ran some baremetal tests. Only one change

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 8 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3579-3580 + let Content = [{ +The ``swift_name`` attribute provides the spelling for the transformed name when +the interface is imported into the Swift

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

daltenty updated this revision to Diff 293262. daltenty added a comment. - Check absence in C cases - Add a note about crti in the nostdlib++ case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87927/new/ https://reviews.llvm.org/D87927 Files: cl

[clang] 6807f24 - [ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

Author: shafik Date: 2020-09-21T14:57:00-07:00 New Revision: 6807f244fa67bb75ef09fb3db54743b5b358a7fa URL: https://github.com/llvm/llvm-project/commit/6807f244fa67bb75ef09fb3db54743b5b358a7fa DIFF: https://github.com/llvm/llvm-project/commit/6807f244fa67bb75ef09fb3db54743b5b358a7fa.diff LOG: [

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG6807f244fa67: [ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87910/new/ https://reviews.llvm.org/D87910 ___

[PATCH] D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87671/new/ https://reviews.llvm.org/D87671 ___

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293254. tianshilei1992 added a comment. Fixed the test case `target_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293253. tianshilei1992 added a comment. Fixed the case `target_parallel_for_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/

[clang] 8c3ef08 - Revert "[clang-cl] Always interpret the LIB env var as separated with semicolons"

Author: Martin Storsjö Date: 2020-09-22T00:14:45+03:00 New Revision: 8c3ef08f8a4eb40609af55d541e5135856fde086 URL: https://github.com/llvm/llvm-project/commit/8c3ef08f8a4eb40609af55d541e5135856fde086 DIFF: https://github.com/llvm/llvm-project/commit/8c3ef08f8a4eb40609af55d541e5135856fde086.diff

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added a comment. I had a quick look through this patch. Have a few comments (mostly nits and questions) inline. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:18 + +/// Fill out Opts based on the options given in Args. +/// Nit

[PATCH] D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.c:16 // CHECK-LD32: "-bpT:0x1000" "-bpD:0x2000" // CHECK-LD32: "[[SYSROOT]]/usr/lib{{/|}}crt0.o" // CHECK-LD32: "-L[[SYSROOT]]/usr/lib" There should be c

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. Yeah, I did clang-format since the last patch complained about some formatting in the linter. Didn't expect it to change quite so much. Also for some reason it won't let me quote your comment. Might've been better to ignore it until the final commit so it doesn't clutte

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

This revision was automatically updated to reflect the committed changes. Closed by commit rGead7c3cdc34c: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8800

[PATCH] D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d85444b317a: [clang-cl] Always interpret the LIB env var as separated with semicolons (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[clang] ead7c3c - [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

Author: Martin Storsjö Date: 2020-09-21T23:42:59+03:00 New Revision: ead7c3cdc34c63d8df78d8e333b7cc64d03236ea URL: https://github.com/llvm/llvm-project/commit/ead7c3cdc34c63d8df78d8e333b7cc64d03236ea DIFF: https://github.com/llvm/llvm-project/commit/ead7c3cdc34c63d8df78d8e333b7cc64d03236ea.diff

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. @sylvestre.ledru After looking more closely at the issue, it seems you're having an issue with Mozilla's comment alignment option. you want the comments to be aligned, and it appears Clang11 no longer has that option set for Mozilla's style is what you're sayin

[clang] 4d85444 - [clang-cl] Always interpret the LIB env var as separated with semicolons

Author: Martin Storsjö Date: 2020-09-21T23:42:59+03:00 New Revision: 4d85444b317a00a3e15da63cdb693d272c99a0cc URL: https://github.com/llvm/llvm-project/commit/4d85444b317a00a3e15da63cdb693d272c99a0cc DIFF: https://github.com/llvm/llvm-project/commit/4d85444b317a00a3e15da63cdb693d272c99a0cc.diff

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:446 +/// from +/// https://github.com/llvm/llvm-project/blob/master/openmp/runtime/src/kmp.h enum OpenMPLocationFlags : unsigned { A lot here seems unrelated. Did you clang format

[clang] 2697d13 - [Analyzer] GNU named variadic macros in Plister

Author: Chris Hamilton Date: 2020-09-21T15:38:28-05:00 New Revision: 2697d138a65a51b8cf58baa2d4a924c1f43af482 URL: https://github.com/llvm/llvm-project/commit/2697d138a65a51b8cf58baa2d4a924c1f43af482 DIFF: https://github.com/llvm/llvm-project/commit/2697d138a65a51b8cf58baa2d4a924c1f43af482.diff

[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2697d138a65a: [Analyzer] GNU named variadic macros in Plister (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 293240. MarcusJohnson91 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/lib/Format/Format.cpp Index: clang/lib/Format/Format.cpp ===

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 293238. jhuber6 added a comment. Added ident_t structs to additional runtime functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpe

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

fhahn added a comment. In D87972#2284060 , @MaskRay wrote: > I have tested this patch internally and seen gains and losses. On one > document search related benchmark 3~5% improvement. One zippy (snappy) there > is 3~5% regression. Perhaps we do need a c

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2285984 , @dmajor wrote: > I threw as many tests as I could find at 9d172c8e9c84 > , and I > don't see any regressions compared to its parent revision.

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9caa3fbe03f4: [Coverage] Add empty line regions to SkippedRegions (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://r

[clang] 9caa3fb - [Coverage] Add empty line regions to SkippedRegions

Author: Zequan Wu Date: 2020-09-21T12:42:53-07:00 New Revision: 9caa3fbe03f43e3eec30262fbba87c1ee15c05a3 URL: https://github.com/llvm/llvm-project/commit/9caa3fbe03f43e3eec30262fbba87c1ee15c05a3 DIFF: https://github.com/llvm/llvm-project/commit/9caa3fbe03f43e3eec30262fbba87c1ee15c05a3.diff LOG

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. I threw as many tests as I could find at 9d172c8e9c84 , and I don't see any regressions compared to its parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra accepted this revision. tra added a comment. In D84362#2283078 , @tra wrote: > It's possible. Unfortunately it's only triggered by our internal tool and > it's hard to create a public reproducer for it. I'll debug and try to fix it > on Monday. It a

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

aykevl added a comment. Looks reasonable to me, although I can't really comment on the contents of this as I'm not very familiar with this code. I would like to see just a single MCU table that contains all the information (including start addresses). Maybe it can even be generated from ATDF fi

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper added a comment. In D87888#2285878 , @rnk wrote: > Honestly, I forget exactly what the memory clobber does beyond the > "sideeffect" marker. I would expect LLVM to model these just as external > function calls that could read or write memory

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM unless @rjmccall has further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 added a comment. X86 data collected by @lebedev.ri looks good as well. @greend for arm?:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 ___ cfe-commit

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

rampitec added a comment. This is obviously LGTM from the AMDGPU BE point of view, we did it ourselves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 ___ cfe-co

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88005/new/ https://reviews.llvm.org/D88005 ___ cfe-com

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

rnk added a comment. Honestly, I forget exactly what the memory clobber does beyond the "sideeffect" marker. I would expect LLVM to model these just as external function calls that could read or write memory that is passed to them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D87923: [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b3a16548568: [MS] On x86_32, pass overaligned, non-copyable arguments indirectly (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87923/new/

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper added a comment. @rnk should this inline asm have a memory clobber on it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing lis

[clang] 3b3a165 - [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

Author: Reid Kleckner Date: 2020-09-21T11:49:17-07:00 New Revision: 3b3a16548568f5b6c4146ca5129eb6af5000e4ff URL: https://github.com/llvm/llvm-project/commit/3b3a16548568f5b6c4146ca5129eb6af5000e4ff DIFF: https://github.com/llvm/llvm-project/commit/3b3a16548568f5b6c4146ca5129eb6af5000e4ff.diff

[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87942/new/ https://reviews.llvm.org/D87942 __

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 293220. jhuber6 added a comment. Herald added subscribers: aaron.ballman, hiraditya. Fixed failing tests from OpenMPOpt. Formatted files which results in a lot of changes showing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://rev

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. Herald added a subscriber: ecnelises. The patches split from the main one look good to me. Please see if David has further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193 ___

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8540427419e: [AIX][Clang][Driver] Add handling of shared option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] d854042 - [AIX][Clang][Driver] Add handling of shared option

Author: David Tenty Date: 2020-09-21T14:03:08-04:00 New Revision: d8540427419ec0c4b9bc02f432ef39c01898e826 URL: https://github.com/llvm/llvm-project/commit/d8540427419ec0c4b9bc02f432ef39c01898e826 DIFF: https://github.com/llvm/llvm-project/commit/d8540427419ec0c4b9bc02f432ef39c01898e826.diff L

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88009/new/ https://reviews.llvm.org/D88009 _

[libunwind] b36bdfe - [cmake] Centralize LLVM_ENABLE_WARNINGS option

Author: Dave Lee Date: 2020-09-21T10:23:17-07:00 New Revision: b36bdfe5ca0c2b863248f327b03d41516b38dc11 URL: https://github.com/llvm/llvm-project/commit/b36bdfe5ca0c2b863248f327b03d41516b38dc11 DIFF: https://github.com/llvm/llvm-project/commit/b36bdfe5ca0c2b863248f327b03d41516b38dc11.diff LOG:

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

This revision was automatically updated to reflect the committed changes. Closed by commit rGb36bdfe5ca0c: [cmake] Centralize LLVM_ENABLE_WARNINGS option (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://rev

[clang] b36bdfe - [cmake] Centralize LLVM_ENABLE_WARNINGS option

Author: Dave Lee Date: 2020-09-21T10:23:17-07:00 New Revision: b36bdfe5ca0c2b863248f327b03d41516b38dc11 URL: https://github.com/llvm/llvm-project/commit/b36bdfe5ca0c2b863248f327b03d41516b38dc11 DIFF: https://github.com/llvm/llvm-project/commit/b36bdfe5ca0c2b863248f327b03d41516b38dc11.diff LOG:

[PATCH] D88034: [SyntaxTree][Synthesis] Implement `deepCopyExpandingMacros`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88034 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Tooling

[clang] 6950db3 - The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled.

Author: Sriraman Tallam Date: 2020-09-21T10:00:12-07:00 New Revision: 6950db36d33d85d18e3241ab6c87494c05ebe0fb URL: https://github.com/llvm/llvm-project/commit/6950db36d33d85d18e3241ab6c87494c05ebe0fb DIFF: https://github.com/llvm/llvm-project/commit/6950db36d33d85d18e3241ab6c87494c05ebe0fb.dif

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG6950db36d33d: The wrong placement of add pass with optimizations led to -funique-internal… (authored by tmsriram). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to c

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

MaskRay added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87737/new/ https://reviews.llvm.org/D87737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293195. tianshilei1992 added a comment. Continued to fix the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clan

[PATCH] D87923: [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87923/new/ https://reviews.llvm.org/D87923 _

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

tambre added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:924 +void Sema::LookupNecessaryTypesForBuiltin(Scope *S, unsigned ID) { + if (getLangOpts().ObjC && ID == Builtin::BIobjc_msgSendSuper) +LookupPredefedObjCSuperType(*this, S); rjmccall w

  1   2   >