MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:104
+ CmdArgs.push_back(Args.MakeArgString(
+ Twine("--plugin-opt=opt-remarks-format=") + Format.data()));
+}
----------------
Delete `.data()`
================
Comment at: clang/test/Driver/opt-record.c:55
+
+// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-filename=FOO.opt.ld.yaml"
+// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-passes=inline"
----------------
I'd write `// CHECK-NOPASS-NOT: "--plugin-opt=opt-remarks-filename=`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85810/new/
https://reviews.llvm.org/D85810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
