[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:114-115 // Convert the array length to size_t. NonLoc IndexLength = SVB.evalCast(SizeD, SizeTy, SizeE->getType()).castAs(); // Multiply the array length by the

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis added a comment. @njames93, do you still have any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D77178: [Analyzer][WebKit] NoUncountedMembersChecker

hokein added a comment. Hi, @jkorous Thanks for working on this analyzer check. Just give you some feedback on this check, it seems to trigger the assertion quite often (we noticed that internally there were a lot of crashes). you can easily reproduce it by running it a LLVM file, e.g. `./bin/

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser created this revision. junparser added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. As title. This patch implement unary operator ! of vector type. TestPlan: check-clang Repository: rG LLVM Github Monorepo ht

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Superseded by D80522 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 ___ cfe-commits

[PATCH] D80771: [MTE] Convert StackSafety into analysis

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 _

[PATCH] D80977: Diagnose cases where the name of a class member is used within a class definition before the member name is declared.

rsmith created this revision. rsmith added a reviewer: rnk. Herald added a project: clang. This is ill-formed per [basic.scope.class]p2. This is done by tracking all unqualified lookups performed within the scope of a class definition that find nothing within the class, and checking for conflicti

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

jkorous added a comment. Hi @kadircet! I am investigating a failure of `PatchesAdditionalIncludes` test that we got internally. It's a failed assert in `ReplayPreamble::replay`. Our clangd source code is for all practical purposes identical to upstream version but not so with clang source. Speci

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/wasm_simd128.h:1040 + (__c4)*2 + 1, (__c5)*2, (__c5)*2 + 1, (__c6)*2, (__c6)*2 + 1, (__c7)*2, \ + (__c7)*2 + 1)) ---

[clang] 4ccb6c3 - Fix violations of [basic.class.scope]p2.

Author: Richard Smith Date: 2020-06-01T22:03:05-07:00 New Revision: 4ccb6c36a9159809f4b98176325ae202753fe136 URL: https://github.com/llvm/llvm-project/commit/4ccb6c36a9159809f4b98176325ae202753fe136 DIFF: https://github.com/llvm/llvm-project/commit/4ccb6c36a9159809f4b98176325ae202753fe136.diff

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1582 +clear that it is a single line. Note that comments should only be hoisted for loops and +'if', and not in 'else if' or 'else', where it would be unclear whether the comment +belonged t

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267783. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80858: [HIP] Support accessing static device variable in host code

rjmccall added a comment. In addition to everyone else's concerns about generating this number randomly, it's also inherently less testable. I'm sure there's something else you could use that's reasonably likely to be unique, like a hash of the input filename or output filename or a combination

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1009 + Actions, Sema::ExpressionEvaluationContext::Unevaluated, + Sema::ReuseLambdaContextDecl); + Res = Actions.TransformToPotentiallyEvaluated(Res.get()); --

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall closed this revision. rjmccall added a comment. 8a8d703be0986dd6785cba0b610c9c4708b83e89 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.o

[clang] 8a8d703 - Fix how cc1 command line options are mapped into FP options.

Author: John McCall Date: 2020-06-01T22:00:30-04:00 New Revision: 8a8d703be0986dd6785cba0b610c9c4708b83e89 URL: https://github.com/llvm/llvm-project/commit/8a8d703be0986dd6785cba0b610c9c4708b83e89 DIFF: https://github.com/llvm/llvm-project/commit/8a8d703be0986dd6785cba0b610c9c4708b83e89.diff L

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: nemanjai, lei, stefanp, saghir, power-llvm-team. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: clang. This patch implements builtins for the following prototypes: unsigned long long __builtin_c

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. The shuffle intrinsic macros did not parenthesize usages of their constant parameters, which could lead to incorrect

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

rnk updated this revision to Diff 267767. rnk added a comment. - revert lld change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

rnk created this revision. rnk added a reviewer: akhuang. Herald added a reviewer: MaskRay. Herald added a project: clang. rnk updated this revision to Diff 267767. rnk added a comment. - revert lld change Clang marks calls to operator new as heap allocation sites, but the operator declared at g

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Did this end up moving to a review thread? Could someone include a link to that phab review, if it did. Otherwise - I'd still be curious about the answer to Sam's question about SuppressUnwrittenScope & see if the inline namespaces could be avoided & then going for the "modifying getFullyQualified

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:114-115 // Convert the array length to size_t. NonLoc IndexLength = SVB.evalCast(SizeD, SizeTy, SizeE->getType()).castAs(); // Multiply the array length by t

[PATCH] D80963: [WIP][clang] Allow {u}int_fastN_t to be different to {u}int_leastN_t

lenary created this revision. lenary added reviewers: luismarques, asb. Herald added a project: clang. This is in order to support psABIs where these two type sizes do not match for specific values of N. The default implementation matches clang's current behaviour where `getLeastIntTypeByWidth` is

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

vsk marked an inline comment as done. vsk added inline comments. Comment at: test/CodeGenObjCXX/os_log.mm:3 +// RUN: -fexceptions -fcxx-exceptions -O1 | FileCheck %s + +// Check that no EH cleanup is emitted around the call to __os_log_helper. ahatanak wrote: >

[PATCH] D80914: [update_cc_test_checks.py] Handle C++ methods

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80914/new/ https://reviews.llvm.org/D80914 __

[PATCH] D80913: [update_cc_test_checks.py] Correctly skip function definitions

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80913/new/ https://reviews.llvm.org/D80913 __

[clang] a66e1d2 - [os_log][test] Remove -O1 from a test, NFC

Author: Vedant Kumar Date: 2020-06-01T16:54:16-07:00 New Revision: a66e1d2aa943959e158821be8956109cb5ef3b3b URL: https://github.com/llvm/llvm-project/commit/a66e1d2aa943959e158821be8956109cb5ef3b3b DIFF: https://github.com/llvm/llvm-project/commit/a66e1d2aa943959e158821be8956109cb5ef3b3b.diff

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

MaskRay added a comment. `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

gribozavr2 added a comment. I think it makes sense to align the documentation and the definition of IgnoreUnlessSpelledInSource, I'm just not sure which component we should change -- the documentation or the implementation. Making IgnoreUnlessSpelledInSource not match template instantiations is

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

arsenm added a comment. In D80952#2067563 , @efriedma wrote: > The problem for the command-line arguments in particular is that they aren't > really new; clang has been eating them for a long time, without any warning. > So if -frounding-math crashes th

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 267756. nickdesaulniers added a comment. - missed one part of the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/include/clang/Basic/Code

[PATCH] D80858: [HIP] Support accessing static device variable in host code

tra added a comment. In D80858#2067537 , @JonChesterfield wrote: > The value is based on llvm::sys::Process::GetRandomNumber(). So unless one > provides a build-system-derived uuid for every compilation unit, recompiling > identical source will yield an

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

wolfgangp added a comment. Hi! Shortly after this patch went in, we started to see intermittent failures with the unittest TUSchedulerTests.ManyUpdates. The build server (Windows) we're running it on is quite powerful and our own hand-run tests only take about 400 ms, so we don't really unders

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 267751. nickdesaulniers added a comment. - rebase on 1b6d29e06b07e518025b6f06445ad3275d6f5684 and D80840 (no other changes yet) Repository: rG

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 267750. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

efriedma added a comment. The problem for the command-line arguments in particular is that they aren't really new; clang has been eating them for a long time, without any warning. So if -frounding-math crashes the compiler, that's a regression. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D80858: [HIP] Support accessing static device variable in host code

JonChesterfield added a comment. The value is based on llvm::sys::Process::GetRandomNumber(). So unless one provides a build-system-derived uuid for every compilation unit, recompiling identical source will yield an observably different binary. The distinction between 'unique' and 'random' is s

[PATCH] D80876: [clang] Default to windows response files when running on windows

rnk added a comment. This seems wrong for mingw, so check with @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org/D80876 ___ cfe-commits mailing list cfe-commi

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4738-4739 +bool ConversionOk = tryConvertToTy(*this, Context.getSizeType(), &ConvExpr); +assert(ConversionOk && + "should be able to convert any integer type to size type"); +ret

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire created this revision. steveire added reviewers: sammccall, aaron.ballman, gribozavr2, ymandel, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire updated this revision to Diff 267750. steveire added a comment. Update IgnoreUnlessSpelledInSource mode

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

leonardchan added a comment. @rjmccall Would it be fine to submit this since you gave LGTM on D72959 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/ https://reviews.llvm.org/D77592 ___

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a subscriber: wdng. If this chooses to just blindly ignore the setting, how is development supposed to be done on other targets? I'd prefer if this behaved more like -fg

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Thanks for working on this! I have a number of suggestions inline. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:44 /// AST files at this

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev updated this revision to Diff 267743. ABataev added a comment. Reworked after comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80925/new/ https://reviews.llvm.org/D80925 Files: clang/include/clang/Basic/TokenKinds.def clang/lib/

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

efriedma added a comment. > Clang :: Misc/warning-flags.c Like the file says, all warnings should be controlled by a -W flag. If you're going to add a new warning, you need a corresponding flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

akhuang added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:886 + } // FIXME: Path to compiler and command line. PDB is intentionally blank unless // we implement /Zi type servers. Can the 'path to compiler and command line' p

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. vitalybuka added a child revision: D80908: [StackSafety] Add info into function summary. Depends on D80847

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267731. vitalybuka marked an inline comment as done. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 Files: clang/lib/CodeGen/Ba

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10676 +ConstantSDNode *C = dyn_cast(Dup->getOperand(0)); +uint64_t ExtVal = C->getZExtValue(); + kmclaughlin wrote: > efriedma wrote: > > Do you need to truncate E

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

kpn created this revision. kpn added reviewers: cameron.mcinally, craig.topper, andrew.w.kaylor, spatel, wristow, nemanjai. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. kpn added a comment. This currently triggers a failure in test "Clang :: Misc/warning-flags.c

[PATCH] D80952: [FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support.

kpn added a comment. This currently triggers a failure in test "Clang :: Misc/warning-flags.c". Suggestions on how to fix that correctly are welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 _

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 267725. cchen added a comment. - Use PointerIntPair to pass non-contiguous information in AST - Error out in Sema if we don't have enough size information for cases involving pointers - Allows `*arr[N][M]` since we don't need size information for the last dime

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, klimek, curdeius, JakeMerdichAMD, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. Herald added a reviewer: bollu. https://bugs.llvm.org/show_bug.cgi?id=44542 https://bugs.llvm.org/show_bug

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. Herald added a subscriber: sstefan1. I documented the issue reported by @yaxunl here, https://bugs.llvm.org/show_bug.cgi?id=46166, and take ownership of the bug. Thanks for the report. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 959517a - Clean up clang/test/CodeGenObjC/os_log.m

Author: Akira Hatanaka Date: 2020-06-01T13:47:20-07:00 New Revision: 959517ace1cd9e8bcd0af3be6259dd4d78a9bd84 URL: https://github.com/llvm/llvm-project/commit/959517ace1cd9e8bcd0af3be6259dd4d78a9bd84 DIFF: https://github.com/llvm/llvm-project/commit/959517ace1cd9e8bcd0af3be6259dd4d78a9bd84.diff

[clang] 6bedfaf - [analyzer][MallocChecker] Fix the incorrect retrieval of the from argument in realloc()

Author: Kirstóf Umann Date: 2020-06-01T22:38:29+02:00 New Revision: 6bedfaf5200474f9a72b059f0d99dd39ece1c03e URL: https://github.com/llvm/llvm-project/commit/6bedfaf5200474f9a72b059f0d99dd39ece1c03e DIFF: https://github.com/llvm/llvm-project/commit/6bedfaf5200474f9a72b059f0d99dd39ece1c03e.diff

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cfded350a7e: [PowerPC] Add clang option -m[no-]pcrel (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80757/new/ https://reviews.llvm.org/D

[clang] 7cfded3 - [PowerPC] Add clang option -m[no-]pcrel

Author: Lei Huang Date: 2020-06-01T15:34:59-05:00 New Revision: 7cfded350a7edc87f4a67f84e4261e44954600d0 URL: https://github.com/llvm/llvm-project/commit/7cfded350a7edc87f4a67f84e4261e44954600d0 DIFF: https://github.com/llvm/llvm-project/commit/7cfded350a7edc87f4a67f84e4261e44954600d0.diff LOG

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane updated this revision to Diff 267714. erichkeane added a comment. Attempt improvements based on feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80947/new/ https://reviews.llvm.org/D80947 Files: llvm/docs/CodingStandards.rst Index: llvm/docs/CodingStandards.rst ===

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane marked 4 inline comments as done. erichkeane added inline comments. Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements +

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

jdoerfert added a comment. Thanks for finally writing this down :) Two minor comments. Comment at: llvm/docs/CodingStandards.rst:1580 +statement is accompanied by a comment that loses its meaning if hoisted above the if +or loop statement, or where the single statement is comp

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267710. vitalybuka marked an inline comment as done. vitalybuka added a comment. SmallPtrSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 Files: clang/lib/CodeG

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; eugenis wrote: > vitalybuka wrote: > > eugenis wrote: > > > Alloca order c

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. In D80828#2067110 , @MaskRay wrote: > (You can change `[Clang]` to `[Driver]` as `[Clang]` may carry less > information. `[Driver]` emphasizes this is related to clangDriver. Nothing in > sema/codegen/analyzer/etc is affe

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1580 +statement is accompanied by a comment that loses its meaning if hoisted above the if +or loop statement, or where the single statement is complex enough that it stops being +clear that

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev added a comment. In D80925#2067145 , @rjmccall wrote: > In D80925#2066915 , @ABataev wrote: > > > In D80925#2066728 , @rjmccall > > wrote: > > > > > Narrowly this se

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/docs/CodingStandards.rst:1582 +clear that it is a single line. Note that comments should only be hoisted for loops and +'if', and not in 'else if'

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

rjmccall added a comment. In D80925#2066915 , @ABataev wrote: > In D80925#2066728 , @rjmccall wrote: > > > Narrowly this seems to fix the immediate problem, but I feel like we're in > > trouble if tentative parsing

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:964 +<< Opts.BBSections; + } + grimar wrote: > Doesn't seem you need "{}" around this li

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added a comment. In D60620#2064839 , @yaxunl wrote: > It means HIP will create two compilation passes: one for gfx908 and one for > gfx908:xnack+:sramecc+. OK, so empty feature list may also be valid. > > >> One thing you'll need is a way to norm

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

MaskRay accepted this revision. MaskRay added a comment. (You can change `[Clang]` to `[Driver]` as `[Clang]` may carry less information. `[Driver]` emphasizes this is related to clangDriver. Nothing in sema/codegen/analyzer/etc is affected.) Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. Re testing, you could copy clang/test/Driver/at_file_win.c, which has an explicit `--rsp-quoting=windows`; remove that option and make it `REQUIRES: system-windows`. That should do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please address small documentation nitpick before committing... Btw does your change fix this bug: https://bugs.llvm.org/show_bug.cgi?id=33103 Comment at

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

lebedev.ri added a comment. SGTM Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements +^ `case` too Reposito

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. Thanks for taking another look at this, @efriedma! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10676 +ConstantSDNode *C = dyn_cast(Dup->getOperand(0)); +uint64_t ExtVal = C->getZE

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 267695. kmclaughlin marked 7 inline comments as done. kmclaughlin added a comment. - Restricted the illegal types which should be lowered for EXTRACT_SUBVECTOR to those handled in this patch (nxv8i8, nxv4i16 & nxv2i32) - Removed unnecessary changes in Rep

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

tra added a comment. In D80897#2066952 , @jdoerfert wrote: > In D80897#2066723 , @tra wrote: > > > Hmm. I'm pretty sure tensorflow is using std::complex for various types. > > I'm surprised that we haven't seen the

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3f88d2f50d: [Matrix] Implement matrix index expressions ([][]). (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D76791?vs=267601&id=267701#toc Repository: rG LLVM Github Mono

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, jdoerfert, jroelofs. Herald added a project: LLVM. This is a rule that seems to have been enforced for the better part of the decade, so we should document it for new contributors. Repository: rG LLVM Github Monorepo

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. It looks like your patch will allow us to remove a private patch that has a similar effect. Incidentally if I apply this to an upstream checkout on Windows, I see clang/test/Driver/at_file.c fails, so you'd at least need to do something for that. (`UNSUPPORTED: system

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267700. nickdesaulniers added a comment. - double backticks in release notes, -O1 rather than -O2 in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 Files

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

MaskRay added inline comments. Comment at: clang/test/Driver/frame-pointer-elim.c:125 +// For Android, keep the framepointers always. +// RUN: %clang -### -target armv7a-linux-androideabi- -marm -O2 -S %s 2>&1 | \ +// RUN: FileCheck --check-prefix=KEEP-ALL %s `

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 267693. yaxunl added a comment. emit empty target id module flag if no -target-cpu is set CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks, Nick, for cleaning this up and always striving to make things more compatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_cuda_complex_builtins.h:136-137 + __d = _COPYSIGNf(_ISINFf(__d) ? 1 : 0, __d); + if (_ISNANf(__a)) +__a = _COPYSIGNf(0, __a); + if (_ISNANf(__b)) Why does this try to prese

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Oh, meant to approve on the last. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80883/new/ https://reviews.llvm.org/D80883 __

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

dblaikie added a comment. Seems like a reasonable direction - presumably every flag (that has a similar form in both driver and frontend) would be classified as one of these (opt in or opt out)? The ones you've migrated are just a sample/example? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80771: [MTE] Convert StackSafety into analysis

eugenis added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; vitalybuka wrote: > eugenis wrote: > > Alloca order can easily change in the future. Not sure how to make this > > better

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn marked an inline comment as done. fhahn added a comment. Thanks for all the feedback John! Comment at: clang/lib/CodeGen/CGExpr.cpp:3787 + ColIdx->getType()->getScalarSizeInBits()); + llvm::Type *IntTy = llvm::IntegerType::get(getLLVMContext

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram marked an inline comment as done. tmsriram added a comment. In D68049#2066937 , @MaskRay wrote: > LLD side changes look good. Are you waiting on an explicit approval from > @rmisth ? Yes. Comment at: lld/ELF/LTO.cpp:79 //

[clang] 8f3f88d - [Matrix] Implement matrix index expressions ([][]).

Author: Florian Hahn Date: 2020-06-01T20:08:49+01:00 New Revision: 8f3f88d2f50d97011bf48ccc507bef033715e566 URL: https://github.com/llvm/llvm-project/commit/8f3f88d2f50d97011bf48ccc507bef033715e566 DIFF: https://github.com/llvm/llvm-project/commit/8f3f88d2f50d97011bf48ccc507bef033715e566.diff

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen created this revision. ychen added reviewers: ABataev, jdenny, lebedev.ri, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Right now it is a '' for cases like this. CounterCoverageMappingBuilder relies on the information to decide the region for a attrib

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan updated this revision to Diff 267684. leonardchan added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836 Files: clang/include/clang/Sema/Initialization.h clang/lib/Sema/Sem

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D80897#2066723 , @tra wrote: > Hmm. I'm pretty sure tensorflow is using std::complex for various types. I'm > surprised that we haven't seen these functions missing. Which functio

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added a comment. LLD side changes look good. Are you waiting on an explicit approval from @rmisth ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267683. nickdesaulniers added a comment. - update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 Files: clang/lib/Basic/Targets/ARM.cpp clang/

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267682. nickdesaulniers added a comment. - prefer Triple#isAndroid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 Files: clang/lib/Basic/Targets/ARM.cpp cl

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith added a comment. Clang side of these changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

amccarth accepted this revision. amccarth added a comment. Yowza. Mingw still links against MSVCRT?! Anyway, I think the patch is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80880/new/ https://reviews.llvm.org/D80880 __

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang

lebedev.ri added a comment. Why not lower it to `@llvm.cttz(and(a, b))`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 ___ cfe-commits mailing list cfe-commit

  1   2   >