tra added a comment.

In D80858#2067537 <https://reviews.llvm.org/D80858#2067537>, @JonChesterfield 
wrote:

> The value is based on llvm::sys::Process::GetRandomNumber(). So unless one 
> provides a build-system-derived uuid for every compilation unit, recompiling 
> identical source will yield an observably different binary.
>
> The distinction between 'unique' and 'random' is significant for anyone 
> depending on repeatable binary output, so this patch should probably rename 
> 'unique' to 'random' everywhere.


+1. Reproducible builds is something we do pay attention to. We've had similar 
issue with -fcuda-rcd compilation and I think ended up generating the ID by 
deriving it from the input file name. It works reasonably well in most 
situations except the cases when the same file is recompiled multiple times 
with different preprocessor macros set.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80858/new/

https://reviews.llvm.org/D80858



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to