vsk marked an inline comment as done. vsk added inline comments.
================ Comment at: test/CodeGenObjCXX/os_log.mm:3 +// RUN: -fexceptions -fcxx-exceptions -O1 | FileCheck %s + +// Check that no EH cleanup is emitted around the call to __os_log_helper. ---------------- ahatanak wrote: > Sorry for the late feedback. > > Can we pass `-O0` instead of `-O1` to avoid running the optimization passes > and just check that the helper function has attribute `nounwind`? I haven't > checked, but I suspect there are already tests in llvm that check > `SimplifyCFG` turns `nounwind` invokes to calls. > > I'm cleaning up this file and `os_log.m` in preparation for adding more test > cases. Done in a66e1d2aa943959e158821be8956109cb5ef3b3b. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60108/new/ https://reviews.llvm.org/D60108 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
