[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

rjmccall added a comment. I'm sympathetic to wanting to get rid of the boolean flag, but this is a really invasive change for pretty minimal benefit. Why not leave `VectorType::get` as meaning a non-scalable vector type and come up with a different method name to get a scalable vector? Repos

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin updated this revision to Diff 265432. aheejin added a comment. - Fix warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/docs/DiagnosticsReference.rst clang/include/clan

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { This diagnostic actually ignores the tag kind that passed down to it, which

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

davidstone added inline comments. Herald added a subscriber: sstefan1. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType &M, const NodeType &N) { !(M == N); } Missing `return` Repository: rG LLVM Github Monor

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In D80061 we added warning for exception specifications with types (such as `throw(int)`), b

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev created this revision. hyd-dev added reviewers: erik.pilkington, rsmith. hyd-dev added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. hyd-dev edited the summary of this revision. hyd-dev edited the summary of this revision. D62825 add

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added a comment. Sorry for the slow review; I'm getting crushed with review requests. Comment at: clang/lib/AST/Expr.cpp:3859 + + auto *SubscriptE = dyn_cast(this); + return SubscriptE You need to `IgnoreParens()` here. Comment at:

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

rjmccall added a comment. Is there a good reason for this to use the same `llvm.assume` intrinsic as before? Are there restrictions about what assumptions can be combined on a single intrinsic call? There can only be one bundle of a particular name on an instruction, right? ===

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan updated this revision to Diff 265423. skan marked an inline comment as done. skan added a comment. Refactor addX86AlignBranchArgs to be reused in CommonArgs.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80289/new/ https://reviews.llvm.org/

[PATCH] D80356: `cc1as -fdebug-compilation-dir` needs -integrated-as

ychen created this revision. ychen added a reviewer: thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80356 Files: clang/test/Driver/clang_f_opts.c Index: clang/test/Driver/clang_f_opts.c ==

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan updated this revision to Diff 265408. skan marked an inline comment as done. skan added a comment. Move tests to x86-malign-branch.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80289/new/ https://reviews.llvm.org/D80289 Files: clang/lib/D

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 265405. michele.scandale added a comment. Fix formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. Just want to follow up and see if anything is missing from the latest patch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 ___ cfe-c

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jfb added a comment. In D71726#2047566 , @ldionne wrote: > In D71726#1791904 , @jfb wrote: > > > This generally seems fine. Does it work on most backends? I want to make > > sure it doesn't fail in backends :) > >

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked 3 inline comments as done. jhuber6 added a comment. Here's the tests it fails, there might be a few that are wrong for reasons beyond the size_t stuff but it's hard to tell until that issue is resolved. The cuda test is just because I have CUDA set up incorrectly on my machine, li

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > It looks like this patch will reject the following code, which used to > compile fine: > > $ cat test.cpp > #include > > typedef CF_ENUM(unsigned, TestEnum) { > A = 2, > B = 3,

[PATCH] D80294: Add support for vmsumudm

amyk added a comment. I think this overall looks good, but just curious, why was the builtin support removed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-commits

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

tentzen created this revision. tentzen added reviewers: andrew.w.kaylor, rnk, majnemer, pengfei, eli.friedman, JosephTremoulet, asmith. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, kbarton, hiraditya, kristof.beyls, nemanjai. Herald added projects: clang, LLVM. This patch adds

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265388. zequanwu edited the summary of this revision. zequanwu added a comment. Check `LambdaContextDecl` is not `ParamVarDecl`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/Micros

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jyknight added a comment. In the commit message, you refer to the preferred alignemtn as the "true" alignment, but that's misleading. As discussed on the mailing list thread, it's not true alignment at all. Comment at: clang/include/clang/AST/RecordLayout.h:74 + /// The maxi

[clang] 51dbda5 - [clang-format][docfix] Update predefined styles in docs

Author: Jake Merdich Date: 2020-05-20T20:03:53-04:00 New Revision: 51dbda54384827533dcfcb712f918cee7acc3185 URL: https://github.com/llvm/llvm-project/commit/51dbda54384827533dcfcb712f918cee7acc3185 DIFF: https://github.com/llvm/llvm-project/commit/51dbda54384827533dcfcb712f918cee7acc3185.diff

[clang] 48a8c7d - [analyzer] Make buildbots happy

Author: Kirstóf Umann Date: 2020-05-21T01:54:50+02:00 New Revision: 48a8c7dcbfb90e917920e90fa2b3ec402e72f4cd URL: https://github.com/llvm/llvm-project/commit/48a8c7dcbfb90e917920e90fa2b3ec402e72f4cd DIFF: https://github.com/llvm/llvm-project/commit/48a8c7dcbfb90e917920e90fa2b3ec402e72f4cd.diff

Re: [clang] 1d393ea - [analyzer] Fix a null FunctionDecl dereference bug after D75432

Yup, I'm working on it already, thanks. On Thu, 21 May 2020 at 01:36, Nico Weber wrote: > This breaks tests: http://45.33.8.238/linux/18215/step_7.txt > > On Wed, May 20, 2020 at 7:05 PM Kirstóf Umann via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: Kirstóf Umann >> Date: 2

Re: [clang] 1d393ea - [analyzer] Fix a null FunctionDecl dereference bug after D75432

This breaks tests: http://45.33.8.238/linux/18215/step_7.txt On Wed, May 20, 2020 at 7:05 PM Kirstóf Umann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kirstóf Umann > Date: 2020-05-21T01:05:15+02:00 > New Revision: 1d393eac8f6907074138612e18d5d1da803b4ad0 > > URL: > https://g

[PATCH] D69585: Add option to instantiate templates already in the PCH

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm IMO there is a pretty clear performance use case for this mode of operation, and it seems to me that you have addressed @rsmith's feedback. Please wait a few days to see if he has more to add,

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

rnk added a comment. After looking at the code more, I'm more convinced that your fix is in the right place. Comment at: clang/lib/AST/MicrosoftMangle.cpp:954 if ((isa(LambdaContextDecl) || - isa(LambdaContextDecl)) && -LambdaContex

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 3 inline comments as done. yaxunl added a comment. In D71726#2047566 , @ldionne wrote: > In D71726#1791904 , @jfb wrote: > > > This generally seems fine. Does it work on most backends? I want to make

[PATCH] D75432: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

Szelethus added a comment. rG1d393eac8f6907074138612e18d5d1da803b4ad0 should fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75432/new/ https://reviews.llvm.org/D75432

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

Hi Richard, It looks like this patch will reject the following code, which used to compile fine: $ cat test.cpp #include typedef CF_ENUM(unsigned, TestEnum) { A = 2, B = 3, }; $ clang++ -std=c++11 -c test.cpp test.cpp:3:9: error: non-defining declaration of enumeration with a fixed unde

[clang] 1d393ea - [analyzer] Fix a null FunctionDecl dereference bug after D75432

Author: Kirstóf Umann Date: 2020-05-21T01:05:15+02:00 New Revision: 1d393eac8f6907074138612e18d5d1da803b4ad0 URL: https://github.com/llvm/llvm-project/commit/1d393eac8f6907074138612e18d5d1da803b4ad0 DIFF: https://github.com/llvm/llvm-project/commit/1d393eac8f6907074138612e18d5d1da803b4ad0.diff

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added a comment. Oh, wait, I was looking at the C11 version. This diagnostic needs to be restricted to C99 or earlier, and only to relational comparisons, I think. And given it isn't really a valuable diagnostic, I think it should be off by default (an "Extension" diagnostic). Repos

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. We pass all clang tests, right? Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:203 + static Function *getOrCreateRuntimeFunction(Module &Md, + omp::RuntimeFunction FnID); N

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added a comment. I'm not sure how you derive this requirement from the standard; the section in question doesn't use the words "complete" or "incomplete" at all. Am I missing something obvious? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

mattdr added a comment. Took a quick look and seems sane -- will look after Craig's comment is addressed and build is passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 _

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

jdoerfert added a comment. In D79744#2047482 , @arsenm wrote: > For the purpose here, only the callee exists. This is essentially a > freestanding function, the entry point to the program. There is no caller > function, and in the future I would like to

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

craig.topper added a comment. In D80251#2046564 , @spatel wrote: > Is it possible to fix those other 5 in the Intel docs for consistency, or is > there some functional reason that those are different? I think it was just a mistake. The docs are derived

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

rnk added inline comments. Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:3457 + if (Diags.isIgnored(diag::warn_profile_data_misexpect, SourceLocation())) +Res.FrontendOpts.LLVMArgs.push_back("-pgo-warn-misexpect"); + Clang generally tries to avoi

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov added a comment. Just a ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/IndexActionTests.cpp:22 using ::testing::ElementsAre; +using testing::EndsWith; using ::testing::Not; ---

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2283 + unsigned Src2Reg = Inst.getOperand(1).getReg(); + if (DestReg == Src2Reg) +return Error(Loc, "The destination vecto

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau created this revision. Herald added subscribers: cfe-commits, dmgreen, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added reviewers: david-arm, fpetrogalli, ddunbar, rjmccall. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

rnk added a comment. Personally, I support this. I never liked the magic `ld.` prefixing. If we want a way to select a proprietary linker, it seems reasonable to ask the user to name the complete binary basename (`ld.lld`, `lld`, `ld64`, `myld`, etc). The driver shouldn't force the linker to us

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/include/clang/AST/RecordLayout.h:74 + /// The maximum allowed field alignment. This is set by #pragma pack. + CharUnits MaxFieldAlignment; + jasonliu wrote: > efriedma wrote: > > If we have to keep around extra

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

ldionne added a comment. In D71726#1791904 , @jfb wrote: > This generally seems fine. Does it work on most backends? I want to make sure > it doesn't fail in backends :) > > Also, @ldionne / @EricWF / @mclow.lists do you need this in libc++ for > floatin

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

Anastasia added subscribers: jeroen.dobbelaere, rjmccall. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10090 // if both are pointers check if operation is valid wrt address spaces - if (S.getLangOpts().OpenCL && isLHSPointer && isRHSPointer) { + i

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

ldionne added inline comments. Comment at: clang/test/CodeGen/atomic-ops.c:296 + // CHECK: fsub + return __atomic_sub_fetch(p, 1.0, memory_order_relaxed); +} Sorry if that's a dumb question, but I'm a bit confused: `p` is a `float*`, but then we add a double

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

mibintc added a comment. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl added a comment. @efriedma I think you were the last person to touch this code regarding cases where pointer comparisons are invalid. Could you have a look at my changes and gimme some feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1531 +/// \endcode +/// +/// \code @MarcusJohnson91 I had to make a couple of minor changes before committing 1) it needed rebasing (because of changes from this m

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ef45b0426a8: [clang-format] Added new option IndentExternBlock (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D75791?vs=264916&id=265337#toc Repository: rG LLVM Gith

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay added a comment. I think we should take these tests now once they are landed, and we can begin to flesh them out with for() , do(), while() if() conditions so we always know we are not breaking the default style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 265333. michele.scandale added a comment. Fix 'clang/test/CodeGenCUDA/library-builtin.cu' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 Files: clang/includ

[PATCH] D80294: Add support for vmsumudm

saghir updated this revision to Diff 265332. saghir edited the summary of this revision. saghir added a comment. Removing the builtin support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 Files: clang/include/clang/Basic/BuiltinsPPC.def l

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71726#2039319 , @arsenm wrote: > In D71726#1801346 , @__simt__ wrote: > > > In D71726#1792852 , @yaxunl w

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2040731 , @rjmccall wrote: > In D79744#2040434 , @jdoerfert wrote: > > > In D79744#2040380 , @rjmccall > > wrote: > > > > > In D79744#20403

[clang] 6ef45b0 - [clang-format] Added new option IndentExternBlock

Author: mydeveloperday Date: 2020-05-20T21:27:15+01:00 New Revision: 6ef45b0426a8c7b9764e102fb1a49561a3a2c118 URL: https://github.com/llvm/llvm-project/commit/6ef45b0426a8c7b9764e102fb1a49561a3a2c118 DIFF: https://github.com/llvm/llvm-project/commit/6ef45b0426a8c7b9764e102fb1a49561a3a2c118.diff

[clang] 166ebef - [clang-format] Set of unit test to begin to validate that we don't change defaults

Author: mydeveloperday Date: 2020-05-20T21:11:10+01:00 New Revision: 166ebefd27ac71e3f911f3d7ba0e168464d372af URL: https://github.com/llvm/llvm-project/commit/166ebefd27ac71e3f911f3d7ba0e168464d372af DIFF: https://github.com/llvm/llvm-project/commit/166ebefd27ac71e3f911f3d7ba0e168464d372af.diff

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2533 + hasFloatingPointAsFirstMember(RD, MaxFieldAlignment)) +return std::max(ABIAlign, (unsigned)toBits(CharUnits::fromQuantity(8))); +} I guess another thing that wor

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay updated this revision to Diff 265331. MyDeveloperDay added a comment. Adding WebKitStyle() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.c

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 _

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader created this revision. bader added a reviewer: Anastasia. Herald added subscribers: cfe-commits, ebevhan, yaxunl. Herald added a project: clang. bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10090 // if both

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 265329. DmitryPolukhin added a comment. Fixed second string after new line + more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/includ

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10090 // if both are pointers check if operation is valid wrt address spaces - if (S.getLangOpts().OpenCL && isLHSPointer && isRHSPointer) { + if ((S.getLangOpts().Op

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 265325. yaxunl added a reviewer: arsenm. yaxunl added a comment. Herald added a subscriber: wdng. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay added a comment. In D80225#2046154 , @theraven wrote: > I'm a bit nervous about this. I'm aware of at least one out-of-tree > toolchain that uses this mechanism to select their proprietary linker. I'd > expect an RFC and for this to be highligh

[PATCH] D79966: [OPENMP]Fix PR45911: Data sharing and lambda capture.

This revision was automatically updated to reflect the committed changes. Closed by commit rG414afdf940e8: [OPENMP]Fix PR45911: Data sharing and lambda capture. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79966/new/ https://

[PATCH] D75323: Support relative dest paths in headermap files

vsapsai added a comment. There is nothing in header maps preventing from using relative paths. For example, I was able to run one of the tests with relative paths like ./bin/clang -cc1 -fsyntax-only ../../../llvm-project/clang/test/Preprocessor/headermap-rel.c -I ./tools/clang/test/Preproces

[PATCH] D80309: [clang-format][docfix] Update predefined styles in docs

curdeius added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80309/new/ https://reviews.llvm.org/D80309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 414afdf - [OPENMP]Fix PR45911: Data sharing and lambda capture.

Author: Alexey Bataev Date: 2020-05-20T15:01:02-04:00 New Revision: 414afdf940e8473db4156d0c1bc500ec527f1a1f URL: https://github.com/llvm/llvm-project/commit/414afdf940e8473db4156d0c1bc500ec527f1a1f DIFF: https://github.com/llvm/llvm-project/commit/414afdf940e8473db4156d0c1bc500ec527f1a1f.diff

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

njames93 added a comment. Running most of the clang tidy checks on the clang-tidy folder yields these results =BeforePatch=== RUN1: 4045.17user 83.93system 11:28.80elapsed 599%CPU (0avgtext+0avgdata 534024maxresident)k

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 265306. nickdesaulniers added a comment. - add enum class test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D80288: [AST] default implementation is possible for non-member functions in C++2a.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good subject to some comment tweaks. Comment at: clang/include/clang/AST/Decl.h:2128 - /// Whether this function is defaulted per C++0x. Only valid for - /// specia

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

vsavchenko accepted this revision. vsavchenko added a comment. LGTM! Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 ___ cfe-commits mailing list

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu added inline comments. Comment at: clang/include/clang/AST/RecordLayout.h:74 + /// The maximum allowed field alignment. This is set by #pragma pack. + CharUnits MaxFieldAlignment; + efriedma wrote: > If we have to keep around extra data anyway, probabl

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale marked an inline comment as done. michele.scandale added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:14 // FINITE: fdiv nnan ninf float - // UNSAFE: fdiv nnan nsz float + // UNSAFE: fdiv reassoc nsz arcp afn float // MAD: fdiv

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale marked 2 inline comments as done. michele.scandale added inline comments. Comment at: clang/test/CodeGen/libcalls.c:11-21 + // CHECK-FAST: call reassoc nsz arcp afn float @llvm.sqrt.f32(float float l0 = sqrtf(a0); // CHECK-YES: call double @sqrt // CH

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale created this revision. michele.scandale added reviewers: rjmccall, mibintc, Anastasia. Herald added subscribers: cfe-commits, jvesely. Herald added a project: clang. michele.scandale marked an inline comment as done. michele.scandale added inline comments. michele.scandale marked 2

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! This is probably not the precise solution (i.e., we might be able to see where exactly is the reference taken and proceed from there) but neither is the original code - it's al

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

fpallares added a comment. Hi Kai, I've added an inline comment regarding constraint validation: Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2283 + unsigned Src2Reg = Inst.getOperand(1).getReg(); + if (DestReg == Src2Reg) +return Error(Loc,

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

gribozavr2 added a comment. + Argyrios for libclang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80126/new/ https://reviews.llvm.org/D80126 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

fpallares added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D69987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D75323: Support relative dest paths in headermap files

thakis added a comment. I don't know why we (chromium) want to use header maps, but assuming we do want to use them: The problem with absolute paths is that they're machine-dependent and can't be run on other machines and then cached globally. See also http://blog.llvm.org/2019/11/deterministic

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

owenv added a comment. Reviewers added are a best guess based on arc cover. Sorry if I made a mistake, it's my first time contributing to LLVM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80126/new/ https://reviews.llvm.org/D80126 ___

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

owenv updated this revision to Diff 265294. owenv added a comment. Updated terminology to generalize the feature so Clang diagnostics can adopt it in the future. Also switched from local paths to URLs so local and remote documentation can both be supported if desired Repository: rG LLVM Gith

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim updated this revision to Diff 265293. fghanim added a comment. Addressing more reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/ https://reviews.llvm.org/D79675 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 265292. DmitryPolukhin added a comment. Fix clang-tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/Replacements

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked an inline comment as done. fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPConstants.cpp:86 + llvm::omp::types::Int8PtrPtr = Int8Ptr->getPointerTo(); + llvm::omp::types::Int8PtrPtrPtr = Int8PtrPtr->getPointerTo(); + fghanim

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1845 + +// V8.2-A BFloat intrinsics +let ArchGuard = "defined(__ARM_FEATURE_BF16_VECTOR_ARITHMETIC)" in { labrinea wrote: > v8.6-A ? Yes V8.2-A,

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 10 inline comments as done. fghanim added a comment. In D79675#2045826 , @jdoerfert wrote: > In D79675#2045563 , @fghanim wrote: > > > So this whole thing was about moving Def.s out of `CGOMPRuntime`?

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

This revision was automatically updated to reflect the committed changes. Closed by commit rG60ee88599098: [clang][asm goto][slh] Warn if asm goto + SLH (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.ll

[PATCH] D80294: Add support for vmsumudm

saghir updated this revision to Diff 265281. saghir added a comment. Added vec_msum builtin for vmsumudm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/te

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 265282. zbrid added a comment. ClangFormat diagnostic definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files: clang/include/clang/Basic/DiagnosticCommonKinds.

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/abseil-string-find-str-contains.rst:4 +abseil-string-find-str-contains += + Please make same length as title. Repository: rG LLVM Github Mo

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

labrinea added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1845 + +// V8.2-A BFloat intrinsics +let ArchGuard = "defined(__ARM_FEATURE_BF16_VECTOR_ARITHMETIC)" in { v8.6-A ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD added a comment. Just belatedly caught something: Webkit style is supported too but not listed here. Can you add that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214 _

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn updated this revision to Diff 265279. john.brawn added a comment. Adjusted to not give multiple errors when more than one error criteria is met. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80295/new/ https://reviews.llvm.org/D80295 Files: clang/lib/Sema/SemaDecl.cpp cl

[PATCH] D80309: [clang-format][docfix] Update predefined styles in docs

JakeMerdichAMD created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, mitchell-stellar, sammccall. JakeMerdichAMD added a project: clang-format. The predefined styles that clang-format supports are li

[clang] 60ee885 - [clang][asm goto][slh] Warn if asm goto + SLH

Author: Zola Bridges Date: 2020-05-20T09:46:18-07:00 New Revision: 60ee885990982197013c71ff965a81e938184fd2 URL: https://github.com/llvm/llvm-project/commit/60ee885990982197013c71ff965a81e938184fd2 DIFF: https://github.com/llvm/llvm-project/commit/60ee885990982197013c71ff965a81e938184fd2.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. probably should add a test for `enum class` in C++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list

  1   2   >