rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
Looks good subject to some comment tweaks. ================ Comment at: clang/include/clang/AST/Decl.h:2128 - /// Whether this function is defaulted per C++0x. Only valid for - /// special member functions. + /// Whether this function is defaulted per C++0x. Valid for e.g. + /// special member functions, C++2a friend default comparisions ---------------- In passing, please remove the "per C++0x" here and below. This isn't a new thing whose existence we need to remind readers of any more! Also, replace "C++2a" with "C++20" or remove that too; C++20 is complete so we shouldn't be using its pre-release codename any more. The term is "defaulted comparisons", not "default comparisons". (I'd also remove the "friend" since that's at best incidental, especially after http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2085r0.html). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80288/new/ https://reviews.llvm.org/D80288 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
