[PATCH] D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks

Szelethus added a comment. @Charusso implemented a flag that can //silence// checkers in D66042 . I can offer that as an alternative while we're working on separating modeling and reporting in the checker insfrastructure. Repository: rG LLVM Github Monorepo

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet updated this revision to Diff 246635. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ https://reviews.llvm.org/D75106 Files: clang-tools-ex

[PATCH] D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks

Szelethus added reviewers: NoQ, Szelethus, baloghadamsoftware. Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. This doesn't seem to be in line with the current idea behind `core` checkers. Turning them off is strongly disenco

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert updated this revision to Diff 246630. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 Files: clang/inclu

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert added a comment. In D59319#1892544 , @JonChesterfield wrote: > I'd like to rebase this on the current deviceRTL, and add any nvptx/amdgcn > specific hooks if necessary. Any objections? No generic objections. Please take a look at the TRegion

[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. BRANCHES master /clang/test/OpenMP/PR44893.c:3 > Can you add some sort of positive test, related to where the crash was? I did, in deduplication.ll. > If this was a debug info related crash, maybe you can test that

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis updated this revision to Diff 246628. zinovy.nis added a comment. Warning on use after move is still generated. But there's also an additional note > std::move of the const expression has no effect; remove std::move() or make > the variable non-const CHANGES SINCE LAST ACTION h

Re: Buildbot cleaning for zorg upgrade

Looking forward to the upgrade. Thanks for investing the time. I am trying to re-add buildbots for polly-x86_64 (https://reviews.llvm.org/D75127) and I am not use whether you received my messages about it. In any case, would you prefer to wait until the new instance of buildbot-master is available

Buildbot cleaning for zorg upgrade

Hello everyone, Zorg upgrade to a recent version of buildbot is coming. We would do our best to make the transition as smooth and transparent to the majority of LLVM community, as possible. The process will be handled similar to how we did the github transition. As the next step, we will be clea

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea created this revision. aganea added reviewers: tejohnson, thakis, rnk, RobRich999. Herald added subscribers: cfe-commits, dang, dexonsmith, mikhail.ramalho, steven_wu, MaskRay, aheejin, hiraditya, arichardson, inglorion, sbc100, emaste. Herald added a reviewer: espindola. Herald added proje

[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

dexonsmith added subscribers: aprantl, cfe-commits, dexonsmith. dexonsmith added inline comments. BRANCHES master /clang/test/OpenMP/PR44893.c:1 Can you change this to a `-cc1` test (invoking `%clang_cc1`), instead of calling the driver? /clang/test/OpenMP/PR44893.c:3 Can you add some sort of

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true for MCAsmStreamer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb61a4aaca5f8: [MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true for MCAsmStreamer

MaskRay updated this revision to Diff 246616. MaskRay retitled this revision from "[MC] Default MCContext::UseNamesOnTempLabels to false and only use it for MCAsmStreamer" to "[MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true for MCAsmStreamer". MaskRay edited the sum

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246614. njames93 added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extra

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only use it for MCAsmStreamer

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75097/new/ https://reviews.llvm.org/D75097 ___

[PATCH] D75152: Fix typo

njames93 closed this revision. njames93 added a comment. In D75152#1892621 , @echristo wrote: > This probably qualifies as "obvious" :) This was arc diff screwing up and creating a new revision instead of updating :) Repository: rG LLVM Github Monore

[PATCH] D75152: Fix typo

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This probably qualifies as "obvious" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75152/new/ https://reviews.llvm.org/D75152

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 added a comment. In D75134#1892607 , @Eugene.Zelenko wrote: > It'll be reasonable to find out what are naming conventions for Python in > LLVM. I just stuck to the trusty old c++ naming conventions. Having a look I see most of it is using `lo

[clang] 6fb70c8 - [Analysis] Fix -Wrange-loop-analysis after D69876

Author: Fangrui Song Date: 2020-02-25T18:05:09-08:00 New Revision: 6fb70c87251708af8fc27b501fd79e26162f7e65 URL: https://github.com/llvm/llvm-project/commit/6fb70c87251708af8fc27b501fd79e26162f7e65 DIFF: https://github.com/llvm/llvm-project/commit/6fb70c87251708af8fc27b501fd79e26162f7e65.diff

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 added a comment. Feel free to apply this and see how it works. Tested with checks that have alias variants which seem to respond well. Renaming a check then renaming it back reverts the state to how it was before apart from release notes and maybe some non standard comments Repositor

[PATCH] D75113: [docs] dump-ast-matchers removes const from Matcher args and handles template functions slightly better

This revision was automatically updated to reflect the committed changes. Closed by commit rGb653ab0e7019: [docs] dump-ast-matchers removes const from Matcher args and handles template… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D75152: Fix typo

njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75152 Files: clang-tools-extra/clang-tidy/add_new_check.py Index: clang-tools-extra/clang-tidy/add_new_check.py =

[PATCH] D75134: [clang-tidy] Improved renamer check logic

Eugene.Zelenko added a comment. It'll be reasonable to find out what are naming conventions for Python in LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134

[clang] b653ab0 - [docs] dump-ast-matchers removes const from Matcher args and handles template functions slightly better

Author: Nathan James Date: 2020-02-26T01:56:50Z New Revision: b653ab0e70196420086a7ba16596533f533b3d1f URL: https://github.com/llvm/llvm-project/commit/b653ab0e70196420086a7ba16596533f533b3d1f DIFF: https://github.com/llvm/llvm-project/commit/b653ab0e70196420086a7ba16596533f533b3d1f.diff LOG:

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

Eugene.Zelenko added a comment. In D74669#1892577 , @jroelofs wrote: > Implement review feedback: > > - Re-purpose `HeaderFileExtensionsUtils.h` to support headers *and* sources. > - Surround file extension in diagnostic with `''`s. > > I have these as two

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

njames93 added a comment. In D74669#1892577 , @jroelofs wrote: > Implement review feedback: > > - Re-purpose `HeaderFileExtensionsUtils.h` to support headers *and* sources. > - Surround file extension in diagnostic with `''`s. > > I have these as two separ

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246610. njames93 added a comment. - Linted entire checks and moved more code into common module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files: clang-tools-ex

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only use it for MCAsmStreamer

MaskRay updated this revision to Diff 246607. MaskRay retitled this revision from "[cc1as] Unset UseNamesOnTempLabels" to "[MC] Default MCContext::UseNamesOnTempLabels to false and only use it for MCAsmStreamer". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added s

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

MaskRay added a comment. In D75097#1892545 , @efriedma wrote: > In terms of tests, we can add cc1as tests to clang/test/Misc; just need to be > marked `REQUIRES: arm-registered-target` or something like that. > > That said, if we need to write cc1as-speci

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 246604. jroelofs added a comment. Implement review feedback: - Re-purpose `HeaderFileExtensionsUtils.h` to support headers *and* sources. - Surround file extension in diagnostic with `''`s. I have these as two separate patches locally, but I don't know how

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

This revision was automatically updated to reflect the committed changes. Closed by commit rG28d38a25e963: Remove std::shared_ptr::allocate_shared (authored by zoecarver). Changed prior to commit: https://reviews.llvm.org/D66178?vs=245918&id=246599#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

efriedma added a comment. In terms of tests, we can add cc1as tests to clang/test/Misc; just need to be marked `REQUIRES: arm-registered-target` or something like that. That said, if we need to write cc1as-specific tests for anything other than the command-line parsing, probably something has g

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

JonChesterfield added a comment. I'd like to rebase this on the current deviceRTL, and add any nvptx/amdgcn specific hooks if necessary. Any objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https://reviews.llvm.org/D59319 __

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

efriedma added a comment. Does UseNamesOnTempLabels really need to be configurable? If we're going to force it to false everywhere, might as well just get rid of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75097/new/ https://reviews.llvm.or

[clang] 0e480b3 - Revert "[libTooling] Add function to determine associated text of a declaration."

Author: Nico Weber Date: 2020-02-25T19:21:52-05:00 New Revision: 0e480b39c66143ad142f9a30d8d40e49d7d7b0ce URL: https://github.com/llvm/llvm-project/commit/0e480b39c66143ad142f9a30d8d40e49d7d7b0ce DIFF: https://github.com/llvm/llvm-project/commit/0e480b39c66143ad142f9a30d8d40e49d7d7b0ce.diff LO

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

ldionne accepted this revision. ldionne added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66178/new/ https://reviews.llvm.org/D66178 ___ cfe-commits mailing list cfe-commits@lists.

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

Hi, I saw that this patch was reverted again later, but wanted to let you know the performance impact we saw with this patch. We are testing this on a variety of x86 machines and saw across the board regressions in Eigen of around 25-50%, changing no compile time options. Thanks, Rumeet On Wed,

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74912/new/ https://reviews.llvm.org/D74912 ___ cfe-commits mailing list cfe-commi

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8fdafe68ce2: [Sema] Perform call checking when building CXXNewExpr (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dd5a298bfff: [clang] Annotating C++'s `operator new` with more attributes (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/

[clang] 3dd5a29 - [clang] Annotating C++'s `operator new` with more attributes

Author: Roman Lebedev Date: 2020-02-26T01:37:17+03:00 New Revision: 3dd5a298bfff48c0939448c9b4bc987cf6bb5385 URL: https://github.com/llvm/llvm-project/commit/3dd5a298bfff48c0939448c9b4bc987cf6bb5385 DIFF: https://github.com/llvm/llvm-project/commit/3dd5a298bfff48c0939448c9b4bc987cf6bb5385.diff

[clang] b8fdafe - [Sema] Perform call checking when building CXXNewExpr

Author: Roman Lebedev Date: 2020-02-26T01:36:44+03:00 New Revision: b8fdafe68ce25b7ff4d31720548622e28db87ebf URL: https://github.com/llvm/llvm-project/commit/b8fdafe68ce25b7ff4d31720548622e28db87ebf DIFF: https://github.com/llvm/llvm-project/commit/b8fdafe68ce25b7ff4d31720548622e28db87ebf.diff

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 246575. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

steven_wu added a comment. In D74784#1891750 , @dmajor wrote: > @steven_wu, ping, could you clarify about the tests please? You want to have testcase to cover all following 3 cases: - Default (version = 0): not using -platform_version - Old version (0 <

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 396b725 - [OpenMP][Opt] Combine `struct ident_t*` during deduplication

Author: Johannes Doerfert Date: 2020-02-25T14:07:14-08:00 New Revision: 396b7253944e927878dff2f6321efabb3aaa0f45 URL: https://github.com/llvm/llvm-project/commit/396b7253944e927878dff2f6321efabb3aaa0f45 DIFF: https://github.com/llvm/llvm-project/commit/396b7253944e927878dff2f6321efabb3aaa0f45.d

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

This revision was automatically updated to reflect the committed changes. Closed by commit rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74925/new/

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri added a comment. In D73020#1892245 , @rsmith wrote: > In D73020#1891368 , @lebedev.ri > wrote: > > > In D73020#1857704 , @rsmith wrote: > > > > > Looks good if yo

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. Hello, any news on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

thakis added a comment. http://45.33.8.238/win/9173/step_7.txt Ptal! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/D72153 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D73020#1891368 , @lebedev.ri wrote: > In D73020#1857704 , @rsmith wrote: > > > Looks good if you change the

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); // TODO: Remove the hack for the binop form when the unary op is optimized // pro

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

simoll marked an inline comment as done. simoll added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); // TODO: Remove the hack for the binop form when the

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pickup the default crt and libs when the musl target is selected. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75139 File

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c54f6154f74: [libTooling] Add function to determine associated text of a declaration. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri updated this revision to Diff 246559. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://reviews.llvm.org/D73020 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExprC

[clang] 9c54f61 - [libTooling] Add function to determine associated text of a declaration.

Author: Yitzhak Mandelbaum Date: 2020-02-25T16:37:20-05:00 New Revision: 9c54f6154f748e707ad2385ddf6d66e812890c6a URL: https://github.com/llvm/llvm-project/commit/9c54f6154f748e707ad2385ddf6d66e812890c6a DIFF: https://github.com/llvm/llvm-project/commit/9c54f6154f748e707ad2385ddf6d66e812890c6a.

Re: r329762 - Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily available (such as in kernel w

It looks like we forgot to document this builtin. Can some documentation be added? On Tue, 10 Apr 2018 at 15:01, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Tue Apr 10 14:58:13 2018 > New Revision: 329762 > > URL: http://llvm.org/viewvc/llvm-p

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel added a comment. Thanks for the detailed review, especially given the complexity of the code! Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:152 +// will not break anything that removing the entity wouldn't have +// already broken. + bool TerminatedBy

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 246556. ymandel marked 8 inline comments as done. ymandel added a comment. Responded to all comments. No functional changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/D72

[PATCH] D75113: [docs] dump-ast-matchers removes const from Matcher args and handles template functions slightly better

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75113/new/ https://reviews.llvm.org/D75113 _

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7944 + if (auto ToEOrErr = Import(From->getAlignmentExpr())) +To = AlignedAttr::Create(ToContext, true, *ToEOrErr, ToRange, + FromAttr->getSyntax(), --

[PATCH] D75134: [clang-tidy] Improved renamer check logic

Eugene.Zelenko added a comment. It'll be reasonable to have script to create check alias, but this could be made in separate patch. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:17 import sys - -# Adapts the module's CMakelist file. Returns 'True' if it could add

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); // TODO: Remove the hack for the binop form when the unary op is optimized // pro

[PATCH] D66839: Fix stack address builtin for negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG6201f6601dec: Check args passed to __builtin_frame_address and __builtin_return_address. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

rnk added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74455/new/ https://reviews.llvm.org/D74455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] 6201f66 - Check args passed to __builtin_frame_address and __builtin_return_address.

Author: zoecarver Date: 2020-02-25T12:47:14-08:00 New Revision: 6201f6601dec03e44424ad2d5cc04a9766f194b1 URL: https://github.com/llvm/llvm-project/commit/6201f6601dec03e44424ad2d5cc04a9766f194b1 DIFF: https://github.com/llvm/llvm-project/commit/6201f6601dec03e44424ad2d5cc04a9766f194b1.diff LOG

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. In D74846#1891580 , @dblaikie wrote: > In D74846#1891486 , @llunak wrote: > > > But before we get to this, can we please first fix my patch for 10.0? I > > didn't check properly for -fmodule

Re: [PATCH] D69876: Support output constraints on "asm goto"

I had to re-do the patch. It works for me now...Sorry about the failure! On Tue, Feb 25, 2020 at 12:10 PM Leonard Chan via Phabricator < revi...@reviews.llvm.org> wrote: > leonardchan added a comment. > > Woops, sorry. Didn't see you sent out > https://reviews.llvm.org/rGe11f9fb4508534d31b09d2ba6

[clang] 6d0d1a6 - Use "nop" to avoid size warnings.

Author: Bill Wendling Date: 2020-02-25T12:31:53-08:00 New Revision: 6d0d1a63f2a6c120f206a83e7c1ddae9fa5a569a URL: https://github.com/llvm/llvm-project/commit/6d0d1a63f2a6c120f206a83e7c1ddae9fa5a569a DIFF: https://github.com/llvm/llvm-project/commit/6d0d1a63f2a6c120f206a83e7c1ddae9fa5a569a.diff

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

simoll updated this revision to Diff 246544. simoll added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - rebased - fixed clang complex-math test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75130/new/ https://r

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. In D75001#1891966 , @tra wrote: > In D75001#1891861 , @kkwli0 wrote: > > > @tra Will it also include -fopenmp-targets=nvptx64-nvidia-cuda? > > > If you're asking whether the warning will be d

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246534. njames93 added a comment. - Remove unnecessary debug print Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files: clang-tools-extra/clang-tidy/add_new_check.

[PATCH] D69876: Support output constraints on "asm goto"

leonardchan added a comment. Woops, sorry. Didn't see you sent out https://reviews.llvm.org/rGe11f9fb4508534d31b09d2ba6cd22428ccc75f65. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 created this revision. njames93 added reviewers: aaron.ballman, Eugene.Zelenko, gribozavr2, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Factored out some similar code in add_new_check.py and rename_check.py. Made rename_check.py less e

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

tra added a comment. In D75001#1891861 , @kkwli0 wrote: > @tra Will it also include -fopenmp-targets=nvptx64-nvidia-cuda? If you're asking whether the warning will be disabled for OpenMP, then no. This OpenMP target appears to rely on CUDA, and I think

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

vitalybuka added a comment. Looks like several independent patches, could you spit them, with descriptions explaining why existing values are not good enough? Could you also add into description test names which switch from FAIL to PASS with your changes. I assume code as-is fails some tests on

[PATCH] D69876: Support output constraints on "asm goto"

leonardchan added a comment. *Bump* We're also seeing the same test fail on our aarch64 bots: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8887516314819686496?blamelist=1#blamelist-tab FAIL: Clang :: Analysis/uninit-asm-goto.cpp (837 of 17008) T

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg updated this revision to Diff 246524. joerg added a comment. Do not depend on max_align_t in C++03 mode in the test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 Files: libcxx/include/cstddef libcxx/include/new libcxx/includ

Re: [PATCH] D69876: Support output constraints on "asm goto"

Hi Vlad, I just submitted a fix for this: e11f9fb4508534d31b09d2ba6cd22428ccc75f65 On Tue, Feb 25, 2020 at 11:42 AM Vlad Vereschaka via Phabricator < revi...@reviews.llvm.org> wrote: > vvereschaka added a comment. > > Hello @void , > > this commit breaks Aarch64 builder with failed > `Clang::uni

[clang] e11f9fb - Add 'l' constraint to goto label reference

Author: Bill Wendling Date: 2020-02-25T11:48:23-08:00 New Revision: e11f9fb4508534d31b09d2ba6cd22428ccc75f65 URL: https://github.com/llvm/llvm-project/commit/e11f9fb4508534d31b09d2ba6cd22428ccc75f65 DIFF: https://github.com/llvm/llvm-project/commit/e11f9fb4508534d31b09d2ba6cd22428ccc75f65.diff

[PATCH] D69876: Support output constraints on "asm goto"

vvereschaka added a comment. Hello @void , this commit breaks Aarch64 builder with failed `Clang::uninit-asm-goto.cpp` test http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5020 - FAIL: Clang::uninit-asm-goto.cpp TEST 'Clang :: Analysis/uninit-asm-goto.cp

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. code lgtm Should we have a standalone test for this? Something that compiles with `clang -cc1 -Wno-microsoft -Wmicrosoft-template-shadow` and looks for the shadowing warnings? CHANGES SINCE LAST

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

This revision was automatically updated to reflect the committed changes. Closed by commit rGa57d9652a0dc: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. In D75001#1891742 , @tra wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this way bett

Re: [PATCH] D69876: Support output constraints on "asm goto"

Okay. I'll take a look at it. Sorry about the failure. On Tue, Feb 25, 2020 at 1:37 AM Yvan Roux wrote: > Hi Bill, > > This commit broke AArch64 bots, logs are available here: > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/22291/steps/ninja%20check%201/logs/FAIL%3A%20Clan

[clang] a57d965 - Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

Author: Yaxun (Sam) Liu Date: 2020-02-25T13:58:20-05:00 New Revision: a57d9652a0dcc823921f2d4bac29680db5dbef64 URL: https://github.com/llvm/llvm-project/commit/a57d9652a0dcc823921f2d4bac29680db5dbef64 DIFF: https://github.com/llvm/llvm-project/commit/a57d9652a0dcc823921f2d4bac29680db5dbef64.dif

[PATCH] D74684: [Sema][C++] Adopt DR2171 relaxed triviality requirements

rsmith added a comment. This change should be guarded by `-fclang-abi-compat=` so that users can opt to using the old ABI. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9200-9202 - // C++11 [class.copy]p12, p25: [DR1593] - // A [special member] is trivial if [...] its paramet

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer updated this revision to Diff 246512. DaanDeMeyer added a comment. Added extra unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unitt

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15683 } + bool VisitUnaryOperator(UnaryOperator *UO) { +if (SemaRef.getLangOpts().OpenMP < 50) { cchen wrote: > ABataev wrote: > > I think you need to extend this to support paren ex

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked 5 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15683 } + bool VisitUnaryOperator(UnaryOperator *UO) { +if (SemaRef.getLangOpts().OpenMP < 50) { ABataev wrote: > I think you need to extend thi

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked 6 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7633 +isa(Next->getAssociatedExpression()) || +isa(Next->getAssociatedExpression())) && "Unexpected expression");

[PATCH] D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:259 /// calls. bool isCalled(const CallDescription &CD) const; NoQ wrote: > Szelethus wrote: > > Sz

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

Is there any way to pull this test out of clang and as an opt test? What's it trying to test? -eric On Tue, Feb 25, 2020 at 6:15 AM Sanjay Patel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sanjay Patel > Date: 2020-02-25T09:13:49-05:00 > New Revision: 83f4372f3a708ceaa800fef

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 246495. cchen added a comment. Add BinaryOperator in components and fix logic in MapBaseChecker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files: clang/include/cl

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dmajor added a comment. @steven_wu, ping, could you clarify about the tests please? >> You should definitely add test for this change. The fact that you change all >> `-mlinker-version=400` to `-mlinker-version=0` but not change any CHECK >> lines means the change is definitely not tested :) >

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

tra added a comment. In D75001#1891284 , @Hahnfeld wrote: > In D75001#1887876 , @jdoerfert wrote: > > > I like this way better. I was hoping we could do it in our cmake only :) > > > > Give others a day or so to com

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

rsmith added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:487 // Only calculate hash on first call of getODRHash per record. - ODRHash Hash; + class ODRHash Hash; Hash.AddCXXRecordDecl(getDefinition()); I think this change is no longer necessary

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

thakis added a comment. https://bugs.chromium.org/p/chromium/issues/detail?id=1051578#c12 : """ FYI for those building on AMD Bulldozer family of processors and its various iterations after this commit: https://reviews.llvm.org/D71775 Building with ThinLTO on Bulldozer and similar appears to n

  1   2   3   >