lebedev.ri added a comment.

In D73020#1892245 <https://reviews.llvm.org/D73020#1892245>, @rsmith wrote:

> In D73020#1891368 <https://reviews.llvm.org/D73020#1891368>, @lebedev.ri 
> wrote:
>
> > In D73020#1857704 <https://reviews.llvm.org/D73020#1857704>, @rsmith wrote:
> >
> > > Looks good if you change the error to a warning.
> >
> >
> > I'm going to treat that as an implicit accept since the error got changed 
> > into a warning.
>
>
> Yes, that was my intent. =) Here's an explicit "accept" for you anyway.


Great. Thank you for review!
Thank you for confirming.
Will land tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73020/new/

https://reviews.llvm.org/D73020



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to