[PATCH] D64914: Implement P1771

erichkeane marked 5 inline comments as done. erichkeane added a comment. In D64914#1591744 , @aaron.ballman wrote: > There seems to be some separable concerns in this patch. I'd rather real with > `warn_unused_result`, `const`, and `pure` attributes sepa

[PATCH] D64970: [clangd] Handle windows line endings in QueryDriver

lh123 added a comment. In D64970#1592881 , @kadircet wrote: > LGTM thanks! > > Do you have commit access? I don't have permission to commit. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https:/

[PATCH] D64970: [clangd] Handle windows line endings in QueryDriver

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM thanks! Do you have commit access? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https://reviews.llvm.org/D64970

[PATCH] D64970: Handle windows line endings in QueryDriver

lh123 updated this revision to Diff 210737. lh123 added a comment. update diff context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https://reviews.llvm.org/D64970 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools

[PATCH] D64970: Handle windows line endings in QueryDriver

lh123 updated this revision to Diff 210735. lh123 added a comment. update test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https://reviews.llvm.org/D64970 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/c

[PATCH] D64970: Handle windows line endings in QueryDriver

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. The previous patch did not fix the end mark. D64789

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen added a comment. @chandlerc ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

Hi Kadir This change is causing test failures, can you please look into it. Refer to http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/58104/testReport/. Assertion failed: (TUsIt != FileToTU.end() && "No TU registered for the shard"), function takeResult, file /Users/buildslave/j

[PATCH] D64955: Fix formatting of inline argument comments. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366518: Fix formatting of inline argument comments. NFC. (authored by sbc, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

r366518 - Fix formatting of inline argument comments. NFC.

Author: sbc Date: Thu Jul 18 17:30:23 2019 New Revision: 366518 URL: http://llvm.org/viewvc/llvm-project?rev=366518&view=rev Log: Fix formatting of inline argument comments. NFC. Also, remove the final arg from ItaniumCXXABI in the PNaCl case since its not needed. Differential Revision: https://

[PATCH] D64957: [WebAssembly] Don't set UseARMGuardVarABI, just use the default (64-bit)

sbc100 abandoned this revision. sbc100 added a comment. We are going to change libc++abi instead: https://reviews.llvm.org/D64961 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64957/new/ https://reviews.llvm.org/D64957 __

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Before making a link to a reference it is required to check that the reference has a path (eg. primitives won't have paths). This was

[PATCH] D64957: [WebAssembly] Don't set UseARMGuardVarABI, just use the default (64-bit)

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, kristof.beyls, jgravelle-google, javed.absar, dschuff. Herald added a project: clang. sbc100 added a reviewer: sunfish. This fixes a disagreement between libc++abi and clang about the width of the guard variabl

[PATCH] D64955: Fix formatting of inline argument comments. NFC.

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin, dschuff. Herald added a project: clang. Also, remove the final arg from ItaniumCXXABI in the PNaCl case since its not needed. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64955 Files: clang/lib/C

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry added a comment. void foo() { __attribute__((address_space(0))) *x; *y; } If the attributes are parsed then the rest of the statement is identical to: { *x; //this one has attributes now *y; { The first line should be a valid declaration and the second

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) +P.push_back(Phase); aaron.ballman wrote: > plotfi wrote: > > aaron.ballman wrote: > > > C

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 210696. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files: clang/include/clang/Driver/Types.def clang/include/clang/Driver/Types.h clang/lib/Driver/Driver.cpp

r366511 - Update the SimpleJIT class in the clang-interpreter example to use ORCv2.

Author: lhames Date: Thu Jul 18 15:47:18 2019 New Revision: 366511 URL: http://llvm.org/viewvc/llvm-project?rev=366511&view=rev Log: Update the SimpleJIT class in the clang-interpreter example to use ORCv2. This will remove the ORCv1 deprecation warnings. Modified: cfe/trunk/examples/clang-i

[PATCH] D64945: [clang-scan-deps] Dependency directives source minimizer: handle #pragma once

This revision was automatically updated to reflect the committed changes. arphaman marked 2 inline comments as done. Closed by commit rL366509: [clang-scan-deps] Dependency directives source minimizer: handle #pragma once (authored by arphaman, committed by ). Herald added a project: LLVM. Herald

r366509 - [clang-scan-deps] Dependency directives source minimizer: handle #pragma once

Author: arphaman Date: Thu Jul 18 15:33:14 2019 New Revision: 366509 URL: http://llvm.org/viewvc/llvm-project?rev=366509&view=rev Log: [clang-scan-deps] Dependency directives source minimizer: handle #pragma once We should re-emit `#pragma once` to ensure the preprocessor will still honor it when

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 210688. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava updated this revision to Diff 210674. Sunil_Srivastava added a comment. - Adapted suggestion from Ried. - Cleaned up line ending and properties of the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64780/new/ https://reviews.llvm.org/D64780 Files: include/c

[PATCH] D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic

quantum updated this revision to Diff 210675. quantum added a comment. Add a test with a memory dependency on __builtin_wasm_tls_base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64949/new/ https://reviews.llvm.org/D64949 Files: clang/include/

[PATCH] D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL366499: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D64949?vs=210675&id=210676#toc Repository: rL LLVM

r366499 - [WebAssembly] Fix __builtin_wasm_tls_base intrinsic

Author: quantum Date: Thu Jul 18 14:17:52 2019 New Revision: 366499 URL: http://llvm.org/viewvc/llvm-project?rev=366499&view=rev Log: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic Summary: Properly generate the outchain for the `__builtin_wasm_tls_base` intrinsic. Also marked the intrinsic

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210673. gtbercea added a comment. - Add static variable. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen

[PATCH] D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM modulo a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64949/new/ https://reviews.llvm.org/D64949 __

[PATCH] D64945: [clang-scan-deps] Dependency directives source minimizer: handle #pragma once

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after you add the testcase I mention. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:623 +// #pragma once +skipLine(First, End); +

[PATCH] D64949: [WebAssembly] Fix __builtin_wasm_tls_base intrinsic

quantum created this revision. quantum added reviewers: tlively, aheejin, sbc100, sunfish. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. Properly generate the outchain for the `__builtin_wasm_tls_base` intrinsic. Al

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64563/new/ https://reviews.llvm.org/D64563 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rnk added a comment. In D64799#1591732 , @ilya-biryukov wrote: > @rsmith, I'll look into emitting the typos when we pop expression evaluation > context, but do we expect this to cover **all** cases where `TypoExpr`s are > produced? > (conservatively as

[PATCH] D64945: [clang-scan-deps] Dependency directives source minimizer: handle #pragma once

arphaman created this revision. arphaman added reviewers: Bigcheese, dexonsmith. Herald added subscribers: tschuett, jkorous. Herald added a project: clang. We should re-emit `#pragma once` to ensure the preprocessor will still honor when running on minimized sources. Repository: rC Clang ht

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

rnk added a comment. I suggested to @akhuang offline that we should discuss this on llvm-dev. I'll add some other X86 reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 __

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

rnk added a comment. In D64067#1592201 , @troyj wrote: > Hi, we just inherited this commit at Cray when we did our latest upstream > merge and there are a few problems with it that I'd like to point out. Sorry > that I was not part of the initial discus

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

hfinkel added a comment. In D64067#1592201 , @troyj wrote: > Hi, we just inherited this commit at Cray when we did our latest upstream > merge and there are a few problems with it that I'd like to point out. Sorry > that I was not part of the initial di

[PATCH] D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause

Prince781 added a comment. In D64585#1592207 , @ABataev wrote: > Fixed this bug myself to be sure it will be merged with 9.0 release, sorry. That's cool. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause

ABataev added a comment. Fixed this bug myself to be sure it will be merged with 9.0 release, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64585/new/ https://reviews.llvm.org/D64585 ___ cfe-com

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added a comment. I don't see a single test for static variables. Do we have at least one? If not, add it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 ___ cfe-comm

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

troyj added a comment. Hi, we just inherited this commit at Cray when we did our latest upstream merge and there are a few problems with it that I'd like to point out. Sorry that I was not part of the initial discussion here, but I didn't know that this work was being done and I had already do

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210652. gtbercea added a comment. - Merge conditionals. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.

r366483 - [OPENMP]Fix sharing of threadprivate variables with TLS support.

Author: abataev Date: Thu Jul 18 12:40:24 2019 New Revision: 366483 URL: http://llvm.org/viewvc/llvm-project?rev=366483&view=rev Log: [OPENMP]Fix sharing of threadprivate variables with TLS support. If the threadprivate variable is used in the copyin clause on inner parallel directive with TLS su

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2594-2597 + if (!VD->isExternallyVisible()) +getTargetEntryUniqueInfo(CGM.getContext(), + VD->getCanonicalDecl()->getBeginLoc(), +

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210650. gtbercea added a comment. - Fix tests. Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

sunfish added inline comments. Comment at: cfe/trunk/include/clang/Basic/BuiltinsWebAssembly.def:34 TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +TARGET_BUILTIN(__builtin_wasm_tls_base, "v*", "n", "bulk-memory") This can also be "p" for "p

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas updated this revision to Diff 210648. cdevadas added a comment. Herald added a subscriber: jvesely. updated test/CodeGenOpenCL/builtins-generic-amdgcn.cl to vaildate the address space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64563/new/ https://reviews.llvm.org/D64563 Fi

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 210649. emmettneyman added a comment. Created diagnostic group, added behavior and documentation for private fields, added documentation regarding GCC attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D64592: [OpenMP] Fix target link implementation

ABataev added a comment. Fix the name of the patch. It is the patch for declare target, not target. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2598-2599 + DeviceID, FileID, Line); + OS << CGM.getMangledName(GlobalDecl(VD)) + << llvm

[PATCH] D64592: [OpenMP] Fix target link implementation

gtbercea updated this revision to Diff 210645. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.cp

[PATCH] D41412: [libcxx] implement concat() and split()

timshen added a comment. Tobias, I spoke to @EricWF who is willing to take a look at all these patches. However, I don't know when exactly will the review starts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.llvm.org/D41412 __

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added a comment. In D64838#1592118 , @Nathan-Huckleberry wrote: > In D64838#1592111 , @aaron.ballman > wrote: > > > In D64838#1589770 , > > @Nathan-Huckleber

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

jakehehrlich added a comment. I'm blindly accepting the CSS but all other code looks fine. I still have that chrome bug where I can't LGTM sometimes but consider this reviewed and accepted by me as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3279 +def ObjCClampingBool : TypeAttr { + let Spellings = [Clang<"objc_clamping_bool">]; + let Subjects = SubjectList<[TypedefName]>; dexonsmith wrote: > erik.pilkington wrote: >

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry added a comment. In D64838#1592111 , @aaron.ballman wrote: > In D64838#1589770 , > @Nathan-Huckleberry wrote: > > > The main problem that we have is that the `__attribute__` token always > > ca

r366480 - [RISCV] Hard float ABI support

Author: asb Date: Thu Jul 18 11:29:59 2019 New Revision: 366480 URL: http://llvm.org/viewvc/llvm-project?rev=366480&view=rev Log: [RISCV] Hard float ABI support The RISC-V hard float calling convention requires the frontend to: * Detect cases where, once "flattened", a struct can be passed using

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

aaron.ballman added inline comments. Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) +P.push_back(Phase); plotfi wrote: > aaron.ballman wrote: > > Can't you use the local `Phases` object instead of calling `ge

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added a comment. In D64838#1589770 , @Nathan-Huckleberry wrote: > The main problem that we have is that the `__attribute__` token always causes > the parser to read the line as a declaration. Then the declaration parser > handles reading t

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. DiegoAstiazaran edited the summary of this revision. An option has been added to clang-d

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

rjmccall added a comment. Yes, that's the right fix, although you might also consider adding a `getObjectType()` to `CXXMemberCallExpr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569 __

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL366475: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D64900?vs=210469&id=210632#toc Repository: rL

r366475 - [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

Author: quantum Date: Thu Jul 18 10:53:22 2019 New Revision: 366475 URL: http://llvm.org/viewvc/llvm-project?rev=366475&view=rev Log: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic Summary: Add `__builtin_wasm_tls_base` so that LeakSanitizer can find the thread-local block and scan thr

r366474 - [OPENMP]Provide correct data sharing attributes for loop control

Author: abataev Date: Thu Jul 18 10:49:13 2019 New Revision: 366474 URL: http://llvm.org/viewvc/llvm-project?rev=366474&view=rev Log: [OPENMP]Provide correct data sharing attributes for loop control variables. Loop control variables are private in loop-based constructs and we shall take this into

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

efriedma added a comment. Yes, that seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rL366473: [LibTooling] Relax Transformer to allow rewriting macro expansions (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subsc

r366473 - [LibTooling] Relax Transformer to allow rewriting macro expansions

Author: ymandel Date: Thu Jul 18 10:44:54 2019 New Revision: 366473 URL: http://llvm.org/viewvc/llvm-project?rev=366473&view=rev Log: [LibTooling] Relax Transformer to allow rewriting macro expansions Summary: Currently, Transformer rejects any changes to source locations inside macro expansions.

[PATCH] D64889: [OPENMP] getDSA(): handle loop control variables

ABataev added a comment. Thanks for the report, but the fix is not quite correct. I'll fix this myself. I just want to push it to 9.0 release branch ASAP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64889/new/ https://reviews.llvm.org/D64889 _

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:292 + /*length*/0UL); + auto NewEnd = NewHighlightings.end(); + auto OldEnd = OldHighlightings.end(); ilya-biryukov wrote: > NIT:

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

quantum added a comment. In D64900#1590715 , @aheejin wrote: > What does this return when `__wasm_init_tls` has not been called? It returns `0`, which I think is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D64924: [LibTooling] Add function to translate and validate source range for editing

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rL366469: [LibTooling] Add function to translate and validate source range for editing (authored by ymandel, committed by ). Herald added a project: LLVM. Herald add

r366469 - [LibTooling] Add function to translate and validate source range for editing

Author: ymandel Date: Thu Jul 18 10:26:57 2019 New Revision: 366469 URL: http://llvm.org/viewvc/llvm-project?rev=366469&view=rev Log: [LibTooling] Add function to translate and validate source range for editing Summary: Adds the function `getRangeForEdit` to validate that a given source range is

[clang-tools-extra] r366468 - [clangd] Remove dead code from BackgroundIndex

Author: kadircet Date: Thu Jul 18 10:25:57 2019 New Revision: 366468 URL: http://llvm.org/viewvc/llvm-project?rev=366468&view=rev Log: [clangd] Remove dead code from BackgroundIndex Modified: clang-tools-extra/trunk/clangd/index/Background.cpp Modified: clang-tools-extra/trunk/clangd/index/B

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

This revision was automatically updated to reflect the committed changes. Closed by commit rL366467: [clangd] BackgroundIndex stores shards to the closest project (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r366467 - [clangd] BackgroundIndex stores shards to the closest project

Author: kadircet Date: Thu Jul 18 10:20:41 2019 New Revision: 366467 URL: http://llvm.org/viewvc/llvm-project?rev=366467&view=rev Log: [clangd] BackgroundIndex stores shards to the closest project Summary: Changes persistance logic to store shards at the directory of closest CDB. Previously we we

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

kadircet updated this revision to Diff 210621. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64745/new/ https://reviews.llvm.org/D64745 Files: clang-tools-ex

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:149 + std::unique_ptr create(PathRef CDBDirectory) { +assert(!CDBDirectory.empty() && + "Tried to create storage for empty directory!"); sammccall

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. It seems this patch went through at least one review and the only open comment is the discussion if __builtin_shuffle should be placed in the configuration. From my perspective, both solutions are technically feasible. While it seems unlikely that gcc will gain this spe

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210613. jvikstrom added a comment. Removed one lock from onSemanticHighlighting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files: clang-tools-extra/clangd/Cla

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, erik.pilkington, ABataev. Herald added a subscriber: dexonsmith. Herald added a project: clang. If a class or struct or union declaration contains a pragma that is not valid in this context, compiler issues generic error

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 210609. plotfi added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files: clang/include/clang/Driver/Types.def clang/include/clang/Driver/Types.

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini marked an inline comment as done. mantognini added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1758-1764 + if (CE) { +ThisTy = CE->getImplicitObjectArgument()->getType(); +if (ThisTy->isPointerType()) + ThisTy = ThisTy->getPointeeType

[PATCH] D64744: #pragma clang loop predicate(enable|disable)

Meinersbur added a comment. [serious] Need to update docs. I'd expect `predicate` to be an option of another transformation. For vectorization, by convention the #pragma name would be `vectorize_predicate` and the metadata `llvm.loop.vectorize.predicate`. As a standalone, it is not clear what

[PATCH] D64924: [LibTooling] Add function to translate and validate source range for editing

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/SourceCode.h:80 +llvm::Optional +getRangeForEdit(const CharSourceRange &EditRange, const ASTContext &Context); } // namespace tooling ily

[PATCH] D64924: [LibTooling] Add function to translate and validate source range for editing

ymandel updated this revision to Diff 210608. ymandel added a comment. Added overload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64924/new/ https://reviews.llvm.org/D64924 Files: clang/include/clang/Tooling/Refactoring/SourceCode.h clang/l

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210606. jvikstrom added a comment. Fixed test case that was actually (kinda) broken even though it didn't fail. (The last two edits in semantic-highlighting test. They removed the `= 2` part and did not insert an extra `;` which produced invalid code. It w

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210605. mantognini added a comment. Add patch for Bug PR42665. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569 Files: clang/include/clang/AST/DeclCXX.h clang/lib

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) +P.push_back(Phase); aaron.ballman wrote: > Can't you use the local `Phases` object instea

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini reopened this revision. mantognini added a subscriber: ilya-biryukov. mantognini added a comment. This revision is now accepted and ready to land. While investigating PR42665, I've noticed that `getImplicitObjectArgument` doesn't always return a pointer type. For example, when dealing

[PATCH] D64592: [OpenMP] Fix target link implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2589 HasRequiresUnifiedSharedMemory))) { +llvm::GlobalValue::LinkageTypes GlobalVarLinkage = + CGM.getLLVMLinkageVarDefinition(VD, false); Currently, I think,

[PATCH] D64712: [clangd] Refactor background-index shard loading

This revision was automatically updated to reflect the committed changes. Closed by commit rL366458: [clangd] Refactor background-index shard loading (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

Author: kadircet Date: Thu Jul 18 09:25:36 2019 New Revision: 366458 URL: http://llvm.org/viewvc/llvm-project?rev=366458&view=rev Log: [clangd] Refactor background-index shard loading Reviewers: sammccall Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210600. jvikstrom marked 7 inline comments as done. jvikstrom added a comment. Address comments and fixed bug where we'd send diffs outside of the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 210601. jvikstrom added a comment. Remove braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-

r366457 - [ASTUnit] Attempt to unbreak Windows buildbots after r366448

Author: ibiryukov Date: Thu Jul 18 09:24:09 2019 New Revision: 366457 URL: http://llvm.org/viewvc/llvm-project?rev=366457&view=rev Log: [ASTUnit] Attempt to unbreak Windows buildbots after r366448 Modified: cfe/trunk/test/Index/complete-qualified-cached.cpp Modified: cfe/trunk/test/Index/com

[PATCH] D64924: [LibTooling] Add function to translate and validate source range for editing

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Tooling/Refactoring/SourceCode.h:80 +llvm::Optional +getRangeForEdit(const CharSourceRange &EditRange, const ASTContext &Co

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); ---

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64518/new/ https://reviews.llvm.org/D64518 _

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske added a comment. Commit was reverted because we were not aware of that clangAST library can not use clangFrontend library. So a different solution is needed, probably pass a SourceLocation import callback to ASTImporter. (A `Preprocessor` that can be used in place of `ASTUnit` here can

[PATCH] D64926: [OpenMP] Fx link clause

gtbercea abandoned this revision. gtbercea added a comment. Not needed as a separate patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64926/new/ https://reviews.llvm.org/D64926 ___ cfe-commits mailing list cfe-co

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rL366455: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG apart from the second global CDB Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:128 + : IndexStorageMapMu(llvm::make_unique()), +

  1   2   3   >