Manikishan marked an inline comment as done. Manikishan added inline comments.
================ Comment at: lib/Format/FormatToken.h:524 + T = T->getPreviousNonComment(); + return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && + T->Next->Tok.is(tok::colon)); ---------------- MyDeveloperDay wrote: > do you think you might need > > (T && T->Tok.is(tok::comma)...... > I have found a method `FieldDecl::isBitField() ` which check whether a current field is a BitField, But `FieldDecl` is not used anywhere in `lib/Format/` . I think it may not be related to Formatting and so I have to modify my declaration of `isBitield()` in `FormatToken.h`. Can I get suggestions whether my understanding is correct? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits