kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:149
+ std::unique_ptr<BackgroundIndexStorage> create(PathRef CDBDirectory) {
+ assert(!CDBDirectory.empty() &&
+ "Tried to create storage for empty directory!");
----------------
sammccall wrote:
> This assertion will be hit if home_directory() fails. It shouldn't, but...
> maybe keep the "return nullstorage" to cover this case (and also the assert?)
elog'ing instead of assertion, since this indeed happens in one of our lit-tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64745/new/
https://reviews.llvm.org/D64745
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
