[clang-tools-extra] r358561 - [clangd] lower_bound -> bsearch, NFC

Author: sammccall Date: Wed Apr 17 00:00:36 2019 New Revision: 358561 URL: http://llvm.org/viewvc/llvm-project?rev=358561&view=rev Log: [clangd] lower_bound -> bsearch, NFC Modified: clang-tools-extra/trunk/clangd/index/Symbol.cpp clang-tools-extra/trunk/clangd/index/dex/PostingList.cpp

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. In D59712#1469693 , @jdenny wrote: > In D59712#1469392 , @lebedev.ri > wrote: > > > In D59712#1469358 , @jdenny wrote: > > > > > In D59712#146930

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ added a comment. Hmm, i think i'd love to know why doesn't the uninitialized variable checker fire on the if-statement as farmed by the body farm: 592 // Signature: 593 // _Bool OSAtomicCompareAndSwapPtr(void *__oldValue, 594 // void *__newValue,

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2580 +if (const BlockDecl *BD = CurContext->getInnerMostBlockDecl()) + if (!getDiagnostics().isIgnored(diag::warn_implicitly_retains_self, Loc)) +ImplicitlyRetainedSelfLocs.push_back({

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore added a comment. In D59806#1469257 , @aaron.ballman wrote: > LGTM! You can either land this now and refactor after the AST matcher lands, > or you can wait until the AST matcher lands and land this patch after -- your > call. I will plan

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1469392 , @lebedev.ri wrote: > In D59712#1469358 , @jdenny wrote: > > > In D59712#1469301 , @lebedev.ri > > wrote: > > > > > In D59712#1469

[clang-tools-extra] r358549 - clangd: Change Windows.h to windows.h.

Author: pcc Date: Tue Apr 16 20:02:18 2019 New Revision: 358549 URL: http://llvm.org/viewvc/llvm-project?rev=358549&view=rev Log: clangd: Change Windows.h to windows.h. This makes the file more cross compilation friendly. Modified: clang-tools-extra/trunk/clangd/Threading.cpp Modified: clan

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

This revision was automatically updated to reflect the committed changes. Closed by commit rL358544: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

r358544 - [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

Author: maskray Date: Tue Apr 16 18:46:27 2019 New Revision: 358544 URL: http://llvm.org/viewvc/llvm-project?rev=358544&view=rev Log: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf Summary: When -gsplit-dwarf is used together with other -g options, in most cases the

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ updated this revision to Diff 195500. NoQ added a comment. Fxd constructors and destructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60742/new/ https://reviews.llvm.org/D60742 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/string.c clang/unitte

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:49 +// Bind(Zero) +Store StX0 = +StMgr.Bind(StInit, LX0, Zero).getStore(); a_sidorin wrote: > This can fit one line. Just wan

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

NoQ added a comment. In D60732#1469026 , @jdenny wrote: > The original patch added documentation to `-cc1 -help`. Doxygen for > VerifyDiagnosticConsumer is another possibility except it currently doesn't > mention command-line usage at all. Maybe it sh

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195498. ahatanak added a comment. Keep a list of pairs of BlockDecl and SourceLocation and, after the body of an ObjC method is parsed, emit a diagnostic if a SourceLocation in the list is inside an escaping block. Repository: rC Clang CHANGES SINCE LA

[PATCH] D60807: Test for Oz fail

pcc added a comment. Interesting, it looks like the difference here is almost entirely due to different inlining decisions. And according to the tool I posted here: http://lists.llvm.org/pipermail/llvm-dev/2019-April/131811.html in the few functions in which we made the same inlining decisions,

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb, a.sidorin, szepet, kristof.beyls, javed.absar. Herald added a project: clang. NoQ up

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ updated this revision to Diff 195497. NoQ added a comment. Fix comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h clang/lib/StaticAnalyzer/Core/BugReporte

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm updated this revision to Diff 195495. bd1976llvm added a comment. No longer shortening "dependent libraries" to "deplibs" except for the .deplibs section (as this takes up bytes on disk). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D6027

[PATCH] D60807: Test for Oz fail

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -Oz builds are usually significantly large than -Os build Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60807 Files: clang/test/CodeGen/oz.cpp __

[PATCH] D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information

NoQ accepted this revision. NoQ added a comment. Yay!! I'm happy with this change and redirected all my wrath on its dependencies. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076 ___ cfe-commits mai

[PATCH] D58033: Add option for emitting dbg info for call sites

aprantl added a comment. And if we plan to enable it by default, too, perhaps not adding a driver option (CC1 only) is preferable, since we need to maintain compatibility with driver options indefinitely. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.or

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195480. akhuang added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-inf

r358538 - [NFC] Remove unused function (Sema::pushExternalDeclIntoScope)

Author: leonardchan Date: Tue Apr 16 15:59:39 2019 New Revision: 358538 URL: http://llvm.org/viewvc/llvm-project?rev=358538&view=rev Log: [NFC] Remove unused function (Sema::pushExternalDeclIntoScope) Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaDecl.cpp Modified:

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

jkorous added inline comments. Comment at: tools/clang-scan-deps/ClangScanDeps.cpp:39 + bool runInvocation(std::shared_ptr Invocation, + FileManager *Files, + std::shared_ptr PCHContainerOps, `Files` -> `FileMgr` might be

r358537 - Modify test to use -S instead of -c so that it works when an external assembler is used that is not present.

Author: dyung Date: Tue Apr 16 15:52:05 2019 New Revision: 358537 URL: http://llvm.org/viewvc/llvm-project?rev=358537&view=rev Log: Modify test to use -S instead of -c so that it works when an external assembler is used that is not present. Modified: cfe/trunk/test/Driver/modules.cpp Modifi

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195478. akhuang added a comment. more typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-c

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58094/new/ https://reviews.llvm.org/D58094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195475. akhuang added a comment. remove comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-in

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang created this revision. akhuang added reviewers: hans, rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug info in codeview. Currently only changes FastISel,

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

kernigh added a comment. I'm stuck. I didn't put a test in this patch because I can't run the tests yet. So far, I can build a clang executable but can't build the rest of the project. I won't run the tests without a complete build, and I won't edit the tests without running them. I had diffic

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. In D59712#1469358 , @jdenny wrote: > In D59712#1469301 , @lebedev.ri > wrote: > > > In D59712#1469295 , @craig.topper > > wrote: > > > > > Wonde

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1469301 , @lebedev.ri wrote: > In D59712#1469295 , @craig.topper > wrote: > > > Wondering if it would be better to assert for asking for the sign of an > > unsigned APSInt. I coul

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. In D59712#1469295 , @craig.topper wrote: > Wondering if it would be better to assert for asking for the sign of an > unsigned APSInt. I could see a caller just wanting to get the msb for some > reason and not knowing that isN

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

craig.topper added a comment. Wondering if it would be better to assert for asking for the sign of an unsigned APSInt. I could see a caller just wanting to get the msb for some reason and not knowing that isNegative won’t work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny updated this revision to Diff 195452. jdenny added a comment. Duplicate new APSInt test but for signed type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 Files: clang/test/OpenMP/distribute_collapse_messages.cpp clang/test/OpenMP/d

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381 + # Don't allow 'clang' or 'llvm' namespaces + if module == 'llvm' or module == 'clang': +namespace = module + '_check' We don't have the `clang` module. No need to

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You can either land this now and refactor after the AST matcher lands, or you can wait until the AST matcher lands and land this patch after -- your call. Repository: rG

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: llvm/unittests/ADT/APSIntTest.cpp:162 +TEST(APSIntTest, UnsignedHighBit) { + APSInt False(APInt(1, 0)); Can you please duplicate this whole test but for signed `APSInt`?

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/unittests/ADT/APSIntTest.cpp:188-194 + EXPECT_FALSE(CharBoundaryUnder.isNegative()); + EXPECT_TRUE(CharBoundaryUnder.isNonNegative()); + EXPECT_TRUE(CharBoundaryUnder.isStrictlyPositive());

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny added a comment. Is there anything I can do to help this patch make progress? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:109 check_notes_prefix = 'CHECK-NOTES' + file_check_suffix +check_fix_descriptions_pr

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: llvm/unittests/ADT/APSIntTest.cpp:188-194 + EXPECT_FALSE(CharBoundaryUnder.isNegative()); + EXPECT_TRUE(CharBoundaryUnder.isNonNegative())

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks ok - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

aaron.ballman added a comment. In D60455#1468714 , @bader wrote: > In D60455#1468386 , @Fznamznon wrote: > > > > Ok, my question is whether you are planning to duplicate the same logic > > > as for OpenCL kernel wh

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8975 +CGM.Error(Clause->getBeginLoc(), + "Target region emitted before requires directive."); + HasRequiresUnifiedSharedMemory = true; The message speaks abou

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. fantastic Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 _

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

sammccall added a comment. In D60539#1469012 , @nemanjai wrote: > > Do you need to build clangd? We explicitly don't aim to support building > > everywhere clang can be built, maybe we should just disable in this case? > > Our environment includes various

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 195425. ilya-biryukov added a comment. - Simplify rawByExpanded by using a helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 Files: clang/include

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + gtbercea wrote: > ABataev wrote: > > gtbercea wrote: > > > gtbercea w

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

jdenny added a comment. In D60732#1469026 , @jdenny wrote: > Sometimes you can avoid an explosion of FileCheck prefixes using -D. I'm not > aware of anything like -D for -verify. I mean a -D that expands a variable within an expected diagnostic. Repo

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

jdenny added a comment. > Just wanted to give a bit more visibility to the underrated technology of > writing -verify=a,b,c instead of the #ifdefclutter. It's great to see this getting more use. > It's also a bit wonky because it seems that you have to write an exponential > number of flags to

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

nemanjai added a comment. > Do you need to build clangd? We explicitly don't aim to support building > everywhere clang can be built, maybe we should just disable in this case? Our environment includes various OS levels running on PowerPC. We certainly wouldn't want to disable building/testing

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + gtbercea wrote: > gtbercea wrote: > > ABataev wrote: > > > gtbercea w

[PATCH] D60786: [FileSystemStatCache] Update test for new FileSystemStatCache API

This revision was automatically updated to reflect the committed changes. Closed by commit rC358511: [FileSystemStatCache] Update test for new FileSystemStatCache API (authored by harlanhaskins, committed by ). Changed prior to commit: https://reviews.llvm.org/D60786?vs=195416&id=195417#toc Re

r358511 - [FileSystemStatCache] Update test for new FileSystemStatCache API

Author: harlanhaskins Date: Tue Apr 16 11:00:43 2019 New Revision: 358511 URL: http://llvm.org/viewvc/llvm-project?rev=358511&view=rev Log: [FileSystemStatCache] Update test for new FileSystemStatCache API Summary: Update this test to return std::error_code instead of LookupResult. Reviewers: ar

[PATCH] D60786: [FileSystemStatCache] Update test for new FileSystemStatCache API

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ormris. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60786/new/ https://reviews.llvm.org/D60786 __

[PATCH] D60786: [FileSystemStatCache] Update test for new FileSystemStatCache API

harlanhaskins created this revision. harlanhaskins added a reviewer: arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Herald added a subscriber: orm

[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

This revision was automatically updated to reflect the committed changes. Closed by commit rC358509: [FileSystemStatCache] Return std::error_code from stat cache methods (authored by harlanhaskins, committed by ). Changed prior to commit: https://reviews.llvm.org/D60735?vs=195264&id=195411#toc

r358509 - [FileSystemStatCache] Return std::error_code from stat cache methods

Author: harlanhaskins Date: Tue Apr 16 10:34:26 2019 New Revision: 358509 URL: http://llvm.org/viewvc/llvm-project?rev=358509&view=rev Log: [FileSystemStatCache] Return std::error_code from stat cache methods Summary: Previously, we would return true/false signifying if the cache/lookup succeeded

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 10 inline comments as done. anton-afanasyev added a comment. Patch by @thakis for BE passes tracing: https://reviews.llvm.org/D60782 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + gtbercea wrote: > ABataev

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 195409. m4tx added a comment. Updated the backticks in the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tools-extra/clang-tidy/readability

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny added a comment. In D60728#1468486 , @hans wrote: > What's the value in checking in this xfail'ed test without an actual fix for > the problem? 1. It may help whoever tries to address it in the future, to have a known-good reproducer. 2. If so

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-redundant-access-specifiers.rst:34 + If set to non-zero, the check will also give warning if the first access + specifier declaration is redundant (e.g. `private` inside `c

[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, please mark it as NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60735/new/ https://reviews.llvm.org/D60735

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 195408. m4tx added a comment. Herald added a project: clang. Updated the diff for the latest (master) version, used GitHub monorepo for the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https:/

[PATCH] D60749: [Test] Remove obsolete test.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358507: [Test] Remove obsolete test. (authored by Meinersbur, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60749/new/ https://reviews.llvm.org/D60749 Fil

r358507 - [Test] Remove obsolete test.

Author: meinersbur Date: Tue Apr 16 09:44:45 2019 New Revision: 358507 URL: http://llvm.org/viewvc/llvm-project?rev=358507&view=rev Log: [Test] Remove obsolete test. The FIXME of this test case has been addressed in r335084/r338800. Its execution still does not succeed because of multiple syntax

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

lebedev.ri added a comment. > Not sure how to test this though? I guess we can trust that std::map is > always sorted just as it says in its description. You could add a test that contains several entries in `OpenCLTypeExtMap` and several entries in `OpenCLDeclExtMap`. In that test, write te PC

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + gtbercea wrote: > ABataev wrote: > > Why do you need this? I think yo

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader added a comment. In D60455#1467279 , @aaron.ballman wrote: > In D60455#1464324 , @Fznamznon wrote: > > > Applied comments from @aaron.ballman and @keryell > > > > - Introduced a C++11 and C2x style spelling i

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > Why do y

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + Why do you need this? I think your function should be called without

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added a comment. FYI, I switched to `std::map` in this review: https://reviews.llvm.org/D60778 @sylvestre.ledru do you think it's possible to apply this patch and see if it work for your bug? Btw I am still confused about the reproducibility - does clang produce the same PCH at leas

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

Anastasia created this revision. Anastasia added reviewers: lebedev.ri, sylvestre.ledru, riccibruno. Herald added subscribers: ebevhan, JDevlieghere, yaxunl. As discussed in https://reviews.llvm.org/D60379 let's use std::map to store OpenCL extensions data structure. Not sure how to test this th

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195394. gtbercea added a comment. - Fix checks for use of requires directive. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/C

[PATCH] D58033: Add option for emitting dbg info for call sites

probinson added a comment. I guess I'm not clear what your final goal is for the option. Keep it, even though GCC doesn't have one like it? Eliminate it? Please clearly state what you intend to have in the end, and what you might have in the short term in case that is different. =

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader added a comment. In D60455#1468386 , @Fznamznon wrote: > > Ok, my question is whether you are planning to duplicate the same logic as > > for OpenCL kernel which doesn't really seem like an ideal design choice. Is > > this the only difference then

r358503 - [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.

Author: abataev Date: Tue Apr 16 08:39:12 2019 New Revision: 358503 URL: http://llvm.org/viewvc/llvm-project?rev=358503&view=rev Log: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode. Combined constructs with parallel and if clauses without modifiers may be executed in SPMD mode

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

krytarowski added a comment. In D60728#1468486 , @hans wrote: > What's the value in checking in this xfail'ed test without an actual fix for > the problem? Raise awareness about the problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60728/

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked 2 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-unhandled-self-assignment.cpp:351 + int *p; +}; aaron.ballman wrote: > ztamas wrote: > > JonasToth wrote: > > > Please add tests with t

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:146 + llvm::Optional> + toOffsetRange(const Token *Begin, const Token *End, +const SourceManager &SM) const; ilya-biryukov wrote: > ilya-biryukov wrote

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

hokein updated this revision to Diff 195385. hokein added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60776/new/ https://reviews.llvm.org/D60776 Files: clang-tools-extra/test/clang-tidy/check_clang_tidy.py clang-tools-extr

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

hokein created this revision. hokein added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a project: clang. Add a new annotation "CHECK-FIX-DESCRIPTIONS" to lit test to verify the fix description provided by checks. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked 4 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:6 + +`cert-oop54-cpp` redirects here as an alias for this check. + aaron.ballman wrote: > You shoul

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 195382. ztamas added a comment. Update patch based on reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files: clang-tools-extra/clang-tidy/bugprone/B

[PATCH] D60775: [libclang] Expose ext_vector_type

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60775/new/ https://reviews.llvm.org/D60775 ___

[PATCH] D60687: [clangd] Check file path of declaring header when deciding whether to insert include.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358496: [clangd] Check file path of declaring header when deciding whether to insert… (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository

[clang-tools-extra] r358496 - [clangd] Check file path of declaring header when deciding whether to insert include.

Author: ioeric Date: Tue Apr 16 07:35:49 2019 New Revision: 358496 URL: http://llvm.org/viewvc/llvm-project?rev=358496&view=rev Log: [clangd] Check file path of declaring header when deciding whether to insert include. Summary: Previously, we would use include spelling of the declaring header to

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Anastasia added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:755 HelpText<"Include the default header file for OpenCL">; +def fgenerate_opencl_builtin: Flag<["-"], "fgenerate-opencl-builtin">, + HelpText<"Generate OpenCL builtin functions using Tableg

r358493 - [OPENMP]Require aarch arch for the tests, NFC.

Author: abataev Date: Tue Apr 16 07:26:10 2019 New Revision: 358493 URL: http://llvm.org/viewvc/llvm-project?rev=358493&view=rev Log: [OPENMP]Require aarch arch for the tests, NFC. Modified: cfe/trunk/test/OpenMP/declare_simd_aarch64.c cfe/trunk/test/OpenMP/declare_simd_aarch64.cpp cf

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Anastasia added a subscriber: joey. Anastasia added a comment. Not related to this patch but it might be good to start thinking about testing this functionality properly. In the past we haven't tested the header because it would take a lot of testing time. So I would suggest we keep a light mini

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28 CheckFactories.registerCheck("llvm-include-order"); +CheckFactories.registerCheck( +"llvm-prefer-isa-or-dyn-cast-in-c

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added inline comments. Comment at: unittests/clangd/DiagnosticsTests.cpp:620 +ParsedAST build(const std::string &MainFile, +const llvm::StringMap &Files) { ilya-biryukov wrote: > We were discussing adding the extra files to `TestTU` ins

[PATCH] D60775: [libclang] Expose ext_vector_type

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Expose `ext_vector_type` through the C API. Repository: rC Clang https://reviews.llvm.org/D60775 Files: bindings/python/clang/cindex.py includ

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 195375. kadircet marked 14 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/Diagnos

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1467279 , @aaron.ballman wrote: > > I'm still wondering what the actual semantics are for the attribute. Right > now, these are being parsed and ignored -- are there future plans here? Yes, we are going to teach

  1   2   >