stephanemoore added a comment.

In D59806#1469257 <https://reviews.llvm.org/D59806#1469257>, @aaron.ballman 
wrote:

> LGTM! You can either land this now and refactor after the AST matcher lands, 
> or you can wait until the AST matcher lands and land this patch after -- your 
> call.


I will plan on landing this and then follow up after the new AST matcher lands. 
I want to make sure the design for the new AST matcher is solid and evaluate 
the implications of the different approaches. I plan on updating both 
`ForbiddenSubclassingCheck` 
<https://github.com/llvm/llvm-project/blob/2946cd7/clang-tools-extra/clang-tidy/objc/ForbiddenSubclassingCheck.cpp#L55>
 and `SuperSelfCheck` once the new AST matcher lands 👍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59806/new/

https://reviews.llvm.org/D59806



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to