lebedev.ri added a comment.
In https://reviews.llvm.org/D50901#1261203, @rsmith wrote:
> This looks good to me. Sounds like @filcab is intending on doing another
> round of review too, so it'd make sense to double-check there before
> committing.
In https://reviews.llvm.org/D50901#1261312,
Hi Richard,
This patch broke ARM bots which don't have x86_64 target available.
Logs are available here:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/4326/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aprofile-remap.cpp
Cheers,
Yvan
On Thu, 11 Oct 2018 at 01:15, Richard
MTC added subscribers: teemperor, baloghadamsoftware, blitz.opensource.
MTC added a comment.
Herald added a subscriber: donat.nagy.
In https://reviews.llvm.org/D53024#1258976, @Szelethus wrote:
> Also, a lot of items on this list is outdated, but I joined the project
> relatively recently, so I'
lebedev.ri added inline comments.
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s
+
One last-minute thought: this is only a positive test.
You don't test what happens before C++17.
https:
thiagomacieira updated this revision to Diff 169152.
https://reviews.llvm.org/D53125
Files:
include/clang/Driver/Distro.h
lib/Driver/Distro.cpp
lib/Driver/ToolChains/Linux.cpp
unittests/Driver/DistroTest.cpp
Index: unittests/Driver/DistroTest.cpp
=
thiagomacieira updated this revision to Diff 169151.
thiagomacieira added a comment.
Oops, add the missing portion of the unit test (the part that actually tests).
https://reviews.llvm.org/D53125
Files:
include/clang/Driver/Distro.h
lib/Driver/Distro.cpp
lib/Driver/ToolChains/Linux.cpp
EricWF added a comment.
Herald added a subscriber: arphaman.
What's with all the XFAIL's?
Comment at:
test/std/utilities/time/time.cal/time.cal.ymwd/time.cal.ymwd.members/ctor.sys_days.pass.cpp:10
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// XFAIL
+
What?
thiagomacieira created this revision.
thiagomacieira added reviewers: mgorny, erichkeane.
Herald added subscribers: cfe-commits, srhines.
/usr/lib/os-release is the official path of /etc/os-release (the latter is
usually a symlink to the former)
Repository:
rC Clang
https://reviews.llvm.org/
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D52673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
srhines added a comment.
This LGTM, but we should wait to hear from Kristof before submitting.
Repository:
rC Clang
https://reviews.llvm.org/D53121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Really cool! Thanks for making everything easier to use out-of-the-box.
Repository:
rC Clang
https://reviews.llvm.org/D53109
___
cfe-commits
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1754
+ // argument here. Any constant would be converted to a register of
+ // the form S1_2_C3_C4_5. Let the hardware throw an exception for incorrect
+ // registers. This matches MSVC behavior.
---
danalbert added a comment.
Related to this but something I was less sure we should do: Android no longer
supports ARMv5. Should we make `arm-linux-androideabi` targets auto pull up to
armv7 if there's no `-march` flag?
Repository:
rC Clang
https://reviews.llvm.org/D53121
danalbert created this revision.
danalbert added reviewers: srhines, pirama.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
Android mandates that devices have at least vfpv3-d16 until
Marshmallow and NEON after that. Still honor the user's decision, but
raise
danalbert created this revision.
danalbert added reviewers: srhines, pirama.
Android supports GNU style hashes as of Marshmallow, so we should be
generating both styles for pre-M targets and GNU hashes for newer
targets.
Repository:
rC Clang
https://reviews.llvm.org/D53118
Files:
lib/Drive
danalbert created this revision.
danalbert added reviewers: srhines, pirama.
RTLD_LAZY is not supported on Android (though failing to use `-z now`
will work since it is assumed by the loader).
RelRO is required.
Repository:
rC Clang
https://reviews.llvm.org/D53117
Files:
lib/Drive
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344205: [WebAssembly] Saturating float-to-int builtins
(authored by tlively, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53009?vs=168738&id=169132#toc
Repository:
rC Clang
htt
Author: tlively
Date: Wed Oct 10 17:07:55 2018
New Revision: 344205
URL: http://llvm.org/viewvc/llvm-project?rev=344205&view=rev
Log:
[WebAssembly] Saturating float-to-int builtins
Summary: Depends on D53007 and D53004.
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunfish,
mgrang updated this revision to Diff 169127.
https://reviews.llvm.org/D53115
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
lib/Sema/SemaChecking.cpp
test/CodeGen/arm64-microsoft-status-reg.cpp
test/Sema/builtins-microsoft-arm64.c
Index:
Author: rsmith
Date: Wed Oct 10 16:33:18 2018
New Revision: 344201
URL: http://llvm.org/viewvc/llvm-project?rev=344201&view=rev
Log:
Update documentation to indicate that profile remapping support is only
implemented for the new pass manager so far.
Modified:
cfe/trunk/docs/UsersManual.rst
M
On 10/10/2018 4:13 PM, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Wed Oct 10 16:13:35 2018
New Revision: 344199
URL: http://llvm.org/viewvc/llvm-project?rev=344199&view=rev
Log:
Add a flag to remap manglings when reading profile data information.
This can be used to preserve prof
LGTM on the clang side too.
Thank you,
Filipe
On Wed, 10 Oct 2018 at 23:33, Richard Smith - zygoloid via Phabricator <
revi...@reviews.llvm.org> wrote:
> rsmith accepted this revision.
> rsmith added a comment.
> This revision is now accepted and ready to land.
>
> This looks good to me. Sounds
filcab added a comment.
LGTM on the clang side too.
Thank you,
Filipe
Repository:
rC Clang
https://reviews.llvm.org/D50901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
Missing Sema changes?
Repository:
rC Clang
https://reviews.llvm.org/D53115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Wed Oct 10 16:13:35 2018
New Revision: 344199
URL: http://llvm.org/viewvc/llvm-project?rev=344199&view=rev
Log:
Add a flag to remap manglings when reading profile data information.
This can be used to preserve profiling information across codebase
changes that have widespread
efriedma added a comment.
Probably should have a test for something like `float x = (__uint128_t)-1;`, to
make sure we print something reasonable.
Comment at: lib/Sema/SemaChecking.cpp:10874
+ if (Target->isSpecificBuiltinType(BuiltinType::LongDouble))
+FloatSem =
mgrang added inline comments.
Comment at: test/CodeGen/arm64-microsoft-status-reg.cpp:1
+// RUN: %clang_cc1 -triple arm64-windows -fms-compatibility -emit-llvm -S \
+// RUN: -o - %s | FileCheck %s -check-prefix CHECK-ASM
I had to create a new test file here as th
mgrang added a comment.
_ReadStatusReg and _WriteStatusReg intrinsics take ARM64_REGNO as input. These
are defined in https://www.codemachine.com/downloads/win10/winnt.h.
LLVM already has intrinsics to read/write status regs:
__builtin_arm_rsr/__builtin_arm_wsr. But these take the string concate
mgrang created this revision.
mgrang added reviewers: rnk, compnerd, mstorsjo, efriedma, TomTan, haripul.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
Repository:
rC Clang
https://reviews.llvm.org/D53115
Files:
include/clang/Basic/BuiltinsAArch64.def
rsmith accepted this revision.
rsmith added a comment.
Thanks, LGTM!
Are you interested in fixing the other cases for which p0145 tightened
evaluation order (`.`, `->`, `.*`, `->*`, `<<`, `>>`, callee in a function
call, assignment and compound assignment) too? =)
https://reviews.llvm.org/D50
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks good to me. Sounds like @filcab is intending on doing another round
of review too, so it'd make sense to double-check there before committing.
Comment at: docs/Un
xbolva00 added a comment.
Any comments? Waiting for approval here to move focus on some other patches :)
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Rakete accepted this revision.
Rakete added a comment.
This revision is now accepted and ready to land.
Nevermind my last comment, I was tired. LGTM
https://reviews.llvm.org/D50766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: rnk
Date: Wed Oct 10 14:59:56 2018
New Revision: 344190
URL: http://llvm.org/viewvc/llvm-project?rev=344190&view=rev
Log:
[AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals
Summary:
In r340386 we added code to give static locals in inline functions
default visibility
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344190: [AST] Use -fvisibility value when ignoring -fv-i-h*
inline static locals (authored by rnk, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.o
NoQ added a comment.
In https://reviews.llvm.org/D53076#1260663, @george.karpenkov wrote:
> 1. Note that "Assuming X" directives are useful for the analyzer developers,
> since they know that's where the checker makes arbitrary assumptions, but to
> end users that mostly feels like noise ("Taki
danalbert updated this revision to Diff 169097.
danalbert added a comment.
Fixed bad merge conflict resolution.
Repository:
rC Clang
https://reviews.llvm.org/D53109
Files:
lib/Driver/ToolChains/Linux.cpp
lib/Driver/ToolChains/Linux.h
test/Driver/android-ndk-standalone.cpp
Index: test/
danalbert planned changes to this revision.
danalbert added a comment.
Oops, ignore this for a moment. Accidentally ran `check-cxx` instead of
`check-clang`.
Repository:
rC Clang
https://reviews.llvm.org/D53109
___
cfe-commits mailing list
cfe-c
Rakete added a comment.
Sorry, for some reason I didn't see your updates.
Can you add a test for C++17? Then your patch is good to go! :)
https://reviews.llvm.org/D50766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
danalbert created this revision.
danalbert added reviewers: srhines, pirama.
Herald added a reviewer: EricWF.
Repository:
rC Clang
https://reviews.llvm.org/D53109
Files:
lib/Driver/ToolChains/Linux.cpp
lib/Driver/ToolChains/Linux.h
test/Driver/android-ndk-standalone.cpp
Index: test/Driv
On Wed, Oct 10, 2018 at 5:11 PM Zachary Turner wrote:
>
> Yea, that’s actually another reason I suggest trying the Clang Power Tools
> extension. It seems to have “won” in this area, and few people ever used the
> LLVM one to begin with.
Given that this isn't being updated and it may not work,
Yea, that’s actually another reason I suggest trying the Clang Power Tools
extension. It seems to have “won” in this area, and few people ever used
the LLVM one to begin with.
On Wed, Oct 10, 2018 at 2:09 PM Aaron Ballman
wrote:
> On Wed, Oct 10, 2018 at 4:54 PM Zachary Turner wrote:
> >
> > Hon
rsmith added a comment.
Herald added a subscriber: arphaman.
This looks great, thanks!
In https://reviews.llvm.org/D36527#892395, @hamzasood wrote:
> Could you expand on your first point a bit more? Do you have an example that
> shows the issue?
You have very little test coverage for the case
On Wed, Oct 10, 2018 at 4:54 PM Zachary Turner wrote:
>
> Honestly I hadn’t thought about this ever since the patch. Out of curiosity,
> have you tried the clang power tools extension? I think it’s more actively
> maintained and at this point probably even is good enough that this one could
> j
Honestly I hadn’t thought about this ever since the patch. Out of
curiosity, have you tried the clang power tools extension? I think it’s
more actively maintained and at this point probably even is good enough
that this one could just go away
On Wed, Oct 10, 2018 at 1:52 PM Aaron Ballman
wrote:
>
On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits
wrote:
>
> Author: zturner
> Date: Wed Sep 7 13:28:55 2016
> New Revision: 280840
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280840&view=rev
> Log:
> Add a clang-tidy visual studio extension.
>
> For now this only adds the UI nec
rnk accepted this revision.
rnk added a comment.
lgtm
Comment at: lib/Driver/Job.cpp:319
+ if (PrintInputFilenames) {
+for (const char *Arg : InputFilenames)
+ llvm::outs() << llvm::sys::path::filename(Arg) << "\n";
Huh, a -cc1 action can have multipl
rnk added a comment.
In https://reviews.llvm.org/D52193#1260933, @aganea wrote:
> I wrote a fully fledged crash reporting system which does that, so I know
> that's possible. The tricky thing is to ensure
> `Driver::generateCompilationDiagnostics()` doesn't touch potentially invalid
> structur
rsmith added a comment.
In https://reviews.llvm.org/D52973#1259992, @mwasplund wrote:
> In https://reviews.llvm.org/D52973#1259909, @rsmith wrote:
>
> > Generally this looks good, but it needs an accompanying test.
>
>
> I was looking into that and trying to read up on the documentation for addin
aganea added a comment.
In https://reviews.llvm.org/D52193#1260862, @zturner wrote:
> I can try to get some timings from my machine. How do we handle crash
> recovery in the case where we don't spawn a child process? I thought the
> whole reason for spawning the cc1 driver as a separate proce
nickdesaulniers added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:543-549
+static const char* GetEndianArg(bool IsBigEndian, const ArgList &Args) {
+ if (Arg *A = Args.getLastArg(options::OPT_mlittle_endian,
+ options::OPT_mbig_endian
nruslan created this revision.
nruslan added reviewers: hans, craig.topper.
Herald added a subscriber: cfe-commits.
Allows to disable direct TLS segment access (%fs or %gs). GCC supports a
similar flag, it can be useful in some circumstances, e.g. when a thread
context block needs to be updated
tatyana-krasnukha created this revision.
tatyana-krasnukha added a reviewer: petecoup.
tatyana-krasnukha added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
tatyana-krasnukha added a dependency: D53100: clang: Add ARCTargetInfo.
This option affects registers count for passing ar
zturner added a comment.
I can try to get some timings from my machine. How do we handle crash
recovery in the case where we don't spawn a child process? I thought the
whole reason for spawning the cc1 driver as a separate process was so that
we could collect and report crash information in a ni
I can try to get some timings from my machine. How do we handle crash
recovery in the case where we don't spawn a child process? I thought the
whole reason for spawning the cc1 driver as a separate process was so that
we could collect and report crash information in a nice way. Not having
that s
Charusso added subscribers: baloghadamsoftware, whisperity.
Charusso added a comment.
In https://reviews.llvm.org/D53076#1260663, @george.karpenkov wrote:
> The change makes sense to me, but:
>
> 1. Note that "Assuming X" directives are useful for the analyzer developers,
> since they know that'
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: petecoup, rjmccall, rsmith.
tatyana-krasnukha added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
This patch is an updated version of https://reviews.llvm.org/D43089 with
changes in arguments classifyin
aganea added a comment.
Updated tests again. This time I've closed all applications, all unused
services, and tried to have a "clean" machine.
New timings without the child `clang-cl.exe` being invoked (hacked from
https://reviews.llvm.org/D52411). The test consists in building Clang+LLVM+LLD
Szelethus added a comment.
I noticed it too, it's already on my TODO list. Didn't look into the causes
just yet though.
https://reviews.llvm.org/D52984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
nickdesaulniers added a comment.
I think we should pass these flags along to the linker, too. Not just the
assembler. Maybe within tools::gnutools::Linker::ConstructJob() within
lib/Driver/ToolChains/Gnu.cpp?
https://reviews.llvm.org/D52784
___
c
JonasToth added a comment.
In https://reviews.llvm.org/D46027#1259989, @ZaMaZaN4iK wrote:
> What is the status of the PR?
I believe xazax doesnt have time to work further, you can commandeer if you
want :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46027
_
george.karpenkov added a comment.
Herald added a subscriber: donat.nagy.
@Szelethus @xazax.hun Since you guys are looking into the website, do you know
why the top bar has disappeared from all pages? (E.g.
http://clang-analyzer.llvm.org/available_checks.html )
https://reviews.llvm.org/D52984
Szelethus added a comment.
Well, the reason why I didn't add tests for these, is that I know so little of
ObjC, I am not even sure when a test case begins and ends. I could go ahead and
google something about the language, but for a site that advertises to find
bugs, maybe someone with more exp
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: donat.nagy.
Great idea, thanks!
Should be good to go once examples are added, and implicit checks are removed.
Comme
Author: ldionne
Date: Wed Oct 10 10:37:37 2018
New Revision: 344159
URL: http://llvm.org/viewvc/llvm-project?rev=344159&view=rev
Log:
[clang] Fix failing attribute test on Windows
The test added in r344146 was failing because the ABI on Windows is
different, and that test includes ABI-specific de
oleg.smolsky added a comment.
@djasper @klimek could you chime in please? This patch strives to cleanup a
quirk in lambda formatting which pushes code too far to the right. Here is the
problematic case:
void f() {
something.something.something.Method(some_arg,
aaron.ballman added a comment.
@steveire and I chatted over IRC and I wanted to capture another alternate
proposal idea as part of the review (we did not reach agreement on this
proposal, however). I've provided it side-by-side with the other proposals for
comparison purposes.
# Original pro
george.karpenkov added a comment.
The change makes sense to me, but:
1. Note that "Assuming X" directives are useful for the analyzer developers,
since they know that's where the checker makes arbitrary assumptions, but to
end users that mostly feels like noise ("Taking true branch" is there al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344157: [Sema] Fix a multiple definition bug with friends
and templates (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53
Author: epilk
Date: Wed Oct 10 10:17:51 2018
New Revision: 344157
URL: http://llvm.org/viewvc/llvm-project?rev=344157&view=rev
Log:
[Sema] Fix a multiple definition bug with friends and templates
The problem was that MergeFunctionDecl sometimes needs the injected template
arguments of a FunctionT
peter.smith added a comment.
Ping. Does anyone have any changes they'd like me to make?
https://reviews.llvm.org/D52784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad added a comment.
IMHO it would be best to try and deal with as many known / exposed issues with
the N32 support and then just enable IAS across the board. Then tackle any
remaining issues as they come up.
Repository:
rC Clang
https://reviews.llvm.org/D52418
_
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 344152
https://reviews.llvm.org/D42242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AntonBikineev added a comment.
@rsmith, thanks. Le'ts see if there is a need for the command-line option down
the road.
Repository:
rL LLVM
https://reviews.llvm.org/D46441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
yaxunl added a comment.
In https://reviews.llvm.org/D52891#1258070, @scott.linder wrote:
> I will update the patch to modify the HIP toolchain and to add tests for
> global variables.
>
> As far as the semantics are concerned, are we OK with this being AMDGPU only?
> I do not see a means of det
Anastasia closed this revision.
Anastasia added a comment.
Committed in r344148. The review link was forgotten and therefore didn't get
closed automatically.
https://reviews.llvm.org/D52598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: stulova
Date: Wed Oct 10 09:05:22 2018
New Revision: 344148
URL: http://llvm.org/viewvc/llvm-project?rev=344148&view=rev
Log:
[OpenCL] Fixed address space cast in C style cast of C++ parsing
C style cast in OpenCL C++ was ignoring the address space
conversions from OpenCL C and as a resul
atanasyan added a comment.
I'm going to test current MIPS N32 ABI implementation. Maybe we are ready to
enable integrated assembler for it. In that case both
`Generic_GCC::IsIntegratedAssemblerDefault()` and `MipsMCAsmInfo` ctor can be
simplified.
https://reviews.llvm.org/D51464
__
atanasyan added a comment.
In https://reviews.llvm.org/D52418#1256189, @brad wrote:
> Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp?
Good point. In fact, integrated assembler for GNUABIN32 was enabled in the
`MipsMCAsmInfo` ctor by me and by mistake. I have another patch
steveire added a comment.
> I don't see this functionality being so critical that we need to deprecate
> the existing spelling when there are backwards compatible options available,
> which is why I'm opposed to this patch going in with the proposed syntax.
I don't think we're going to go anywh
Author: sidneym
Date: Wed Oct 10 08:37:03 2018
New Revision: 344147
URL: http://llvm.org/viewvc/llvm-project?rev=344147&view=rev
Log:
[Hexagon] Use GetLinkerPath instead of hard-coded string.
Add GetLinkerPath and set the default to "hexagon-link".
Use GetLinkerPath instead of the hard-coded stri
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344147: [Hexagon] Use GetLinkerPath instead of hard-coded
string. (authored by sidneym, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53038
Files:
lib/Driver/ToolChains/Hexagon.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344146: [clang] Properly apply attributes on explicit
instantiations of static data… (authored by ldionne, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: ldionne
Date: Wed Oct 10 08:32:29 2018
New Revision: 344146
URL: http://llvm.org/viewvc/llvm-project?rev=344146&view=rev
Log:
[clang] Properly apply attributes on explicit instantiations of static data
members
Summary: https://llvm.org/PR39118
Reviewers: aaron.ballman, rnk
Subscribers:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D53046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Szelethus added a comment.
I'm sadly not that knowledgeable on visitors to help you, but the idea is
awesome, thank you for working on this!
https://reviews.llvm.org/D53076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test framework, with a small
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test framework, with a small
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test fram
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1260455, @steveire wrote:
> > you have to find the right place to stick the `set dump-output true` in
> > order to enable it.
>
> What do you mean "the right place"?
The point from which they want to enable dump outputting.
steveire added a comment.
> you have to find the right place to stick the `set dump-output true` in
> order to enable it.
What do you mean "the right place"?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits m
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1259522, @steveire wrote:
> > What's more, given that clang-output has no real documentation to speak of,
> > how will users even *know* to update their scripts?
>
> The release notes will tell them.
That's not user friendly.
>
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D53079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added a project: clang.
Herald added subscribers: cfe-commits, arphaman, guansong.
Added new `dynamic_allocators` clause to existing OMP5.0
lebedev.ri added a reviewer: JonasToth.
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
LG unless @JonasToth or @aaron.ballman has any further comments.
https://reviews.llvm.org/D52727
hans added a comment.
Thanks! I think this is getting close now.
Comment at: clang/lib/Sema/SemaDecl.cpp:11976
+
+while (FD && !getDLLAttr(FD) &&
+ !FD->hasAttr() &&
Why does this need to be a loop? I don't think FunctionDecl's can be nested?
==
hans updated this revision to Diff 168999.
hans added a comment.
Here's a version now using cc1 flags, but printing directly from the driver.
Please take a look.
https://reviews.llvm.org/D52773
Files:
include/clang/Driver/CLCompatOptions.td
include/clang/Driver/Job.h
lib/Driver/Job.cpp
xbolva00 added a comment.
In https://reviews.llvm.org/D52949#1259947, @jfb wrote:
> Can you add tests with arrays?
Yes :)
> The error message doesn't really say what to do instead. What's wrong? What's
> correct instead?
What do you suggest? "division produces the incorrect number of array e
Author: jdevlieghere
Date: Wed Oct 10 06:27:25 2018
New Revision: 344140
URL: http://llvm.org/viewvc/llvm-project?rev=344140&view=rev
Log:
Lift VFS from clang to llvm (NFC)
This patch moves the virtual file system form clang to llvm so it can be
used by more projects.
Concretely the patch:
- Mo
1 - 100 of 134 matches
Mail list logo
