efriedma added inline comments.

================
Comment at: lib/Sema/SemaChecking.cpp:1754
+  // argument here. Any constant would be converted to a register of
+  // the form S1_2_C3_C4_5. Let the hardware throw an exception for incorrect
+  // registers. This matches MSVC behavior.
----------------
I agree we shouldn't try to figure out whether the register is valid, but we 
probably want a range check anyway: if the value is greater than 0x7FFF, it 
can't be encoded.


https://reviews.llvm.org/D53115



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to