[PATCH] D51090: [clangd] Add index benchmarks

lebedev.ri accepted this revision. lebedev.ri added a comment. In https://reviews.llvm.org/D51090#1230659, @kbobyrev wrote: > Add `--benchmark_min_time=0.01` to prevent testing time increase. Thanks! https://reviews.llvm.org/D51090 ___ cfe-commit

[PATCH] D51847: Print correctly dependency paths on Windows

xbolva00 updated this revision to Diff 165012. xbolva00 added a comment. Convert paths to platform native paths https://reviews.llvm.org/D51847 Files: lib/Frontend/DependencyFile.cpp Index: lib/Frontend/DependencyFile.cpp === -

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

lebedev.ri added a comment. Thank you for working on this! I really miss this check. To be noted, there is preexisting, almost finished version - https://reviews.llvm.org/D27621. I'm not sure in what state it really is, but it might be simpler to take that over and finish it. Repository: rCT

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

This revision was automatically updated to reflect the committed changes. Closed by commit rC342021: [Driver] Search LibraryPaths when handling -print-file-name (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D51573?vs=163636&id=165008#toc Repository: r

r342021 - [Driver] Search LibraryPaths when handling -print-file-name

Author: phosek Date: Tue Sep 11 20:26:10 2018 New Revision: 342021 URL: http://llvm.org/viewvc/llvm-project?rev=342021&view=rev Log: [Driver] Search LibraryPaths when handling -print-file-name This is necessary to handle the multiarch runtime directories. Differential Revision: https://reviews.l

r342020 - Revert r342019, "Track definition merging on the canonical declaration

Author: rsmith Date: Tue Sep 11 19:28:14 2018 New Revision: 342020 URL: http://llvm.org/viewvc/llvm-project?rev=342020&view=rev Log: Revert r342019, "Track definition merging on the canonical declaration even when [...]" Further testing has revealed that this causes build breaks during explicit m

r342019 - Track definition merging on the canonical declaration even when local

Author: rsmith Date: Tue Sep 11 19:13:48 2018 New Revision: 342019 URL: http://llvm.org/viewvc/llvm-project?rev=342019&view=rev Log: Track definition merging on the canonical declaration even when local submodule visibility is disabled. Attempting to pick a specific declaration to make visible wh

r342017 - Fix tracking of merged definitions when the merge target is also merged

Author: rsmith Date: Tue Sep 11 19:13:46 2018 New Revision: 342017 URL: http://llvm.org/viewvc/llvm-project?rev=342017&view=rev Log: Fix tracking of merged definitions when the merge target is also merged into something else. Added: cfe/trunk/test/Modules/merge-template-pattern-visibility-2.c

r342018 - Consistently create a new declaration when merging a pre-existing but

Author: rsmith Date: Tue Sep 11 19:13:47 2018 New Revision: 342018 URL: http://llvm.org/viewvc/llvm-project?rev=342018&view=rev Log: Consistently create a new declaration when merging a pre-existing but hidden definition with a would-be-parsed redefinition. This permits a bunch of cleanups. In pa

[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

aaronpuchert marked an inline comment as done. aaronpuchert added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3016-3017 +def warn_thread_attribute_not_on_capability_member : Warning< + "%0 attribute without capability arguments can only be applied in

[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

aaronpuchert updated this revision to Diff 165004. aaronpuchert added a comment. Improved handling of type-dependent base classes and slightly reworded warning message. Repository: rC Clang https://reviews.llvm.org/D51901 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDe

[clang-tools-extra] r342012 - [NFC] Fix build breakage due to missing dep caused by D51950

Author: shuaiwang Date: Tue Sep 11 17:32:13 2018 New Revision: 342012 URL: http://llvm.org/viewvc/llvm-project?rev=342012&view=rev Log: [NFC] Fix build breakage due to missing dep caused by D51950 Modified: clang-tools-extra/trunk/clang-tidy/performance/CMakeLists.txt Modified: clang-tools-e

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

vlad.tsyrklevich added a comment. This change causes all compiler-rt cfi tests to be UNSUPPORTED for me locally, do you have any idea why that might be? The lit changes don't make it immediately clear. Comment at: clang/lib/CodeGen/CGVTables.cpp:1055 +// When vtable inter

[clang-tools-extra] r342006 - [clangtidy] Remove old copy of ExprMutationAnalyzer

Author: shuaiwang Date: Tue Sep 11 15:59:46 2018 New Revision: 342006 URL: http://llvm.org/viewvc/llvm-project?rev=342006&view=rev Log: [clangtidy] Remove old copy of ExprMutationAnalyzer Summary: This is 2/2 of moving ExprMutationAnalyzer from clangtidy to clang/Analysis. ExprMutationAnalyzer is

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth added a comment. Ty for the initial review, I am currently rewriting the approach for it. I will probably make the business logic as standalone class/functions to utilize this functionality in multiple checks. I first try to evaluate my approach and as I had many unclear things i opened

[PATCH] D51950: [clangtidy] Remove old copy of ExprMutationAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342006: [clangtidy] Remove old copy of ExprMutationAnalyzer (authored by shuaiwang, committed by ). Changed prior to commit: https://reviews.llvm.org/D51950?vs=164977&id=164991#toc Repository: rCTE

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

Eugene.Zelenko added a comment. I would suggest to use declaration or declarations in check name instead of abbreviation. Actually there are existing coding guidelines for thus rule, like SEI CERT

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:29 + +namespace { +std::string GetIsolatedDecl(const VarDecl *D, const SourceManager &SM, Please use static instead. Comment at: clang-tidy/readabilit

r342005 - [NFC] Fix build breakage caused by D51948

Author: shuaiwang Date: Tue Sep 11 15:41:14 2018 New Revision: 342005 URL: http://llvm.org/viewvc/llvm-project?rev=342005&view=rev Log: [NFC] Fix build breakage caused by D51948 Modified: cfe/trunk/lib/Analysis/CMakeLists.txt Modified: cfe/trunk/lib/Analysis/CMakeLists.txt URL: http://llvm.

[PATCH] D51955: Create infrastructure for defining and testing feature test macros

mclow.lists created this revision. mclow.lists added reviewers: ldionne, EricWF. Herald added a reviewer: jfb. Herald added a subscriber: jfb. mclow.lists edited the summary of this revision. In P0941 , the committee standardized a bunch of feature test macros. [ I think

[PATCH] D51950: [clangtidy] Remove old copy of ExprMutationAnalyzer

JonasToth added a comment. LGTM (not owner, but alexfh was not involved in the ExprMutAnalyzer so far, i think he has no concerns with moving that around as it is fairly new as well) Am 11.09.2018 um 23:44 schrieb George Karpenkov via Phabricator: > george.karpenkov added a comment. > > Looks g

[PATCH] D51950: [clangtidy] Remove old copy of ExprMutationAnalyzer

george.karpenkov added a comment. Looks good to me, but I'm not the code owner. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D51950: [clangtidy] Remove old copy of ExprMutationAnalyzer

shuaiwang created this revision. shuaiwang added reviewers: george.karpenkov, JonasToth. Herald added subscribers: cfe-commits, Szelethus, a.sidorin, mgorny. This is 2/2 of moving ExprMutationAnalyzer from clangtidy to clang/Analysis. ExprMutationAnalyzer is moved to clang/Analysis in https://rev

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth created this revision. JonasToth added reviewers: rsmith, aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun, mgorny. The idea of this check is to enforce one decl per statement and to include an automated code transformation for all multi-decl statments. It

[PATCH] D51948: [analyzer] Add ExprMutationAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rC341994: [analyzer] Add ExprMutationAnalyzer (authored by shuaiwang, committed by ). Changed prior to commit: https://reviews.llvm.org/D51948?vs=164969&id=164972#toc Repository: rL LLVM https://revie

[PATCH] D51948: [analyzer] Add ExprMutationAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL341994: [analyzer] Add ExprMutationAnalyzer (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51948 Files: cfe/trunk/incl

r341994 - [analyzer] Add ExprMutationAnalyzer

Author: shuaiwang Date: Tue Sep 11 14:13:20 2018 New Revision: 341994 URL: http://llvm.org/viewvc/llvm-project?rev=341994&view=rev Log: [analyzer] Add ExprMutationAnalyzer Summary: This is 1/2 of moving ExprMutationAnalyzer from clangtidy to clang/Analysis. This diff along simply copies the ExprM

[PATCH] D51948: [analyzer] Add ExprMutationAnalyzer

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Wow, thanks a lot, I'm really looking forward to using this! Repository: rC Clang https://reviews.llvm.org/D51948 ___ cfe-

[PATCH] D51948: [analyzer] Add ExprMutationAnalyzer

shuaiwang created this revision. shuaiwang added a reviewer: george.karpenkov. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, szepet, xazax.hun, mgorny. This is 1/2 of moving ExprMutationAnalyzer from clangtidy to clang/Analysis. This diff along simply copies the Ex

[libcxx] r341990 - Update the synopsis for . NFC

Author: marshall Date: Tue Sep 11 13:51:54 2018 New Revision: 341990 URL: http://llvm.org/viewvc/llvm-project?rev=341990&view=rev Log: Update the synopsis for . NFC Modified: libcxx/trunk/include/version Modified: libcxx/trunk/include/version URL: http://llvm.org/viewvc/llvm-project/libcxx/

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rC341989: Introduce the VTable interleaving scheme to the CFI design documentation (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D50372?vs=164964&id=164967#toc Repos

r341989 - Introduce the VTable interleaving scheme to the CFI design documentation

Author: pcc Date: Tue Sep 11 13:43:52 2018 New Revision: 341989 URL: http://llvm.org/viewvc/llvm-project?rev=341989&view=rev Log: Introduce the VTable interleaving scheme to the CFI design documentation Dimitar et. al. in [1] proposed a novel VTable layout scheme that enables efficient implement

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

zhaomo updated this revision to Diff 164964. zhaomo added a comment. Fixed typos pointed out by pcc. https://reviews.llvm.org/D50372 Files: clang/docs/ControlFlowIntegrityDesign.rst Index: clang/docs/ControlFlowIntegrityDesign.rst =

[PATCH] D51945: [Clang] Fix test to followup https://reviews.llvm.org/rL341977

calixte added a comment. My bad, I missed that Repository: rC Clang https://reviews.llvm.org/D51945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

pcc added a comment. Can you update this patch please? Then I will commit. https://reviews.llvm.org/D50372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51945: [Clang] Fix test to followup https://reviews.llvm.org/rL341977

vsk added a comment. I took care of this in r341985. Repository: rC Clang https://reviews.llvm.org/D51945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. ...and unless I'm mistaken, this commit is responsible for both changes (that is, I need to apply all of this patch to make tests pass at its point). https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D51340: [WIP] Add /Zc:DllexportInlines option to clang-cl

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244 + false)) +CmdArgs.push_back("-fvisibility-inlines-hidden"); + takuto.ikuta wrote: > hans wrote: > > takuto.ikuta wrote: > > > hans wrote: > > > > Huh, does th

[PATCH] D51946: Remove PseudoConstantAnalysis

shuaiwang created this revision. Herald added subscribers: cfe-commits, mgorny. It's not used anywhere for years. The last usage is removed in https://reviews.llvm.org/rL198476 in 2014. Repository: rC Clang https://reviews.llvm.org/D51946 Files: include/clang/Analysis/Analyses/PseudoConst

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Apparently the first change changing the completion results is: commit a408f8d27bfd5bab55c39ef2a6fff6850be4a351 Author: Ilya Biryukov Date: Tue Apr 24 15:48:53 2018 [CodeComplete] Fix completion at the end of keywords Summary: Make comp

[PATCH] D51945: [Clang] Fix test to followup https://reviews.llvm.org/rL341977

calixte created this revision. calixte added a reviewer: vsk. Herald added a subscriber: cfe-commits. In the previous patch, __llvm_gcov_indirect_counter_increment has been removed. Repository: rC Clang https://reviews.llvm.org/D51945 Files: test/CodeGen/code-coverage.c Index: test/CodeG

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL341986: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

efriedma accepted this revision. efriedma added a comment. LGTM https://reviews.llvm.org/D50507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r341986 - [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

Author: shuaiwang Date: Tue Sep 11 13:05:37 2018 New Revision: 341986 URL: http://llvm.org/viewvc/llvm-project?rev=341986&view=rev Log: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer Summary: This handles cases like this: ``` typedef int& IntRef; void mutate(IntRef); void f()

[PATCH] D51416: [RTTI] Align rtti types to prevent over-alignment

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one change. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2730 llvm::GlobalVariable *GV = -CGM.CreateOrReplaceCXXRuntimeVariable(Name, Init->getType(), Linka

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

pcc added a subscriber: cfe-commits. pcc added a reviewer: rsmith. pcc added inline comments. Comment at: clang/lib/CodeGen/CGCXXABI.h:53 + // interleaved layout is decided. + bool EnableVTableInterleaving; + Why does this need to be stored separately on the CG

r341985 - [gcov] Update a clang test for r341977

Author: vedantk Date: Tue Sep 11 12:42:58 2018 New Revision: 341985 URL: http://llvm.org/viewvc/llvm-project?rev=341985&view=rev Log: [gcov] Update a clang test for r341977 Update test/CodeGen/code-coverage.c so that it doesn't refer to a gcov function which is no longer emitted after r341977. F

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 164948. JonasToth marked 7 inline comments as done. JonasToth added a comment. - Merge branch 'master' into check_macros_usage - address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguide

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. F7179032: llvm_lib_references.out F7179031: llvm_lib_pointer_values.out F7179030: llvm_lib_values.out Here are results for `llvm/lib` with the current version.

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

stryku marked an inline comment as done. stryku added a comment. Not sure if you guys are still reviewing this. Do you have any more thoughts? If no, what should I do to move further with the patch? https://reviews.llvm.org/D50766 ___ cfe-commits m

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

r341978 - [analyzer] [NFC] Change the tests by making the version check more resilient

Author: george.karpenkov Date: Tue Sep 11 11:45:15 2018 New Revision: 341978 URL: http://llvm.org/viewvc/llvm-project?rev=341978&view=rev Log: [analyzer] [NFC] Change the tests by making the version check more resilient Modified: cfe/trunk/test/Analysis/MismatchedDeallocator-path-notes.cpp

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

shuaiwang updated this revision to Diff 164938. shuaiwang added a comment. More test cases: - Mutating pointers - Const values Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50953 Files: clang-tidy/utils/ExprMutationAnalyzer.cpp unittests/clang-tidy/ExprMutationAnalyzerTes

[libcxx] r341975 - Fix PR# 38900 - don't call swap inside of random_shuffle when we'd be swapping an element with itself

Author: marshall Date: Tue Sep 11 11:33:45 2018 New Revision: 341975 URL: http://llvm.org/viewvc/llvm-project?rev=341975&view=rev Log: Fix PR# 38900 - don't call swap inside of random_shuffle when we'd be swapping an element with itself Modified: libcxx/trunk/include/algorithm Modified: lib

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

JonasToth added a comment. > I feel constness doesn't matter much since we're treating them as values and > both const values & non-const values are just values. marking the pointer itself const is not very common as well, thats why i feel we should be especially exhaustive with our tests as re

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

JonasToth added a comment. Could you please add a mutating test for the pointers as well? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

shuaiwang added a comment. In https://reviews.llvm.org/D50953#1230138, @JonasToth wrote: > In https://reviews.llvm.org/D50953#1230003, @shuaiwang wrote: > > > In https://reviews.llvm.org/D50953#1229287, @JonasToth wrote: > > > > > What happens to pointers in a typedef (in the sense of `*` instead

[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

shuaiwang updated this revision to Diff 164929. shuaiwang added a comment. more test cases Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50953 Files: clang-tidy/utils/ExprMutationAnalyzer.cpp unittests/clang-tidy/ExprMutationAnalyzerTest.cpp Index: unittests/clang-tidy/Ex

[PATCH] D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341967: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer (authored by shuaiwang, committed by ). Changed prior to commit: https://reviews.llvm.org/D50883?vs=164810&id=164926#to

[clang-tools-extra] r341967 - [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer

Author: shuaiwang Date: Tue Sep 11 10:33:12 2018 New Revision: 341967 URL: http://llvm.org/viewvc/llvm-project?rev=341967&view=rev Log: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer Summary: For smart pointers like std::unique_ptr which uniquely owns the underlying obje

[PATCH] D51847: Print correctly dependency paths on Windows

zturner added a comment. clang-cl in general tries to do the thing that makes native Windows developers the most comfortable, while gcc in general tries to do the thing that makes Unix developers most comfortable. So I think we should probably use \ here. If anyone complains we can revisit.

[PATCH] D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

This revision was automatically updated to reflect the committed changes. Closed by commit rC341963: [clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop (authored by mikerice, committed by ). Changed prior to commit: https://reviews.llvm.org/D51391?vs=164698&id=164917#t

r341963 - [clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop

Author: mikerice Date: Tue Sep 11 10:10:44 2018 New Revision: 341963 URL: http://llvm.org/viewvc/llvm-project?rev=341963&view=rev Log: [clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop With clang-cl, when the user specifies /Yc or /Yu without a filename the compiler use

[PATCH] D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer

shuaiwang added a comment. Yeah let's see what happens in the wild and decide whether we need further actions. In any case I think that deserves a separate diff. Is there other concerns about this diff? In https://reviews.llvm.org/D50883#1230805, @JonasToth wrote: > Your point is valid, that th

[PATCH] D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer

JonasToth added a comment. Your point is valid, that the decision of what to analyze should be done outside. My const-correctness check does analyze all versions of the templated function, because it just matches on `functionDecl(compoundStmt())`. Maybe we just need some experience with real worl

[PATCH] D51847: Print correctly dependency paths on Windows

xbolva00 added a comment. In https://reviews.llvm.org/D51847#1230766, @zturner wrote: > Alright I see it. The reason I'm asking is because after your change you're > now printing `main.o: main.c ../include/lib/test.h`. But I wonder if you > should instead be printing `main.o: main.c ..\includ

[PATCH] D51847: Print correctly dependency paths on Windows

zturner added a comment. Alright I see it. The reason I'm asking is because after your change you're now printing `main.o: main.c ../include/lib/test.h`. But I wonder if you should instead be printing `main.o: main.c ..\include\lib\test.h`. It seems like paths that we show to the user should

[PATCH] D51847: Print correctly dependency paths on Windows

xbolva00 added a comment. Please see PR38877. https://reviews.llvm.org/D51847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer

shuaiwang added inline comments. Comment at: unittests/clang-tidy/ExprMutationAnalyzerTest.cpp:658 + "void f() { UniquePtr x; x->mf(); }"); + Results = match(withEnclosingCompound(declRefTo("x")), AST->getASTContext()); + EXPECT_FALSE(isMutated(Results, AST.

[PATCH] D51880: [ASTMatchers] add three matchers for dependent expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rC341958: [ASTMatchers] add three matchers for dependent expressions (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D51880?vs=164876&id=164907#toc Repository:

r341958 - [ASTMatchers] add three matchers for dependent expressions

Author: jonastoth Date: Tue Sep 11 09:09:19 2018 New Revision: 341958 URL: http://llvm.org/viewvc/llvm-project?rev=341958&view=rev Log: [ASTMatchers] add three matchers for dependent expressions Summary: The new matchers can be used to check if an expression is type-, value- or instantiation-dep

[PATCH] D51880: [ASTMatchers] add three matchers for dependent expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL341958: [ASTMatchers] add three matchers for dependent expressions (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51880

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341955: Reland "Implement a (simple) Markdown generator" (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D43424?vs=161123&id=164903#toc Repository: rL L

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL341955: Reland "Implement a (simple) Markdown generator" (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43424?vs=1

[clang-tools-extra] r341955 - Reland "Implement a (simple) Markdown generator"

Author: juliehockett Date: Tue Sep 11 08:56:55 2018 New Revision: 341955 URL: http://llvm.org/viewvc/llvm-project?rev=341955&view=rev Log: Reland "Implement a (simple) Markdown generator" Relanding with fixes to tests for the failing bots. Differential Revision: https://reviews.llvm.org/D43424

[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D51880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D51544: [OpenCL] Split opencl-c.h header

Anastasia added a comment. In https://reviews.llvm.org/D51544#1230264, @asavonic wrote: > In https://reviews.llvm.org/D51544#1229105, @Anastasia wrote: > > > > With this setup, we can compile opencl-c-common.h, opencl-c-fp16.h and > > > opencl-c-fp64.h into PCHs with one set of extensions/OpenCL

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 164898. JonasToth added a comment. - ignore lambdas properly Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp clang-tidy/c

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:55 + +// llvm::formatv string pattern for pretty-printing symbols. +void fuzzyFind(llvm::StringRef UnqualifiedName, const SymbolIndex &Index) { Is this a leftover fr

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164895. kbobyrev added a comment. Add `--benchmark_min_time=0.01` to prevent testing time increase. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/cl

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev updated this revision to Diff 164893. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address comments https://reviews.llvm.org/D51628 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt clang-tools-extra/clan

[PATCH] D51926: [scan-build-py] Prevent crashes of CTU analysis by suppressing warnings

whisperity added a comment. Will this properly synergise across compilers with user-specified warning options, such as `-Wall -Werror`? Repository: rC Clang https://reviews.llvm.org/D51926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51090: [clangd] Add index benchmarks

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote: > In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote: > > > The only problem left is that I'm not sure how to run b

[PATCH] D51090: [clangd] Add index benchmarks

lebedev.ri added a comment. In https://reviews.llvm.org/D51090#1230629, @sammccall wrote: > In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote: > > > > > The only problem left is that I'm not sure how to run binary whic

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164887. kbobyrev added a comment. Find a hacky workaround to call `IndexBenchmark` binary. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benc

[PATCH] D51847: Print correctly dependency paths on Windows

zturner added a comment. I mean in practice. What command do i run to hit this and what will the output look like? Can you paste some terminal output showing the command and output? https://reviews.llvm.org/D51847 ___ cfe-commits mailing list cfe-co

[PATCH] D51910: [Modules] Add platform feature to requires clause

aprantl added inline comments. Comment at: docs/Modules.rst:470 +*platform variant* + A specific os/platform variant (e.g. ``ios``, ``macos``, ``android``, ``win32``, ``linux``, etc) is available. Does this work with platforms+environment combinations, such a

Re: [PATCH] D51847: Print correctly dependency paths on Windows

I mean in practice. What command do i run to hit this and what will the output look like? Can you paste some terminal output showing the command and output? On Tue, Sep 11, 2018 at 12:55 AM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 added a comment. > > In https:

[PATCH] D51924: [clangd] Add unittests for D51917

This revision was automatically updated to reflect the committed changes. Closed by commit rL341950: [clangd] Add unittests for D51917 (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51924?vs=164845&id=164886#toc

[clang-tools-extra] r341950 - [clangd] Add unittests for D51917

Author: kadircet Date: Tue Sep 11 08:12:10 2018 New Revision: 341950 URL: http://llvm.org/viewvc/llvm-project?rev=341950&view=rev Log: [clangd] Add unittests for D51917 Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits Differential

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 164885. teemperor marked 3 inline comments as done. teemperor added a comment. - Removed comment about redeclaring free in the test. That's wasn't correctly formulated and is anyway no longer true now that the test case including this file got bigger. - Fi

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

This revision was automatically updated to reflect the committed changes. Closed by commit rC341949: [CodeCompletion] Enable signature help when initializing class/struct/union… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D51917?vs=164866&id=164883#t

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341949: [CodeCompletion] Enable signature help when initializing class/struct/union… (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D51090: [clangd] Add index benchmarks

lebedev.ri added a comment. In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote: > The only problem left is that I'm not sure how to run binary which is not > under bin (`IndexBenchmark`) using llvm-lit. But it's a //benchmark//.. What use could be from running it as part of the _test

r341949 - [CodeCompletion] Enable signature help when initializing class/struct/union members.

Author: kadircet Date: Tue Sep 11 08:02:18 2018 New Revision: 341949 URL: http://llvm.org/viewvc/llvm-project?rev=341949&view=rev Log: [CodeCompletion] Enable signature help when initializing class/struct/union members. Summary: Factors out member decleration gathering and uses it in parsing to

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164881. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. The only problem left is that I'm not sure how to run binary which is not under bin (`IndexBenchmark`) using llvm-lit. https://reviews.llvm.org/D51090 Files: clang-tools-extra/

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt:10 + Dexp.cpp + ) + Should we indent closing parens to the opening one or keep at the start of the line? Let's pick one style and be consistent (the best op

[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! Repository: rC Clang https://reviews.llvm.org/D51917 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Really just details now. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:56 +// llvm::formatv string pattern for pretty-printing symbols. +static const aut

  1   2   >