efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land.
LGTM with one change. ================ Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2730 llvm::GlobalVariable *GV = - CGM.CreateOrReplaceCXXRuntimeVariable(Name, Init->getType(), Linkage); + CGM.CreateOrReplaceCXXRuntimeVariable(Name, Init->getType(), Linkage, 1); ---------------- Please use getTypeAlignInChars(getContext().CharTy), or something like that, so it's clear where the "1" is coming from. https://reviews.llvm.org/D51416 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
