craig.topper added inline comments.
Comment at: include/bit:163
+ static_assert(sizeof(unsigned long long) == 8, "");
+ return __popcnt64(__x);
+#endif
I don't think __popcnt64 exists in MSVC when targeting 32-bit mode.
https://reviews.llvm.org/D50815
martong accepted this revision.
martong added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/AST/ASTImporter.cpp:1317
+ for (auto *D : FromRD->decls()) {
+Decl *ToD = Importer.GetAlreadyImportedOrNull(D);
+assert(ToRD == ToD->getDeclCon
craig.topper added inline comments.
Comment at: include/bit:145
+ static_assert(sizeof(unsigned) == 4, "");
+ return __popcnt(__x);
+#endif
How does this work on pre-Haswell X86 CPUs? Doesn't MSVC just blindly emit the
popcnt instruction when it sees this?
h
Author: ctopper
Date: Wed Aug 15 23:20:29 2018
New Revision: 339843
URL: http://llvm.org/viewvc/llvm-project?rev=339843&view=rev
Log:
[X86] Remove masking from the 512-bit padds and psubs builtins. Use select
builtin instead.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/tr
lebedev.ri added inline comments.
Comment at: include/bit:99
+ unsigned long where;
+ // Search from LSB to MSB for first set bit.
+ // Returns zero if no set bit is found.
Pretty sure this is the other way around here.
```
// Search from MSB to LSB for first
atanasyan added a comment.
Any test cases?
Comment at: lib/Basic/Targets/Mips.cpp:62
+unsigned MipsTargetInfo::getISARev(const std::string& CPU) const {
+ return llvm::StringSwitch(getCPU())
The CPU argument looks unused. We can either remove it or make this
Hello Ilya,
This commit has broken the ABI test builder - lab.llvm.org:8011/builders/
clang-x86_64-linux-abi-test/builds/30676
Could you take care of this, please?
Thanks
Galina
. . .
FAILED:
tools/clang/tools/extra/unittests/clangd/CMakeFiles/ClangdTests.dir/CodeCompleteTests.cpp.o
/usr/bin
hiraditya added inline comments.
Comment at: test/Import/cxx-noexcept-expr/test.cpp:1
+// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s |
FileCheck %s
+
Can we add a line/comment to explain what this test does? Same for the input
files
rnk added a comment.
In https://reviews.llvm.org/D50805#1201805, @rsmith wrote:
> There is no guarantee that you can use an address-of-label value from one
> function invocation in another invocation of the same function. GCC's
> documentation says it's the user's own problem to prevent inlinin
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339839: [ASTImporter] Add test for CXXDefaultInitExpr
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50732?vs=160678&
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339838: [ASTImporter] Add test for CXXScalarValueInit
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50735?vs=160685&
Author: teemperor
Date: Wed Aug 15 18:37:43 2018
New Revision: 339839
URL: http://llvm.org/viewvc/llvm-project?rev=339839&view=rev
Log:
[ASTImporter] Add test for CXXDefaultInitExpr
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: a_sidorin, martong, cfe-commits
Differential
Author: teemperor
Date: Wed Aug 15 18:36:37 2018
New Revision: 339838
URL: http://llvm.org/viewvc/llvm-project?rev=339838&view=rev
Log:
[ASTImporter] Add test for CXXScalarValueInit
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339837: [ASTImporter] Add test for ForStmt and ContinueStmt
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50812?vs=1
Author: teemperor
Date: Wed Aug 15 18:35:47 2018
New Revision: 339837
URL: http://llvm.org/viewvc/llvm-project?rev=339837&view=rev
Log:
[ASTImporter] Add test for ForStmt and ContinueStmt
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commits
Differential Revi
leonardchan added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1034
+ if (DstFPSema.isSaturated() &&
+ (CGF.getContext().getCorrespondingSaturatedType(SrcTy) != DstTy)) {
+auto Mask = APInt::getBitsSetFrom(
rjmccall wrote:
> leonardchan wro
leonardchan updated this revision to Diff 160964.
leonardchan marked 7 inline comments as done.
leonardchan added a comment.
- Reworked logic for saturation
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/README.txt:104
+To translate a cxx_loop_proto file into LLVM IR do:
+ bin/clang-loop-proto-to-llvm
+To translate a cxx_loop_proto file into C++ do:
`bin/clang-loop-proto-to-llvm CORPUS_OUTPUT_
emmettneyman added a comment.
Is there anything I should add to the documentation? Anything I should remove?
Repository:
rC Clang
https://reviews.llvm.org/D50829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
shuaiwang updated this revision to Diff 160960.
shuaiwang added a comment.
Test case with non-type template
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50619
Files:
clang-tidy/utils/ExprMutationAnalyzer.cpp
unittests/clang-tidy/ExprMutationAnalyzerTest.cpp
Index: unitte
emmettneyman created this revision.
emmettneyman added reviewers: morehouse, kcc.
Herald added a subscriber: cfe-commits.
Added commands to Dockerfile to build llvm-proto-fuzzer and the other related
tools. Also added a section to the bottom of the README describing what
llvm-proto-fuzzer does a
shuaiwang added inline comments.
Comment at: unittests/clang-tidy/ExprMutationAnalyzerTest.cpp:309
+TEST(ExprMutationAnalyzerTest, CallUnresolved) {
+ auto AST =
JonasToth wrote:
> I think we are missing tests for non-type template paramters (`template
> `).
rsmith added a comment.
There is no guarantee that you can use an address-of-label value from one
function invocation in another invocation of the same function. GCC's
documentation says it's the user's own problem to prevent inlining and cloning
if the program requires an address-of-label exte
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339834: [Driver] -print-target-triple and
-print-effective-triple options (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Author: phosek
Date: Wed Aug 15 17:22:03 2018
New Revision: 339834
URL: http://llvm.org/viewvc/llvm-project?rev=339834&view=rev
Log:
[Driver] -print-target-triple and -print-effective-triple options
These can be used to print Clang target and effective triple.
Differential Revision: https://revi
shuaiwang updated this revision to Diff 160952.
shuaiwang marked 3 inline comments as done.
shuaiwang added a comment.
More test cases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50619
Files:
clang-tidy/utils/ExprMutationAnalyzer.cpp
unittests/clang-tidy/ExprMutationAnal
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho,
baloghadamsoftware.
The analyzer doesn't need them and they seem to have pretty weird AST from time
to time, so
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thanks!
> As a side note: It seems this test case actually reveals that we don't import
> the body of Foo's destructor?
This is strange. If you manage to find the reason, please notify
a_sidorin added a comment.
Hi Balasz,
Thank you for the fixes.
Comment at: unittests/AST/ASTImporterTest.cpp:2258
+ASSERT_EQ(lookup_res.size(), 0u);
+lookup_res = cast(FromTU)->noload_lookup(FromName);
+ASSERT_EQ(lookup_res.size(), 1u);
a_sidorin w
a_sidorin added a comment.
Hello Gabor and Balazs,
> With Balazs, we are working on something similar, but with a different, fine
> grained error value mechanism. Unfortunately we were not aware of that you
> have been working on error handling, and we didn't say that we are working on
> error
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339832: Implementation of nested loops in cxx_loop_proto
(authored by emmettneyman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50670?vs=160936&id=160937#toc
Repository:
rC Cla
Author: emmettneyman
Date: Wed Aug 15 16:05:48 2018
New Revision: 339832
URL: http://llvm.org/viewvc/llvm-project?rev=339832&view=rev
Log:
Implementation of nested loops in cxx_loop_proto
Summary: Extended `cxx_loop_proto` to have neste for loops. Modified
`loop_proto_to_llvm` and `loop_proto_to
emmettneyman updated this revision to Diff 160936.
emmettneyman added a comment.
Updated comments, rebased, and ready to land
Repository:
rC Clang
https://reviews.llvm.org/D50670
Files:
clang/tools/clang-fuzzer/cxx_loop_proto.proto
clang/tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.
Author: teemperor
Date: Wed Aug 15 15:52:21 2018
New Revision: 339831
URL: http://llvm.org/viewvc/llvm-project?rev=339831&view=rev
Log:
[ASTImporter] Add test for ArrayInitLoopExpr
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commits
Differential Revision: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339831: [ASTImporter] Add test for ArrayInitLoopExpr
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50733?vs=160682&i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339830: [ASTImporter] Add test for ExprWithCleanups
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50731
Files:
test/Import/expr-with-cleanups/Inputs/S.cpp
Author: teemperor
Date: Wed Aug 15 15:51:37 2018
New Revision: 339830
URL: http://llvm.org/viewvc/llvm-project?rev=339830&view=rev
Log:
[ASTImporter] Add test for ExprWithCleanups
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: a_sidorin, martong, cfe-commits
Differential R
a_sidorin marked an inline comment as done.
a_sidorin added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1317
+ for (auto *D : FromRD->decls()) {
+Decl *ToD = Importer.GetAlreadyImportedOrNull(D);
+assert(ToRD == ToD->getDeclContext() && ToRD->containsDecl(ToD));
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM except for a few spelling/grammar nits.
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:361
+it starts by allocating two work lists, one initialized with all the
offset
mclow.lists added a comment.
Thanks for doing this.
This looks good to me; but I want to play with it a bit before committing. I'll
do that tonight.
Repository:
rCXX libc++
https://reviews.llvm.org/D50736
___
cfe-commits mailing list
cfe-commits
Author: cbieneman
Date: Wed Aug 15 15:50:06 2018
New Revision: 339829
URL: http://llvm.org/viewvc/llvm-project?rev=339829&view=rev
Log:
[Darwin Driver] Fix Simulator builtins and test cases
In r339807, I broke linking the builtins libraries for simulator targets, which
itself was bad, but turns
emmettneyman updated this revision to Diff 160932.
emmettneyman added a comment.
Changed modifying global var to scoped class
Repository:
rC Clang
https://reviews.llvm.org/D50670
Files:
clang/tools/clang-fuzzer/cxx_loop_proto.proto
clang/tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Tests are always welcome. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D50731
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: teemperor
Date: Wed Aug 15 15:36:58 2018
New Revision: 339827
URL: http://llvm.org/viewvc/llvm-project?rev=339827&view=rev
Log:
[ASTImporter] Add test for IfStmt
Reviewers: a.sidorin, hiraditya
Reviewed By: hiraditya
Subscribers: hiraditya, martong, cfe-commits
Differential Revision: h
ldionne added a comment.
If that's possible at all, I would like for the Chromium people to build with
this patch applied. The expectation is that we'll cherry-pick this patch onto
LLVM 7, and it would suck if that did not solve Chromium's problem for some
stupid reason.
Repository:
rCXX li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339825: [ASTImporter] Add test for IfStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50796?vs=160876&id=160930#to
sbc100 added a comment.
Please ignore this change, I had thought we wanted size_t to match either
int32_t or int64_t, but it turns out that isn't a requirement and that code
that expects this to be true needs fixing.
Repository:
rC Clang
https://reviews.llvm.org/D50477
_
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, ldionne.
Herald added a subscriber: christof.
In C++20, we're going to have a header named for bit manipulations.
See https://wg21.link/P0553 and https://wg21.link/P0556 for more info.
This doesn't do any of that.
It just cr
arphaman created this revision.
arphaman added reviewers: ilya-biryukov, jkorous, sammccall.
Herald added subscribers: cfe-commits, dexonsmith, MaskRay, ioeric, javed.absar.
This patch extends Clangd to allow the clients to specify the preference for
how it wants to consume the fixes on the notes
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.cpp:124
+void SingleLoopToString(std::ostream &os, const LoopFunction &x) {
+ inner_loop = false;
+ os << "void foo(int *a, int *b, int *__restrict__ c, size_t s) {\n"
-
teemperor added a comment.
As a side note: It seems this test case actually reveals that we don't import
the body of Foo's destructor?
test/Import/cxx-default-init-expr/Inputs/S.cpp:1:8: inline function
'Foo::~Foo' is not defined
struct Foo {
^
test/Import/cxx-default-init-expr/I
hubert.reinterpretcast updated this revision to Diff 160923.
hubert.reinterpretcast added a comment.
Address review comments by Marshall
Add a line break after the template-head. Add a comment with the requested
quote from the Standard. Move test from the `test/libcxx/` tree to the
`test/std/`
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50813
Files:
test/Import/indirect-goto/Inputs/F.cpp
test/Import/indirect-goto/test.cpp
Index: test/Import/indirect-goto/test.cpp
===
joerg added a comment.
I don't understand the desire for this logic. Why can't wasm override the rest
of the types if it wants to have something special?
Repository:
rC Clang
https://reviews.llvm.org/D50477
___
cfe-commits mailing list
cfe-commi
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50812
Files:
test/Import/for-stmt/Inputs/F.cpp
test/Import/for-stmt/test.cpp
Index: test/Import/for-stmt/test.cpp
==
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D50736#1200774, @hubert.reinterpretcast wrote:
> In https://reviews.llvm.org/D50736#1200761, @mclow.lists wrote:
>
> > Is this test that's being added libc++ specific, or would it apply to other
> > implementations as well?
>
>
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM if thakis is happy.
Repository:
rCXX libc++
https://reviews.llvm.org/D50652
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
emmettneyman updated this revision to Diff 160920.
emmettneyman added a comment.
Made the inner loop optional
Repository:
rC Clang
https://reviews.llvm.org/D50670
Files:
clang/tools/clang-fuzzer/cxx_loop_proto.proto
clang/tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.cpp
clang/tool
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50811
Files:
test/Import/while-stmt/Inputs/F.cpp
test/Import/while-stmt/test.cpp
Index: test/Import/while-stmt/test.cpp
teemperor created this revision.
Herald added a subscriber: martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D50810
Files:
test/Import/do-stmt/Inputs/F.cpp
test/Import/do-stmt/test.cpp
Index: test/Import/do-stmt/test.cpp
=
Author: marshall
Date: Wed Aug 15 14:19:08 2018
New Revision: 339816
URL: http://llvm.org/viewvc/llvm-project?rev=339816&view=rev
Log:
Selectively import timespec_get into namespace std, since some C libraries
don't have it. Reviewed as https://reviews.llvm.org/D50799
Modified:
libcxx/trunk/
dim accepted this revision.
dim added a comment.
LGTM.
https://reviews.llvm.org/D50799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
The C++ standard just says "An integer literal of type std::size_t whose value
is the alignment guaranteed by a call to operator new(std::size_t) or operator
new[](std::size_t)." I would take that in the obvious sense, that any pointer
returned by operator new must ha
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D50799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rnk added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7872-7874
-def warn_ret_addr_label : Warning<
- "returning address of label, which is local">,
- InGroup;
lebedev.ri wrote:
> Why completely drop the diagnostic just because
lebedev.ri added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7872-7874
-def warn_ret_addr_label : Warning<
- "returning address of label, which is local">,
- InGroup;
Why completely drop the diagnostic just because it is undesi
rnk created this revision.
rnk added reviewers: niravd, rsmith, nickdesaulniers.
There aren't any lifetime issues inherent in returning a local label.
Hypothetically, it could be used to drive a state machine driven by
computed goto the next time that same scope is re-entered. In any case,
the Lin
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127
}
+ inner_loop = true;
return os;
emmettneyman wrote:
> morehouse wrote:
> > Maybe this fixes the bug, but modifying `inner_loop` from different
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
I don't have access to the PS4 SDK, but this is the most plausible explanation
I've seen for why I was experiencing issues on these platforms. Thanks for this!
Do you have commit access
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339810: Add a newline to SourceLocation dump output
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50661
Files:
cfe/tru
Author: steveire
Date: Wed Aug 15 13:32:06 2018
New Revision: 339810
URL: http://llvm.org/viewvc/llvm-project?rev=339810&view=rev
Log:
Add a newline to SourceLocation dump output
Summary:
Migrate callers to print().
dump() should be useful to downstreams and third parties as a debugging
aid. Ev
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
This doesn't seem necessary. `NewAlign` specifies the alignment beyond which
types acquire "new-extended alignment" per the C++ standard, or equivalently
the alignment beyond which w
rjmccall added a comment.
In https://reviews.llvm.org/D50783#1200868, @ahatanak wrote:
> A few points I forgot to mention:
>
> - This optimization kicks in only in NonGC mode. I don't think we need to
> care much about GC anymore, so I think that's OK.
Yes, that's fine.
> - There is a lot of
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:132
+ os << "target triple = \"x86_64-pc-linux-gnu\"\n"
+ << "define void @foo(i32* %a, i32* %b, i32* noalias %c, i64 %s) {\n"
+ << "%cmp = icmp sgt i64 %s, 0\n"
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1042
+std::min(DstScale + DstFPSema.getIntegralBits(), ResultWidth));
+Value *Zero = ConstantInt::get(CGF.getLLVMContext(), APInt(ResultWidth,
0));
+
You can just pass 0 here an
Author: devnexen
Date: Wed Aug 15 13:09:52 2018
New Revision: 339808
URL: http://llvm.org/viewvc/llvm-project?rev=339808&view=rev
Log:
[CStringSyntaxChecker] Reduces space around error message for strlcat.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339807: Refactor Darwin driver to refer to runtimes by
component (authored by cbieneman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50618?vs=160279&id=160903#toc
Repository:
r
Author: cbieneman
Date: Wed Aug 15 13:09:38 2018
New Revision: 339807
URL: http://llvm.org/viewvc/llvm-project?rev=339807&view=rev
Log:
Refactor Darwin driver to refer to runtimes by component
Summary:
In r335809, Petr Hosek lays out support for what he calls the multiarch
runtimes layout. This n
arphaman created this revision.
arphaman added reviewers: jkorous, hokein, ioeric.
Herald added a subscriber: dexonsmith.
This patch is a followup to https://reviews.llvm.org/D50740 .
This patch fixes the issue where clang-refactor local-rename was unable to find
a declaration in a header file i
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D50755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
This looks like a NFC change.
Given that the next patch moves these methods out of line, you might consider
introducing them out of line here (and moving the constructors out of line).
Th
mclow.lists updated this revision to Diff 160898.
https://reviews.llvm.org/D50799
Files:
include/__config
include/cstdlib
include/ctime
test/std/language.support/support.runtime/ctime.pass.cpp
test/std/utilities/time/date.time/ctime.pass.cpp
test/support/test_macros.h
Index: test/sup
steveire added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:272
bool HasLeadingEmptyMacro = Tok.hasLeadingEmptyMacro();
-return Actions.ActOnNullStmt(ConsumeToken(), HasLeadingEmptyMacro);
+SourceLocation SemiLoc = ConsumeToken();
+return Actions.ActOnNul
NoQ added inline comments.
Comment at: cfe/trunk/test/Analysis/cstring-syntax.c:45
+ strlcpy(dest, "012345678", sizeof(dest));
+ strlcat(dest, "910", sizeof(dest)); // expected-warning {{The third argument
allows to potentially copy more bytes than it should. Replace with the
mclow.lists updated this revision to Diff 160897.
mclow.lists added a comment.
Copy/paste error in original diff.
https://reviews.llvm.org/D50799
Files:
include/__config
include/cstdlib
include/ctime
test/std/language.support/support.runtime/ctime.pass.cpp
test/std/utilities/time/date
mclow.lists created this revision.
mclow.lists added reviewers: ldionne, EricWF, dim.
Fixes this by adding a new config macro `_LIBCPP_HAS_TIMESPEC_GET` (sigh)
There's also a drive-by fix in here about not importing `aligned_alloc` into
namespace `std` before C++17.
https://reviews.llvm.org/D
xazax.hun added a comment.
Generally looks good, I only wonder if this works well with inline namespaces.
Could you test?
Repository:
rC Clang
https://reviews.llvm.org/D48027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: Szelethus.
This looks great, thanks, this is exactly how i imagined it!
Repository:
rC Clang
https://reviews.llvm.org/D48027
Author: abataev
Date: Wed Aug 15 12:45:12 2018
New Revision: 339805
URL: http://llvm.org/viewvc/llvm-project?rev=339805&view=rev
Log:
[OPENMP] FIx processing of declare target variables.
The compiler may produce unexpected error messages/crashes when declare
target variables were used. Patch fixe
ldionne added a comment.
In https://reviews.llvm.org/D50652#1201236, @thakis wrote:
> I haven't read all the messages in these threads, forgive me if someone asked
> this already. It's a bit weird to me that we have to override this behavior
> in Chromium while the default is different. Why isn
leonardchan updated this revision to Diff 160892.
leonardchan marked 6 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticGroups.td
inc
thakis added a comment.
I haven't read all the messages in these threads, forgive me if someone asked
this already. It's a bit weird to me that we have to override this behavior in
Chromium while the default is different. Why isn't the executable size blowup
we see in chromium a problem for eve
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
The approach lgtm, thanks.
How does the gcc driver codepath handle this? Does it just not have to worry
about this because it doesn't have something like
warn_pp_macro_def_mismatch_with_pch?
hiraditya accepted this revision.
hiraditya added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the test.
Repository:
rC Clang
https://reviews.llvm.org/D50796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
acoomans added subscribers: mattd, Sunil_Srivastava.
acoomans added a comment.
@mattd @Sunil_Srivastava if you have access to the PS4 SDK, could you tell if
the `-debug-info-macro` command line clang option is available? Thank you
Repository:
rC Clang
https://reviews.llvm.org/D50410
_
Author: marshall
Date: Wed Aug 15 12:27:53 2018
New Revision: 339804
URL: http://llvm.org/viewvc/llvm-project?rev=339804&view=rev
Log:
Mark the at_exit and at_quick_exit tests as unsupported under C++98 an 03,
since those calls were introduced in C++11. They're already guarded by an
ifdef in th
rjmccall added a comment.
Our experience is that we keep adding more complexity to `FunctionType`, so
it'd be nice if the bits weren't pressed up against the absolute limit.
Dynamic exception specifications are really common, but only in the
zero-exceptions case, so as long as we can efficient
stryku updated this revision to Diff 160885.
stryku added a comment.
Thanks for pointing that out. You're probably right, these two calls are
self-explanatory.
https://reviews.llvm.org/D50766
Files:
lib/Sema/SemaChecking.cpp
Index: lib/Sema/SemaChecking.cpp
leonardchan updated this revision to Diff 160884.
leonardchan marked 3 inline comments as done.
leonardchan added a comment.
- Added check for if we should check for saturation when converting to a
saturated fixed point type.
- Replaced `llvm_unreachable()`s with temporary diagnostic to be eventu
1 - 100 of 160 matches
Mail list logo
