Author: steveire Date: Wed Aug 15 13:32:06 2018 New Revision: 339810 URL: http://llvm.org/viewvc/llvm-project?rev=339810&view=rev Log: Add a newline to SourceLocation dump output
Summary: Migrate callers to print(). dump() should be useful to downstreams and third parties as a debugging aid. Everyone trips up on this and creates confusing output. Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50661 Modified: cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp cfe/trunk/lib/AST/CommentLexer.cpp cfe/trunk/lib/Analysis/LiveVariables.cpp cfe/trunk/lib/Basic/Diagnostic.cpp cfe/trunk/lib/Basic/SourceLocation.cpp cfe/trunk/lib/Lex/Preprocessor.cpp Modified: cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp?rev=339810&r1=339809&r2=339810&view=diff ============================================================================== --- cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp (original) +++ cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp Wed Aug 15 13:32:06 2018 @@ -340,7 +340,7 @@ void MigrationContext::dumpGCAttrs() { llvm::errs() << "KIND: " << (Attr.Kind == GCAttrOccurrence::Strong ? "strong" : "weak"); llvm::errs() << "\nLOC: "; - Attr.Loc.dump(Pass.Ctx.getSourceManager()); + Attr.Loc.print(llvm::errs(), Pass.Ctx.getSourceManager()); llvm::errs() << "\nTYPE: "; Attr.ModifiedType.dump(); if (Attr.Dcl) { Modified: cfe/trunk/lib/AST/CommentLexer.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/CommentLexer.cpp?rev=339810&r1=339809&r2=339810&view=diff ============================================================================== --- cfe/trunk/lib/AST/CommentLexer.cpp (original) +++ cfe/trunk/lib/AST/CommentLexer.cpp Wed Aug 15 13:32:06 2018 @@ -21,7 +21,7 @@ namespace comments { void Token::dump(const Lexer &L, const SourceManager &SM) const { llvm::errs() << "comments::Token Kind=" << Kind << " "; - Loc.dump(SM); + Loc.print(llvm::errs(), SM); llvm::errs() << " " << Length << " \"" << L.getSpelling(*this, SM) << "\"\n"; } Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/LiveVariables.cpp?rev=339810&r1=339809&r2=339810&view=diff ============================================================================== --- cfe/trunk/lib/Analysis/LiveVariables.cpp (original) +++ cfe/trunk/lib/Analysis/LiveVariables.cpp Wed Aug 15 13:32:06 2018 @@ -626,7 +626,7 @@ void LiveVariablesImpl::dumpBlockLivenes de = declVec.end(); di != de; ++di) { llvm::errs() << " " << (*di)->getDeclName().getAsString() << " <"; - (*di)->getLocation().dump(M); + (*di)->getLocation().print(llvm::errs(), M); llvm::errs() << ">\n"; } } Modified: cfe/trunk/lib/Basic/Diagnostic.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=339810&r1=339809&r2=339810&view=diff ============================================================================== --- cfe/trunk/lib/Basic/Diagnostic.cpp (original) +++ cfe/trunk/lib/Basic/Diagnostic.cpp Wed Aug 15 13:32:06 2018 @@ -239,7 +239,7 @@ DiagnosticsEngine::DiagStateMap::getFile void DiagnosticsEngine::DiagStateMap::dump(SourceManager &SrcMgr, StringRef DiagName) const { llvm::errs() << "diagnostic state at "; - CurDiagStateLoc.dump(SrcMgr); + CurDiagStateLoc.print(llvm::errs(), SrcMgr); llvm::errs() << ": " << CurDiagState << "\n"; for (auto &F : Files) { @@ -261,7 +261,7 @@ void DiagnosticsEngine::DiagStateMap::du << Decomp.first.getHashValue() << "> "; SrcMgr.getLocForStartOfFile(Decomp.first) .getLocWithOffset(Decomp.second) - .dump(SrcMgr); + .print(llvm::errs(), SrcMgr); } if (File.HasLocalTransitions) llvm::errs() << " has_local_transitions"; @@ -281,7 +281,7 @@ void DiagnosticsEngine::DiagStateMap::du llvm::errs() << " "; SrcMgr.getLocForStartOfFile(ID) .getLocWithOffset(Transition.Offset) - .dump(SrcMgr); + .print(llvm::errs(), SrcMgr); llvm::errs() << ": state " << Transition.State << ":\n"; }; Modified: cfe/trunk/lib/Basic/SourceLocation.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/SourceLocation.cpp?rev=339810&r1=339809&r2=339810&view=diff ============================================================================== --- cfe/trunk/lib/Basic/SourceLocation.cpp (original) +++ cfe/trunk/lib/Basic/SourceLocation.cpp Wed Aug 15 13:32:06 2018 @@ -77,6 +77,7 @@ SourceLocation::printToString(const Sour LLVM_DUMP_METHOD void SourceLocation::dump(const SourceManager &SM) const { print(llvm::errs(), SM); + llvm::errs() << '\n'; } //===----------------------------------------------------------------------===// Modified: cfe/trunk/lib/Lex/Preprocessor.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/Preprocessor.cpp?rev=339810&r1=339809&r2=339810&view=diff ============================================================================== --- cfe/trunk/lib/Lex/Preprocessor.cpp (original) +++ cfe/trunk/lib/Lex/Preprocessor.cpp Wed Aug 15 13:32:06 2018 @@ -250,7 +250,7 @@ void Preprocessor::DumpToken(const Token } void Preprocessor::DumpLocation(SourceLocation Loc) const { - Loc.dump(SourceMgr); + Loc.print(llvm::errs(), SourceMgr); } void Preprocessor::DumpMacro(const MacroInfo &MI) const { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
