thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land.
The approach lgtm, thanks. How does the gcc driver codepath handle this? Does it just not have to worry about this because it doesn't have something like warn_pp_macro_def_mismatch_with_pch? ================ Comment at: test/Driver/cl-pch.cpp:368 +// CHECK-YU-E-NOT: -emit-pch +// CHECK-YU-E-NOT: -include-pch ---------------- Can we have an integration-test type test that creates a pch and uses it, and checks that there are no warnings? (Like in https://bugs.llvm.org/show_bug.cgi?id=38508#c1) Probably fairly easy to add to one of the test/PCH/pch-through* files. Repository: rC Clang https://reviews.llvm.org/D50640 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
