HsiangKai created this revision.
HsiangKai added reviewers: aprantl, probinson, dblaikie.
Herald added subscribers: cfe-commits, JDevlieghere.
After refactoring DbgInfoIntrinsic class hierarchy, we use
DbgVariableIntrinsic as the base class of variable debug info.
In resolveTopLevelMetadata() in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338820: [libclang 8/8] Add support for the flag_enum
attribute (authored by mwu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49635
Files:
include/clang-c/Index.h
test/Index/attr
Author: mwu
Date: Thu Aug 2 22:55:40 2018
New Revision: 338820
URL: http://llvm.org/viewvc/llvm-project?rev=338820&view=rev
Log:
[libclang 8/8] Add support for the flag_enum attribute
Summary:
This adds support to libclang for reading the flag_enum attribute.
This also bumps CINDEX_VERSION_MINO
michaelwu added a comment.
Thanks for the reviews!
Repository:
rC Clang
https://reviews.llvm.org/D49635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338819: [CMake] Allow building standalone without any
llvm-config available (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://revi
Author: mstorsjo
Date: Thu Aug 2 22:51:31 2018
New Revision: 338819
URL: http://llvm.org/viewvc/llvm-project?rev=338819&view=rev
Log:
[CMake] Allow building standalone without any llvm-config available
This is the same as libcxxabi/libcxx do.
Differential Revision: https://reviews.llvm.org/D501
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338816: [libclang 7/8] Add support for getting property
setter and getter names (authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49634?vs=156691&id=158919#toc
Reposi
Author: mwu
Date: Thu Aug 2 22:38:29 2018
New Revision: 338816
URL: http://llvm.org/viewvc/llvm-project?rev=338816&view=rev
Log:
[libclang 7/8] Add support for getting property setter and getter names
Summary: This allows libclang to access the actual names of property setters
and getters witho
michaelwu added a comment.
The patch will be adjusted slightly to replace a // comment with a /* */
comment.
Repository:
rC Clang
https://reviews.llvm.org/D49634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: mwu
Date: Thu Aug 2 22:20:23 2018
New Revision: 338815
URL: http://llvm.org/viewvc/llvm-project?rev=338815&view=rev
Log:
[libclang 6/8] Add support for reading implicit attributes
Summary:
Having access to implicit attributes is sometimes useful so users of libclang
don't have to duplic
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338815: [libclang 6/8] Add support for reading implicit
attributes (authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49631?vs=15&id=158918#toc
Repository:
rC Cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338813: [libclang 5/8] Add support for ObjC attributes
without args (authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49127?vs=154785&id=158916#toc
Repository:
rC C
Author: mwu
Date: Thu Aug 2 22:03:22 2018
New Revision: 338813
URL: http://llvm.org/viewvc/llvm-project?rev=338813&view=rev
Log:
[libclang 5/8] Add support for ObjC attributes without args
Summary:
This adds support to libclang for identifying ObjC related attributes that
don't take arguments.
michaelwu added a comment.
Some of the CHECKs in the test will be reordered to pass, but it's still the
same test.
Repository:
rC Clang
https://reviews.llvm.org/D49127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1691
+
+Name += "_" + llvm::to_string(E.Capture->getOffset().getQuantity());
+ }
I feel like this reads a little better if you write the quantity first. Also I
think you can drop the unde
DHowett-MSFT added a subscriber: smeenai.
DHowett-MSFT added inline comments.
Comment at: include/clang/Driver/Options.td:1491
// Objective-C ABI options.
-def fobjc_runtime_EQ : Joined<["-"], "fobjc-runtime=">, Group,
Flags<[CC1Option]>,
+def fobjc_runtime_EQ : Joined<["-"], "
Author: meinersbur
Date: Thu Aug 2 21:42:52 2018
New Revision: 338810
URL: http://llvm.org/viewvc/llvm-project?rev=338810&view=rev
Log:
[CodeGen] Emit parallel_loop_access for each loop in the loop stack.
Summary:
Emit !llvm.mem.parallel_loop_access metadata for memory accesses even if the
para
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338810: [CodeGen] Emit parallel_loop_access for each loop in
the loop stack. (authored by Meinersbur, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48808?vs=155288&id=158912#toc
Re
Author: mwu
Date: Thu Aug 2 21:38:04 2018
New Revision: 338809
URL: http://llvm.org/viewvc/llvm-project?rev=338809&view=rev
Log:
[libclang 4/8] Add the clang_Type_getNullability() API
Summary:
This patch adds a clang-c API for querying the nullability of an AttributedType.
The test here also te
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338809: [libclang 4/8] Add the clang_Type_getNullability()
API (authored by mwu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49082
Files:
include/clang-c/Index.h
test/Index/null
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338808: [libclang 3/8] Add support for AttributedType
(authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49081?vs=154609&id=158909#toc
Repository:
rC Clang
https://
Author: mwu
Date: Thu Aug 2 21:21:25 2018
New Revision: 338808
URL: http://llvm.org/viewvc/llvm-project?rev=338808&view=rev
Log:
[libclang 3/8] Add support for AttributedType
Summary:
This patch adds support to the libclang API for identifying AttributedTypes in
CXTypes and reading the modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338807: [libclang 2/8] Add support for ObjCTypeParam
(authored by mwu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49066
Files:
include/clang-c/Index.h
test/Index/print-type.m
Author: mwu
Date: Thu Aug 2 21:02:40 2018
New Revision: 338807
URL: http://llvm.org/viewvc/llvm-project?rev=338807&view=rev
Log:
[libclang 2/8] Add support for ObjCTypeParam
Summary:
This patch adds support to the libclang API for identifying ObjCTypeParams in
CXTypes.
This patch depends on D4
mgrang added a comment.
Please add some unit tests.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3830
+ RegFnNameParts.push_back(Device.getTriple());
+std::sort(RegFnNameParts.begin() + 2, RegFnNameParts.end());
+std::string Descriptor = getName(RegFnNameParts);
---
sdmitriev abandoned this revision.
sdmitriev added a comment.
A simpler solution was proposed while discussing an RFC which I submitted a
while ago per Alexey's request. It would lead to (almost) the same results but
requires much smaller amount of changes.
Repository:
rC Clang
https://revi
Author: yaxunl
Date: Thu Aug 2 20:18:56 2018
New Revision: 338805
URL: http://llvm.org/viewvc/llvm-project?rev=338805&view=rev
Log:
Sema: Fix explicit address space cast involving void pointers
Explicit cast of a void pointer to a pointer type in different address space is
incorrectly classified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338805: Sema: Fix explicit address space cast involving void
pointers (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D500
sdmitriev created this revision.
sdmitriev added reviewers: ABataev, hfinkel.
Herald added subscribers: cfe-commits, mgrang, guansong.
Encoding offload target triples onto comdat group key for offload
initialization code guarantees that it will be executed once per each unique
combination of off
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338804: [libclang 1/8] Add support for ObjCObjectType
(authored by mwu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49063?vs=156692&id=158897#toc
Repository:
rC Clang
https://
Meinersbur added a comment.
I have two approaches to tackle the wrong marker order:
https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216. IMHO both
are too invasive to be justified for the small issue.
Repository:
rL LLVM
https://reviews.llvm.org/D48100
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338804: [libclang 1/8] Add support for ObjCObjectType
(authored by mwu, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49063?vs=156692&id=158
Author: mwu
Date: Thu Aug 2 20:03:20 2018
New Revision: 338804
URL: http://llvm.org/viewvc/llvm-project?rev=338804&view=rev
Log:
[libclang 1/8] Add support for ObjCObjectType
Summary: This patch adds support to the clang-c API for identifying ObjCObjects
in CXTypes, enumerating type args and pr
Meinersbur created this revision.
Herald added subscribers: cfe-commits, eraman.
Attempt to solve the the diagnostic marker order ('note: previous declaration
here' pointing to a source location before the main error marker) from
https://reviews.llvm.org/D48100.
The approach is to pass a `IsInh
Author: marshall
Date: Thu Aug 2 19:58:16 2018
New Revision: 338803
URL: http://llvm.org/viewvc/llvm-project?rev=338803&view=rev
Log:
Make my new test harness work w/c++03
Modified:
libcxx/trunk/test/support/test_comparisons.h
Modified: libcxx/trunk/test/support/test_comparisons.h
URL:
htt
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I see, so that's how it's done!
I also noticed that checker name was weird in exploded graph dumps, i.e. it was
showing regular new/delete stuff as if it was done by InnerPointer checker.
I'll chec
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:492
+if (!RD->isExternallyVisible())
+ info.CapturesNonExternalType = true;
+
rjmccall wrote:
> You only need to do this if you're going to mangle the type name, i.e. if
> it's
ahatanak updated this revision to Diff 158892.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/CodeGen/CGNonTrivialStruct.cpp
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, aaron.ballman, nicholas, dlj, echristo,
erichkeane.
Currently, attributes from previous declarations ('inherited attributes') are
added to the end of a declaration's list of attributes. Before r338800, the
attribute list was
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D50104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
For `InnerPointerChecker` to function properly, both the checker itself and
`MallocChecker`'s capabili
Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6091
+ for (auto *F : Record->fields()) {
+if (F->isMutable()) {
Rakete wrote:
> Can you move this in `ActOnFields`? That way we avoid
Rakete added a reviewer: Rakete.
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6091
+ for (auto *F : Record->fields()) {
+if (F->isMutable()) {
Quuxplusone wrote:
> Rakete wrote:
> > Can you move this in `ActOnFields`?
Author: rakete
Date: Thu Aug 2 18:24:52 2018
New Revision: 338801
URL: http://llvm.org/viewvc/llvm-project?rev=338801&view=rev
Log:
Fold two cast plus a cast in a loop into a variable.
This avoids to recast `Record` multiple times.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cf
rjmccall added a comment.
Sorry, let me be more precise. The semantics of LLVM IR are that the element
type of a pointer matters when doing specific operations on pointers: loads,
stores, GEPs, calls, and so on. Many of these operations have been at least
partially updated — in some combinati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338800: Append new attributes to the end of an
AttributeList. (authored by Meinersbur, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48100
File
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338800: Append new attributes to the end of an
AttributeList. (authored by Meinersbur, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48100?vs=158639&id=158880#toc
Repository:
rC
Author: meinersbur
Date: Thu Aug 2 18:21:16 2018
New Revision: 338800
URL: http://llvm.org/viewvc/llvm-project?rev=338800&view=rev
Log:
Append new attributes to the end of an AttributeList.
Recommit of r335084 after revert in r335516.
... instead of prepending it at the beginning (the original
Author: rsmith
Date: Thu Aug 2 18:00:01 2018
New Revision: 338798
URL: http://llvm.org/viewvc/llvm-project?rev=338798&view=rev
Log:
[modules] Defer merging deduced return types.
We can't read a deduced return type until we are sure that the types referred
to by it are not in the middle of being
andrew.w.kaylor added a comment.
Fair enough.
FYI, I've spent most of the day poking at the IR linker and I've found all
sorts of ways that I can get it to make a complete mess of structure types and
pointers to them, including some simple cases where it will mess it up in
different ways depen
Author: marshall
Date: Thu Aug 2 17:47:12 2018
New Revision: 338797
URL: http://llvm.org/viewvc/llvm-project?rev=338797&view=rev
Log:
Update the changes to the array tests (that I committed yesterday) to use the
test_comparison routines that I committed last week. NFC.
Modified:
libcxx/tru
Author: juliehockett
Date: Thu Aug 2 17:40:11 2018
New Revision: 338796
URL: http://llvm.org/viewvc/llvm-project?rev=338796&view=rev
Log:
[clang-doc] Fix unique_ptr error on bots
Explicitly return the base unique_ptr type, as some of the older
compilers on the bots don't support full C++11.
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE338796: [clang-doc] Fix unique_ptr error on bots (authored
by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50208?vs=158872&id=158874#toc
Repository:
rCTE Clang T
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rUNW libunwind
https://reviews.llvm.org/D50135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
Make sure the commit message reflects this change but other than that LGTM
https://reviews.llvm.org/D50208
___
cfe-commits mailing li
juliehockett updated this revision to Diff 158872.
https://reviews.llvm.org/D50208
Files:
clang-tools-extra/clang-doc/Serialize.cpp
Index: clang-tools-extra/clang-doc/Serialize.cpp
===
--- clang-tools-extra/clang-doc/Serialize.cp
bviyer updated this revision to Diff 158870.
bviyer added a comment.
Simplified the case a bit more as requested by Erik. I also induced some errors
in the test so that if someone symbolic-linked clang to /bin/true, the test
will fail.
Repository:
rC Clang
https://reviews.llvm.org/D50122
F
ldionne added a comment.
In https://reviews.llvm.org/D50205#1186419, @ahatanak wrote:
> I just wanted to make sure that this doesn't have the same problem as
> https://reviews.llvm.org/D34556. Is that correct?
>
> The patch was reverted in r306859. https://reviews.llvm.org/D34574#791158
> expla
juliehockett created this revision.
juliehockett added reviewers: ioeric, lebedev.ri, jakehehrlich, leonardchan.
juliehockett added a project: clang-tools-extra.
Explicitly declare the return unique_ptr instead of using auto type deduction,
as some of the bots' older compilers don't support some
Hello everyone,
Below are some buildbot numbers for the last week of 7/22/2018 - 7/28/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 7/15/2018 - 7/21/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
efriedma added a comment.
"0.0040" is four milliseconds? You're probably crediting time incorrectly,
somehow. Can you tell which FrontendTimeRAII the time is coming from?
https://reviews.llvm.org/D47196
___
cfe-commits mailing list
cfe-commits@li
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1638
+switch (E.Kind) {
+case BlockCaptureEntityKind::CXXRecord: {
+ Name += "c";
ahatanak wrote:
> rjmccall wrote:
> > I forget whether this case has already filtered out trivial
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6174
+ Record->hasAttr() &&
+ !isTemplateInstantiation(Record->getTemplateSpecializationKind())) {
+if (Record->getDefinition() && !Record->isDependentContext() &&
The call to `i
ahatanak added a comment.
I just wanted to make sure that this doesn't have the same problem as
https://reviews.llvm.org/D34556. Is that correct?
The patch was reverted in r306859. https://reviews.llvm.org/D34574#791158
explains why the approach taken in the patch was wrong.
Repository:
rCX
Author: rkovacs
Date: Thu Aug 2 16:02:08 2018
New Revision: 338780
URL: http://llvm.org/viewvc/llvm-project?rev=338780&view=rev
Log:
[analyzer] Detect pointers escaped after ReturnStmt execution in MallocChecker.
Objects local to a function are destroyed right after the statement returning
(part
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338780: [analyzer] Detect pointers escaped after ReturnStmt
execution in MallocChecker. (authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
shuaiwang updated this revision to Diff 158856.
shuaiwang marked 2 inline comments as done.
shuaiwang added a comment.
Update comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50102
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performa
shuaiwang added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:108
return;
+ if (const auto *Ctor = dyn_cast(Function)) {
+for (const auto *Init : Ctor->inits()) {
hokein wrote:
> Is this a new fix or a special case
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1050
+ SrcType->getAs()->getPointeeType().getAddressSpace() !=
+
DestType->getAs()->getPointeeType().getAddressSpace();
+}
yaxunl wrote:
> rjmccall wrote:
> > yaxunl wrote:
> >
ldionne created this revision.
ldionne added reviewers: EricWF, vsapsai.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The aligned allocation and deallocation functions were added in the dylib
in Mac OSX 10.13. This commit does two things: first, it adds availability
markup to those
The attached patch adds support for @files to ccc-analyzer (which is used
by scan-build). This feature is a commonly accepted compiler option that
clang, gcc, and cl.exe (microsoft's compiler) all already support. This
will allow scan-build to support it too (assuming that the perl version of
ccc-a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338777: [analyzer] Obtain a ReturnStmt from a
CFGAutomaticObjDtor. (authored by rkovacs, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49811
Files:
lib/StaticAnalyzer/Checkers/Analy
Author: rkovacs
Date: Thu Aug 2 15:31:03 2018
New Revision: 338777
URL: http://llvm.org/viewvc/llvm-project?rev=338777&view=rev
Log:
[analyzer] Obtain a ReturnStmt from a CFGAutomaticObjDtor.
The CoreEngine only gives us a ReturnStmt if the last element in the
CFGBlock is a CFGStmt, otherwise th
Thanks for the notice. Have you managed to get the repro? I haven't
succeeded in constructing one yet, but I've committed a check for the
CXXRecordDecl. I hope that fixes the crashes.
Alexander Kornienko ezt írta (időpont: 2018. aug. 2.,
Cs, 11:07):
>
>
> On Mon, Jul 30, 2018 at 5:44 PM Reka Kov
Author: rkovacs
Date: Thu Aug 2 15:19:57 2018
New Revision: 338775
URL: http://llvm.org/viewvc/llvm-project?rev=338775&view=rev
Log:
[analyzer] Add a safety check to InnerPointerChecker.
Do not crash if the CXXRecordDecl of an object is not available.
Modified:
cfe/trunk/lib/StaticAnalyzer/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338771: [WebAssembly] Support for atomic.wait / atomic.wake
builtins (authored by aheejin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49396
Author: aheejin
Date: Thu Aug 2 14:44:40 2018
New Revision: 338771
URL: http://llvm.org/viewvc/llvm-project?rev=338771&view=rev
Log:
[WebAssembly] Support for atomic.wait / atomic.wake builtins
Summary:
Add support for atomic.wait / atomic.wake builtins based on the Wasm
thread proposal.
Review
mstorsjo added a comment.
In https://reviews.llvm.org/D50199#1186282, @cdavis5x wrote:
> I actually believe this is supposed to have one other effect: it sets the
> entry point to `wmainCRTStartup()`/`wWinMainCRTStartup()`, making the user
> entry point `wmain()`/`wWinMain()`, which take wide a
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6187
+Record->dropAttr();
+ } else if (Record->needsImplicitMoveConstructor() &&
+ Record->defaultedMoveConstructorIsDeleted()) {
Rakete wrote:
> Quuxplusone w
cdavis5x added a comment.
Are you sure this shouldn't also define `_UNICODE`? //looks// Hmm... GCC
doesn't define it. I wonder if we should anyway. A user who set `-municode` may
also be using ``, and thus may want those macros set to their Unicode
counterparts.
I actually believe this is supp
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Great! The comment should be updated though.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:32
+// `-analyzer-config \
george.karpenkov added a comment.
> Dereferencing is disabled by default
Great! Thank you!
> but I haven't seen the current version of the checker crash due to pointer
> chasing.
@NoQ saw quite a few crashes during evaluation, right?
> This might be a little nit-picking, but I don't think the
pirama added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the
> driver level and skip the -cc1 flag?
It seems odd to include predefined macros at the driver, which AFAIK is just a
bridge to the fron
simoncook added a comment.
It seems the ability to link objects has been broken by this change. As an
example from our nightly tests:
Executing on host: riscv32-unknown-elf-clang
/data/jenkins/workspace/riscv32-llvm-gcc/gcc-tests/gcc/testsuite/gcc.c-torture/execute/20080502-1.c
-march=rv32g
(+Hans) +1
On Thu, 2 Aug 2018 at 11:37, Martin Storsjö via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hans,
>
> I think this commit should be merged to the 7.0 release branch; the first
> half of the GCC workaround made it in before the branch happened, but
> there was another identical c
mstorsjo added inline comments.
Comment at: CMakeLists.txt:363
-add_subdirectory(test)
+if (EXISTS ${LLVM_CMAKE_PATH})
+ add_subdirectory(test)
phosek wrote:
> libcxx seems to be using a different condition: `IS_DIRECTORY
> "${CMAKE_CURRENT_SOURCE_DIR}/test"`
aaron.ballman added inline comments.
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+mu_.Unlock();
+ }
+
+ void unlockShared() SHARED_UNLOCK_FUNCTION(mu_) {
Nothing calls either
Author: rsmith
Date: Thu Aug 2 13:30:52 2018
New Revision: 338766
URL: http://llvm.org/viewvc/llvm-project?rev=338766&view=rev
Log:
Fix assertion failure when emitting code for a merged lambda.
Modified:
cfe/trunk/lib/AST/DeclCXX.cpp
cfe/trunk/test/Modules/merge-lambdas.cpp
Modified: cf
aaron.ballman accepted this revision.
aaron.ballman added a comment.
I am still okay with this, and agree that the ordering issues are a separate
thing to tackle.
Repository:
rC Clang
https://reviews.llvm.org/D48100
___
cfe-commits mailing list
phosek added inline comments.
Comment at: CMakeLists.txt:363
-add_subdirectory(test)
+if (EXISTS ${LLVM_CMAKE_PATH})
+ add_subdirectory(test)
libcxx seems to be using a different condition: `IS_DIRECTORY
"${CMAKE_CURRENT_SOURCE_DIR}/test"`, should this be uni
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3489
+
+``noderef`` is currently only supported for C style pointers and arrays and
not usable for
+references or Objective-C pointers.
I would drop the "C style" and just say it's
mstorsjo updated this revision to Diff 158827.
mstorsjo added a comment.
Simplified the patch to just handle the flag within the driver, without making
it a flag to cc1.
https://reviews.llvm.org/D50199
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/mingw.cpp
Index: test/Driver/mingw.
mstorsjo added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the
> driver level and skip the -cc1 flag?
Yes, that also works. Initially I looked at where to place that in
lib/Driver/ToolChains/MinGW.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The attribute itself is looking reasonable aside from some minor nits, but this
should not be committed until the clang-tidy functionality is approved (since
it has no utility be
dblaikie added a comment.
Hi - sorry about the stalled opaque pointer types effort.
For my money - ideally - if someone comes across a bug caused by incorrect
pointee types, ideally that would be fixed by adjusting whatever piece of code
was depending on that pointee type being correct to not d
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6187
+Record->dropAttr();
+ } else if (Record->needsImplicitMoveConstructor() &&
+ Record->defaultedMoveConstructorIsDeleted()) {
Quuxplusone wrote:
> Rakete w
Quuxplusone added inline comments.
Comment at: compiler-explorer-llvm-commit.sh:1
+# This is the commit of LLVM that we're currently based on.
+git reset --hard 1fa19f68007cd126a04448093c171f40e556087e
Rakete wrote:
> What's this file? A mistake?
Yeah, it's p
Quuxplusone updated this revision to Diff 158822.
Quuxplusone marked 20 inline comments as done.
Quuxplusone added a comment.
Further removal of dead code based on @Rakete's feedback.
Repository:
rC Clang
https://reviews.llvm.org/D50119
Files:
docs/LanguageExtensions.rst
include/clan
rnk added a comment.
Does this do anything other than -DUNICODE? Maybe just translate it at the
driver level and skip the -cc1 flag?
Repository:
rC Clang
https://reviews.llvm.org/D50199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
1 - 100 of 178 matches
Mail list logo
