mgrang added a comment. Please add some unit tests.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3830 + RegFnNameParts.push_back(Device.getTriple()); + std::sort(RegFnNameParts.begin() + 2, RegFnNameParts.end()); + std::string Descriptor = getName(RegFnNameParts); ---------------- Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements. Repository: rC Clang https://reviews.llvm.org/D50218 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
